Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Translation process. Configured language not recognized #102

Merged
merged 10 commits into from
Apr 21, 2020

Conversation

huard
Copy link
Contributor

@huard huard commented Apr 14, 2020

Overview

This PR fixes #101

Changes:

  • Added Translation process
  • Tried to configure server, but does not seem to work.

Related Issue / Discussion

bird-house/birdy#164

Additional Information

Links to other issues or sources.

@cehbrecht
Copy link
Member

get capabilities request ... :
http://localhost:5000/wps?request=GetCapabilities&service=WPS

... only shows en-US language:

<wps:Languages>
    <wps:Default>
      <ows:Language>en-US</ows:Language>
    </wps:Default>
    <wps:Supported>
      <ows:Language>en-US</ows:Language>
    </wps:Supported>
  </wps:Languages>

But the pywps 4.2.4 version should have language support:
geopython/pywps#510

@cehbrecht
Copy link
Member

cehbrecht commented Apr 20, 2020

@huard tests are failing. translation process needs to be added to the test_wps_caps.py test.

emu/default.cfg Outdated Show resolved Hide resolved
@cehbrecht
Copy link
Member

cehbrecht commented Apr 20, 2020

Translation is not shown:
http://localhost:5000/wps?request=DescribeProcess&service=WPS&version=1.0.0&identifier=translation&language=fr-CA

... title in English, not French:

<DataInputs>
      <ows:Title>Input1 number</ows:Title>

... it works when using the fr-CA as key in process definition:

LiteralInput('input1', 'Input1 number',
                         translations={"fr-CA": {"title": "Entrée #1", 

@huard
Copy link
Contributor Author

huard commented Apr 20, 2020

There was a mismatch between process and config. Should work now.

@huard
Copy link
Contributor Author

huard commented Apr 20, 2020

Want to add a German translation for your own demos ?

emu/processes/wps_translation.py Outdated Show resolved Hide resolved
@cehbrecht
Copy link
Member

Want to add a German translation for your own demos ?

@huard sure. I add it and make the merge.

@cehbrecht cehbrecht added this to the 1.0.0 milestone Apr 21, 2020
@cehbrecht
Copy link
Member

@huard I have added support for de-DE and fixed the tests and test.cfg config.

@cehbrecht cehbrecht merged commit dea910c into master Apr 21, 2020
@cehbrecht cehbrecht deleted the fix-101 branch April 21, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation process
2 participants