Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for wps_multiple_outputs #60

Merged
merged 4 commits into from
Sep 19, 2018
Merged

Add test for wps_multiple_outputs #60

merged 4 commits into from
Sep 19, 2018

Conversation

huard
Copy link
Contributor

@huard huard commented Sep 18, 2018

Overview

I think this exposes a potential bug in pywps. If we set as_reference to False for both outputs in the multiple_output process, only "reference" is sent back as data, while "output" is still transferred as a reference. Is this expected or the server should force the data to be included in the response ?

Also, the content is in CDATA format with escape characters. Again, not sure if this is expected or not.

@cehbrecht cehbrecht added this to the 0.10.0 milestone Sep 19, 2018
@cehbrecht
Copy link
Member

@huard I have never really checked to return complex inputs as data in the response document in pywps. It should return each output either as reference or as data (as requested in the execute request):

http://geoprocessing.info/wpsdoc/1x0ExecuteGETOutputs

Copy link
Member

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test looks fine.

@cehbrecht
Copy link
Member

@huard do you like to open an issue on pywps?

@cehbrecht cehbrecht merged commit 773d667 into master Sep 19, 2018
@cehbrecht cehbrecht deleted the mo_test branch September 19, 2018 11:53
@huard
Copy link
Contributor Author

huard commented Sep 19, 2018

Yes, I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants