Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output for float is now sum of floats passed as inputs. #90

Merged
merged 1 commit into from
Jun 4, 2019
Merged

output for float is now sum of floats passed as inputs. #90

merged 1 commit into from
Jun 4, 2019

Conversation

huard
Copy link
Contributor

@huard huard commented Jun 4, 2019

Overview

This PR fixes #89

Changes:

  • Slight change to wps_inout to allow passing multiple values for float parameter. Output is the sum of all floats.

@huard huard requested a review from cehbrecht June 4, 2019 16:04
cehbrecht
cehbrecht approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cehbrecht cehbrecht merged commit fb729f3 into master Jun 4, 2019
@cehbrecht cehbrecht deleted the fix-89 branch June 4, 2019 16:36
@cehbrecht cehbrecht added this to the 1.0.0 milestone Jun 4, 2019
@cehbrecht
Copy link
Member

@huard done. nice and simple :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cehbrecht cehbrecht cehbrecht approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Add input with multiple values (max_occurs > 1)
2 participants
@huard @cehbrecht