Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeling adjacent squares in surveyor sheets* #111

Open
dbl3raf opened this issue Dec 8, 2018 · 12 comments
Open

Labeling adjacent squares in surveyor sheets* #111

dbl3raf opened this issue Dec 8, 2018 · 12 comments
Assignees
Labels
hibernated Issue will be reassessed at a later date question Further information is requested

Comments

@dbl3raf
Copy link
Contributor

dbl3raf commented Dec 8, 2018

the latest batch of surveyor sheet maps uses hybrid maps - my reasoning was that it can be tricky to identify where many grid squares are, and that the labelling on the hybrid maps would help readers orientate, especially to some of the place names mentioned in the descriptions. But the extra labelling makes some of the maps a bit cluttered. Any thoughts @Louis-Backstrom ?

@dbl3raf dbl3raf added the question Further information is requested label Dec 8, 2018
@jeffreyhanson
Copy link
Member

Hmm, we could add an extra column into the grid-metadata.xlsx file that indicates which type of map (e.g. satellite, hybrid, etc) each surveyor sheet should contain?

@Louis-Backstrom
Copy link
Contributor

I agree that some labelling to help the reader orientate would be good, but I think it is too cluttered at the moment. We've already got cluttering problems with some maps and I think this would make it worse. The only other thought I have with maps to help the reader orientate would be to have the adjoining squares labelled on the map so they know the region - something like this?

image

Excuse the horrendous mouse on paint handwriting...

@dbl3raf
Copy link
Contributor Author

dbl3raf commented Dec 9, 2018

Labels for adjacent grid squares would be great if this is easy to program by @jeffreyhanson - and I love the suggestion of having a column where we could specify which map type each surveyor sheet should have. I think that squares with less survey effort really benefit from having hybrid maps, e.g. http://github.com/bird-team/brisbane-bird-atlas/releases/download/v.0.0.2/grid-10050-albany-creek.pdf

@jeffreyhanson
Copy link
Member

I'll have a go this weekend and see if I can add the column to specify the map type for each surveyor sheet. But adding labels to adjacent grid squares will be a lot trickier.

@jeffreyhanson
Copy link
Member

I have updated the code to use the map_type column in the grid metadata spreadsheet for the map types. However, it does not currently work because someone has enforced data types on the spreadsheet, and for what ever reason, Libre Office is treating the new column as a boolean or number - and this means that R is reading in the "hybrid" labels as 1s or missing values. Can someone please set the cell types to text or remove cell types from the spreadsheet?

@jeffreyhanson
Copy link
Member

I have also added a section to the wiki on changing the map types.

@Louis-Backstrom
Copy link
Contributor

I've just tried to change all the cell types to text in the grid metadata spreadsheet - should this fix the build errors?

@jeffreyhanson
Copy link
Member

Thanks for trying - but that didn't fix it. I'll just export it as a CSV then re-export as a XLSX.

jeffreyhanson added a commit that referenced this issue Dec 16, 2018
@dbl3raf
Copy link
Contributor Author

dbl3raf commented Dec 17, 2018

awesome, thanks @jeffreyhanson - I'll have a play when the build is working again

@Louis-Backstrom
Copy link
Contributor

Is this issue resolved for now? Can we hibernate it until @jeffreyhanson has time to play around with adding labels to adjacent grid squares?

@jeffreyhanson
Copy link
Member

Hmm, we have the functionality for hybrid maps (as per the original motivation in this thread), but we don't have the labels for adjacent grid cells that were suggested later in the issue - I suggest we hibernate it for now?

@Louis-Backstrom
Copy link
Contributor

Agreed. Done

@Louis-Backstrom Louis-Backstrom added the hibernated Issue will be reassessed at a later date label Mar 4, 2019
@Louis-Backstrom Louis-Backstrom changed the title Thoughts on hybrid maps? Labeling adjacent squares in surveyor sheets* Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hibernated Issue will be reassessed at a later date question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants