Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

List Devcoin (DVC) #3

Merged
merged 2 commits into from May 9, 2018
Merged

List Devcoin (DVC) #3

merged 2 commits into from May 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 3, 2018

blabno
blabno suggested changes May 7, 2018
View reviewed changes
Copy link
Collaborator

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK
Do not extend DefaultAddressValidator. It is deprecated.

@cbeams cbeams assigned ghost May 7, 2018
cbeams
cbeams suggested changes May 7, 2018
View reviewed changes
Copy link
Member

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK. The test also doesn't test anything.

ghost
ghost commented May 7, 2018
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced DefaultAddressValidator since it is deprecated
Updated the Test to check for valid addresses

@cbeams cbeams merged commit 3043d26 into bisq-network:master May 9, 2018
cbeams added a commit that referenced this pull request May 9, 2018
@cbeams
Merge pull request #3 from ctya/list-devcoin-asset
668a628 
List Devcoin (DVC)
@ghost ghost mentioned this pull request Aug 17, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeams @blabno