Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <a> title attribute to os selector #350

Closed
wants to merge 2 commits into from

Conversation

RiccardoMasutti
Copy link
Contributor

Meta title tags are a major factor in helping search engines understand what pages are about. Title tags are used in three key places:

  • search engine results pages (SERPs)
  • web browsers
  • social networks.

@m52go
Copy link
Contributor

m52go commented Mar 2, 2020

@RiccardoMasutti did we discuss priority or budget for #350, #349, #348, and #347?

@RiccardoMasutti
Copy link
Contributor Author

@m52go no we didn't.
I proposed those changes without defining the budget because they are all low-budget changes; I thought I'd discuss it with you once all the PRs were added

@m52go
Copy link
Contributor

m52go commented Mar 4, 2020

With your request history, I'm not sure what "low-budget" means. Also it takes time and and effort for reviewers to review, and your past PRs have taken lots of time to review and fix, so your time and budget is not the only consideration.

Above all, this isn't the general workflow in place for growth. Compensation and priority must be determined before making pull requests. Specifically for you, we decided you'd make issues before making any pull requests—right?

I would have rejected the notion of making these changes if you had run them by me beforehand, so I'm rejecting them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants