Add null checks

Return early at connection if stopped Cleanup logs
bisq-network · Dec 8, 2021 · 3d40b3b · 3d40b3b
1 parent 2474e0d
commit 3d40b3b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/common/src/main/java/bisq/common/ClockWatcher.java b/common/src/main/java/bisq/common/ClockWatcher.java
@@ -80,7 +80,9 @@ public void start() {
     }
 
     public void shutDown() {
-        timer.stop();
+        if (timer != null) {
+            timer.stop();
+        }
         timer = null;
         counter = 0;
     }

diff --git a/core/src/main/java/bisq/core/app/BisqExecutable.java b/core/src/main/java/bisq/core/app/BisqExecutable.java
@@ -286,7 +286,7 @@ private void flushAndExit(ResultHandler resultHandler, int status) {
             // If user tried to downgrade we do not write the persistable data to avoid data corruption
             log.info("PersistenceManager flushAllDataToDiskAtShutdown started");
             PersistenceManager.flushAllDataToDiskAtShutdown(() -> {
-                log.info("Graceful shutdown resulted in an error. Exiting now.");
+                log.info("Graceful shutdown completed. Exiting now.");
                 resultHandler.handleResult();
                 UserThread.runAfter(() -> System.exit(status), 100, TimeUnit.MILLISECONDS);
             });

diff --git a/p2p/src/main/java/bisq/network/p2p/network/Connection.java b/p2p/src/main/java/bisq/network/p2p/network/Connection.java
@@ -727,6 +727,9 @@ public void run() {
                     }
 
                     if (proto == null) {
+                        if (stopped) {
+                            return;
+                        }
                         if (protoInputStream.read() == -1) {
                             log.warn("proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown.");
                         } else {

diff --git a/p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java b/p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java
@@ -156,7 +156,6 @@ public void shutDown(@Nullable Runnable shutDownCompleteHandler) {
             try {
                 tor = Tor.getDefault();
                 if (tor != null) {
-                    log.info("Tor has been created already so we can shut it down.");
                     tor.shutdown();
                     tor = null;
                     log.info("Tor shutdown completed");