Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fails if language is not set to en_US #2259

Closed
ManfredKarrer opened this issue Jan 12, 2019 · 0 comments
Closed

Test fails if language is not set to en_US #2259

ManfredKarrer opened this issue Jan 12, 2019 · 0 comments
Assignees
@ripcurlx @blabno @devinbileck
Labels
a:bug re:testing

Comments

@ManfredKarrer
Copy link
Member

CurrencyListTest.testUpdateWhenNotSortNumerically fails for some users.

See #1562 (comment)

"My system's locale is lt_LT.UTF-8. Using LC_ALL=en_US fixes the problem."
@ManfredKarrer ManfredKarrer mentioned this issue Jan 12, 2019
Closed
devinbileck added a commit to devinbileck/bisq that referenced this issue Jan 14, 2019
@devinbileck
Fix CurrencyListTest when locale is not en_US
7a16b3f 
When declaring a fiat currency and only providing the currency code,
it uses the system locale to get the currency display name.
This potentially causes different sorting results in
testUpdateWhenNotSortNumerically when locale is not en_US.

Now, it specifies the en_US locale when defining the fiat currencies
for this test.

Fixes bisq-network#2259
@devinbileck devinbileck mentioned this issue Jan 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

@blabno blabno

@devinbileck devinbileck

Labels
a:bug re:testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ripcurlx @blabno @devinbileck @ManfredKarrer