Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoneyBeam N26 account doesnt have any validation to create #3458

Closed
beingindot opened this issue Oct 24, 2019 · 1 comment · Fixed by #3573
Closed

MoneyBeam N26 account doesnt have any validation to create #3458

beingindot opened this issue Oct 24, 2019 · 1 comment · Fixed by #3573
Labels
a:bug good first issue in:gui in:payment-methods

Comments

@beingindot
Copy link
Contributor

Description

MoneyBeam N26 account doesn't have any validation to create

Version

1.2.0

Steps to reproduce

  1. select MoneyBeam N26
  2. just type space key
  3. save new account enabled.

Expected behaviour

Should have email/phone validation also account name should be there i guess.

Actual behaviour

Able to save new account with just space key.

Screenshots

Screenshot from 2019-10-24 21-55-56

Device or machine

Ubuntu

Additional info
@beingindot
Copy link
Contributor Author

working on it. will push PR

beingindot added a commit to beingindot/bisq that referenced this issue Nov 7, 2019
@beingindot
Added check for empty validation
31645f5 
This commit is for github issue bisq-network#3458 and bisq-network#3459
check added for moneybeam and national bank transfer
This was referenced Nov 7, 2019
Merged
Closed
beingindot added a commit to beingindot/bisq that referenced this issue Nov 12, 2019
@beingindot
Added check for empty validation
133d40a 
This commit is for github issue bisq-network#3458 and bisq-network#3459
check added for moneybeam and national bank transfer
beingindot added a commit to beingindot/bisq that referenced this issue Nov 13, 2019
@beingindot
Added check for empty validation
755ca19 
This commit is for github issue bisq-network#3458 and bisq-network#3459
check added for moneybeam and national bank transfer
@beingindot beingindot mentioned this issue Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug good first issue in:gui in:payment-methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added check for empty validation beingindot/bisq
2 participants
@freimair @beingindot