Add asset listing fee #1904
Merged
Add asset listing fee #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into cbeams-delist-untraded-assets
# Conflicts: # desktop/src/main/java/bisq/desktop/util/GUIUtil.java # desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java
# Conflicts: # core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java
# Conflicts: # desktop/src/main/java/bisq/desktop/util/GUIUtil.java # desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java
|
See bisq-network/proposals#42 for context... I uploaded here a video to demonstrate the implementation: |
sqrrm
approved these changes
Nov 11, 2018
core/src/main/java/bisq/core/dao/state/model/blockchain/OpReturnType.java
Show resolved
Hide resolved
core/src/main/java/bisq/core/dao/state/model/blockchain/OpReturnType.java
Show resolved
Hide resolved
core/src/main/java/bisq/core/dao/state/model/blockchain/OpReturnType.java
Show resolved
Hide resolved
|
@sqrrm The suggested changes are not clear to me from the GH view. Could you describe or post the whole suggested change code? |
|
Hmm, yeah, thought it would be smooth to do it inline, better you do it. I just noticed the PROOF_OF_BURN and ASSET_LISTING_FEE coming before lockup in most enums so I tried to make it consistent, not very clear perhaps in my suggested changes. |
|
Its only in TxOutputType but there its opReturn types which are all grouped. All others are as well after lockup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.