Issue 2021 - Asset validation override issues in many coin extensions #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix length issue in regular expression of validate() override in main asset coins.
PIVX most likely started the 1+{25,34} that was then proliferated through the copies.
While it likely should be 1+33, I could only confirm that 35 is too long, so the
code is changed to be 1+{24,33} in order to reduce it by the presumed forgotten first
character.
- Fixup testInvalidAddresses() to better test regex rules in test asset coins. The PIVX
base code was testing against 3 addresses, that all had a different first character,
therefore none of the rest of the regular expression was being tested. Changed those
addresses (and others for other susceptable coins) to accurately test first character
match, length, and invalid characters in the 24 to 33 series.
|
Thanks, much better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIVX most likely started the 1+{25,34} that was then proliferated through the copies.
While it likely should be 1+33, I could only confirm that 35 is too long, so the
code is changed to be 1+{24,33} in order to reduce it by the presumed forgotten first
character.
base code was testing against 3 addresses, that all had a different first character,
therefore none of the rest of the regular expression was being tested. Changed those
addresses (and others for other susceptable coins) to accurately test first character
match, length, and invalid characters in the 24 to 33 series.