Left align columns, except last one #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last columns with avatars or icons are centered Use IBM Sans in columns
|
I think those colums with buttons (Select) or checkboxes should be centered still or the header alignment aligned with the button text. But no strong opinions here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted the left align style for all columns except the last one based on the design of @pedromvpg. I saw that for avatars and icons that are in the last column they were centered, so I implemented it like that. @pedromvpg Could you please have a look if it is as you wanted it to have?
Maybe we could discuss in this PR also the line height of rows in certain screens. It came up during the release that some are not very happy with the line height as it will show less information now than it did before.
The question is f the user has the requirement to get everything in one screen or if the extended height of the rows is more pleasant to watch.
As this is an design issue @pedromvpg has the last call, but it seems there should be some public discussion on this.