Refine various ui strings #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfredKarrer
approved these changes
Dec 10, 2018
| @@ -807,26 +807,26 @@ support.buyerOfferer=BTC buyer/Maker | |||
| support.sellerOfferer=BTC seller/Maker | |||
| support.buyerTaker=BTC buyer/Taker | |||
| support.sellerTaker=BTC seller/Taker | |||
| support.backgroundInfo=Bisq is not a company and does not provide any kind of customer support.\n\n\ | |||
| support.backgroundInfo=Bisq is not a company and does not guarantee customer support.\n\n\ | |||
There was a problem hiding this comment.
Maybe we can rewrite that. It sounds a bit harsh to say there is no support. In fact our support is better than in many companies. its just nto company provided but community driven....
There was a problem hiding this comment.
Ha yes, I thought the same thing, but assumed it was on purpose for legal reasons so I didn't change it. Pushing an update now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I installed a fresh copy of Bisq to test the DAO, some of the text in the UI looked like it could use some edits.
This PR includes edits to a variety of text, beyond what I saw, but I only made significant changes (e.g., adding a line break) to elements that I came across myself which I knew for sure could handle them.
There were a couple places I wanted to add a new line break, but wasn't sure if the UI could handle it, so I passed (in order to avoid creating any other issues).