inject clock for usage in isDateInTolerance #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clock doesn't seem to be used yet, are those commits coming? |
|
i have a different PR that adds unit tests for the |
|
For these kinds of PRs it would be good to have an explanation of why they're needed. It's not obvious why this one is needed without the follow up conversation. |
ok. |
julianknutsen
added a commit
to julianknutsen/bisq
that referenced
this pull request
Nov 7, 2019
Convert the isDateInTolerance code to use the already available clock instead of using new Date().getTime(). This allow finer control of time in tests and finishes the intention of bisq-network#3037.
julianknutsen
added a commit
to julianknutsen/bisq
that referenced
this pull request
Nov 7, 2019
Attach a Clock object that can be used instead of System.currentTimeMillis() so that we have more control over the testing of time-sensitive code. Specifically, the code around expiration. This involves attaching a Clock to the resolver so all fromProto methods have one available when they reconstruct a message. This uses the Injector for the APP and a default Clock.systemDefaultZone is used in the manual instantiations. Work was already done in bisq-network#3037 to make this possible. All tests still use the default system clock for now.
julianknutsen
added a commit
to julianknutsen/bisq
that referenced
this pull request
Nov 7, 2019
Attach a Clock object that can be used instead of System.currentTimeMillis() so that we have more control over the testing of time-sensitive code. Specifically, the code around expiration. This involves attaching a Clock to the resolver so all fromProto methods have one available when they reconstruct a message. This uses the Injector for the APP and a default Clock.systemDefaultZone is used in the manual instantiations. Work was already done in bisq-network#3037 to make this possible. All tests still use the default system clock for now.
julianknutsen
added a commit
to julianknutsen/bisq
that referenced
this pull request
Nov 13, 2019
Switch from System.currentTimeMills() to Clock.millis() so dependency injection can be used for tests that need finer control of time. This involves attaching a Clock to the resolver so all fromProto methods have one available when they reconstruct a message. This uses the Injector for the APP and a default Clock.systemDefaultZone is used in the manual instantiations. Work was already done in bisq-network#3037 to make this possible. All tests still use the default system clock for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.