Fix small p2p network issues #3154
Conversation
ripcurlx
changed the title
|
@chimp1984 I've added [WIP] to your title, so it is easier to see that you are still working on this. |
# Conflicts: # core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java
chimp1984
changed the title
|
Maybe @sqrrm or @ManfredKarrer could give it a quick ACK again. From my side changes seem to be fine. |
|
looks good. some of the commits messages could be improved by explaining why the change was done, and also the pr description could explain the overall motivation. |
@chimp1984 Yes, please just add a small description for your PRs in the future. Everything looks perfectly fine, what you are contributing, but it helps to review if there is more context. |
also a good idea: reformat in a separate commit |
We do better next time.
I use the formatting settings from the IDEA which are part of the project and as far I understand formatting should be applied before commit.
Agree. |
| /** | ||
| * Marker interface for messages which must not be added again after a remove message has been received (e.g. MailboxMessages). | ||
| */ | ||
| public interface AddOncePayload { |
There was a problem hiding this comment.
Is there an issue number that this change fixes? After reviewing and refactoring this code I'm having trouble understanding the bug that would have needed this fix. I'd like to try and reproduce it in my tests, if possible.
No description provided.