Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account validation #3575

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Conversation

beingindot
Copy link
Contributor

#3460

Added empty check validation for
popmoney/uphold/revolut/zelle

bank forms already have required changes with previous PR.

chimp1984
chimp1984 previously approved these changes Nov 12, 2019
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Please see my comments

@ripcurlx
Copy link
Contributor

@beingindot Also all your commits need signing and you need to resolve the conflict now that your other PR got merged.

@beingindot
Copy link
Contributor Author

@ripcurlx Resolved conflicts and included changes. pls check.

@ripcurlx ripcurlx merged commit 7e08d66 into bisq-network:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants