Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve test failures on windows #3960

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Resolve test failures on windows #3960

merged 3 commits into from
Feb 11, 2020

Commits on Feb 10, 2020

  1. Close stream writer prior to deleting temp file 

    On Windows, instantiating the stream writer appears to lock the file,
preventing the file from being deleted. This was causing the assertion
that the file is deleted to fail.
    @devinbileck
    devinbileck committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    12e2da9 View commit details
    Browse the repository at this point in the history

  2. Use proper file path on Windows 

    On Windows, the exception message contained backwards slashes causing
the test to fail.
    @devinbileck
    devinbileck committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    d0eb759 View commit details
    Browse the repository at this point in the history

  3. Resolve codacy issues

    @devinbileck
    devinbileck committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    cb9cb65 View commit details
    Browse the repository at this point in the history