Update offer address to new hidden service files #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freimair
changed the title
wiz
approved these changes
Mar 4, 2020
ripcurlx
added
the
is:priority
This was referenced Mar 11, 2020
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivated by and fixes #3995, at least its symptoms
When the hiddenservice address changes, offers now get updated to the new address before republishing. If there are open trades, they will still fail but at least there are no faulty offers out there anymore. Plus, a user might wonder why nobody takes his offers.
Happens if Bisq silently starts a fresh hiddenservice. Reasons for that to happen might be: