Reduce # of hash calculations in UI OfferBook view #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can cache an offer payload hash as soon as its `offerFeePaymentTxId` is set. (The payload hash cannot be calculated until the object can be transformed into a protobuf message, which requires a non-null offerFeePaymentTxId.) Another benefit is removal of the payload hash argument from the `OfferBookListItem` constructor. Changes include - `OfferPayload` Added `transient byte[] hash` field + getter method (where hash is calculated and cached). - `OfferBookService` Removed `P2PDataStorage.ByteArray hashOfPayload` parameter from `OfferBookChangedListener` listener methods `onAdded` & `onRemoved`. (Hash is cached in `OfferPayload`.) - `P2PDataStorage` Added null check to `ByteArray` class constructor. - `OfferBook` Adjusted for change to `OfferBookChangedListener`. Also removed redundant payload hash null checks. - `TakeOfferDataModel` and `MarketAlerts` Adjusted for change to `OfferBookChangedListener`. - `OfferBookListItem` Removed overloaded constructor with `@Nullable P2PDataStorage.ByteArray hashOfPayload` parameter. (Field value is set from cached offer payload hash.) - `OfferBookViewModelTest` and `OfferMaker` Adjusted test and test fixture: do not attempt to create offer payloads without an `offerFeePaymentTxId`.
ripcurlx
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can cache an offer payload hash as soon as its
offerFeePaymentTxIdis set. (The payload hash cannot be calculated until the object can be transformed into a protobuf message, which requires a non-nullofferFeePaymentTxId.)Another benefit is removal of the payload hash argument from the
OfferBookListItemconstructor.Changes include
OfferPayloadAddedtransient byte[] hashfield + getter method (where hash is calculated and cached).OfferBookServiceRemovedP2PDataStorage.ByteArray hashOfPayloadparameter fromOfferBookChangedListenerlistener methodsonAdded&onRemoved. (Hash is cached inOfferPayload.)P2PDataStorageAdded null check toByteArrayclass constructor.OfferBookAdjusted for change toOfferBookChangedListener, and removed redundant payload hash null checks.TakeOfferDataModelandMarketAlertsAdjusted for change toOfferBookChangedListener.OfferBookListItemRemoved overloaded constructor with@Nullable P2PDataStorage.ByteArray hashOfPayloadparameter. (Field value is set from cached offer payload hash.)OfferBookViewModelTestandOfferMakerAdjusted test and test fixture: do not attempt to create offer payloads without anofferFeePaymentTxId.Follow up to the last PR in series to support API
editoffermethod.