Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI bug fix: show trade's contract volume, not moving offer volume #5704

Merged
merged 4 commits into from
Sep 27, 2021

Commits on Sep 17, 2021

  1. Show frozen fiat trade cost in CLI console

    This is a bug fix for the CLI's displayed fiat trade cost
    value, which should be trade.volume, not offer.volume.  Offer volume
    varies with BTC volatility, and the CLI should be showing the trade.volume
    value instead, frozen when the contract is made.
    ghubstan committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    484f882 View commit details
    Browse the repository at this point in the history
  2. Show correct altcoin trade amount (volume) in CLI console

    This is a bug fix for the CLI's displayed altcoin trade amount
    value, which should be trade.volume, not offer.volume.  It has been
    hidden by the stability of the BSQ price, and exposed while testing
    API support for XMR trades.
    ghubstan committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    a0f3d0a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Fix typo in help text

    ghubstan committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    542aa77 View commit details
    Browse the repository at this point in the history
  2. Show trade.price in margin based altcoin 'gettrade' console output

    Fixes problem simlar to other CLI output changes in this PR.
    CLI's 'gettrade' output should show contracted trade.price instead of
    moving offer.price value for price margin based altcoin offers.
    
    This fixed bug did not affect any fiat or BSQ trades, only price margin
    based XMR trades, and API support for XMR trading has not yet been
    released.
    ghubstan committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    55cb126 View commit details
    Browse the repository at this point in the history