Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required for GRIN re-listing #5820

Merged
merged 1 commit into from Nov 11, 2021
Merged

Changes required for GRIN re-listing #5820

merged 1 commit into from Nov 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2021

bisq-network/proposals#350
bisq-network/growth#205 (comment)

Screenshots

Account creation

image

Account creation

image

Account creation popup

grin_account_popup

Trade, start payment

grin_payment_start

Trade, confirm payment received

grin_confirm_payment

@boring-cyborg boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Nov 10, 2021
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.0 milestone Nov 11, 2021
@ripcurlx
Copy link
Contributor

I'll re-enable the Grin support in the app as soon as the proposal is approved.

@ripcurlx ripcurlx merged commit de5805c into bisq-network:master Nov 11, 2021
@ghost ghost mentioned this pull request Nov 18, 2021
@ripcurlx
Copy link
Contributor

@jmacxx Do we need some pricenode changes for it as well, or will it be offered as a fixed price only pair?
Bildschirmfoto 2021-11-24 um 10 39 44

@ghost
Copy link
Author

ghost commented Nov 24, 2021

It'll be like the BSQ market, where the price is determined by the offers in Bisq itself GRIN is not on any of the big exchanges, so I think a feed would not be applicable. Documented in the wiki

@ghost ghost deleted the grin_slatepack branch May 29, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants