Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment methods ACH Transfer and Domestic Wire Transfer #5823

Merged
merged 1 commit into from Nov 12, 2021
Merged

Add payment methods ACH Transfer and Domestic Wire Transfer #5823

merged 1 commit into from Nov 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2021

Fixes bisq-network/growth#219
Fixes bisq-network/growth#218

  • Makes use of existing BankAccountPayload having most of the fields already; adds holder_address in specializations.
  • AccountForm code is shared between the two payment methods due to the similarity.

Screenshots for ACH Transfer

Account Creation

ach_account_popup

image

Popup shown to Buyers

ach_buyer_popup

Popup shown to Sellers

ach_seller_popup

Start Payment

ach_start_payment

Confirm Payment

ach_confirm_payment


Screenshots for Domestic Wire Transfer

Account Creation

domwire_account_popup

domwire_account

Popup shown to Buyers

domwire_buyer_popup

Popup shown to Sellers

domwire_seller_popup

Start Payment

domwire_start_payment

Confirm Payment

domwire_confirm_payment

Trades

image

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.0 milestone Nov 12, 2021
@ripcurlx ripcurlx merged commit 17d4d42 into bisq-network:master Nov 12, 2021
@ghost ghost mentioned this pull request Nov 18, 2021
@ghost ghost deleted the add_ach_domestic_wire branch October 18, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ACH Transfer - USA as payment method Add Domestic Wire Transfer - USA as payment method
1 participant