Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of missing Failed Trade tab #5831

Merged
merged 1 commit into from Nov 16, 2021
Merged

Fix display of missing Failed Trade tab #5831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions desktop/src/main/java/bisq/desktop/main/portfolio/PortfolioView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public class PortfolioView extends ActivatableView<TabPane, Void> {
private boolean editOpenOfferViewOpen;
private OpenOffer openOffer;
private OpenOffersView openOffersView;
private int initialTabCount = 0;

@Inject
public PortfolioView(CachingViewLoader viewLoader, Navigation navigation, FailedTradesManager failedTradesManager) {
Expand All @@ -82,6 +83,7 @@ public PortfolioView(CachingViewLoader viewLoader, Navigation navigation, Failed

@Override
public void initialize() {
initialTabCount = root.getTabs().size();
root.setTabClosingPolicy(TabPane.TabClosingPolicy.ALL_TABS);
failedTradesTab.setClosable(false);

Expand Down Expand Up @@ -151,10 +153,10 @@ private void onDuplicateOfferRemoved() {
@Override
protected void activate() {
failedTradesManager.getObservableList().addListener((ListChangeListener<Trade>) c -> {
if (failedTradesManager.getObservableList().size() > 0 && root.getTabs().size() == 3)
if (failedTradesManager.getObservableList().size() > 0 && root.getTabs().size() == initialTabCount)
root.getTabs().add(failedTradesTab);
});
if (failedTradesManager.getObservableList().size() > 0 && root.getTabs().size() == 3)
if (failedTradesManager.getObservableList().size() > 0 && root.getTabs().size() == initialTabCount)
root.getTabs().add(failedTradesTab);

root.getSelectionModel().selectedItemProperty().addListener(tabChangeListener);
Expand Down