Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPEs in Portfolio View wrt. BSQ swap #5888

Merged
merged 1 commit into from Dec 3, 2021
Merged

Fix NPEs in Portfolio View wrt. BSQ swap #5888

merged 1 commit into from Dec 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2021

  1. Alice creates a BSQ swap offer
  2. Bob takes the offer
  3. While the trade is unconfirmed, Bob or Alice closes Bisq and then re-starts.
  4. Go to Portfolio -> Unconfirmed BSQ Swap
  5. Type into the Filter input box.
  6. An NPE occurs.
  7. Confirm the trade.
  8. Go to Portfolio -> History
  9. Type into the Filter input box.
  10. An NPE occurs.

Screenshot from 2021-12-02 12-52-15

Screenshot from 2021-12-02 12-53-13

Screenshot from 2021-12-02 13-07-48

@ripcurlx ripcurlx added this to the v1.8.0 milestone Dec 3, 2021
ripcurlx
ripcurlx approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested on Regtest

@ripcurlx ripcurlx merged commit b9fa9d6 into bisq-network:master Dec 3, 2021
@ripcurlx ripcurlx mentioned this pull request Dec 20, 2021
Closed
@ghost ghost mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ripcurlx