Improve shutdown process #5905
Merged
Improve shutdown process #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires still tor when sending close messages. Reduce timeout from 5 sec to 2 sec. Reduce timeout for executor shutdown from 500 ms to 100 ms
Move timeout before shutdown sequence starts and use a Timer thread instead of UserThread to avoid that in case the UserThread gets blocked that the timeout would not get triggered. Reduce timeout from 20 sec. to 10 sec.
Add logs when shutdown starts
Return early at connection if stopped Cleanup logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed several times that the app shutdown got blocked for about 1 minute. I could not find out what blocks it, but I suspect its in the network/tor layer. I added more logs to make it easier to spot the issue and improved the shutdown process as well as reduced the timeouts. There was also a incorrect handling of the tor shutdown process which got fixed.