Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoind: Fix blockHash ZMQ test #2745

Merged
merged 5 commits into from
Sep 3, 2024
Merged

bitcoind: Fix blockHash ZMQ test #2745

merged 5 commits into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. wallets: Don't wait for subprocess shutdown after response 

    We send a `stop` RPC call and wait for the subprocess after receiving a
`success/ok` message. This is unnecessary because we received a `success`
reply already.
    @alvasw
    alvasw committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2b5e36e View commit details
    Browse the repository at this point in the history

  2. wallets: Fix bitcoind deadlock 

    We parse stdout and wait for the "init message: Done loading" line to
detect when bitcoind is ready. After seeing this line, we stop reading
stdout causing the stdout buffer to fill up. When the stdout buffer
fills up, bitcoind waits until its parent process reads from it but this
unfortunately never happens leading to a deadlock.
    @alvasw
    alvasw committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dedc162 View commit details
    Browse the repository at this point in the history

  3. BitcoindProcess: Reuse BitcoinDaemon class instance in stop call

    @alvasw
    alvasw committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8fefd91 View commit details
    Browse the repository at this point in the history

  4. Remove BitcoindZeroMqRawTxIntegrationTests 

    The assumptions and expectations of the tests are wrong.
    @alvasw
    alvasw committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6e4e5e9 View commit details
    Browse the repository at this point in the history

  5. bitcoind: Fix blockHash ZMQ test 

    The test mines blocks and waits until it sees the block hashes of the
mined blocks over ZMQ. Unfortunately, ZMQ publishers are stateless and
can't re-transmit lost messages [1]. Consequently, the test was wrong.
The fixed test subscribes to the publisher, starts mining blocks, and
waits until it observes a new block hash.

[1] https://zguide.zeromq.org/docs/chapter5/#Pros-and-Cons-of-Pub-Sub
    @alvasw
    alvasw committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    42dc646 View commit details
    Browse the repository at this point in the history