Use JRE instead of JDK Desktop Binary #2773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
Use Gradle Java Toolchain--> Couldn't get it to pick up the JREDownload JRE manually and use it for runtime--> Too complicated, increase build timesResults
How to test this PR
$ ./gradlew apps:desktop:desktop-app-launcher:clean apps:desktop:desktop-app-launcher:generateInstallers --info
apps/desktop/desktop-app-launcher/build
folder thecustom-jre
folder with the gerated skimmed JRE, and inpackages/jpackages/package/Bisq2...
the installer corresponding to your env (e.g. Bisq2....dmg) . Install it and run the app. Also check the size of the binary. Please comment your results with details on your environment in this PR.Known Issues / Future lines of improvement
Dev Commit logs