Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Major update #61

Draft
wants to merge 69 commits into
base: master
Choose a base branch
from

Conversation

devinbileck
Copy link
Member

@devinbileck devinbileck commented Jan 26, 2024

Changelog

UI improvements

  • Refine layout, content, and colors of all UI screens
  • Implemented an action menu in notification table screen
  • Reworked settings screen
  • Implemented dark mode with dark/light mode selection

Features

  • Add support for handling data-only push notification messages (pending changes to bisq-relay)
  • Allow prompts to be dismissed by navigating back or clicking elsewhere on screen

Fixes

  • Reset device should preserve token and generate new key
  • Prevent navigating back in various scenarios
  • Correct send pairing token label and fix intent type

Outstanding tasks

  • Review TODO's and either resolve them or create issues
  • Perform complete system testing following test docs

@devinbileck devinbileck force-pushed the major-update branch 2 times, most recently from 52bb51e to bed269a Compare January 31, 2024 07:58
@devinbileck devinbileck changed the title Major update [WIP] Major update Jan 31, 2024
@devinbileck devinbileck marked this pull request as draft January 31, 2024 20:11
@devinbileck devinbileck force-pushed the major-update branch 2 times, most recently from 0169d4d to 1bb66cb Compare February 1, 2024 21:43
The latest version of Gradle does not seem to like having duplicate
source sets between androidTest and test for a common directory
within the same module.
- Refine layout, content, and colors of all UI screens
- Implemented an action menu in notification table screen
- Reworked settings screen
- Implemented dark mode with dark/light mode selection
minSdkVersion was bumped to 26 so as not to worry about
handling older versions that may not fully support
notifications. This corresponds to Android 8 (released
in 2017) and as of now currently covers 94.9% of all
Android users (according to apilevels.com/) and
over 99% of our install base.
Using text/plain type should hopefully ensure a copy option
is always available in the chooser.
The default version used by the action (29.0.3) is no longer available
in the latest ubuntu images, causing the action to fail. This change
will allow the action to always use the latest version available.
Jobs should be allowed to complete in order to get complete results
of all matrix combinations.
The buildType value was not being set when running the connectedCheck
task for instrumentation tests in CI. I did not find a better approach
to determining the build type other then checking the task being
executed. Therefore, just assume debug in the androidTests reports
directory.
Tests for some API levels were failing for not having Google Play
services available.
Try to use google_apis target for all APIs in CI instrumentation tests.
It seems the restrictions for google_atd system images are no
longer applicable.
@Setarland
Copy link

salam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants