Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] For Cycle 8 #416

Closed
RiccardoMasutti opened this issue Nov 21, 2019 · 4 comments
Closed

[WIP] For Cycle 8 #416

RiccardoMasutti opened this issue Nov 21, 2019 · 4 comments

Comments

@RiccardoMasutti
Copy link

RiccardoMasutti commented Nov 21, 2019

Summary

Specify the total amount of BSQ you are requesting:

  • BSQ requested:

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

Code Development

Bisq Website:
bisq-network/bisq-website#290
bisq-network/bisq-website#291
bisq-network/bisq-website#307

Code Review

bisq-network/bisq-website#267
bisq-network/bisq-website#279
bisq-network/bisq-website#280
bisq-network/bisq-website#284
bisq-network/bisq-website#289
bisq-network/bisq#3647
bisq-network/incubator-bisq-api#21
bisq-network/incubator-bisq-xmr-integration#2
bisq-network/bisq#3681
bisq-network/bisq-website#302
bisq-network/bisq-website#303

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Code Development

Bisq Website:

Bisq Explorer:
bisq-network/bisq-explorer#9

Roles performed

Provide links to your monthly report on any roles you are responsible for.

Bisq-desktop italian translator
https://www.transifex.com/bisq/bisq-desktop/viewstrings/#it/displaystringsproperties/110522284?q=translator%3ARiccardo

Twitter Italian Account Maintainer
https://twitter.com/BisqITA

Keybase Italian Team Maintainer
https://keybase.io/team/bisq_italia

Telegram Italian Group Maintainer
https://t.me/BisqITA

@m52go
Copy link

m52go commented Nov 28, 2019

I would suggest you to slow down. I appreciate your initiative and go-for-it approach, and realize every contributor will have their own style of doing things, so take this as constructive advice.

  1. Reviews are typically done by people with at least a handful of merged contributions, otherwise it's hard to attribute any significance to the reviews.

  2. A number of items you listed above haven't been merged yet. At least one item wasn't even performed as claimed on this compensation request. And none of your reviews have included any comments, even on ones that have generated discussion like this one. And on what basis did you approve these changes to the Bisq software itself? It could be that you're planning to review the items you've listed before the end of the cycle, but as it stands, the impression you're giving is that you're stacking contributions to get as fat a paycheck as possible.

  3. The roles you listed are not roles. These are roles. It's fine do that stuff (i.e., create new accounts and venues for discussing Bisq) but it's premature to count them as roles performed.

I highly recommend that you consider discussing your ideas and goals with other contributors first. Are you on Keybase? I don't recognize your handle (not sure if you go by another one elsewhere).

This would help make your work more broadly accepted. For example, why start a whole new Keybase team for Italian, instead of simply creating a new channel on the existing Keybase team? Is your approach wrong? Not necessarily. But not discussing something potentially controversial and then asking to be paid for it is not a good approach.

@RiccardoMasutti
Copy link
Author

RiccardoMasutti commented Nov 29, 2019

I would suggest you to slow down. I appreciate your initiative and go-for-it approach, and realize every contributor will have their own style of doing things, so take this as constructive advice.

  1. Reviews are typically done by people with at least a handful of merged contributions, otherwise it's hard to attribute any significance to the reviews.
  2. A number of items you listed above haven't been merged yet. At least one item wasn't even performed as claimed on this compensation request. And none of your reviews have included any comments, even on ones that have generated discussion like this one. And on what basis did you approve these changes to the Bisq software itself? It could be that you're planning to review the items you've listed before the end of the cycle, but as it stands, the impression you're giving is that you're stacking contributions to get as fat a paycheck as possible.
  3. The roles you listed are not roles. These are roles. It's fine do that stuff (i.e., create new accounts and venues for discussing Bisq) but it's premature to count them as roles performed.

I highly recommend that you consider discussing your ideas and goals with other contributors first. Are you on Keybase? I don't recognize your handle (not sure if you go by another one elsewhere).

This would help make your work more broadly accepted. For example, why start a whole new Keybase team for Italian, instead of simply creating a new channel on the existing Keybase team? Is your approach wrong? Not necessarily. But not discussing something potentially controversial and then asking to be paid for it is not a good approach.

Hi @m52go , I didn't know that code reviews are done only by reputable sources. I read differently here.

About my reviews, it wasn't a try to get a big paycheck, exactly the opposite. I will not request anything for those reviews as there's no content, fixes or suggestions, but just simple approvals. In my opinion were ready.

It was a way to manage all the work I'm doing and simultaneously show to the rest of the contributors what I'm working on.
I apologize for any errors or incorrectness but it is my first contributiond Cycle :)

About newly created social accounts, I did by reading your comment here: bisq-network/growth#142 (comment)

And by following @MwithM.
I saw him managing spanish Twitter account and then I realized there was a lot of foreign accounts like FR, PT, BR, etc.
I did the same for Telegram and Keybase.

Why?

Because here in Italy there's a huge informational gap about Bisq and decentralized networks/exchanges so I though it would be a great idea to launch italian channels to give support in italian.

Not only that, I will personally translate the entire website, software and subtitles in italian.
bisq-network/bisq-website#173

What I want to show by doing this is that in Italy there is a great interest and need for Bisq.

Ps: I requested italian language project on Transifex to both subtitles and website.
I'm already working hard on software and should be ready and reviewed in 1-2 weeks.

@m52go
Copy link

m52go commented Nov 29, 2019

Great to hear @RiccardoMasutti, and I didn't mean to accuse. Maybe it was just a matter of first impressions that didn't look right.

As you'll see in the doc you linked, it also says:

With that said, it’s a good idea to consult with stakeholders via Slack, GitHub, the mailing list, or other communication channels before setting out on any serious contribution effort.

Typically people use GitHub and Keybase (formerly Slack) to introduce themselves and keep people informed of in-progress and upcoming work, and compensation requests are the final result of a cycle's work. It seems like you did the opposite, and used the compensation request as a way to communicate your in-progress work instead.

I guess that's not a bad thing, but like I said above, without having ever interacted with you before, it seemed strange to me.

Thanks for your work so far. I encourage you to consider making GitHub issues and being more active on Keybase to send people signals of what you're up to, instead of relying on your compensation requests.

@RiccardoMasutti
Copy link
Author

Great to hear @RiccardoMasutti, and I didn't mean to accuse. Maybe it was just a matter of first impressions that didn't look right.

As you'll see in the doc you linked, it also says:

With that said, it’s a good idea to consult with stakeholders via Slack, GitHub, the mailing list, or other communication channels before setting out on any serious contribution effort.

Typically people use GitHub and Keybase (formerly Slack) to introduce themselves and keep people informed of in-progress and upcoming work, and compensation requests are the final result of a cycle's work. It seems like you did the opposite, and used the compensation request as a way to communicate your in-progress work instead.

I guess that's not a bad thing, but like I said above, without having ever interacted with you before, it seemed strange to me.

Thanks for your work so far. I encourage you to consider making GitHub issues and being more active on Keybase to send people signals of what you're up to, instead of relying on your compensation requests.

I will do it from today.

I believe I will also propose significant changes to the structure of the documents.

I have found it very difficult to find this kind of information too, because they are scattered ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants