Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings to reflect Bisq is exchange network #3681

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

devinbileck
Copy link
Member

Motivated by changes done to the website, as described in
bisq-network/bisq-website#280

Motivated by changes done to the website, as described in
bisq-network/bisq-website#280
@freimair
Copy link
Member

is "The exchange" a marketing statement?

@m52go @ManfredKarrer @ripcurlx @sqrrm

@m52go
Copy link
Contributor

m52go commented Nov 25, 2019

I'm not sure where/how "the exchange" wording originated, but like I said in this comment, it's pretentious and unusual.

Debian - a free operating system (OS) for your computer (link)
Qubes - a reasonably secure operating system (link)
Bitcoin - an experimental digital currency (link)

I'll wait to merge the website changes until this gets more consensus since it's a relatively meaningful change (i.e., definition of the project).

@devinbileck
Copy link
Member Author

Initially I felt "The" was a valid statement. But after @m52go pointed it out, I have to agree as I am all for humility.

@ripcurlx
Copy link
Contributor

On hold until consensus is found in bisq-network/bisq-website#280

Based on feedback mentioned in this comment:
bisq-network/bisq-website#280 (comment)
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx changed the title Update strings to reflect bisq is exchange network Update strings to reflect Bisq is exchange network Dec 3, 2019
@ripcurlx ripcurlx merged commit 5a0db50 into bisq-network:master Dec 3, 2019
@devinbileck devinbileck deleted the exchange-network branch December 3, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants