Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

Sort output #2

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Sort output #2

merged 1 commit into from
Nov 15, 2019

Conversation

freimair
Copy link
Member

@freimair freimair commented Nov 9, 2019

Whenever dependencies are updated, it is quite an effort to just commit the changed checksums.

This PR sorts the artifacts alphabetically each time and thus, reduces the efforts required.

Motivated by bisq-network/bisq#3585

Here is the checksum:

% ./gradlew clean build
[snip]
> Task :jar
md5=a42d3713bf35b1f52cfe9a3a605e4c52

Whenever dependencies are updated, it is quite an effort to just commit the changed checksums.
Copy link

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link

@cbeams I think this change is quite small, so I'd merge it with the GitHub Admin on Monday if you don't have any concerns as the only maintainer for this repo.

@cbeams
Copy link
Member

cbeams commented Nov 15, 2019

utACK. I'm merging this now, but someone will need to issue a follow-up PR updating the witness jar in the main repo, e.g. as @devinbileck did in bisq-network/bisq@286dd51. And of course that PR should include the newly-sorted output in gradle/witness/gradle-witness.gradle.

@cbeams cbeams merged commit 7fde3e6 into bisq-network:master Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants