Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI icons KDE Plasma compatibility fix suggestion #1159

Closed
Sadi58 opened this issue May 12, 2021 · 6 comments
Closed

GUI icons KDE Plasma compatibility fix suggestion #1159

Sadi58 opened this issue May 12, 2021 · 6 comments
Assignees
Labels
Cosmetics appearance, icons, themes

Comments

@Sadi58
Copy link

Sadi58 commented May 12, 2021

At the present Back In Time looks out of place under KDE Plasma 5.
To fix this, the following 2 changes are required in ./qt/icon.py (installed as /usr/share/backintime/qt/icon.py).

  1. Insert 'breeze' between 'gnome' and 'oxygen' in line 19.
  2. Replace 'show-hidden' with 'view-hidden' in line 62.
    This last change (because Breeze icon theme has such an icon already) will then require changing all icon names under ./qt/icons from show-hidden.svg to view-hidden.svg (which are installed in hicolor icon theme action icons).
@farion
Copy link

farion commented Jun 5, 2021

And Icons should work for HiDPI.

@aryoda
Copy link
Contributor

aryoda commented Sep 9, 2022

I am not sure if the view-hidden.svg icon is always available in the desktops but should be installed by BiT (see #507)...

@emtiu emtiu added the Cosmetics appearance, icons, themes label Sep 9, 2022
@aryoda aryoda self-assigned this Nov 24, 2022
@aryoda
Copy link
Contributor

aryoda commented Nov 24, 2022

@Sadi58 Very thoughtful proposal!

Could be fixed together with #1306

@aryoda
Copy link
Contributor

aryoda commented Nov 27, 2022

And Icons should work for HiDPI.

@farion Did you observe problems with BiT on High DPI displays?

The High DPI settings of our underlying GUI framework Qt5 are described here

https://doc.qt.io/qt-5/highdpi.html

and in BiT at least the AA_EnableHighDpiScaling is activated by default:

backintime/qt/qttools.py

Lines 163 to 165 in 3132f4d

if Version(QT_VERSION_STR) >= Version('5.6') and \
hasattr(Qt, 'AA_EnableHighDpiScaling'):
QApplication.setAttribute(Qt.AA_EnableHighDpiScaling)

@buhtz buhtz added this to the 1.3.5 / 1.4.0 milestone Mar 19, 2023
aryoda added a commit that referenced this issue Jul 17, 2023
…" issues (#1159, #1236, #1364)

Candidate to fix all major sys-tray icon and missing app icon issues (#1159, #1236, #1306, #1364).
Refactor qtsystrayiconplugin.py
@aryoda
Copy link
Contributor

aryoda commented Jul 17, 2023

I have fixed all known issues (hopefully) with my PR #1480, re-testing and feed-back welcome!

for theme in ('ubuntu-mono-dark', 'gnome', 'breeze', 'breeze dark', 'hicolor', 'adwaita', 'adwaita-dark', 'yaru', 'oxygen'):

backintime/qt/icon.py

Lines 95 to 97 in 535b1c7

SHOW_HIDDEN = QIcon.fromTheme('view-hidden', # currently only in Breeze (see #1159)
QIcon.fromTheme('show-hidden', # icon installed with BiT!
QIcon.fromTheme('list-add')))

@aryoda
Copy link
Contributor

aryoda commented Sep 4, 2023

I am closing this now as fixed and will be contained in the next release.

Please open a new issue in case of any problems.

@aryoda aryoda closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmetics appearance, icons, themes
Projects
None yet
Development

No branches or pull requests

5 participants