Shortcuts for menu bar and tabs, toolbar items and remove exit from toolbar

[TheTimeWalker]

Adds accelerator keys to the menu bars and tabs in the settings screen. Most of the toolbar buttons now also have shortcut keys for easier keyboard access. This also removes the exit button from the toolbar and changes the shortcut to the more standard CTRL + Q instead of CTRL + W which is often used for closing tabs

Closes #1104, closes #172

[buhtz]

Sorry for the late answer and thanks for your PR.

@emtiu I vote for merge (incl. #1104 and #172). Small code modifications regarding the UI.

[emtiu]

Thanks! I like the added accelerator keys, and I especially enjoy closing an issue as old as #172 ;)

But I have one reservation about this last change: I have gotten very used to closing BackInTime through the Quit button, you could say it's in my muscle memory by now.

If the button is removed, anyone like me will press the "Shutdown after the snapshot has finished" button instead, and this might have unintended consequences (at worst, the system shuts down when you don't want it to).

What do you think?

[buhtz]

I agree to you with the close Button. It doesn't hurt anyone when the button stays where it is.

We can take care of that when we do a bigger redesign of the UI (someday 😄 ).

Technically I don't know what would be the next steps if the opener @TheTimeWalker won't do a new commit. You are "Mr. Rights" here.

[TheTimeWalker]

This is how it looks like for KDE users:

The "Exit" button looks like a normal cancel/close button. I personally have to specifically remind myself to not push that button and I can think that people new to using the tool probably get confused by that button as well since it's against any guidelines and no other tool does that.

[emtiu]

This is how it looks like for KDE users:

The "Exit" button looks like a normal cancel/close button. I personally have to specifically remind myself to not push that button and I can think that people new to using the tool probably get confused by that button as well since it's against any guidelines and no other tool does that.

You're right, it doesn't even look like an "Exit this window" button. Combined with the fact that ⏸ (pause) and ⏹ (stop) buttons appear at the left end of the toolbar when a snapshot is being taken, this is rather confusing.

I'll just have to re-train my muscle memory ;)

Also: If somebody did mistakenly push the "Shutdown after snapshot" button when they actually meant to just close the window, it wouldn't immediately do anything, but just visibly toggle the setting. Chances are rather slim that this would happen right in the instant before a snapshot is finished, leading to an unwanted shutdown. (And this is the comment everyone can angrily link to when that inevitably does happen and is reported as a bug ;))