Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1181: test_readWriteCrontab fails when crontab is empty #1286

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Closes #1181: test_readWriteCrontab fails when crontab is empty #1286

merged 1 commit into from
Sep 8, 2022

Conversation

aryoda
Copy link
Contributor

@aryoda aryoda commented Sep 8, 2022

@emtiu If have fixed this and performed the following manual tests successfully, please merge if OK:

  1. Empty crontab file (zero bytes)
  2. crontab file with one empty line "\n\n" (no real text contained)
  3. crontab file with one text line ("# test")

I have run the unit test for all three scenarios...

@emtiu
Copy link
Member

emtiu commented Sep 8, 2022

Awesome! Thanks a lot for your work. I will test the fix in a virtual machine next chance I get.

@emtiu emtiu self-assigned this Sep 8, 2022
@emtiu emtiu added Scheduling cron, anacron etc. Bug labels Sep 8, 2022
@emtiu
Copy link
Member

emtiu commented Sep 8, 2022

Tested and confirmed, now merging. Thanks for the good work :)

@emtiu emtiu merged commit f7cc1b7 into bit-team:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Scheduling cron, anacron etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants