-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code comments and PEP8 prettification. #1360
Conversation
Some minor suggestions, but looks good otherwise :) Out of curiosity: Is the manpage generation covered by testing somehow? Or does it only happen when we run the script manually? |
Co-authored-by: Michael Büker <[email protected]>
Co-authored-by: Michael Büker <[email protected]>
Co-authored-by: Michael Büker <[email protected]>
No.
Only, when we run it manually. It is a "helper" script and conceptually don't belong to the release version of BIT. But looking into my Debian installation of BIT that py file is shipped with the release version. |
I think my fix for #1270 (schedule.time doc outdated) is still lost if we create the man pages again. My changes from 3c1e08e need to be added here: Lines 852 to 855 in 775c9c3
Shall I commit to your PR or could you do the change for me (saves me the setup overhead ;-) ? |
You mean this? I'll do it for you. ❤️ |
Can we merge this? |
While investiagting the manpage creation script some comments where added. Also some code formatting was done to improve readability and better fitting PEP8 rules.
Also repaired special #? comments accidentially removed in PR #1313 before.
Related to #1354