Fix SplashScreen crash when run with -disablewallet #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
changed the title
promag
reviewed
Oct 12, 2020
|
tACK c056064 |
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Dec 3, 2020
stevenroose
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Mar 22, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 19, 2021
Summary: bitcoin/bitcoin@e4f4350 > Add WalletClient interface so node interface is cleaner and don't need > wallet-specific methods. > > The new NodeContext::wallet_client pointer will also be needed to eliminate > global wallet variables like ::vpwallets, because createWallet(), loadWallet(), > getWallets(), etc methods called by the GUI need a way to get a reference to > the list of open wallets if it is no longer a global variable. > > Also tweaks splash screen registration for load wallet events to be delayed > until after wallet client is created. bitcoin-core/gui@c056064 > gui: Fix SplashScreen crash when run with -disablewallet This is a backport of [[bitcoin/bitcoin#19099 | core#19099]] [2/3] and [[bitcoin-core/gui#102 | core-gui#102]] (small bugfix) Depends on D10141 Test Plan: `ninja all check-all` Test for bugfix core-gui#102: `src/qt/bitcoin-qt -disablewallet` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Klakurka, boardgamesaz, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10142
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug introduced in bitcoin/bitcoin#19099: