Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6: Handle deprecated QLocale::nativeCountryName #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Sep 29, 2024

Split from bitcoin/bitcoin#30997.

QLocale::nativeCountryName() has been deprecated since Qt 6.6.

QLocale::nativeTerritoryName() was introduced in Qt 6.2.

This PR ensures compatibility across all supported Qt versions.

No behaviour change for the current codebase, which uses Qt 5.


This PR can be tested on macOS using the first commit from bitcoin/bitcoin#30997 and Homebrew's qt package.

This change ensures compatibility across all supported Qt versions.
@hebasto hebasto added the Qt 6 Transition to Qt 6 label Sep 29, 2024
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@hebasto
Copy link
Member Author

hebasto commented Oct 2, 2024

Friendly ping @Sjors @furszy @achow101 @jarolrod ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Qt 6 Transition to Qt 6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants