Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed-digit multi-comb ecmult_gen algorithm #1058

Merged
merged 17 commits into from
Apr 22, 2024

Conversation

sipa
Copy link
Contributor

@sipa sipa commented Dec 29, 2021

A third iteration of the signed-digit multi-comb ecmult_gen algorithm (earlier attempts: #693, and #546 by Peter Dettman). Short summary:

  • A new constant-time point multiplication algorithm with precomputation (so only used for multiply with G).
  • Based on section 3.3 of https://eprint.iacr.org/2012/309 by Mike Hamburg.
  • Configurable through two parameters: COMB_BLOCKS and COMB_TEETH
    • Currently only 3 predefined configurations reachable through ./configure. All three are included in precomputed_ecmult_gen.c and tested in CI.
      • --with-ecmult-gen-kb=2: 2 kB table with COMB_BLOCKS=2 COMB_TEETH=5
      • --with-ecmult-gen-kb=22: 22 kB table with COMB_BLOCKS=11 COMB_TEETH=6
      • --with-ecmult-gen-kb=86: 86 kB table with COMB_BLOCKS=43 COMB_TEETH=6
    • Many more configurations can be reached by manually setting the macros. These are not tested.

Compared with the previous PR #693:

  • Updated to the new static-precomputation-only model (Fully static precomputation tables #893).
  • Just 3 curated configurations reachable through configure.
  • Removed some optimizations that do not matter (much).
  • Do blinding through an final correction add rather than an initial start point, which may later permit usage of incomplete addition formulae (Try a non-uniform group law (e.g., for ecmult_gen)? #1051).
  • The recoding of the input scalar to signed bit representation is done slightly differently, which needs fewer special cases.

@sipa
Copy link
Contributor Author

sipa commented Dec 29, 2021

Benchmarks:

AMD Ryzen 5950X, GCC 11.2.0, default compile options

Using ./autogen.sh && ./configure --enable-experimental --enable-module-schnorrsig && make clean && make -j check && SECP256K1_BENCH_ITERS=1000000 ./bench schnorrsig_sign

master:       schnorrsig_sign               ,    18.1       ,    18.1       ,    18.1    
pr1058 kb=2:  schnorrsig_sign               ,    17.9       ,    17.9       ,    17.9 
pr1058 kb=22: schnorrsig_sign               ,    15.1       ,    15.1       ,    15.1    
pr1058 kb=86: schnorrsig_sign               ,    14.4       ,    14.4       ,    14.4 

Intel Core I7-7820HQ @ 2.3 GHz, GCC 10.3.0, default compile options

Using ./autogen.sh && ./configure --enable-experimental --enable-module-schnorrsig && make clean && make -j check && SECP256K1_BENCH_ITERS=1000000 ./bench schnorrsig_sign

master:       schnorrsig_sign               ,    38.8       ,    38.9       ,    38.9
pr1058 kb=2:  schnorrsig_sign               ,    39.4       ,    39.4       ,    39.4
pr1058 kb=22: schnorrsig_sign               ,    33.2       ,    33.3       ,    33.3
pr1058 kb=86: schnorrsig_sign               ,    32.4       ,    32.4       ,    32.4

ARM Cortex-A53 @ 1 GHz, GCC 9.3.0, default compile options

Using ./autogen.sh && ./configure --enable-experimental --enable-module-schnorrsig && make clean && make -j check && SECP256K1_BENCH_ITERS=100000 ./bench schnorrsig_sign

master:       schnorrsig_sign               ,   249.0       ,   249.0       ,   249.0
pr1058 kb=2:  schnorrsig_sign               ,   250.0       ,   250.0       ,   250.0 
pr1058 kb=22: schnorrsig_sign               ,   200.0       ,   200.0       ,   200.0
pr1058 kb=86: schnorrsig_sign               ,   192.0       ,   192.0       ,   192.0

@sipa
Copy link
Contributor Author

sipa commented Dec 30, 2021

I occurs to me that we could actually avoid the cost of doing the scalar halving at ecmult_gen time, by instead having precomputed tables with multiples of G/2 instead of G.

@peterdettman
Copy link
Contributor

I occurs to me that we could actually avoid the cost of doing the scalar halving at ecmult_gen time, by instead having precomputed tables with multiples of G/2 instead of G.

The scalar halving also ensures that the low bit (the shifted-away bit) is 0.

@sipa
Copy link
Contributor Author

sipa commented Dec 30, 2021

I don't think that matters? Even/odd has no special meaning when working modulo a prime.

The PR currently uses the bits of scalar (input + 2^COMB_BITS - 1 - blind) * 2^-1 to select multiples of G to add together.

My suggestion is that instead it could use the bits of (input + 2^COMB_BITS - 1 - blind) to select multiples of G/2 to add together.

@sipa
Copy link
Contributor Author

sipa commented Dec 30, 2021

It seems I'm wrong, but I'm confused why!

@peterdettman
Copy link
Contributor

peterdettman commented Dec 30, 2021

I think confusion is creeping in since after the halving the scalar isn't a scalar value anymore; it's in signed-digit form, which can only represent an odd value. In particular the bits of a scalar s in signed-digit form represent the scalar value 2*s+1. I think you should also be careful not to reason modulo the order in signed-digit form.

Edit: Actually, even that might not be quite complete since the high bit is being treated specially here.

@sipa
Copy link
Contributor Author

sipa commented Dec 30, 2021

It works, but you need to use the bits of input - blind + (2^COMB_BITS - 1)/2 instead. That's what you get when you substitute 2*(input-blind) for e in the formula in the paper (because now we're trying to compute input*G = 2*(input-blind)*(G/2) + blind*G).

@peterdettman
Copy link
Contributor

Oh I see, using double the input and the blind (of G/2) lets the halving be moved to precomputation. Nice.

src/ecmult_gen_impl.h Outdated Show resolved Hide resolved
@sipa
Copy link
Contributor Author

sipa commented Dec 30, 2021

Updated to use the avoid-halving-scalar trick.

src/ecmult_gen.h Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
src/ecmult_gen.h Outdated Show resolved Hide resolved
src/ecmult_gen.h Outdated Show resolved Hide resolved
src/ecmult_gen.h Outdated Show resolved Hide resolved
@peterdettman
Copy link
Contributor

As an exercise I added a 2 blocks, 4 teeth configuration:

  1. add {2,4} to CONFIGS table in precompute_ecmult_gen.c; nice and declarative.
  2. make precompute_ecmult_gen and run to get new precomputed_ecmult_gen.c which correctly includes new {2,4} option.
  3. modify configure.ac to support new "1" option for ecmult-gen-kb
  4. configure --with-ecmult-gen-kb=1, confirm in libsecp256k1-config.h that COMB_BLOCKS, COMB_TEETH are correct.
  5. make clean, make, tests to confirm it's working

This all worked without isues and was reasonably minimal effort. This particular example also satisfied me that there is no issue with combs covering exactly 256 bits.

@sipa
Copy link
Contributor Author

sipa commented Dec 31, 2021

@peterdettman FWIW, the easiest way of achieving the same would be:

  1. Modify configure.ac to support a new option
  2. Run configure with that option
  3. make clean-precomp && make normally

Because precompute_ecmult_gen is automatically built & run when a precomputed_*.c file is missing, and because precompute_ecmult_gen will always include the table for whatever the configuration is.

@peterdettman
Copy link
Contributor

Having some confusion over possible bad interactions between modular reduction and signed-digit form, I wanted to reason things out in reverse.

For point P of order N, scalar s in [0,N), and an L-bit comb (2^L > N), let C(s,P) be the value calculated by our comb, which considers the bits of s, zero-extended to L bits as signed digits. Then:

    C(s,P) == (2.s - (2^L - 1)) * P

Therefore in order to use the comb to calculate k * G, we solve for the scalar t to use:

    k * G == C(t,G) == (2.t - (2^L - 1)) * G 
=>  k == 2.t - (2^L - 1) mod N
=>  t == (k + (2^L - 1))/2 mod N

Can we skip that halving and use G/2 instead?

    C(2t,G/2) == (4.t - (2^L - 1)) * G/2
              == (2.t - (2^L - 1)/2) * G
              != C(t,G) unless 2^L == 1 mod N

So no, but let's back up a step and ask what scalar u to use in the comb to calculate k * G as 2.k * (G/2):

    2.k * (G/2) == C(u,G/2) == (2.u - (2^L - 1)) * G/2
=>  2.k == 2.u - (2^L - 1) mod N
=>  u == k + (2^L - 1)/2 mod N

and since L is constant, the halving is now only needed in the precomputation.

Scalar blinding (using b * G == B):

    k * G == (k - b) * G + B == 2.(k - b) * (G/2) + B == C(k - b + (2^L - 1)/2, G/2) + B

where -b + (2^L - 1)/2 can be precomputed.

@sipa
Copy link
Contributor Author

sipa commented Jan 1, 2022

Nice, that's much better explained than my current comments. I'll try to include it.

@peterdettman
Copy link
Contributor

Although the above satisfies me mathematically, I would like to see an explicit test case where the comb_offset (2^L - 1)/2 causes a modular reduction (relative to k-b). e.g. arrange for k-b == N + 1 - comb_offset. I hope that's not too painful, but otherwise random testing seems unlikely to hit such a case.

@sipa
Copy link
Contributor Author

sipa commented Jan 1, 2022

@peterdettman Making this change causes instant failure during the tests, at least:

--- a/src/ecmult_gen_impl.h
+++ b/src/ecmult_gen_impl.h
@@ -78,7 +78,7 @@ static void secp256k1_ecmult_gen(const secp256k1_ecmult_gen_context *ctx, secp25
      */
 
     /* Compute the scalar (gn + ctx->scalar_offset). */
-    secp256k1_scalar_add(&tmp, &ctx->scalar_offset, gn);
+    CHECK(!secp256k1_scalar_add(&tmp, &ctx->scalar_offset, gn));
     /* Convert to recoded array. */
     for (i = 0; i < 8; ++i) {
         recoded[i] = secp256k1_scalar_get_bits(&tmp, 32 * i, 32);

Including a test case that results in tmp=0 or tmp=1 or so may be useful though.

@peterdettman
Copy link
Contributor

scalar_offset includes the randomly-distributed blind, so there will be modular reductions. This isn't concerning at all because we can reason about the blind independently of the comb (just input offset + output offset).

However the comb offset is small: 2^(COMB_BITS-256) * (2^256 - N). So I would like a test that involves the comb_offset itself causing a modular reduction. The math checks out of course, but an explicit test can't hurt.

@peterdettman
Copy link
Contributor

Actually, I think (2^L - 1)/2 mod N is only small (128 bits) if L == 256.

peterdettman and others added 14 commits April 19, 2024 11:43
This introduces the signed-digit multi-comb multiplication algorithm
for constant-time G multiplications (ecmult_gen). It is based on
section 3.3 of "Fast and compact elliptic-curve cryptography" by
Mike Hamburg (see https://eprint.iacr.org/2012/309).

Original implementation by Peter Dettman, with changes by Pieter Wuille
to use scalars for recoding, and additional comments.
It is unnecessary to recompute this term needed by the SDMC algorithm
for every multiplication; move it into the context scalar_offset value
instead.
The old code would trigger UB when count=32.
The existing code needs to deal with the edge case that bit_pos >= 256,
which would lead to an out-of-bounds read from secp256k1_scalar.

Instead, recode the scalar into an array of uint32_t with enough zero
padding at the end to alleviate the issue. This also simplifies the
code, and is necessary for a security improvement in a follow-up
commit.

Original code by Peter Dettman, with modifications by Pieter Wuille.
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK 4c341f8

Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4c341f8

Copy link
Contributor

@stratospher stratospher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4c341f8. Did these benchmarks and saw a 12.4% on gcc 13.2.0 and 11.5% on clang 15.0.0. Also summarised how the precomputed table generation works here for future me :)

@jonasnick jonasnick merged commit da51507 into bitcoin-core:master Apr 22, 2024
107 checks passed
fanquake added a commit to fanquake/cryptofuzz that referenced this pull request Apr 25, 2024
This was removed upstream in
bitcoin-core/secp256k1#1058, and is causing
build failures downstream:
```bash
clang++ -O1 -fno-omit-frame-pointer -gline-tables-only -Wno-error=enum-constexpr-conversion -Wno-error=incompatible-function-pointer-types -Wno-error=int-conversion -Wno-error=deprecated-declarations -Wno-error=implicit-function-declaration -Wno-error=implicit-int -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION  -fprofile-instr-generate -fcoverage-mapping -pthread -Wl,--no-as-needed -Wl,-ldl -Wl,-lm -Wno-unused-command-line-argument -stdlib=libc++ -DCRYPTOFUZZ_NO_OPENSSL -I /src/boost_1_84_0/ -DCRYPTOFUZZ_SECP256K1 -DCRYPTOFUZZ_TREZOR_FIRMWARE -DCRYPTOFUZZ_BOTAN -DCRYPTOFUZZ_BOTAN_IS_ORACLE -DCRYPTOFUZZ_BITCOIN -Wall -Wextra -std=c++17 -I include/ -I . -I fuzzing-headers/include -DFUZZING_HEADERS_NO_IMPL bignum_fuzzer_importer.o botan_importer.o builtin_tests_importer.o components.o crypto.o datasource.o driver.o ecc_diff_fuzzer_exporter.o ecc_diff_fuzzer_importer.o entry.o executor.o expmod.o mutator.o mutatorpool.o numbers.o openssl_importer.o operation.o options.o repository.o tests.o util.o wycheproof.o z3.o modules/trezor/module.a modules/secp256k1/module.a modules/botan/module.a modules/bitcoin/module.a -fsanitize=fuzzer third_party/cpu_features/build/libcpu_features.a  -o cryptofuzz
/usr/bin/ld: modules/secp256k1/module.a(secp256k1_api.o): in function `cryptofuzz_secp256k1_scalar_get_bits':
/src/cryptofuzz/modules/secp256k1/secp256k1_api.c:75:(.text+0xfdf): undefined reference to `secp256k1_scalar_get_bits'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:33: cryptofuzz] Error 1
ERROR:__main__:Building fuzzers failed.
```
josibake added a commit to josibake/bitcoin that referenced this pull request May 4, 2024
92f592023f ci: enable silentpayments module
8ddc4574c9 tests: add BIP-352 test vectors
8315abd830 silentpayments: add benchmark for `scan_outputs`
f3a9516ec8 silentpayments: add examples/silentpayments.c
7e11e7613b silentpayments: add recipient light client support
3321771b0e silentpayments: add recipient scanning routine
766567f099 silentpayments: add opaque data type `public_data`
8d0bb06ce7 silentpayments: add recipient label support
9c9bd057bc silentpayments: add sender routine
036e688fd0 silentpayments: implement output pubkey creation
1ffee123d6 silentpayments: implement shared secret creation
7a5683260c silentpayments: add sortable recipient struct
a8d6f4b8e1 doc: add module description for silentpayments
1121a4d376 build: add skeleton for new silentpayments (BIP352) module
7d2591ce12 Add secp256k1_pubkey_sort
da515074e3 Merge bitcoin-core/secp256k1#1058: Signed-digit multi-comb ecmult_gen algorithm
4c341f89ab Add changelog entry for SDMC
a043940253 Permit COMB_BITS < 256 for exhaustive tests
39b2f2a321 Add test case for ecmult_gen recoded = {-1,0,1}
644e86de9a Reintroduce projective blinding
07810d9abb Reduce side channels from single-bit reads
a0d32b597d Optimization: use Nx32 representation for recoded bits
e03dcc44b5 Make secp256k1_scalar_get_bits support 32-bit reads
5005abee60 Rename scalar_get_bits -> scalar_get_bits_limb32; return uint32_t
6247f485b6 Optimization: avoid unnecessary doublings in precomputation
15d0cca2a6 Optimization: first table lookup needs no point addition
7a33db35cd Optimization: move (2^COMB_BITS-1)/2 term into ctx->scalar_offset
ed2a056f3d Provide 3 configurations accessible through ./configure
5f7be9f6a5 Always generate tables for current (blocks,teeth) config
fde1dfcd8d Signed-digit multi-comb ecmult_gen algorithm
486518b350 Make exhaustive tests's scalar_inverse(&x,&x) work
ab45c3e089 Initial gej blinding -> final ge blinding
aa00a6b892 Introduce CEIL_DIV macro and use it
REVERT: 0270b14309 labels: actually set the label
REVERT: 3d08027789 ci: enable silentpayments module
REVERT: 85946762a5 tests: add BIP-352 test vectors
REVERT: bf349c2a08 silentpayments: add examples/silentpayments.c
REVERT: 9a7106e19c silentpayments: add recipient light client support
REVERT: f113564298 silentpayments: add recipient scanning routine
REVERT: 4fb8716f4f silentpayments: add opaque data type `public_data`
REVERT: 987d829e8f silentpayments: add recipient label support
REVERT: 14ca754578 silentpayments: add sender routine
REVERT: 9b965927da silentpayments: implement output pubkey creation
REVERT: a0fcc2c780 silentpayments: implement shared secret creation
REVERT: 13f203dacd silentpayments: add sortable recipient struct
REVERT: a9326bdd7a doc: add module description for silentpayments
REVERT: 15d3e71cc1 build: add skeleton for new silentpayments (BIP352) module
REVERT: cc7d18a8a8 extrakeys: add secp256k1_pubkey_sort

git-subtree-dir: src/secp256k1
git-subtree-split: 92f592023f3f4d6a66724772349fbdc4967ab50f
josibake added a commit to josibake/bitcoin that referenced this pull request May 6, 2024
92f592023f ci: enable silentpayments module
8ddc4574c9 tests: add BIP-352 test vectors
8315abd830 silentpayments: add benchmark for `scan_outputs`
f3a9516ec8 silentpayments: add examples/silentpayments.c
7e11e7613b silentpayments: add recipient light client support
3321771b0e silentpayments: add recipient scanning routine
766567f099 silentpayments: add opaque data type `public_data`
8d0bb06ce7 silentpayments: add recipient label support
9c9bd057bc silentpayments: add sender routine
036e688fd0 silentpayments: implement output pubkey creation
1ffee123d6 silentpayments: implement shared secret creation
7a5683260c silentpayments: add sortable recipient struct
a8d6f4b8e1 doc: add module description for silentpayments
1121a4d376 build: add skeleton for new silentpayments (BIP352) module
7d2591ce12 Add secp256k1_pubkey_sort
da515074e3 Merge bitcoin-core/secp256k1#1058: Signed-digit multi-comb ecmult_gen algorithm
4c341f89ab Add changelog entry for SDMC
a043940253 Permit COMB_BITS < 256 for exhaustive tests
39b2f2a321 Add test case for ecmult_gen recoded = {-1,0,1}
644e86de9a Reintroduce projective blinding
07810d9abb Reduce side channels from single-bit reads
a0d32b597d Optimization: use Nx32 representation for recoded bits
e03dcc44b5 Make secp256k1_scalar_get_bits support 32-bit reads
5005abee60 Rename scalar_get_bits -> scalar_get_bits_limb32; return uint32_t
6247f485b6 Optimization: avoid unnecessary doublings in precomputation
15d0cca2a6 Optimization: first table lookup needs no point addition
7a33db35cd Optimization: move (2^COMB_BITS-1)/2 term into ctx->scalar_offset
ed2a056f3d Provide 3 configurations accessible through ./configure
5f7be9f6a5 Always generate tables for current (blocks,teeth) config
fde1dfcd8d Signed-digit multi-comb ecmult_gen algorithm
486518b350 Make exhaustive tests's scalar_inverse(&x,&x) work
ab45c3e089 Initial gej blinding -> final ge blinding
aa00a6b892 Introduce CEIL_DIV macro and use it

git-subtree-dir: src/secp256k1
git-subtree-split: 92f592023f3f4d6a66724772349fbdc4967ab50f
hebasto added a commit to hebasto/secp256k1-CMake-example that referenced this pull request May 11, 2024
e3a885d Merge bitcoin-core/secp256k1#1522: release: prepare for 0.5.0
c0e4ec3 release: prepare for 0.5.0
bb528cf Merge bitcoin-core/secp256k1#1518: Add secp256k1_pubkey_sort
7d2591c Add secp256k1_pubkey_sort
da51507 Merge bitcoin-core/secp256k1#1058: Signed-digit multi-comb ecmult_gen algorithm
4c341f8 Add changelog entry for SDMC
a043940 Permit COMB_BITS < 256 for exhaustive tests
39b2f2a Add test case for ecmult_gen recoded = {-1,0,1}
644e86d Reintroduce projective blinding
07810d9 Reduce side channels from single-bit reads
a0d32b5 Optimization: use Nx32 representation for recoded bits
e03dcc4 Make secp256k1_scalar_get_bits support 32-bit reads
5005abe Rename scalar_get_bits -> scalar_get_bits_limb32; return uint32_t
6247f48 Optimization: avoid unnecessary doublings in precomputation
15d0cca Optimization: first table lookup needs no point addition
7a33db3 Optimization: move (2^COMB_BITS-1)/2 term into ctx->scalar_offset
ed2a056 Provide 3 configurations accessible through ./configure
5f7be9f Always generate tables for current (blocks,teeth) config
fde1dfc Signed-digit multi-comb ecmult_gen algorithm
486518b Make exhaustive tests's scalar_inverse(&x,&x) work
ab45c3e Initial gej blinding -> final ge blinding
aa00a6b Introduce CEIL_DIV macro and use it
d831168 Merge bitcoin-core/secp256k1#1515: ci: Note affected clangs in comment on ASLR quirk
a85e223 ci: Note affected clangs in comment on ASLR quirk
4b77fec Merge bitcoin-core/secp256k1#1512: msan: notate more variable assignments from assembly code
f7f0184 msan: notate more variable assignments from assembly code
a613391 change inconsistent array param to pointer
05bfab6 Merge bitcoin-core/secp256k1#1507: ci: Add workaround for ASLR bug in sanitizers
a5e8ab2 ci: Add sanitizer env variables to debug output
84a93de ci: Add workaround for ASLR bug in sanitizers
427e86b Merge bitcoin-core/secp256k1#1490: tests: improve fe_sqr test (issue #1472)
2028069 doc: clarify input requirements for secp256k1_fe_mul
11420a7 tests: improve fe_sqr test
cdc9a62 Merge bitcoin-core/secp256k1#1489: tests: add missing fe comparison checks for inverse field test cases
d926510 Merge bitcoin-core/secp256k1#1496: msan: notate variable assignments from assembly code
31ba404 msan: notate variable assignments from assembly code
e7ea32e msan: Add SECP256K1_CHECKMEM_MSAN_DEFINE which applies to memory sanitizer and not valgrind
e7bdddd refactor: rename `check_fe_equal` -> `fe_equal`
00111c9 tests: add missing fe comparison checks for inverse field test cases
0653a25 Merge bitcoin-core/secp256k1#1486: ci: Update cache action
94a14d5 ci: Update cache action
2483627 Merge bitcoin-core/secp256k1#1483: cmake: Recommend native CMake commands in README
5ad3aa3 Merge bitcoin-core/secp256k1#1484: tests: Drop redundant _scalar_check_overflow calls
51df2d9 tests: Drop redundant _scalar_check_overflow calls
3777e3f cmake: Recommend native CMake commands in README
e4af41c Merge bitcoin-core/secp256k1#1249: cmake: Add `SECP256K1_LATE_CFLAGS` configure option
3bf4d68 Merge bitcoin-core/secp256k1#1482: build: Clean up handling of module dependencies
e682267 build: Error if required module explicitly off
89ec583 build: Clean up handling of module dependencies
4437886 Merge bitcoin-core/secp256k1#1468: v0.4.1 release aftermath
a9db9f2 Merge bitcoin-core/secp256k1#1480: Get rid of untested sizeof(secp256k1_ge_storage) == 64 code path
74b7c3b Merge bitcoin-core/secp256k1#1476: include: make docs more consistent
b37fdb2 check-abi: Minor UI improvements
ad5f589 check-abi: Default to HEAD for new version
9fb7e2f release process: Style and formatting nits
ba5d72d assumptions: Use new STATIC_ASSERT macro
e53c2d9 Require that sizeof(secp256k1_ge_storage) == 64
d0ba2ab util: Add STATIC_ASSERT macro
da7bc1b include: in doc, remove article in front of "pointer"
aa3dd52 include: make doc about ctx more consistent
e3f6900 include: remove obvious "cannot be NULL" doc
d373bf6 Merge bitcoin-core/secp256k1#1474: tests: restore scalar_mul test
79e0945 Merge bitcoin-core/secp256k1#1473: Fix typos
3dbfb48 tests: restore scalar_mul test
d77170a Fix typos
e7053d0 release process: Add email step
429d21d release process: Run sanity checks on release PR
efe85c7 Merge bitcoin-core/secp256k1#1466: release cleanup: bump version after 0.4.1
4b2e06f release cleanup: bump version after 0.4.1
1ad5185 Merge bitcoin-core/secp256k1#1465: release: prepare for 0.4.1
672053d release: prepare for 0.4.1
1a81df8 Merge bitcoin-core/secp256k1#1380: Add ABI checking tool for release process
74a4d97 doc: Add ABI checking with `check-abi.sh` to the Release Process
e7f830e Add `tools/check-abi.sh`
77af1da Merge bitcoin-core/secp256k1#1455: doc: improve secp256k1_fe_set_b32_mod doc
3928b7c doc: improve secp256k1_fe_set_b32_mod doc
5e9a4d7 Merge bitcoin-core/secp256k1#990: Add comment on length checks when parsing ECDSA sigs
4197d66 Merge bitcoin-core/secp256k1#1431: Add CONTRIBUTING.md
0e5ea62 CONTRIBUTING: add some coding and style conventions
e2c9888 Merge bitcoin-core/secp256k1#1451: changelog: add entry for "field: Remove x86_64 asm"
d2e36a2 changelog: add entry for "field: Remove x86_64 asm"
1a432cb README: update first sentence
0922a04 docs: move coverage report instructions to CONTRIBUTING
76880e4 Add CONTRIBUTING.md including scope and guidelines for new code
d3e29db Merge bitcoin-core/secp256k1#1450: Add group.h ge/gej equality functions
04af0ba Replace ge_equals_ge[,j] calls with group.h equality calls
60525f6 Add unit tests for group.h equality functions
a47cd97 Add group.h ge/gej equality functions
10e6d29 Merge bitcoin-core/secp256k1#1446: field: Remove x86_64 asm
07687e8 Merge bitcoin-core/secp256k1#1393: Implement new policy for VERIFY_CHECK and #ifdef VERIFY (issue #1381)
bb46723 remove VERIFY_SETUP define
a3a3e11 remove unneeded VERIFY_SETUP uses in ECMULT_CONST_TABLE_GET_GE macro
a0fb68a introduce and use SECP256K1_SCALAR_VERIFY macro
cf25c86 introduce and use SECP256K1_{FE,GE,GEJ}_VERIFY macros
5d89bc0 remove superfluous `#ifdef VERIFY`/`#endif` preprocessor conditions
c2688f8 redefine VERIFY_CHECK to empty in production (non-VERIFY) mode
5814d84 Merge bitcoin-core/secp256k1#1438: correct assertion for secp256k1_fe_mul_inner
c1b4966 Merge bitcoin-core/secp256k1#1445: bench: add --help option to bench_internal
f07cead build: Don't call assembly an optimization
2f0762f field: Remove x86_64 asm
1ddd76a bench: add --help option to bench_internal
e721039 Merge bitcoin-core/secp256k1#1441: asm: add .note.GNU-stack section for non-exec stack
ea47c82 Merge bitcoin-core/secp256k1#1442: Return temporaries to being unsigned in secp256k1_fe_sqr_inner
dcdda31 Tighten secp256k1_fe_mul_inner's VERIFY_BITS checks
1027135 Return temporaries to being unsigned in secp256k1_fe_sqr_inner
33dc7e4 asm: add .note.GNU-stack section for non-exec stack
c891c5c Merge bitcoin-core/secp256k1#1437: ci: Ignore internal errors of snapshot compilers
8185e72 ci: Ignore internal errors in snapshot compilers
40f50d0 Merge bitcoin-core/secp256k1#1184: Signed-digit based ecmult_const algorithm
8e2a5fe correct assertion for secp256k1_fe_mul_inner
355bbdf Add changelog entry for signed-digit ecmult_const algorithm
21f49d9 Remove unused secp256k1_scalar_shr_int
115fdc7 Remove unused secp256k1_wnaf_const
aa9f3a3 ecmult_const: add/improve tests
4d16e90 Signed-digit based ecmult_const algorithm
ba523be make SECP256K1_SCALAR_CONST reduce modulo exhaustive group order
2140da9 Add secp256k1_scalar_half for halving scalars (+ tests/benchmarks).
1f1bb78 Merge bitcoin-core/secp256k1#1430: README: remove CI badge
5dab0ba README: remove CI badge
b314cf2 Merge bitcoin-core/secp256k1#1426: ci/cirrus: Add native ARM64 jobs
fa4d6c7 ci/cirrus: Add native ARM64 persistent workers
ee7aaf2 Merge bitcoin-core/secp256k1#1395: tests: simplify `random_fe_non_zero` (remove loop limit and unneeded normalize)
ba9cb6f Merge bitcoin-core/secp256k1#1424: ci: Bump major versions for docker actions
d9d80fd ci: Bump major versions for docker actions
4fd00f4 Merge bitcoin-core/secp256k1#1422: cmake: Install `libsecp256k1.pc` file
421d848 ci: Align Autotools/CMake `CI_INSTALL` directory names
9f005c6 cmake: Install `libsecp256k1.pc` file
2262d0e ci/cirrus: Bring back skeleton .cirrus.yml without jobs
b10ddd2 Merge bitcoin-core/secp256k1#1416: doc: Align documented scripts with CI ones
49be5be Merge bitcoin-core/secp256k1#1390: tests: Replace counting_illegal_callbacks with CHECK_ILLEGAL_VOID
cbf3053 Merge bitcoin-core/secp256k1#1417: release cleanup: bump version after 0.4.0
9b118bc release cleanup: bump version after 0.4.0
199d27c Merge bitcoin-core/secp256k1#1415: release: Prepare for 0.4.0
7030364 tests: add CHECK_ERROR_VOID and use it in scratch tests
f8d7ea6 tests: Replace counting_illegal_callbacks with CHECK_ILLEGAL_VOID
1633980 release: Prepare for 0.4.0
d9a8506 changelog: Catch up in preparation of release
b0f7bfe doc: Do not mention soname in CHANGELOG.md "ABI Compatibility" section
bd9d98d doc: Align documented scripts with CI ones
0b4640a Merge bitcoin-core/secp256k1#1413: ci: Add `release` job
8659a01 ci: Add `release` job
f9b3889 ci: Update `actions/checkout` version
a1d52e3 tests: remove unnecessary test in run_ec_pubkey_parse_test
875b0ad tests: remove unnecessary set_illegal_callback
727bec5 Merge bitcoin-core/secp256k1#1414: ci/gha: Add ARM64 QEMU jobs for clang and clang-snapshot
2635068 ci/gha: Let MSan continue checking after errors in all jobs
e78c7b6 ci/Dockerfile: Reduce size of Docker image further
2f0d3bb ci/Dockerfile: Warn if `ulimit -n` is too high when running Docker
4b8a647 ci/gha: Add ARM64 QEMU jobs for clang and clang-snapshot
6ebe7d2 ci/Dockerfile: Always use versioned clang packages
65c79fe Merge bitcoin-core/secp256k1#1412: ci: Switch macOS from Ventura to Monterey and add Valgrind
c223d7e ci: Switch macOS from Ventura to Monterey and add Valgrind
ea26b71 Merge bitcoin-core/secp256k1#1411: ci: Make repetitive command the default one
cce0456 ci: Make repetitive command the default one
317a4c4 ci: Move `git config ...` to `run-in-docker-action`
4d7fe60 Merge bitcoin-core/secp256k1#1409: ci: Move remained task from Cirrus to GitHub Actions
676ed8f ci: Move "C++ (public headers)" from Cirrus to GitHub Actions
61fc3a2 ci: Move "C++ -fpermissive..." from Cirrus to GitHub Actions
d51fb0a ci: Move "MSan" from Cirrus to GitHub Actions
c22ac27 ci: Move sanitizers task from Cirrus to GitHub Actions
26a9899 Merge bitcoin-core/secp256k1#1410: ci: Use concurrency for pull requests only
ee1be62 ci: Use concurrency for pull requests only
6ee1455 Merge bitcoin-core/secp256k1#1406: ci, gha: Move more non-x86_64 tasks from Cirrus CI to GitHub Actions
fc3dea2 ci: Move "ppc64le: Linux..." from Cirrus to GitHub Actions
7782dc8 ci: Move "ARM64: Linux..." from Cirrus to GitHub Actions
0a16de6 ci: Move "ARM32: Linux..." from Cirrus to GitHub Actions
ea33914 ci: Move "s390x (big-endian): Linux..." from Cirrus to GitHub Actions
880be8a ci: Move "i686: Linux (Debian stable)" from Cirrus to GiHub Actions
2e6cf9b Merge bitcoin-core/secp256k1#1396: ci, gha: Add "x86_64: Linux (Debian stable)" GitHub Actions job
5373693 Merge bitcoin-core/secp256k1#1405: ci: Drop no longer needed workaround
ef9fe95 ci: Drop no longer needed workaround
e10878f ci, gha: Drop `driver-opts.network` input for `setup-buildx-action`
4ad4914 ci, gha: Add `retry_builder` Docker image builder
6617a62 ci: Remove "x86_64: Linux (Debian stable)" task from Cirrus CI
03c9e65 ci, gha: Add "x86_64: Linux (Debian stable)" GitHub Actions job
ad3e65d ci: Remove GCC build files and sage to reduce size of Docker image
6b9507a Merge bitcoin-core/secp256k1#1398: ci, gha: Add Windows jobs based on Linux image
87d35f3 ci: Rename `cirrus.sh` to more general `ci.sh`
d6281dd ci: Remove Windows tasks from Cirrus CI
2b6f9cd ci, gha: Add Windows jobs based on Linux image
48b1d93 Merge bitcoin-core/secp256k1#1403: ci, gha: Ensure only a single workflow processes `github.ref` at a time
0ba2b94 Merge bitcoin-core/secp256k1#1373: Add invariant checking for scalars
c45b7c4 refactor: introduce testutil.h (deduplicate `random_fe_`, `ge_equals_` helpers)
dc55141 tests: simplify `random_fe_non_zero` (remove loop limit and unneeded normalize)
060e32c Merge bitcoin-core/secp256k1#1401: ci, gha: Run all MSVC tests on Windows natively
de657c2 Merge bitcoin-core/secp256k1#1062: Removes `_fe_equal_var`, and unwanted `_fe_normalize_weak` calls (in tests)
bcffeb1 Merge bitcoin-core/secp256k1#1404: ci: Remove "arm64: macOS Ventura" task from Cirrus CI
c2f6435 ci: Add comment about switching macOS to M1 on GHA later
4a24fae ci: Remove "arm64: macOS Ventura" task from Cirrus CI
b0886fd ci, gha: Ensure only a single workflow processes `github.ref` at a time
3d05c86 Merge bitcoin-core/secp256k1#1394: ci, gha: Run "x86_64: macOS Ventura" job on GitHub Actions
d78bec7 ci: Remove Windows MSVC tasks from Cirrus CI
3545dc2 ci, gha: Run all MSVC tests on Windows natively
5d8fa82 Merge bitcoin-core/secp256k1#1274: test: Silent noisy clang warnings about Valgrind code on macOS x86_64
8e54a34 ci, gha: Run "x86_64: macOS Ventura" job on GitHub Actions
b327abf Merge bitcoin-core/secp256k1#1402: ci: Use Homebrew's gcc in native macOS task
d62db57 ci: Use Homebrew's gcc in native macOS task
54058d1 field: remove `secp256k1_fe_equal_var`
bb4efd6 tests: remove unwanted `secp256k1_fe_normalize_weak` call
eedd781 Merge bitcoin-core/secp256k1#1348: tighten group magnitude limits, save normalize_weak calls in group add methods (revival of #1032)
b2f6712 Merge bitcoin-core/secp256k1#1400: ctimetests: Use new SECP256K1_CHECKMEM macros also for ellswift
9c91ea4 ci: Enable ellswift module where it's missing
db32a24 ctimetests: Use new SECP256K1_CHECKMEM macros also for ellswift
ce765a5 Merge bitcoin-core/secp256k1#1399: ci, gha: Run "SageMath prover" job on GitHub Actions
8408dfd Revert "ci: Run sage prover on CI"
c8d9914 ci, gha: Run "SageMath prover" job on GitHub Actions
8d2960c Merge bitcoin-core/secp256k1#1397: ci: Remove "Windows (VS 2022)" task from Cirrus CI
f1774e5 ci, gha: Make MSVC job presentation more explicit
5ee039b ci: Remove "Windows (VS 2022)" task from Cirrus CI
96294c0 Merge bitcoin-core/secp256k1#1389: ci: Run "Windows (VS 2022)" job on GitHub Actions
a2f7ccd ci: Run "Windows (VS 2022)" job on GitHub Actions
374e2b5 Merge bitcoin-core/secp256k1#1290: cmake: Set `ENVIRONMENT` property for examples on Windows
1b13415 Merge bitcoin-core/secp256k1#1391: refactor: take use of `secp256k1_scalar_{zero,one}` constants (part 2)
a1bd497 refactor: take use of `secp256k1_scalar_{zero,one}` constants (part 2)
b7c685e Save _normalize_weak calls in group add methods
c83afa6 Tighten group magnitude limits
26392da Merge bitcoin-core/secp256k1#1386: ci: print $ELLSWIFT in cirrus.sh
d23da6d use secp256k1_scalar_verify checks
4692478 ci: print $ELLSWIFT in cirrus.sh
c7d0454 add verification for scalars
c734c64 Merge bitcoin-core/secp256k1#1384: build: enable ellswift module via SECP_CONFIG_DEFINES
ad15215 update max scalar in scalar_cmov_test and fix schnorrsig_verify exhaustive test
78ca880 build: enable ellswift module via SECP_CONFIG_DEFINES
0e00fc7 Merge bitcoin-core/secp256k1#1383: util: remove unused checked_realloc
b097a46 util: remove unused checked_realloc
2bd5f3e Merge bitcoin-core/secp256k1#1382: refactor: Drop unused cast
4f8c5bd refactor: Drop unused cast
173e8d0 Implement current magnitude assumptions
49afd2f Take use of _fe_verify_magnitude in field_impl.h
4e9661f Add _fe_verify_magnitude (no-op unless VERIFY is enabled)
690b0fc add missing group element invariant checks
175db31 ci: Drop no longer needed `PATH` variable update on Windows
116d2ab cmake: Set `ENVIRONMENT` property for examples on Windows
cef3739 cmake, refactor: Use helper function instead of interface library
747ada3 test: Silent noisy clang warnings about Valgrind code on macOS x86_64
42f8c51 cmake: Add `SECP256K1_LATE_CFLAGS` configure option
e02f313 Add comment on length checks when parsing ECDSA sigs

git-subtree-dir: src/secp256k1
git-subtree-split: e3a885d42a7800c1ccebad94ad1e2b82c4df5c65
fanquake added a commit to fanquake/bitcoin that referenced this pull request May 16, 2024
06bff6dec8 Merge bitcoin-core/secp256k1#1528: tests: call `secp256k1_ecmult_multi_var` with a non-`NULL` error callback
4155e62fcc Merge bitcoin-core/secp256k1#1526: cmake: Fix `check_arm32_assembly` when using as subproject
9554362b15 tests: call secp256k1_ecmult_multi_var with a non-NULL error callback
9f4c8cd730 cmake: Fix `check_arm32_assembly` when using as subproject
7712a53061 Merge bitcoin-core/secp256k1#1524: check-abi: explicitly provide public headers
7d0bc0870f Merge bitcoin-core/secp256k1#1525: changelog: Correct 0.5.0 release date
d45d9b74bb changelog: Correct 0.5.0 release date
d7f6613dbb Merge bitcoin-core/secp256k1#1523: release cleanup: bump version after 0.5.0
2f05e2da4b release cleanup: bump version after 0.5.0
e3a885d42a Merge bitcoin-core/secp256k1#1522: release: prepare for 0.5.0
dd695563e6 check-abi: explicitly provide public headers
c0e4ec3fee release: prepare for 0.5.0
bb528cfb08 Merge bitcoin-core/secp256k1#1518: Add secp256k1_pubkey_sort
7d2591ce12 Add secp256k1_pubkey_sort
da515074e3 Merge bitcoin-core/secp256k1#1058: Signed-digit multi-comb ecmult_gen algorithm
4c341f89ab Add changelog entry for SDMC
a043940253 Permit COMB_BITS < 256 for exhaustive tests
39b2f2a321 Add test case for ecmult_gen recoded = {-1,0,1}
644e86de9a Reintroduce projective blinding
07810d9abb Reduce side channels from single-bit reads
a0d32b597d Optimization: use Nx32 representation for recoded bits
e03dcc44b5 Make secp256k1_scalar_get_bits support 32-bit reads
5005abee60 Rename scalar_get_bits -> scalar_get_bits_limb32; return uint32_t
6247f485b6 Optimization: avoid unnecessary doublings in precomputation
15d0cca2a6 Optimization: first table lookup needs no point addition
7a33db35cd Optimization: move (2^COMB_BITS-1)/2 term into ctx->scalar_offset
ed2a056f3d Provide 3 configurations accessible through ./configure
5f7be9f6a5 Always generate tables for current (blocks,teeth) config
fde1dfcd8d Signed-digit multi-comb ecmult_gen algorithm
486518b350 Make exhaustive tests's scalar_inverse(&x,&x) work
ab45c3e089 Initial gej blinding -> final ge blinding
aa00a6b892 Introduce CEIL_DIV macro and use it

git-subtree-dir: src/secp256k1
git-subtree-split: 06bff6dec8d038f7b4112664a9b882293ebc5178
vmta added a commit to umkoin/umkoin that referenced this pull request May 20, 2024
da515074e Merge bitcoin-core/secp256k1#1058: Signed-digit multi-comb ecmult_gen algorithm
4c341f89a Add changelog entry for SDMC
a04394025 Permit COMB_BITS < 256 for exhaustive tests
39b2f2a32 Add test case for ecmult_gen recoded = {-1,0,1}
644e86de9 Reintroduce projective blinding
07810d9ab Reduce side channels from single-bit reads
a0d32b597 Optimization: use Nx32 representation for recoded bits
e03dcc44b Make secp256k1_scalar_get_bits support 32-bit reads
5005abee6 Rename scalar_get_bits -> scalar_get_bits_limb32; return uint32_t
6247f485b Optimization: avoid unnecessary doublings in precomputation
15d0cca2a Optimization: first table lookup needs no point addition
7a33db35c Optimization: move (2^COMB_BITS-1)/2 term into ctx->scalar_offset
ed2a056f3 Provide 3 configurations accessible through ./configure
5f7be9f6a Always generate tables for current (blocks,teeth) config
fde1dfcd8 Signed-digit multi-comb ecmult_gen algorithm
486518b35 Make exhaustive tests's scalar_inverse(&x,&x) work
ab45c3e08 Initial gej blinding -> final ge blinding
aa00a6b89 Introduce CEIL_DIV macro and use it
d8311688b Merge bitcoin-core/secp256k1#1515: ci: Note affected clangs in comment on ASLR quirk
a85e2233e ci: Note affected clangs in comment on ASLR quirk
4b77fec67 Merge bitcoin-core/secp256k1#1512: msan: notate more variable assignments from assembly code
f7f0184ba msan: notate more variable assignments from assembly code
a61339149 change inconsistent array param to pointer
05bfab69a Merge bitcoin-core/secp256k1#1507: ci: Add workaround for ASLR bug in sanitizers
a5e8ab248 ci: Add sanitizer env variables to debug output
84a93de4d ci: Add workaround for ASLR bug in sanitizers
427e86b9e Merge bitcoin-core/secp256k1#1490: tests: improve fe_sqr test (issue #1472)
2028069df doc: clarify input requirements for secp256k1_fe_mul
11420a7a2 tests: improve fe_sqr test
cdc9a6258 Merge bitcoin-core/secp256k1#1489: tests: add missing fe comparison checks for inverse field test cases
d926510cf Merge bitcoin-core/secp256k1#1496: msan: notate variable assignments from assembly code
31ba40494 msan: notate variable assignments from assembly code
e7ea32e30 msan: Add SECP256K1_CHECKMEM_MSAN_DEFINE which applies to memory sanitizer and not valgrind
e7bdddd9c refactor: rename `check_fe_equal` -> `fe_equal`
00111c9c5 tests: add missing fe comparison checks for inverse field test cases
0653a25d5 Merge bitcoin-core/secp256k1#1486: ci: Update cache action
94a14d529 ci: Update cache action
248362729 Merge bitcoin-core/secp256k1#1483: cmake: Recommend native CMake commands in README
5ad3aa3dc Merge bitcoin-core/secp256k1#1484: tests: Drop redundant _scalar_check_overflow calls
51df2d9ab tests: Drop redundant _scalar_check_overflow calls
3777e3f36 cmake: Recommend native CMake commands in README
e4af41c61 Merge bitcoin-core/secp256k1#1249: cmake: Add `SECP256K1_LATE_CFLAGS` configure option
3bf4d68fc Merge bitcoin-core/secp256k1#1482: build: Clean up handling of module dependencies
e6822678e build: Error if required module explicitly off
89ec583cc build: Clean up handling of module dependencies
44378867a Merge bitcoin-core/secp256k1#1468: v0.4.1 release aftermath
b37fdb28c check-abi: Minor UI improvements
ad5f589a9 check-abi: Default to HEAD for new version
9fb7e2f15 release process: Style and formatting nits
e7053d065 release process: Add email step
429d21dc7 release process: Run sanity checks on release PR
42f8c5140 cmake: Add `SECP256K1_LATE_CFLAGS` configure option

git-subtree-dir: src/secp256k1
git-subtree-split: da515074e3ebc8abc85a4fff3a31d7694ecf897b
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Jun 6, 2024
06bff6dec8 Merge bitcoin-core/secp256k1#1528: tests: call `secp256k1_ecmult_multi_var` with a non-`NULL` error callback
4155e62fcc Merge bitcoin-core/secp256k1#1526: cmake: Fix `check_arm32_assembly` when using as subproject
9554362b15 tests: call secp256k1_ecmult_multi_var with a non-NULL error callback
9f4c8cd730 cmake: Fix `check_arm32_assembly` when using as subproject
7712a53061 Merge bitcoin-core/secp256k1#1524: check-abi: explicitly provide public headers
7d0bc0870f Merge bitcoin-core/secp256k1#1525: changelog: Correct 0.5.0 release date
d45d9b74bb changelog: Correct 0.5.0 release date
d7f6613dbb Merge bitcoin-core/secp256k1#1523: release cleanup: bump version after 0.5.0
2f05e2da4b release cleanup: bump version after 0.5.0
e3a885d42a Merge bitcoin-core/secp256k1#1522: release: prepare for 0.5.0
dd695563e6 check-abi: explicitly provide public headers
c0e4ec3fee release: prepare for 0.5.0
bb528cfb08 Merge bitcoin-core/secp256k1#1518: Add secp256k1_pubkey_sort
7d2591ce12 Add secp256k1_pubkey_sort
da515074e3 Merge bitcoin-core/secp256k1#1058: Signed-digit multi-comb ecmult_gen algorithm
4c341f89ab Add changelog entry for SDMC
a043940253 Permit COMB_BITS < 256 for exhaustive tests
39b2f2a321 Add test case for ecmult_gen recoded = {-1,0,1}
644e86de9a Reintroduce projective blinding
07810d9abb Reduce side channels from single-bit reads
a0d32b597d Optimization: use Nx32 representation for recoded bits
e03dcc44b5 Make secp256k1_scalar_get_bits support 32-bit reads
5005abee60 Rename scalar_get_bits -> scalar_get_bits_limb32; return uint32_t
6247f485b6 Optimization: avoid unnecessary doublings in precomputation
15d0cca2a6 Optimization: first table lookup needs no point addition
7a33db35cd Optimization: move (2^COMB_BITS-1)/2 term into ctx->scalar_offset
ed2a056f3d Provide 3 configurations accessible through ./configure
5f7be9f6a5 Always generate tables for current (blocks,teeth) config
fde1dfcd8d Signed-digit multi-comb ecmult_gen algorithm
486518b350 Make exhaustive tests's scalar_inverse(&x,&x) work
ab45c3e089 Initial gej blinding -> final ge blinding
aa00a6b892 Introduce CEIL_DIV macro and use it

git-subtree-dir: src/secp256k1
git-subtree-split: 06bff6dec8d038f7b4112664a9b882293ebc5178
fanquake added a commit to fanquake/oss-fuzz that referenced this pull request Jul 31, 2024
This option was renamed in
bitcoin-core/secp256k1#1058, resulting in
`configure: WARNING: unrecognized options: --with-ecmult-gen-precision`.

Update the option and change the values.

Also add `--enable-option-checking`, so that it'll be harder for this to
happen in future. See:
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Option-Checking.html.
DavidKorczynski pushed a commit to google/oss-fuzz that referenced this pull request Jul 31, 2024
This option was renamed in
bitcoin-core/secp256k1#1058, resulting in
`configure: WARNING: unrecognized options: --with-ecmult-gen-precision`.

Update the option and change the values.

Also add `--enable-option-checking`, so that it'll be harder for this to
happen in future. See:

https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Option-Checking.html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants