tests: really test the non-var scalar inverse #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function `test_inverse_scalar` contains:
(var ? secp256k1_scalar_inverse_var : secp256k1_scalar_inverse_var)(&l, x); /* l = 1/x */
The two sides of the condition are the same function. This seems to be
an error, as there also exists a non-var function, named
`secp256k1_scalar_inverse`.
Make `test_inverse_scalar` use this other function when `var` is false.
This issue was found using clang's static analyzer, which reported a
"Logic error: Identical expressions in conditional expression" (with
checker `alpha.core.IdenticalExpr`).
real-or-random
approved these changes
Jun 28, 2021
Can you elaborate on how you used/called the tool? Maybe we could add it to our arsenal in CI if it doesn't give a gazillion false positives. |
I used the Ubuntu package scan-build \
--force-analyze-debug-code \
-enable-checker security \
-enable-checker unix \
-enable-checker valist \
-enable-checker alpha.core.BoolAssignment \
-enable-checker alpha.core.CastSize \
-enable-checker alpha.core.CastToStruct \
-enable-checker alpha.core.DynamicTypeChecker \
-enable-checker alpha.core.FixedAddr \
-enable-checker alpha.core.IdenticalExpr \
-enable-checker alpha.core.PointerArithm \
-enable-checker alpha.core.PointerSub \
-enable-checker alpha.core.SizeofPtr \
-enable-checker alpha.core.TestAfterDivZero \
-enable-checker alpha.security.ArrayBoundV2 \
-enable-checker alpha.security.MallocOverflow \
-enable-checker alpha.security.ReturnPtrRange \
-enable-checker alpha.security.taint.TaintPropagation \
-enable-checker alpha.unix.PthreadLock \
-enable-checker alpha.unix.SimpleStream \
-enable-checker alpha.unix.Stream \
-enable-checker alpha.unix.cstring.BufferOverlap \
-enable-checker alpha.unix.cstring.OutOfBounds \
-enable-checker alpha.unix.cstring.NotNullTerminated \
-maxloop 257 \
-analyze-headers \
-o "$(pwd)/scan-build-output" \
sh -c 'export CFLAGS=-DVERIFY ; ./configure --enable-coverage=no --with-asm=no && make'This command produces several HTML files in a new directory
At first there were ~100 warnings, but many of them were duplicates because they occur in C header files. |
|
Thanks, that's helpful. Now I remember I used this before. I believe it's possible to eliminate most of the false positives.
Not a switch so far but the easiest way to set environment variables is to pass them to |
jonasnick
reviewed
Jun 28, 2021
|
Thank you @niooss-ledger |
|
Posthumous ACK |
sipa
added a commit
to sipa/bitcoin
that referenced
this pull request
Jul 14, 2021
be8d9c2 Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM aeece44 gen_context: Don't use any ASM 7688a4f Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups 90e8344 ci: Add C++ test f698caa Use unsigned char consistently for byte arrays b5b8e7b Don't declare constants twice 769528f Don't use string literals for char arrays without NUL termination 2cc3cfa Fix -Wmissing-braces warning in clang 0440945 Merge bitcoin#844: schnorrsig API overhaul ec3aaa5 Merge bitcoin#960: tests_exhaustive: check the result of secp256k1_ecdsa_sign a1ee83c tests_exhaustive: check the result of secp256k1_ecdsa_sign 253f90c Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG 446d28d Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS 0302138 ci: Make compiler warning into errors on CI b924e1e build: Ensure that configure's compile checks default to -O2 7939cd5 build: List *CPPFLAGS before *CFLAGS like on the compiler command line 595e8a3 build: Enable -Wcast-align=strict warning 0725626 build: Use own variable SECP_CFLAGS instead of touching user CFLAGS 4866178 Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests 75ce488 Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse 41ed139 tests: really test the non-var scalar inverse 5f6ceaf schnorrsig: allow setting MSGLEN != 32 in benchmark fdd06b7 schnorrsig: add tests for sign_custom and varlen msg verification d8d806a schnorrsig: add extra parameter struct for sign_custom a0c3fc1 schnorrsig: allow signing and verification of variable length msgs 5a8e499 Add secp256k1_tagged_sha256 as defined in BIP-340 b6c0b72 schnorrsig: remove noncefp args from sign; add sign_custom function bdf19f1 Add random field multiply/square tests 8ae56e3 Merge bitcoin#879: Avoid passing out-of-bound pointers to 0-size memcpy a4642fa configure: replace AC_PATH_PROG to AC_CHECK_PROG 1758a92 Merge bitcoin#950: ci: Add ppc64le build c58c4ea ci: Add ppc64le build 7973576 Merge bitcoin#662: Add ecmult_gen, ecmult_const and ecmult to benchmark 8f879c2 Fix array size in bench_ecmult 2fe1b50 Add ecmult_gen, ecmult_const and ecmult to benchmark 593e6ba Clean up ecmult_bench to make space for more benchmarks 50f3367 Merge bitcoin#947: ci: Run PRs on merge result even for i686 a35fdd3 ci: Run PRs on merge result even for i686 442cee5 schnorrsig: add algolen argument to nonce_function_hardened df3bfa1 schnorrsig: clarify result of calling nonce_function_bip340 without data 99e8614 README: mention schnorrsig module 3dc8c07 Merge bitcoin#846: ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs 02dcea1 ci: Make test iterations configurable and tweak for sanitizer builds 489ff5c tests: Treat empty SECP2561_TEST_ITERS as if it was unset fcfcb97 ci: Simplify to use generic wrapper for QEMU, Valgrind, etc de4157f ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs 399722a Merge bitcoin#941: Clean up git tree 09b3bb8 Clean up git tree bf0ac46 Merge bitcoin#930: Add ARM32/ARM64 CI 202a030 Merge bitcoin#850: add `secp256k1_ec_pubkey_cmp` method 1e78c18 Merge bitcoin-core/secp256k1#940: contrib: Explain explicit header guards 6939487 Merge bitcoin#926: secp256k1.h: clarify that by default arguments must be != NULL 6eceec6 add `secp256k1_xonly_pubkey_cmp` method 0d9561a add `secp256k1_ec_pubkey_cmp` method 22a9ea1 contrib: Explain explicit header guards 6c52ae8 Merge bitcoin#937: Have ge_set_gej_var, gej_double_var and ge_set_all_gej_var initialize all fields of their outputs. 185a6af Merge bitcoin#925: changed include statements without prefix 'include/' 14c9739 tests: Improve secp256k1_ge_set_all_gej_var for some infinity inputs 4a19668 tests: Test secp256k1_ge_set_all_gej_var for all infinity inputs 3c90bdd change local lib headers to be relative for those pointing at "include/" dir 45b6468 Have secp256k1_ge_set_all_gej_var initialize all fields. Previous behaviour would not initialize r->y values in the case where infinity is passed in. Furthermore, the previous behaviour wouldn't initialize anything in the case where all inputs were infinity. 31c0f6d Have secp256k1_gej_double_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in. dd6c3de Have secp256k1_ge_set_gej_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in. d0bd269 Merge bitcoin-core/secp256k1#936: Fix gen_context/ASM build on ARM 8bbad7a Add asm build to ARM32 CI 7d65ed5 Add ARM32/ARM64 CI c848352 Makefile.am: Don't pass a variable twice 2161f31 Makefile.am: Honor config when building gen_context 99f47c2 gen_context: Don't use external ASM because it complicates the build 98e0358 Merge bitcoin#933: Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers 99e2d5b Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers. 34388af Merge bitcoin#922: Add mingw32-w64/wine CI build 7012a18 Merge bitcoin#928: Define SECP256K1_BUILD in secp256k1.c directly. ed5a199 tests: fopen /dev/urandom in binary mode ae9e648 Define SECP256K1_BUILD in secp256k1.c directly. 4dc37bf Add mingw32-w64/wine CI build 0881633 secp256k1.h: clarify that by default arguments must be != NULL 9570f67 Avoid passing out-of-bound pointers to 0-size memcpy git-subtree-dir: src/secp256k1 git-subtree-split: be8d9c2
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Jul 28, 2021
90580edcc98 Merge pull request ElementsProject#140 from apoelstra/2021-07--resync 6ad66de6802 rangeproof: add an (unnecessary) variable initialization to shut up CI 2979e4d9d46 Merge commits '8ae56e33 75ce488c 4866178d 446d28d9 253f90cd ec3aaa50 0440945f 7688a4f1 be8d9c26 ' into temp-merge-965 5d2df054196 Merge BlockstreamResearch/secp256k1-zkp#120: Add MuSig Key Aggregation spec fc26ca8ddef musig: remove unnecessary constant time normalize in combine 48f63efe683 musig: remove unnecessary branch in pubkey_tweak_add 5860b5e0fe7 musig: do not also require schnorrsig module config flag f27fd1d5e75 musig: improve test coverage of pubkey_combine 56014e8ca01 musig: change pubkey_combine arg to array of pointers to pks 08fa02d5791 musig: add key aggregation spec draft 4a9b059b16d musig: rename Musig coefficient to KeyAgg coefficient 4bc46d836e7 musig: optimize key aggregation using const 1 for 2nd key 2310849f50f musig: compute musig coefficient by hashing key instead of index 9683c8a7eb6 musig: add static test vectors for key aggregation 9b3d7bf5361 extrakeys: add xonly_sort function f31affd8a61 extrakeys: add hsort, in-place, iterative heapsort be8d9c262f4 Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM d9560e0af78 Merge BlockstreamResearch/secp256k1-zkp#136: Eliminate a wrong -Wmaybe-uninitialized warning in GCC aeece445997 gen_context: Don't use any ASM 6db00f5b2e0 Merge BlockstreamResearch/secp256k1-zkp#132: Upstream PRs 831, 907, 903, 889, 918, 906, 928, 922, 933, Merge bitcoin-core/secp256k1#936: Fix gen_context/ASM build on ARM, 925, 937, 926, Merge bitcoin-core/secp256k1#940: contrib: Explain explicit header guards, 850, 930, 941, 846, 947, 662, 950 cc0b279568d Eliminate a wrong -Wmaybe-uninitialized warning in GCC f09497ea3e0 CI: tweak cirrus.yml to prevent OOM and timeout w sanitizer/valgrind 7226cf215aa ecdsa_adaptor: fix too small buffer in tests b053e853d4f ecdsa_adaptor: fix test case with invalid signature 91b64770c3b Merge BlockstreamResearch/secp256k1-zkp#135: sync-upstream: fix "end" parameter for specifying range 907633e2e9a sync-upstream: fix "end" parameter for specifying range 394f49fd1a6 sync-upstream: quote variables 1bb5db3d602 Merge BlockstreamResearch/secp256k1-zkp#134: sync-upstream: parse merge commits w/ and w/o repo identifier 9321d42f751 sync-upstream: parse merge commits w/ and w/o repo identifier 7688a4f13a3 Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups 90e83449b2c ci: Add C++ test f698caaff6a Use unsigned char consistently for byte arrays b5b8e7b7190 Don't declare constants twice 769528f3071 Don't use string literals for char arrays without NUL termination 2cc3cfa5838 Fix -Wmissing-braces warning in clang 0440945fb5c Merge ElementsProject#844: schnorrsig API overhaul ec3aaa5014f Merge ElementsProject#960: tests_exhaustive: check the result of secp256k1_ecdsa_sign a1ee83c6546 tests_exhaustive: check the result of secp256k1_ecdsa_sign 253f90cdeb1 Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG 446d28d9de3 Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS 0302138f750 ci: Make compiler warning into errors on CI b924e1e605d build: Ensure that configure's compile checks default to -O2 7939cd571c7 build: List *CPPFLAGS before *CFLAGS like on the compiler command line 595e8a35d80 build: Enable -Wcast-align=strict warning 07256267ffa build: Use own variable SECP_CFLAGS instead of touching user CFLAGS 4866178dfc9 Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests 75ce488c2a6 Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse 41ed13942bd tests: really test the non-var scalar inverse 5f6ceafcfa4 schnorrsig: allow setting MSGLEN != 32 in benchmark fdd06b79671 schnorrsig: add tests for sign_custom and varlen msg verification d8d806aaf38 schnorrsig: add extra parameter struct for sign_custom a0c3fc177f7 schnorrsig: allow signing and verification of variable length msgs 5a8e4991ad4 Add secp256k1_tagged_sha256 as defined in BIP-340 b6c0b72fb06 schnorrsig: remove noncefp args from sign; add sign_custom function bdf19f105c6 Add random field multiply/square tests 8ae56e33e74 Merge ElementsProject#879: Avoid passing out-of-bound pointers to 0-size memcpy a4642fa15ee configure: replace AC_PATH_PROG to AC_CHECK_PROG d27e4598610 Revert "Remove unused Jacobi symbol support" edcacc2b2ec Merge commits '26de4dfe 6e898534 c083cc6e 1e5d50fa cc2c09e3 efad3506 7012a188 34388af6 98e0358d d0bd2693 185a6af2 6c52ae87 69394879 1e78c18d 202a030f bf0ac460 399722a6 3dc8c072 50f33677 7973576f 1758a92f ' into temp-merge-950 1758a92ffd8 Merge ElementsProject#950: ci: Add ppc64le build c58c4ea4707 ci: Add ppc64le build 7973576f6e3 Merge ElementsProject#662: Add ecmult_gen, ecmult_const and ecmult to benchmark 8f879c2887e Fix array size in bench_ecmult 2fe1b50df16 Add ecmult_gen, ecmult_const and ecmult to benchmark 593e6bad9c5 Clean up ecmult_bench to make space for more benchmarks 50f33677122 Merge ElementsProject#947: ci: Run PRs on merge result even for i686 a35fdd3478f ci: Run PRs on merge result even for i686 442cee5bafb schnorrsig: add algolen argument to nonce_function_hardened df3bfa12c3b schnorrsig: clarify result of calling nonce_function_bip340 without data 99e8614812b README: mention schnorrsig module 3dc8c072b6d Merge ElementsProject#846: ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs 02dcea1ad94 ci: Make test iterations configurable and tweak for sanitizer builds 489ff5c20a1 tests: Treat empty SECP2561_TEST_ITERS as if it was unset fcfcb97e74b ci: Simplify to use generic wrapper for QEMU, Valgrind, etc de4157f13ac ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs 399722a63ad Merge ElementsProject#941: Clean up git tree 09b3bb8648f Clean up git tree bf0ac460661 Merge ElementsProject#930: Add ARM32/ARM64 CI 202a030f7d1 Merge ElementsProject#850: add `secp256k1_ec_pubkey_cmp` method 1e78c18d5b8 Merge bitcoin-core/secp256k1#940: contrib: Explain explicit header guards 69394879b64 Merge ElementsProject#926: secp256k1.h: clarify that by default arguments must be != NULL 6eceec6d566 add `secp256k1_xonly_pubkey_cmp` method 0d9561ae879 add `secp256k1_ec_pubkey_cmp` method 22a9ea154a2 contrib: Explain explicit header guards 6c52ae87247 Merge ElementsProject#937: Have ge_set_gej_var, gej_double_var and ge_set_all_gej_var initialize all fields of their outputs. 185a6af2279 Merge ElementsProject#925: changed include statements without prefix 'include/' 14c9739a1fb tests: Improve secp256k1_ge_set_all_gej_var for some infinity inputs 4a19668c37b tests: Test secp256k1_ge_set_all_gej_var for all infinity inputs 3c90bdda95a change local lib headers to be relative for those pointing at "include/" dir 45b6468d7e3 Have secp256k1_ge_set_all_gej_var initialize all fields. Previous behaviour would not initialize r->y values in the case where infinity is passed in. Furthermore, the previous behaviour wouldn't initialize anything in the case where all inputs were infinity. 31c0f6de413 Have secp256k1_gej_double_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in. dd6c3de3227 Have secp256k1_ge_set_gej_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in. d0bd2693e30 Merge bitcoin-core/secp256k1#936: Fix gen_context/ASM build on ARM 8bbad7a18e5 Add asm build to ARM32 CI 7d65ed52142 Add ARM32/ARM64 CI c8483520c90 Makefile.am: Don't pass a variable twice 2161f31785e Makefile.am: Honor config when building gen_context 99f47c20ec4 gen_context: Don't use external ASM because it complicates the build 98e0358d297 Merge ElementsProject#933: Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers 99e2d5be0db Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers. 34388af6b6a Merge ElementsProject#922: Add mingw32-w64/wine CI build 7012a188e6e Merge ElementsProject#928: Define SECP256K1_BUILD in secp256k1.c directly. ed5a199bed6 tests: fopen /dev/urandom in binary mode ae9e648526c Define SECP256K1_BUILD in secp256k1.c directly. 4dc37bf81b5 Add mingw32-w64/wine CI build 0881633dfd0 secp256k1.h: clarify that by default arguments must be != NULL efad3506a89 Merge ElementsProject#906: Use modified divsteps with initial delta=1/2 for constant-time cc2c09e3a78 Merge ElementsProject#918: Clean up configuration in gen_context 07067967ee9 add ECMULT_GEN_PREC_BITS to basic_config.h a3aa2628c7b gen_context: Don't include basic-config.h be0609fd54a Add unit tests for edge cases with delta=1/2 variant of divsteps cd393ce2283 Optimization: only do 59 hddivsteps per iteration instead of 62 277b224b6ab Use modified divsteps with initial delta=1/2 for constant-time 376ca366db0 Fix typo in explanation 1e5d50fa93d Merge ElementsProject#889: fix uninitialized read in tests f3708a1ecb4 Merge ElementsProject#117: Add ECDSA adaptor signatures module 5710ebacb9e Merge ElementsProject#128: Make function argument name consistent with doc b0ffa923199 ecdsa_adaptor: add tests 6955af5ca89 ecdsa_adaptor: add ECDSA adaptor signature APIs c083cc6e52a Merge ElementsProject#903: Make argument of fe_normalizes_to_zero{_var} const 6e898534ff4 Merge ElementsProject#907: changed import to use brackets <> for openssl cc82ad5ab74 Make function argument name consistent with doc 4504472269d changed import to use brackets <> for openssl as they are not local to the project 26de4dfeb1f Merge ElementsProject#831: Safegcd inverses, drop Jacobi symbols, remove libgmp b508e5dd9b1 ecdsa_adaptor: add support for proof of discrete logarithm equality d8f336564fe ecdsa_adaptor: add nonce function and tags 654cd633f50 ecdsa_adaptor: initialize project 23c3fb629b9 Make argument of fe_normalizes_to_zero{_var} const 24ad04fc064 Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS ebc1af700f9 Optimization: track f,g limb count and pass to new variable-time update_fg_var b306935ac12 Optimization: use formulas instead of lookup tables for cancelling g bits 9164a1b6582 Optimization: special-case zero modulus limbs in modinv64 1f233b3fa05 Remove num/gmp support fac477f822a Merge ElementsProject#126: Upstream PRs ElementsProject#854 ElementsProject#852 ElementsProject#857 ElementsProject#858 ElementsProject#860 ElementsProject#845 ElementsProject#862 ElementsProject#875 ElementsProject#878 ElementsProject#874 ElementsProject#877 ElementsProject#880 ElementsProject#864 ElementsProject#882 ElementsProject#894 ElementsProject#891 ElementsProject#901 20448b8d09a Remove unused Jacobi symbol support 5437e7bdfbf Remove unused scalar_sqr aa9cc521800 Improve field/scalar inverse tests 1e0e885c8ac Make field/scalar code use the new modinv modules for inverses 436281afdcb Move secp256k1_fe_inverse{_var} to per-impl files aa404d53bef Move secp256k1_scalar_{inverse{_var},is_even} to per-impl files 08d54964e51 Improve bounds checks in modinv modules 6a7861f646f Merge ElementsProject#127: sync-upstream: Create proper links to upstream PRs 4091e619248 cirrus: increase timeout for macOS tasks 136ed8f84d9 sync-upstream: Fix output of command to reproduce 38f1e777d49 sync-upstream: Create proper links to upstream PRs 79d4c3ac681 whitelist: add SECP_INCLUDES to bench_whitelist CPPFLAGS 649bf201d85 musig: fix tests for 32-bit 151aac00d31 Add tests for modinv modules d8a92fcc4c6 Add extensive comments on the safegcd algorithm and implementation 8e415acba25 Add safegcd based modular inverse modules de0a643c3dc Add secp256k1_ctz{32,64}_var functions d4ca81f48e9 Merge commits 'dc6e5c3a 2d9e7175 b61f9da5 98dac878 8c727b90 328aaef2 f2d9aeae b732701f db726782 5671e5f3 a4abaab7 659d0d47 f8c0b57e 24d1656c 3a8b47bc ebdba03c 4c3ba88c ' into temp-merge-901 4c3ba88c3a8 Merge ElementsProject#901: ci: Switch all Linux builds to Debian and more improvements 9361f360bb0 ci: Select number of parallel make jobs depending on CI environment 28eccdf8064 ci: Split output of logs into multiple sections c7f754fe4d5 ci: Run PRs on merge result instead of on the source branch b994a8be3cf ci: Print information about binaries using "file" f24e122d13d ci: Switch all Linux builds to Debian ebdba03cb56 Merge ElementsProject#891: build: Add workaround for automake 1.13 and older 3a8b47bc6d1 Merge ElementsProject#894: ctime_test: move context randomization test to the end 6da00ec6245 Merge pull request ElementsProject#124 from apoelstra/2021-02--rename-klepto e354c5751d6 ecdsa_s2c: rename anti-klepto to anti-exfil 7d3497cdc4c ctime_test: move context randomization test to the end 99a1cfec174 print warnings for conditional-uninitialized 3d2cf6c5bd3 initialize variable in tests f329bba2442 build: Add workaround for automake 1.13 and older 24d1656c328 Merge ElementsProject#882: Use bit ops instead of int mult for constant-time logic in gej_add_ge e491d06b98c Use bit ops instead of int mult for constant-time logic in gej_add_ge f8c0b57e6ba Merge ElementsProject#864: Add support for Cirrus CI cc2a5451dc8 ci: Refactor Nix shell files 2480e55c8f3 ci: Remove support for Travis CI 2b359f1c1d8 ci: Enable simple cache for brewing valgrind on macOS 8c02e465c5a ci: Add support for Cirrus CI 659d0d47989 Merge ElementsProject#880: Add parens around ROUND_TO_ALIGN's parameter. b6f649889ae Add parens around ROUND_TO_ALIGN's parameter. This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation. a4abaab7931 Merge ElementsProject#877: Add missing secp256k1_ge_set_gej_var decl. 5671e5f3fd0 Merge ElementsProject#874: Remove underscores from header defs. db726782fa2 Merge ElementsProject#878: Remove unused secp256k1_fe_inv_all_var b732701faa7 Merge ElementsProject#875: Avoid casting (void**) values. 9570f674cc7 Avoid passing out-of-bound pointers to 0-size memcpy 75d2ae149ef Remove unused secp256k1_fe_inv_all_var 482e4a9cfce Add missing secp256k1_ge_set_gej_var decl. 27306186045 Avoid casting (void**) values. Replaced with an expression that only casts (void*) values. fb390c5299e Remove underscores from header defs. This makes them consistent with other files and avoids reserved identifiers. ed69ea79b42 Merge ElementsProject#98: Add contrib/sync-upstream.sh script to automate syncing PRs 7eeacd7725f Add contrib/sync-upstream.sh script to automate merging upstream PRs f2d9aeae6d5 Merge ElementsProject#862: Autoconf improvements 328aaef22a4 Merge ElementsProject#845: Extract the secret key from a keypair 3c15130709d Improve CC_FOR_BUILD detection 47802a47624 Restructure and tidy configure.ac 252c19dfc65 Ask brew for valgrind include path 8c727b9087a Merge ElementsProject#860: fixed trivial typo cfac088e1b2 Merge ElementsProject#119: Remove repeated schnorr flag from travis config 96c83a83dcf Remove repeated schnorr flag from travis config d2b6740688f Merge pull request ElementsProject#118 from jonasnick/clarify-rangeproof-rewind 41d6963bc1c rangeproof: clarify rewind outlen argument 673e551f4d1 Merge ElementsProject#111: Add ECDSA sign-to-contract module b7bc3a4aaa5 fixed typo 47efb5e39a1 ecdsa-s2c: add ctime tests 396b558273c ecdsa-s2c: add anti-klepto protocol 290dee566e1 ecdsa-s2c: add actual sign-to-contract functionality 8e46cac5b31 ecdsa-s2c: block in module 826bd04b43f add eccommit functionality 33cb3c2b1fc Add secret key extraction from keypair to constant time tests 36d9dc1e8e6 Add seckey extraction from keypair to the extrakeys tests fc96aa73f5c Add a function to extract the secretkey from a keypair 98dac878398 Merge ElementsProject#858: Fix insecure links 07aa4c70ffb Fix insecure links b61f9da54ef Merge ElementsProject#857: docs: fix simple typo, dependecy -> dependency 18aadf9d288 docs: fix simple typo, dependecy -> dependency 2d9e7175c6e Merge ElementsProject#852: Add sage script for generating scalar_split_lambda constants dc6e5c3a5c4 Merge ElementsProject#854: Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation 6e85d675aaf Rename tweak to tweak32 in public API f587f04e357 Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation 329a2e0a3f2 sage: Add script for generating scalar_split_lambda constants f554dfc7088 sage: Reorganize files git-subtree-dir: src/secp256k1 git-subtree-split: 90580edcc98350c9df9bebee58d2f9616d801849
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Nov 5, 2021
be8d9c262f Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM aeece44599 gen_context: Don't use any ASM 7688a4f13a Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups 90e83449b2 ci: Add C++ test f698caaff6 Use unsigned char consistently for byte arrays b5b8e7b719 Don't declare constants twice 769528f307 Don't use string literals for char arrays without NUL termination 2cc3cfa583 Fix -Wmissing-braces warning in clang 0440945fb5 Merge #844: schnorrsig API overhaul ec3aaa5014 Merge #960: tests_exhaustive: check the result of secp256k1_ecdsa_sign a1ee83c654 tests_exhaustive: check the result of secp256k1_ecdsa_sign 253f90cdeb Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG 446d28d9de Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS 0302138f75 ci: Make compiler warning into errors on CI b924e1e605 build: Ensure that configure's compile checks default to -O2 7939cd571c build: List *CPPFLAGS before *CFLAGS like on the compiler command line 595e8a35d8 build: Enable -Wcast-align=strict warning 07256267ff build: Use own variable SECP_CFLAGS instead of touching user CFLAGS 4866178dfc Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests 75ce488c2a Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse 41ed13942b tests: really test the non-var scalar inverse 5f6ceafcfa schnorrsig: allow setting MSGLEN != 32 in benchmark fdd06b7967 schnorrsig: add tests for sign_custom and varlen msg verification d8d806aaf3 schnorrsig: add extra parameter struct for sign_custom a0c3fc177f schnorrsig: allow signing and verification of variable length msgs 5a8e4991ad Add secp256k1_tagged_sha256 as defined in BIP-340 b6c0b72fb0 schnorrsig: remove noncefp args from sign; add sign_custom function bdf19f105c Add random field multiply/square tests 8ae56e33e7 Merge #879: Avoid passing out-of-bound pointers to 0-size memcpy a4642fa15e configure: replace AC_PATH_PROG to AC_CHECK_PROG 1758a92ffd Merge #950: ci: Add ppc64le build c58c4ea470 ci: Add ppc64le build 7973576f6e Merge #662: Add ecmult_gen, ecmult_const and ecmult to benchmark 8f879c2887 Fix array size in bench_ecmult 2fe1b50df1 Add ecmult_gen, ecmult_const and ecmult to benchmark 593e6bad9c Clean up ecmult_bench to make space for more benchmarks 50f3367712 Merge #947: ci: Run PRs on merge result even for i686 a35fdd3478 ci: Run PRs on merge result even for i686 442cee5baf schnorrsig: add algolen argument to nonce_function_hardened df3bfa12c3 schnorrsig: clarify result of calling nonce_function_bip340 without data 99e8614812 README: mention schnorrsig module 3dc8c072b6 Merge #846: ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs 02dcea1ad9 ci: Make test iterations configurable and tweak for sanitizer builds 489ff5c20a tests: Treat empty SECP2561_TEST_ITERS as if it was unset fcfcb97e74 ci: Simplify to use generic wrapper for QEMU, Valgrind, etc de4157f13a ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs 399722a63a Merge #941: Clean up git tree 09b3bb8648 Clean up git tree bf0ac46066 Merge #930: Add ARM32/ARM64 CI 202a030f7d Merge #850: add `secp256k1_ec_pubkey_cmp` method 1e78c18d5b Merge bitcoin-core/secp256k1#940: contrib: Explain explicit header guards 69394879b6 Merge #926: secp256k1.h: clarify that by default arguments must be != NULL 6eceec6d56 add `secp256k1_xonly_pubkey_cmp` method 0d9561ae87 add `secp256k1_ec_pubkey_cmp` method 22a9ea154a contrib: Explain explicit header guards 6c52ae8724 Merge #937: Have ge_set_gej_var, gej_double_var and ge_set_all_gej_var initialize all fields of their outputs. 185a6af227 Merge #925: changed include statements without prefix 'include/' 14c9739a1f tests: Improve secp256k1_ge_set_all_gej_var for some infinity inputs 4a19668c37 tests: Test secp256k1_ge_set_all_gej_var for all infinity inputs 3c90bdda95 change local lib headers to be relative for those pointing at "include/" dir 45b6468d7e Have secp256k1_ge_set_all_gej_var initialize all fields. Previous behaviour would not initialize r->y values in the case where infinity is passed in. Furthermore, the previous behaviour wouldn't initialize anything in the case where all inputs were infinity. 31c0f6de41 Have secp256k1_gej_double_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in. dd6c3de322 Have secp256k1_ge_set_gej_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in. d0bd2693e3 Merge bitcoin-core/secp256k1#936: Fix gen_context/ASM build on ARM 8bbad7a18e Add asm build to ARM32 CI 7d65ed5214 Add ARM32/ARM64 CI c8483520c9 Makefile.am: Don't pass a variable twice 2161f31785 Makefile.am: Honor config when building gen_context 99f47c20ec gen_context: Don't use external ASM because it complicates the build 98e0358d29 Merge #933: Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers 99e2d5be0d Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers. 34388af6b6 Merge #922: Add mingw32-w64/wine CI build 7012a188e6 Merge #928: Define SECP256K1_BUILD in secp256k1.c directly. ed5a199bed tests: fopen /dev/urandom in binary mode ae9e648526 Define SECP256K1_BUILD in secp256k1.c directly. 4dc37bf81b Add mingw32-w64/wine CI build 0881633dfd secp256k1.h: clarify that by default arguments must be != NULL 9570f674cc Avoid passing out-of-bound pointers to 0-size memcpy git-subtree-dir: src/secp256k1 git-subtree-split: be8d9c262f46309d9b4165b0498b71d704aba8fe
patricklodder
added a commit
to patricklodder/dogecoin
that referenced
this pull request
Jul 25, 2022
44c2452fd3 Merge bitcoin-core/secp256k1#1105: Don't export symbols in static libraries
6f6cab9989 abi: Don't export symbols in static Windows libraries
485f608fa9 Merge bitcoin-core/secp256k1#1104: Fix the false positive of `SECP_64BIT_ASM_CHECK`
8b013fce51 Merge bitcoin-core/secp256k1#1056: Save negations in var-time group addition
7efc9835a9 Fix the false positive of `SECP_64BIT_ASM_CHECK`
8746600eec Merge bitcoin-core/secp256k1#1093: hash: Make code agnostic of endianness
2f984ffc45 Save negations in var-time group addition
37d36927df tests: Add tests for _read_be32 and _write_be32
912b7ccc44 Merge bitcoin-core/secp256k1#1094: doc: Clarify configure flags for optional modules
55512d30b7 doc: clean up module help text in configure.ac
d9d94a9969 doc: mention optional modules in README
616b43dd3b util: Remove endianness detection
8d89b9e6e5 hash: Make code agnostic of endianness
d0ad5814a5 Merge bitcoin-core/secp256k1#995: build: stop treating schnorrsig, extrakeys modules as experimental
1ac7e31c5b Merge bitcoin-core/secp256k1#1089: Schnorrsig API improvements
587239dbe3 Merge bitcoin-core/secp256k1#731: Change SHA256 byte counter from size_t to uint64_t
f8d9174357 Add SHA256 bit counter tests
7f09d0f311 README: mention that ARM assembly is experimental
b8f8b99f0f docs: Fix return value for functions that don't have invalid inputs
f813bb0df3 schnorrsig: Adapt example to new API
99e6568fc6 schnorrsig: Rename schnorrsig_sign to schnorsig_sign32 and deprecate
fc94a2da44 Use SECP256K1_DEPRECATED for existing deprecated API functions
3db0560606 Add SECP256K1_DEPRECATED attribute for marking API parts as deprecated
80cf4eea5f build: stop treating schnorrsig, extrakeys modules as experimental
e0508ee9db Merge bitcoin-core/secp256k1#1090: configure: Remove redundant pkg-config code
21b2ebaf74 configure: Remove redundant pkg-config code
0e5cbd01b3 Merge bitcoin-core/secp256k1#1088: configure: Use modern way to set AR
0d253d52e8 configure: Use modern way to set AR
9b514ce1d2 Add test vector for very long SHA256 messages
8e3dde1137 Simplify struct initializer for SHA256 padding
eb28464a8b Change SHA256 byte counter from size_t to uint64_t
ac83be33d0 Merge bitcoin-core/secp256k1#1079: configure: Add hidden --enable-dev-mode to enable all the stuff
e0838d663d configure: Add hidden --enable-dev-mode to enable all the stuff
fabd579dfa configure: Remove redundant code that sets _enable variables
0d4226c051 configure: Use canonical variable prefix _enable consistently
64b34979ed Merge bitcoin-core/secp256k1#748: Add usage examples
7c9502cece Add a copy of the CC0 license to the examples
42e03432e6 Add usage examples to the readme
517644eab1 Optionally compile the examples in autotools, compile+run in travis
422a7cc86a Add a ecdh shared secret example
b0cfbcc143 Add a Schnorr signing and verifying example
fee7d4bf9e Add an ECDSA signing and verifying example
1253a27756 Merge bitcoin-core/secp256k1#1033: Add _fe_half and use in _gej_add_ge and _gej_double
3ef94aa5ba Merge bitcoin-core/secp256k1#1026: ecdh: Add test computing shared_secret=basepoint with random inputs
3531a43b5b ecdh: Make generator_basepoint test depend on global iteration count
c881dd49bd ecdh: Add test computing shared_secret=basepoint with random inputs
077528317d Merge bitcoin-core/secp256k1#1074: ci: Retry brew update a few times to avoid random failures
e51ad3b737 ci: Retry `brew update` a few times to avoid random failures
b1cb969e8a ci: Revert "Attempt to make macOS builds more reliable"
5dcc6f8dbd Merge bitcoin-core/secp256k1#1069: build: Replace use of deprecated autoconf macro AC_PROG_CC_C89
59547943d6 Merge bitcoin-core/secp256k1#1072: ci: Attempt to make macOS builds more reliable
85b00a1c65 Merge bitcoin-core/secp256k1#1068: sage: Fix incompatibility with sage 9.4
ebb1beea78 sage: Ensure that constraints are always fastfracs
d8d54859ed ci: Run sage prover on CI
77cfa98dbc sage: Normalize sign of polynomial factors in prover
eae75869cf sage: Exit with non-zero status in case of failures
d9396a56da ci: Attempt to make macOS builds more reliable
e0db3f8a25 build: Replace use of deprecated autoconf macro AC_PROG_CC_C89
e848c3799c Update sage files for new formulae
d64bb5d4f3 Add fe_half tests for worst-case inputs
b54d843eac sage: Fix printing of errors
4eb8b932ff Further improve doubling formula using fe_half
557b31fac3 Doubling formula using fe_half
2cbb4b1a42 Run more iterations of run_field_misc
9cc5c257ed Add test for secp256k1_fe_half
925f78d55e Add _fe_half and use in _gej_add_ge
e108d0039c sage: Fix incompatibility with sage 9.4
d8a2463246 Merge bitcoin-core/secp256k1#899: Reduce stratch space needed by ecmult_strauss_wnaf.
0a40a4861a Merge bitcoin-core/secp256k1#1049: Faster fixed-input ecmult tests
070e772211 Faster fixed-input ecmult tests
c8aa516b57 Merge bitcoin-core/secp256k1#1064: Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063
b797a500ec Create a SECP256K1_ECMULT_TABLE_VERIFY macro.
a731200cc3 Replace ECMULT_TABLE_GET_GE_STORAGE macro with a function.
fe34d9f341 Eliminate input_pos state field from ecmult_strauss_wnaf.
0397d00ba0 Eliminate na_1 and na_lam state fields from ecmult_strauss_wnaf.
7ba3ffcca0 Remove the unused pre_a_lam allocations.
b3b57ad6ee Eliminate the pre_a_lam array from ecmult_strauss_wnaf.
ae7ba0f922 Remove the unused prej allocations.
e5c18892db Eliminate the prej array from ecmult_strauss_wnaf.
c9da1baad1 Move secp256k1_fe_one to field.h
45f37b6506 Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063.
a1102b1219 Merge bitcoin-core/secp256k1#1029: Simpler and faster ecdh skew fixup
e82144edfb Fixup skew before global Z fixup
40b624c90b Add tests for _gej_cmov
8c13a9bfe1 ECDH skews by 0 or 1
1515099433 Simpler and faster ecdh skew fixup
39a36db94a Merge bitcoin-core/secp256k1#1054: tests: Fix test whose result is implementation-defined
a310e79ee5 Merge bitcoin-core/secp256k1#1052: Use xoshiro256++ instead of RFC6979 for tests
423b6d19d3 Merge bitcoin-core/secp256k1#964: Add release-process.md
9281c9f4e1 Merge bitcoin-core/secp256k1#1053: ecmult: move `_ecmult_odd_multiples_table_globalz_windowa`
77a19750b4 Use xoshiro256++ PRNG instead of RFC6979 in tests
5f2efe684e secp256k1_testrand_int(2**N) -> secp256k1_testrand_bits(N)
05e049b73c ecmult: move `_ecmult_odd_multiples_table_globalz_windowa`
3d7cbafb5f tests: Fix test whose result is implementation-defined
3ed0d02bf7 doc: add CHANGELOG template
6f42dc16c8 doc: add release_process.md
0bd3e4243c build: set library version to 0.0.0 explicitly
b4b02fd8c4 build: change libsecp version from 0.1 to 0.1.0-pre
09971a3ffd Merge bitcoin-core/secp256k1#1047: ci: Various improvements
0b83b203e1 Merge bitcoin-core/secp256k1#1030: doc: Fix upper bounds + cleanup in field_5x52_impl.h comment
1287786c7a doc: Add comment to top of field_10x26_impl.h
58da5bd589 doc: Fix upper bounds + cleanup in field_5x52_impl.h comment
b39d431aed Merge bitcoin-core/secp256k1#1044: Add another ecmult_multi test
b4ac1a1d5f ci: Run valgrind/memcheck tasks with 2 CPUs
e70acab601 ci: Use Cirrus "greedy" flag to use idle CPU time when available
d07e30176e ci: Update brew on macOS
22382f0ea0 ci: Test different ecmult window sizes
a69df3ad24 Merge bitcoin-core/secp256k1#816: Improve checks at top of _fe_negate methods
22d25c8e0a Add another ecmult_multi test
515e7953ca Improve checks at top of _fe_negate methods
26a022a3a0 ci: Remove STATICPRECOMPUTATION
10461d8bd3 precompute_ecmult: Always compute all tables up to default WINDOW_G
be6944ade9 Merge bitcoin-core/secp256k1#1042: Follow-ups to making all tables fully static
e05da9e480 Fix c++ build
c45386d994 Cleanup preprocessor indentation in precompute{,d}_ecmult{,_gen}
19d96e15f9 Split off .c file from precomputed_ecmult.h
1a6691adae Split off .c file from precomputed_ecmult_gen.h
bb36331412 Simplify precompute_ecmult_print_*
38cd84a0cb Compute ecmult tables at runtime for tests_exhaustive
e458ec26d6 Move ecmult table computation code to separate file
fc1bf9f15f Split ecmult table computation and printing
31feab053b Rename function secp256k1_ecmult_gen_{create_prec -> compute}_table
725370c3f2 Rename ecmult_gen_prec -> ecmult_gen_compute_table
075252c1b7 Rename ecmult_static_pre_g -> precomputed_ecmult
7cf47f72bc Rename ecmult_gen_static_prec_table -> precomputed_ecmult_gen
f95b8106d0 Rename gen_ecmult_static_pre_g -> precompute_ecmult
bae77685eb Rename gen_ecmult_gen_static_prec_table -> precompute_ecmult_gen
0559fc6e41 Merge bitcoin-core/secp256k1#988: Make signing table fully static
7dfceceea6 build: Remove #undef hack for ASM in the precomputation programs
bb36fe9be0 ci: Test `make precomp`
d94a37a20c build: Remove CC_FOR_BUILD stuff
ad63bb4c29 build: Prebuild and distribute ecmult_gen table
ac49361ed0 prealloc: Get rid of manual memory management for prealloc contexts
6573c08f65 ecmult_gen: Tidy precomputed file and save space
5eba83f17c ecmult_gen: Precompute tables for all values of ECMULT_GEN_PREC_BITS
5d0dbef018 Merge bitcoin-core/secp256k1#942: Verify that secp256k1_ge_set_gej_zinv does not operate on infinity.
486205aa68 Merge bitcoin-core/secp256k1#920: Test all ecmult functions with many j*2^i combinations
fdb33dd122 refactor: Make PREC_BITS a parameter of ecmult_gen_build_prec_table
5eb519e1f6 ci: reduce TEST_ITERS in memcheck run
e2cf77328a Test ecmult functions for all i*2^j for j=0..255 and odd i=1..255.
61ae37c612 Merge bitcoin-core/secp256k1#1022: build: Windows DLL additions
4f01840b82 Merge bitcoin-core/secp256k1#1027: build: Add a check that Valgrind actually supports a host platform
6ad908aa00 Merge bitcoin-core/secp256k1#1008: bench.c: add `--help` option and ci: move env variables
592661c22f ci: move test environment variable declaration to .cirrus.yml
dcbe84b841 bench: add --help option to bench.
099bad945e Comment and check a parameter for inf in secp256k1_ecmult_const.
6c0be857f8 Verify that secp256k1_ge_set_gej_zinv does not operate on infinity. a->x and a->y should not be used if the infinity flag is set.
4900227451 Merge bitcoin-core/secp256k1#1025: build: replace backtick command substitution with $()
7c7ce872a5 build: Add a check that Valgrind actually supports a host platform
a4875e30a6 refactor: Move default callbacks to util.h
4c94c55bce doc: Remove obsolete hint for valgrind stack size
5106226991 exhaustive_tests: Fix with ecmult_gen table with custom generator
e1a76530db refactor: Make generator a parameter of ecmult_gen_create_prec_table
9ad09f6911 refactor: Rename program that generates static ecmult_gen table
8ae18f1ab3 refactor: Rename file that contains static ecmult_gen table
00d2fa116e ecmult_gen: Make code consistent with comment
3b0c2185ea ecmult_gen: Simplify ecmult_gen context after making table static
2b7c7497ef build: replace backtick command substitution with $()
49f608de47 Merge bitcoin-core/secp256k1#1004: ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS
c0cd7de6d4 build: add -no-undefined to libtool LDFLAGS
fe32a79d35 build: pass win32-dll to LT_INIT
60bf8890df ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS
fecf436d53 Merge bitcoin-core/secp256k1#1019: build: don't append valgrind CPPFLAGS if not installed (macOS)
2e5e4b67df Merge bitcoin-core/secp256k1#1020: doc: remove use of <0xa0> "no break space"
812ff5c747 doc: remove use of 0xa0 "no break space"
214042a170 build: don't append valgrind CPPFLAGS if not installed
e43ba02cfc refactor: Decouple table generation and ecmult_gen context
22dc2c0a0d ecmult_gen: Move table creation to new file and force static prec
793ad9016a Merge bitcoin-core/secp256k1#1010: doc: Minor fixes in safegcd_implementation.md
dc9b6853b7 doc: Minor fixes in safegcd_implementation.md
ea5e8a9c47 Merge bitcoin-core/secp256k1#1012: Fix typos
233297579d Fix typos
7006f1b97f Merge bitcoin-core/secp256k1#1011: ci: Enable -g if we set CFLAGS manually
72de1359e9 ci: Enable -g if we set CFLAGS manually
74c34e727b Merge bitcoin-core/secp256k1#1009: refactor: Use (int)&(int) in boolean context to avoid compiler warning
16d132215c refactor: Use (int)&(int) in boolean context to avoid compiler warning
c74a7b7e51 Merge bitcoin-core/secp256k1#1007: doc: Replace apoelstra's GPG key by jonasnick's GPG key
3b157c48ed doc: Suggest keys.openpgp.org as keyserver in SECURITY.md
73a7472cd0 doc: Replace apoelstra's GPG key by jonasnick's GPG key
515a5dbd02 Merge bitcoin-core/secp256k1#991: Merge all "external" benchmarks into a single bench binary
af6abcb3d0 Make bench support selecting which benchmarks to run
9f56bdf5b9 Merge bench_schnorrsig into bench
3208557ae1 Merge bench_recover into bench
855e18d8a8 Merge bench_ecdh into bench
2a7be678a6 Combine bench_sign and bench_verify into single bench
8fa41201bd Merge bitcoin-core/secp256k1#1002: Make aux_rnd32==NULL behave identical to 0x0000..00.
5324f8942d Make aux_rnd32==NULL behave identical to 0x0000..00.
21c188b3c5 Merge bitcoin-core/secp256k1#943: VERIFY_CHECK precondition for secp256k1_fe_set_int.
3e7b2ea194 Merge bitcoin-core/secp256k1#999: bench_ecmult: improve clarity of output
23e2f66726 bench: don't return 1 in have_flag() if argc = 1
96b1ad2ea9 bench_ecmult: improve clarity of output
20d791edfb Merge bitcoin-core/secp256k1#989: Shared benchmark format for command line and CSV outputs
aa1b889b61 Merge bitcoin-core/secp256k1#996: Fix G.y parity in sage code
044d956305 Fix G.y parity in sage code
b4b130678d create csv file from the benchmark output
26a255beb6 Shared benchmark format for command line and CSV outputs
9526874d14 Merge bitcoin-core/secp256k1#810: Avoid overly-wide multiplications in 5x52 field mul/sqr
920a0e5fa6 Merge bitcoin-core/secp256k1#952: Avoid computing out-of-bounds pointer.
f34b5cae03 Merge bitcoin-core/secp256k1#983: [RFC] Remove OpenSSL testing support
297ce82091 Merge bitcoin-core/secp256k1#966: Make aux_rand32 arg to secp256k1_schnorrsig_sign const
2888640132 VERIFY_CHECK precondition for secp256k1_fe_set_int.
d49011f54c Make _set_fe_int( . , 0 ) set magnitude to 0
bc08599e77 Remove OpenSSL testing support
10f9bd84f4 Merge bitcoin-core/secp256k1#987: Fix unused parameter warnings when building without VERIFY
189f6bcfef Fix unused parameter warnings when building without VERIFY
da0092bccc Merge bitcoin-core/secp256k1#986: tests: remove `secp256k1_fe_verify` from tests.c and modify `_fe_from_storage` to call `_fe_verify`
d43993724d tests: remove `secp256k1_fe_verify` from tests.c and modify `secp256k1_fe_from_storage` to call `secp256k1_fe_verify`
2a3a97c665 Merge bitcoin-core/secp256k1#976: `secp256k1_schnorrsig_sign_internal` should be static
aa5d34a8fe Merge bitcoin-core/secp256k1#783: Make the public API docs more consistent and explicit
72713872a8 Add missing static to secp256k1_schnorrsig_sign_internal
db4667d5e0 Make aux_rand32 arg to secp256k1_schnorrsig_sign const
9a5a87e0f1 Merge bitcoin-core/secp256k1#956: Replace ecmult_context with a generated static array.
20abd52c2e Add tests for pre_g tables.
6815761cf5 Remove ecmult_context.
f20dcbbad1 Correct typo.
16a3cc07e8 Generate ecmult_static_pre_g.h
8de2d86a06 Bump memory limits in advance of making the ecmult context static.
d7ec49a689 Merge bitcoin-core/secp256k1#969: ci: Fixes after Debian release
5d5c74a057 tests: Rewrite code to circument potential bug in clang
3d2f492ceb ci: Install libasan6 (instead of 5) after Debian upgrade
be8d9c262f Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM
aeece44599 gen_context: Don't use any ASM
7688a4f13a Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups
90e83449b2 ci: Add C++ test
adec5a1638 Add missing null check for ctx and input keys in the public API
f4edfc7581 Improve consistency for NULL arguments in the public interface
f698caaff6 Use unsigned char consistently for byte arrays
b5b8e7b719 Don't declare constants twice
769528f307 Don't use string literals for char arrays without NUL termination
2cc3cfa583 Fix -Wmissing-braces warning in clang
0440945fb5 Merge #844: schnorrsig API overhaul
ec3aaa5014 Merge #960: tests_exhaustive: check the result of secp256k1_ecdsa_sign
a1ee83c654 tests_exhaustive: check the result of secp256k1_ecdsa_sign
253f90cdeb Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG
446d28d9de Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS
0302138f75 ci: Make compiler warning into errors on CI
b924e1e605 build: Ensure that configure's compile checks default to -O2
7939cd571c build: List *CPPFLAGS before *CFLAGS like on the compiler command line
595e8a35d8 build: Enable -Wcast-align=strict warning
07256267ff build: Use own variable SECP_CFLAGS instead of touching user CFLAGS
4866178dfc Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests
75ce488c2a Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse
41ed13942b tests: really test the non-var scalar inverse
5f6ceafcfa schnorrsig: allow setting MSGLEN != 32 in benchmark
fdd06b7967 schnorrsig: add tests for sign_custom and varlen msg verification
d8d806aaf3 schnorrsig: add extra parameter struct for sign_custom
a0c3fc177f schnorrsig: allow signing and verification of variable length msgs
5a8e4991ad Add secp256k1_tagged_sha256 as defined in BIP-340
b6c0b72fb0 schnorrsig: remove noncefp args from sign; add sign_custom function
bdf19f105c Add random field multiply/square tests
9be7b0f083 Avoid computing out-of-bounds pointer.
8ae56e33e7 Merge #879: Avoid passing out-of-bound pointers to 0-size memcpy
a4642fa15e configure: replace AC_PATH_PROG to AC_CHECK_PROG
1758a92ffd Merge #950: ci: Add ppc64le build
c58c4ea470 ci: Add ppc64le build
7973576f6e Merge #662: Add ecmult_gen, ecmult_const and ecmult to benchmark
8f879c2887 Fix array size in bench_ecmult
2fe1b50df1 Add ecmult_gen, ecmult_const and ecmult to benchmark
593e6bad9c Clean up ecmult_bench to make space for more benchmarks
50f3367712 Merge #947: ci: Run PRs on merge result even for i686
a35fdd3478 ci: Run PRs on merge result even for i686
442cee5baf schnorrsig: add algolen argument to nonce_function_hardened
df3bfa12c3 schnorrsig: clarify result of calling nonce_function_bip340 without data
99e8614812 README: mention schnorrsig module
3dc8c072b6 Merge #846: ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs
02dcea1ad9 ci: Make test iterations configurable and tweak for sanitizer builds
489ff5c20a tests: Treat empty SECP2561_TEST_ITERS as if it was unset
fcfcb97e74 ci: Simplify to use generic wrapper for QEMU, Valgrind, etc
de4157f13a ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs
399722a63a Merge #941: Clean up git tree
09b3bb8648 Clean up git tree
bf0ac46066 Merge #930: Add ARM32/ARM64 CI
202a030f7d Merge #850: add `secp256k1_ec_pubkey_cmp` method
1e78c18d5b Merge bitcoin-core/secp256k1#940: contrib: Explain explicit header guards
69394879b6 Merge #926: secp256k1.h: clarify that by default arguments must be != NULL
6eceec6d56 add `secp256k1_xonly_pubkey_cmp` method
0d9561ae87 add `secp256k1_ec_pubkey_cmp` method
22a9ea154a contrib: Explain explicit header guards
6c52ae8724 Merge #937: Have ge_set_gej_var, gej_double_var and ge_set_all_gej_var initialize all fields of their outputs.
185a6af227 Merge #925: changed include statements without prefix 'include/'
14c9739a1f tests: Improve secp256k1_ge_set_all_gej_var for some infinity inputs
4a19668c37 tests: Test secp256k1_ge_set_all_gej_var for all infinity inputs
3c90bdda95 change local lib headers to be relative for those pointing at "include/" dir
45b6468d7e Have secp256k1_ge_set_all_gej_var initialize all fields. Previous behaviour would not initialize r->y values in the case where infinity is passed in. Furthermore, the previous behaviour wouldn't initialize anything in the case where all inputs were infinity.
31c0f6de41 Have secp256k1_gej_double_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in.
dd6c3de322 Have secp256k1_ge_set_gej_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in.
d0bd2693e3 Merge bitcoin-core/secp256k1#936: Fix gen_context/ASM build on ARM
8bbad7a18e Add asm build to ARM32 CI
7d65ed5214 Add ARM32/ARM64 CI
c8483520c9 Makefile.am: Don't pass a variable twice
2161f31785 Makefile.am: Honor config when building gen_context
99f47c20ec gen_context: Don't use external ASM because it complicates the build
98e0358d29 Merge #933: Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers
99e2d5be0d Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers.
34388af6b6 Merge #922: Add mingw32-w64/wine CI build
7012a188e6 Merge #928: Define SECP256K1_BUILD in secp256k1.c directly.
ed5a199bed tests: fopen /dev/urandom in binary mode
ae9e648526 Define SECP256K1_BUILD in secp256k1.c directly.
4dc37bf81b Add mingw32-w64/wine CI build
0881633dfd secp256k1.h: clarify that by default arguments must be != NULL
efad3506a8 Merge #906: Use modified divsteps with initial delta=1/2 for constant-time
cc2c09e3a7 Merge #918: Clean up configuration in gen_context
07067967ee add ECMULT_GEN_PREC_BITS to basic_config.h
a3aa2628c7 gen_context: Don't include basic-config.h
be0609fd54 Add unit tests for edge cases with delta=1/2 variant of divsteps
cd393ce228 Optimization: only do 59 hddivsteps per iteration instead of 62
277b224b6a Use modified divsteps with initial delta=1/2 for constant-time
376ca366db Fix typo in explanation
1e5d50fa93 Merge #889: fix uninitialized read in tests
c083cc6e52 Merge #903: Make argument of fe_normalizes_to_zero{_var} const
6e898534ff Merge #907: changed import to use brackets <> for openssl
4504472269 changed import to use brackets <> for openssl as they are not local to the project
26de4dfeb1 Merge #831: Safegcd inverses, drop Jacobi symbols, remove libgmp
23c3fb629b Make argument of fe_normalizes_to_zero{_var} const
24ad04fc06 Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS
ebc1af700f Optimization: track f,g limb count and pass to new variable-time update_fg_var
b306935ac1 Optimization: use formulas instead of lookup tables for cancelling g bits
9164a1b658 Optimization: special-case zero modulus limbs in modinv64
1f233b3fa0 Remove num/gmp support
20448b8d09 Remove unused Jacobi symbol support
5437e7bdfb Remove unused scalar_sqr
aa9cc52180 Improve field/scalar inverse tests
1e0e885c8a Make field/scalar code use the new modinv modules for inverses
436281afdc Move secp256k1_fe_inverse{_var} to per-impl files
aa404d53be Move secp256k1_scalar_{inverse{_var},is_even} to per-impl files
08d54964e5 Improve bounds checks in modinv modules
151aac00d3 Add tests for modinv modules
d8a92fcc4c Add extensive comments on the safegcd algorithm and implementation
8e415acba2 Add safegcd based modular inverse modules
de0a643c3d Add secp256k1_ctz{32,64}_var functions
4c3ba88c3a Merge #901: ci: Switch all Linux builds to Debian and more improvements
9361f360bb ci: Select number of parallel make jobs depending on CI environment
28eccdf806 ci: Split output of logs into multiple sections
c7f754fe4d ci: Run PRs on merge result instead of on the source branch
b994a8be3c ci: Print information about binaries using "file"
f24e122d13 ci: Switch all Linux builds to Debian
ebdba03cb5 Merge #891: build: Add workaround for automake 1.13 and older
3a8b47bc6d Merge #894: ctime_test: move context randomization test to the end
7d3497cdc4 ctime_test: move context randomization test to the end
99a1cfec17 print warnings for conditional-uninitialized
3d2cf6c5bd initialize variable in tests
f329bba244 build: Add workaround for automake 1.13 and older
24d1656c32 Merge #882: Use bit ops instead of int mult for constant-time logic in gej_add_ge
e491d06b98 Use bit ops instead of int mult for constant-time logic in gej_add_ge
f8c0b57e6b Merge #864: Add support for Cirrus CI
cc2a5451dc ci: Refactor Nix shell files
2480e55c8f ci: Remove support for Travis CI
2b359f1c1d ci: Enable simple cache for brewing valgrind on macOS
8c02e465c5 ci: Add support for Cirrus CI
659d0d4798 Merge #880: Add parens around ROUND_TO_ALIGN's parameter.
b6f649889a Add parens around ROUND_TO_ALIGN's parameter. This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.
a4abaab793 Merge #877: Add missing secp256k1_ge_set_gej_var decl.
5671e5f3fd Merge #874: Remove underscores from header defs.
db726782fa Merge #878: Remove unused secp256k1_fe_inv_all_var
b732701faa Merge #875: Avoid casting (void**) values.
9570f674cc Avoid passing out-of-bound pointers to 0-size memcpy
75d2ae149e Remove unused secp256k1_fe_inv_all_var
482e4a9cfc Add missing secp256k1_ge_set_gej_var decl.
2730618604 Avoid casting (void**) values. Replaced with an expression that only casts (void*) values.
fb390c5299 Remove underscores from header defs. This makes them consistent with other files and avoids reserved identifiers.
f2d9aeae6d Merge #862: Autoconf improvements
328aaef22a Merge #845: Extract the secret key from a keypair
3c15130709 Improve CC_FOR_BUILD detection
47802a4762 Restructure and tidy configure.ac
252c19dfc6 Ask brew for valgrind include path
8c727b9087 Merge #860: fixed trivial typo
b7bc3a4aaa fixed typo
33cb3c2b1f Add secret key extraction from keypair to constant time tests
36d9dc1e8e Add seckey extraction from keypair to the extrakeys tests
fc96aa73f5 Add a function to extract the secretkey from a keypair
98dac87839 Merge #858: Fix insecure links
07aa4c70ff Fix insecure links
b61f9da54e Merge #857: docs: fix simple typo, dependecy -> dependency
18aadf9d28 docs: fix simple typo, dependecy -> dependency
2d9e7175c6 Merge #852: Add sage script for generating scalar_split_lambda constants
dc6e5c3a5c Merge #854: Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
6e85d675aa Rename tweak to tweak32 in public API
f587f04e35 Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
329a2e0a3f sage: Add script for generating scalar_split_lambda constants
8f0c6f1545 Merge #851: make test count iteration configurable by environment variable
f4fa8d226a forbid a test iteration of 0 or less
f554dfc708 sage: Reorganize files
3a106966aa Merge #849: Convert Sage code to Python 3 (as used by Sage >= 9)
13c88efed0 Convert Sage code to Python 3 (as used by Sage >= 9)
0ce4554881 make test count iteration configurable by environment variable
9e5939d284 Merge #835: Don't use reserved identifiers memczero and benchmark_verify_t
d0a83f7328 Merge #839: Prevent arithmetic on NULL pointer if the scratch space is too small
903b16aa6c Merge #840: Return NULL early in context_preallocated_create if flags invalid
1f4dd03838 Typedef (u)int128_t only when they're not provided by the compiler
3967d96bf1 Merge #838: Make autotools check for all the used openssl functions
3734b68200 Configure echo if openssl tests are enabled
ebfa2058e9 Return NULL early in context_preallocated_create if flags invalid
6f54e69f03 Merge #841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_
29a299e373 Run the undefined behaviour sanitizer on Travis
7506e064d7 Prevent arithmetic on NULL pointer if the scratch space is too small
8893f42438 Avoids a potentially shortening size_t to int cast in strauss_wnaf_
e6692778d3 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing
ac05f61fcf Merge #809: Stop treating ECDH as experimental
e6e3d5da2f travis: add schnorrsig to valgrind and big endian platform test
353dff156f Stop treating ECDH as experimental
e89278f211 Don't use reserved identifiers memczero and benchmark_verify_t
c6b6b8f1bb Merge #830: Rip out non-endomorphism code + dependencies
c582abade1 Consistency improvements to the comments
63c6b71616 Reorder comments/function around scalar_split_lambda
2edc514c90 WNAF of lambda_split output has max size 129
4232e5b7da Rip out non-endomorphism code
ebad8414b0 Check correctness of lambda split without -DVERIFY
fe7fc1fda8 Make lambda constant accessible
9d2f2b44d8 Add tests to exercise lambda split near bounds
9aca2f7f07 Add secp256k1_split_lambda_verify
acab934d24 Detailed comments for secp256k1_scalar_split_lambda
76ed922a5f Increase precision of g1 and g2
6173839c90 Switch to our own memcmp function
63150ab4da Merge #827: Rename testrand functions to have test in name
c5257aed0b Merge #821: travis: Explicitly set --with-valgrind
bb1f54280f Merge #818: Add static assertion that uint32_t is unsigned int or wider
a45c1fa63c Rename testrand functions to have test in name
5006895bd6 Merge #808: Exhaustive test improvements + exhaustive schnorrsig tests
4eecb4d6ef travis: VALGRIND->RUN_VALGRIND to avoid confusion with WITH_VALGRIND
66a765c775 travis: Explicitly set --with-valgrind
d7838ba6a6 Merge #813: Enable configuring Valgrind support
7ceb0b7611 Merge #819: Enable -Wundef warning
8b7dcdd955 Add exhaustive test for extrakeys and schnorrsig
08d7d89299 Make pubkey parsing test whether points are in the correct subgroup
87af00b511 Abstract out challenge computation in schnorrsig
63e1b2aa7d Disable output buffering in tests_exhaustive.c
39f67dd072 Support splitting exhaustive tests across cores
e99b26fcd5 Give exhaustive_tests count and seed cmdline inputs
49e6630bca refactor: move RNG seeding to testrand
b110c106fa Change exhaustive test groups so they have a point with X=1
cec7b18a34 Select exhaustive lambda in function of order
78f6cdfaae Make the curve B constant a secp256k1_fe
d7f39ae4b6 Delete gej_is_valid_var: unused outside tests
8bcd78cd79 Make secp256k1_scalar_b32 detect overflow in scalar_low
c498366e5b Move exhaustive tests for recovery to module
be31791543 Make group order purely compile-time in exhaustive tests
e73ff30922 Enable -Wundef warning
c0041b5cfc Add static assertion that uint32_t is unsigned int or wider
4ad408faf3 Merge #782: Check if variable=yes instead of if var is set in travis.sh
412bf874d0 configure: Allow specifying --with[out]-valgrind explicitly
34debf7a6d Modify .travis.yml to explictly pass no in env vars instead of setting to nothing
a0e99fc121 Merge #814: tests: Initialize random group elements fully
5738e8622d tests: Initialize random group elements fully
c9939ba55d Merge #812: travis: run bench_schnorrsig
a51f2af62b travis: run bench_schnorrsig
8ab24e8dad Merge #558: Add schnorrsig module which implements BIP-340 compliant signatures
f3733c5433 Merge #797: Fix Jacobi benchmarks and other benchmark improvements
b53e0cd61f Avoid overly-wide multiplications
cb5524adc5 Add benchmark for secp256k1_ge_set_gej_var
5c6af60ec5 Make jacobi benchmarks vary inputs
d0fdd5f009 Randomize the Z coordinates in bench_internal
c7a3424c5f Rename bench_internal variables
875d68b95f Merge #699: Initialize field elements when resulting in infinity
54caf2e74f Merge #799: Add fallback LE/BE for architectures with known endianness + SHA256 selftest
f431b3f28a valgrind_ctime_test: Add schnorrsig_sign
16ffa9d97c schnorrsig: Add taproot test case
8dfd53ee3f schnorrsig: Add benchmark for sign and verify
4e43520026 schnorrsig: Add BIP-340 compatible signing and verification
7332d2db6b schnorrsig: Add BIP-340 nonce function
7a703fd97d schnorrsig: Init empty experimental module
eabd9bc46a Allow initializing tagged sha256
6fcb5b845d extrakeys: Add keypair_xonly_tweak_add
58254463f9 extrakeys: Add keypair struct with create, pub and pub_xonly
f0010349b8 Separate helper functions for pubkey_create and seckey_tweak_add
910d9c284c extrakeys: Add xonly_pubkey_tweak_add & xonly_pubkey_tweak_add_test
176bfb1110 Separate helper function for ec_pubkey_tweak_add
4cd2ee474d extrakeys: Add xonly_pubkey with serialize, parse and from_pubkey
f49c9896b0 Merge #806: Trivial: Add test logs to gitignore
aabf00c155 Merge #648: Prevent ints from wrapping around in scratch space functions
f5adab16a9 Merge #805: Remove the extremely outdated TODO file.
bceefd6547 Add test logs to gitignore
1c325199d5 Remove the extremely outdated TODO file.
47e6618e11 extrakeys: Init empty experimental module
3e08b02e2a Make the secp256k1_declassify argument constant
8bc6aeffa9 Add SHA256 selftest
670cdd3f8b Merge #798: Check assumptions on integer implementation at compile time
5e5fb28b4a Use additional system macros to figure out endianness
7c068998ba Compile-time check assumptions on integer types
02b6c87b52 Add support for (signed) __int128
979961c506 Merge #787: Use preprocessor macros instead of autoconf to detect endianness
887bd1f8b6 Merge #793: Make scalar/field choice depend on C-detected __int128 availability
0dccf98a21 Use preprocessor macros instead of autoconf to detect endianness
b2c8c42cf1 Merge #795: Avoid linking libcrypto in the valgrind ct test.
57d3a3c64c Avoid linking libcrypto in the valgrind ct test.
79f1f7a4f1 Autodetect __int128 availability on the C side
0d7727f95e Add SECP256K1_FE_STORAGE_CONST_GET to 5x52 field
805082de11 Merge #696: Run a Travis test on s390x (big endian)
39295362cf Test travis s390x (big endian)
ef37761fee Change travis.sh to check if variables are equal to yes instead of not-empty. Before this, setting `VALGRIND=wat` was considered as true, and to make it evaluate as false you had to unset the variable `VALGRIND=` but not it checks if `VALGRIND=yes` and if it's not `yes` then it's evaluated to false
6034a04fb1 Merge #778: secp256k1_gej_double_nonzero supports infinity
f60915906d Merge #779: travis: Fix argument quoting for ./configure
9e49a9b255 travis: Fix argument quoting for ./configure
18d36327fd secp256k1_gej_double_nonzero supports infinity
214cb3c321 Merge #772: Improve constant-timeness on PowerPC
40412b1930 Merge #774: tests: Abort if malloc() fails during context cloning tests
2e1b9e0458 tests: Abort if malloc() fails during context cloning tests
67a429f31f Suppress a harmless variable-time optimization by clang in _int_cmov
5b196338f0 Remove redundant "? 1 : 0" after comparisons in scalar code
3e5cfc5c73 Merge #741: Remove unnecessary sign variable from wnaf_const
66bb9320c0 Merge #773: Fix some compile problems on weird/old compilers.
1309c03c45 Fix some compile problems on weird/old compilers.
2309c7dd4a Merge #769: Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
22e578bb11 Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
3f4a5a10e4 Merge #765: remove dead store in ecdsa_signature_parse_der_lax
f00d6575ca remove dead store in ecdsa_signature_parse_der_lax
dbd41db16a Merge #759: Fix uninitialized variables in ecmult_multi test
2e7fc5b537 Fix uninitialized variables in ecmult_multi test
2ed54da18a Merge #755: Recovery signing: add to constant time test, and eliminate non ct operators
28609507e7 Add tests for the cmov implementations
73596a85a2 Add ecdsa_sign_recoverable to the ctime tests
2876af4f8d Split ecdsa_sign logic into a new function and use it from ecdsa_sign and recovery
5e1c885efb Merge #754: Fix uninit values passed into cmov
f79a7adcf5 Add valgrind uninit check to cmovs output
05d315affe Merge #752: autoconf: Use ":" instead of "dnl" as a noop
a39c2b09de Fixed UB(arithmetics on uninit values) in cmovs
3a6fd7f636 Merge #750: Add macOS to the CI
5e8747ae2a autoconf: Use ":" instead of "dnl" as a noop
71757da5cc Explictly pass SECP256K1_BENCH_ITERS to the benchmarks in travis.sh
99bd661d71 Replace travis_wait with a loop printing "\a" to stdout every minute
bc818b160c Bump travis Ubuntu from xenial(16.04) to bionic(18.04)
0c5ff9066e Add macOS support to travis
b6807d91d8 Move travis script into a standalone sh file
f39f99be0e Merge #701: Make ec_ arithmetic more consistent and add documentation
37dba329c6 Remove unnecessary sign variable from wnaf_const
6bb0b77e15 Fix test_constant_wnaf for -1 and add a test for it.
39198a03ea Merge #732: Retry if r is zero during signing
59a8de8f64 Merge #742: Fix typo in ecmult_const_impl.h
4e284655d9 Fix typo in ecmult_const_impl.h
f862b4ca13 Merge #740: Make recovery/main_impl.h non-executable
ffef45c98a Make recovery/main_impl.h non-executable
2361b3719a Merge #735: build: fix OpenSSL EC detection on macOS
3b7d26b23c build: add SECP_TEST_INCLUDES to bench_verify CPPFLAGS
84b5fc5bc3 build: fix OpenSSL EC detection on macOS
37ed51a7ea Make ecdsa_sig_sign constant-time again after reverting 25e3cfb
93d343bfc5 Revert "ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign"
7e3952ae82 Clarify documentation of tweak functions.
89853a0f2e Make tweak function documentation more consistent.
41fc785602 Make ec_privkey functions aliases for ec_seckey_negate, ec_seckey_tweak_add and ec_seckey_mul
22911ee6da Rename private key to secret key in public API (with the exception of function names)
5a73f14d6c Mention that value is unspecified for In/Out parameters if the function returns 0
f03df0e6d7 Define valid ECDSA keys in the documentation of seckey_verify
5894e1f1df Return 0 if the given seckey is invalid in privkey_negate, privkey_tweak_add and privkey_tweak_mul
8f814cddb9 Add test for boundary conditions of scalar_set_b32 with respect to overflows
3fec982608 Use scalar_set_b32_seckey in ecdsa_sign, pubkey_create and seckey_verify
9ab2cbe0eb Add scalar_set_b32_seckey which does the same as scalar_set_b32 and also returns whether it's a valid secret key
4f27e344c6 Merge #728: Suppress a harmless variable-time optimization by clang in memczero
01993878bb Add test for memczero()
52a03512c1 Suppress a harmless variable-time optimization by clang in memczero
8f78e208ad Merge #722: Context isn't freed in the ECDH benchmark
ed1b91171a Merge #700: Allow overriding default flags
85b35afa76 Add running benchmarks regularly and under valgrind in travis
ca4906b02e Pass num of iters to benchmarks as variable, and define envvar
02dd5f1bbb free the ctx at the end of bench_ecdh
e9fccd4de1 Merge #708: Constant-time behaviour test using valgrind memtest.
08fb6c4926 Run valgrind_ctime_test in travis
3d2302257f Constant-time behaviour test using valgrind memtest.
96d8ccbd16 Merge #710: Eliminate harmless non-constant time operations on secret data.
0585b8b2ee Merge #718: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1
7b50483ad7 Adds a declassify operation to aid constant-time analysis.
34a67c773b Eliminate harmless non-constant time operations on secret data.
ca739cba23 Compile with optimization flag -O2 by default instead of -O3
eb45ef3384 Clarify that a secp256k1_ecdh_hash_function must return 0 or 1
856a01d6ad Merge #714: doc: document the length requirements of output parameter.
d72b9e2483 Merge #682: Remove Java Native Interface
4b48a43106 doc: document the length requirements of output parameter.
1b4d256e2e Merge #713: Docstrings
dabfea7e21 field: extend docstring of secp256k1_fe_normalize
dc7d8fd9e2 scalar: extend docstring of secp256k1_scalar_set_b32
074ab582dd Merge #704: README: add a section for test coverage
acb7f97eb8 README: add a section for test coverage
227a4f2d07 Merge #709: Remove secret-dependant non-constant time operation in ecmult_const.
d567b779fe Clarify comments about use of rzr on ge functions and abs function.
2241ae6d14 Remove secret-dependant non-constant time operation in ecmult_const.
642cd062bd Remove Java Native Interface
83fb1bcef4 Remove -O2 from default CFLAGS because this would override the -O3 flag (see AC_PROG_CC in the Autoconf manual)
ecba8138ec Append instead of Prepend user-CFLAGS to default CFLAGS allowing the user to override default variables
613c34cd86 Remove test in configure.ac because it doesn't have an effect
f45d897101 Merge #703: Overhaul README.md
2e759ec753 Overhaul README.md
d644dda5c9 Merge #689: Remove "except in benchmarks" exception for fp math
bde2a32286 Convert bench.h to fixed-point math
47a7b8382f Clear field elements when writing infinity
61d1ecb028 Added test with additions resulting in infinity
387d723c3f Merge #679: Add SECURITY.md
0db61d25c9 Merge #685: Fix issue where travis does not show the ./tests seed…
a0771d15e6 Explicitly disable buffering for stderr in tests
fb424fbba2 Make travis show the ./tests seed by removing stdout buffering and always cat tests.log after a travis run.
22a6031184 Merge #690: Add valgrind check to travis
544002c008 Merge #678: Preventing compiler optimizations in benchmarks without a memory fence
dd98cc988f travis: Added a valgrind test without endro and enabled recovery+ecdh
b4c1382a87 Add valgrind check to travis
0c774d89e6 Merge #688: Fix ASM setting in travis
5c5f71eea5 Fix ASM setting in travis
e2625f8a98 Merge #684: Make no-float policy explicit
bae1bea3c4 Make no-float policy explicit
78c3836341 Add SECURITY.md
362bb25608 Modified bench_scalar_split so it won't get optimized out
73a30c6b58 Added accumulators and checks on benchmarks so they won't get optimized out
770b3dcd6f Merge #677: Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var
b76142ff25 Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var which was removed in 47045270fa90f81205d989f7107769bce1e71c4d
137d304a6b Merge #647: Increase robustness against UB in secp256k1_scalar_cadd_bit
0d9540b13f Merge #664: Remove mention of ec_privkey_export because it doesn't exist
59782c68b4 Remove mention of ec_privkey_export because it doesn't exist
96cd94e385 Merge #337: variable sized precomputed table for signing
dcb2e3b3ff variable signing precompute table
b4bff99028 Merge #661: Make ./configure string consistent
a467047e11 Make ./configure string consistent
e729cc7f5a Merge #657: Fix a nit in the recovery tests
b64a2e2597 Fix a nit in the recovery tests
e028aa33d3 Merge #650: secp256k1/src/tests.c: Properly handle sscanf return value
f1e11d363d Merge #654: Fix typo (∞)
ef83281c3a Merge pull request #656 from real-or-random/patch-1
556caad2ca Fix typo in docs for _context_set_illegal_callback
0d82732a9a Improve VERIFY_CHECK of overflow in secp256k1_scalar_cadd_bit. This added check ensures that any curve order overflow doesn't go undetected due a uint32_t overflow.
786dfb49f5 Merge #583: JNI: fix use sig array
e95f8ab098 Merge #644: Avoid optimizing out a verify_check
384f55606a Merge #652: README.md: update instruction to run tests
ee56accd47 Merge #651: Fix typo in secp256k1_preallocated.h
7b9b117230 Merge #640: scalar_impl.h: fix includes
d99bec2e21 Merge #655: jni: Use only Guava for hex encoding and decoding
2abcf951af jni: Use only Guava for hex encoding and decoding
271582b3b7 Fix typo
60f7f2de5d Don't assume that ALIGNMENT > 1 in tests
ada6361dec Use ROUND_TO_ALIGN in scratch_create
8ecc6ce50e Add check preventing rounding to alignment from wrapping around in scratch_alloc
4edaf06fb0 Add check preventing integer multiplication wrapping around in scratch_max_allocation
ce6d438266 README.md: update instruction to run tests
b1e68cb8e6 Fix typo in secp256k1_preallocated.h
a11c76c59a secp256k1/src/tests.c: Properly handle sscanf return value
8fe63e5654 Increase robustness against UB. Thanks to elichai2 who noted that the literal '1' is a signed integer, and that shifting a signed 32-bit integer by 31 bits causes an overflow and yields undefined behaviour. While 'scalar_low_impl''s 'secp256k1_scalar_cadd_bit' is only used for testing purposes and currently the 'bit' parameter is only 0 or 1, it is better to avoid undefined behaviour in case the used domain of 'secp256k1_scalar_cadd_bit' expands.
94ae7cbf83 Moved a dereference so the null check will be before the dereferencing
2cb73b1064 scalar_impl.h: fix includes
fa33017135 Merge #634: Add a descriptive comment for secp256k1_ecmult_const.
ee9e68cd30 Add a descriptive comment for secp256k1_ecmult_const.
d0d738d32d Merge #631: typo in comment for secp256k1_ec_pubkey_tweak_mul ()
6914c25276 typo in comment for secp256k1_ec_pubkey_tweak_mul ()
e541a90ef6 Merge #629: Avoid calling _is_zero when _set_b32 fails.
f34b0c3f35 Merge #630: Note intention of timing sidechannel freeness.
8d1563b0ff Note intention of timing sidechannel freeness.
1669bb2865 Merge #628: Fix ability to compile tests without -DVERIFY.
ecc94abcc8 Merge #627: Guard memcmp in tests against mixed size inputs.
544435fc90 Merge #578: Avoid implementation-defined and undefined behavior when dealing with sizes
143dc6e9ee Merge #595: Allow to use external default callbacks
e49f7991c2 Add missing #(un)defines to base-config.h
77defd2c3b Add secp256k1_ prefix to default callback functions
908bdce64e Include stdio.h and stdlib.h explicitly in secp256k1.c
5db782e655 Allow usage of external default callbacks
6095a863fa Replace CHECKs for no_precomp ctx by ARG_CHECKs without a return
cd473e02c3 Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails.
6c36de7a33 Merge #600: scratch space: use single allocation
98836b11f0 scratch: replace frames with "checkpoint" system
7623cf2b97 scratch: save a couple bytes of unnecessarily-allocated memory
a7a164f2c6 scratch: rename `max_size` to `size`, document that extra will actually be allocated
5a4bc0bb95 scratch: unify allocations
c2b028a281 scratch space: thread `error_callback` into all scratch space functions
0be1a4ae62 scratch: add magic bytes to beginning of structure
92a48a764d scratch space: use single allocation
40839e21b9 Merge #592: Use trivial algorithm in ecmult_multi if scratch space is small
dcf392027b Fix ability to compile tests without -DVERIFY.
a484e0008b Merge #566: Enable context creation in preallocated memory
0522caac8f Explain caller's obligations for preallocated memory
238305fdbb Move _preallocated functions to separate header
695feb6fbd Export _preallocated functions
814cc78d71 Add tests for contexts in preallocated memory
ba12dd08da Check arguments of _preallocated functions
5feadde462 Support cloning a context into preallocated memory
c4fd5dab45 Switch to a single malloc call
ef020de16f Add size constants for preallocated memory
1bf7c056ba Prepare for manual memory management in preallocated memory
248bffb052 Guard memcmp in tests against mixed size inputs.
36698dcfee Merge #596: Make WINDOW_G configurable
a61a93ff50 Clean up ./configure help strings
2842dc523e Make WINDOW_G configurable
1a02d6ce51 Merge #626: Revert "Merge #620: Install headers automatically"
662918cb29 Revert "Merge #620: Install headers automatically"
14c7dbd444 Simplify control flow in DER parsing
ec8f20babd Avoid out-of-bound pointers and integer overflows in size comparisons
01ee1b3b3c Parse DER-enconded length into a size_t instead of an int
912680ed86 Merge #561: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
91fae3ace0 Merge #620: Install headers automatically
5df77a0eda Merge #533: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...)
975e51e0d9 Merge #617: Pass scalar by reference in secp256k1_wnaf_const()
735fbde04e Merge #619: Clear a copied secret key after negation
16e86150d0 Install headers automatically
069870d92a Clear a copied secret key after negation
8979ec0d9a Pass scalar by reference in secp256k1_wnaf_const()
84a808598b Merge #612: Allow field_10x26_arm.s to compile for ARMv7 architecture
d4d270a59c Allow field_10x26_arm.s to compile for ARMv7 architecture
b19c000063 Merge #607: Use size_t shifts when computing a size_t
4d01bc2d9c Merge #606: travis: Remove unused sudo:false
e6d01e9347 Use size_t shifts when computing a size_t
7667532bd7 travis: Remove unused sudo:false
248f046611 Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...)
9ab96f7b12 Use trivial algorithm in ecmult_multi if scratch space is small
ee99f12f3d Merge #599: Switch x86_64 asm to use "i" instead of "n" for immediate values.
d58bc93f2c Switch x86_64 asm to use "i" instead of "n" for immediate values.
05362ee042 Merge #597: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
83483869ac Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
aa15154a48 Merge #568: Fix integer overflow in ecmult_multi_var when n is large
2277af5ff0 Fix integer overflow in ecmult_multi_var when n is large
dbed75d969 Undefine `STATIC_PRECOMPUTATION` if using the basic config
310111e093 Keep LDFLAGS if `--coverage`
85d0e1bcce Merge #591: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
14196379ec Merge #580: Add trivial ecmult_multi algorithm which does not require a scratch space
a697d82da9 Add trivial ecmult_multi to the benchmark tool
bade617417 Add trivial ecmult_multi algorithm. It is selected when no scratch space is given and just multiplies and adds the points.
5545e13dea Merge #584: configure: Use CFLAGS_FOR_BUILD when checking native compiler
20c5869df2 Merge #516: improvements to random seed in src/tests.c
b76e45d5d6 Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
870a977644 Merge #562: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
be40c4d0b5 Fixup for C90 mixed declarations.
c71dd2c08f Merge #509: Fix algorithm selection in bench_ecmult
6492bf88cc Merge #518: Summarize build options after running configure
0e9ada1941 Merge #567: Correct order of libs returned on pkg-config --libs --static libsecp2…
e96901a4b9 Merge #587: Make randomization of a non-signing context a noop
58df8d03ad Merge #511: Portability fix for the configure scripts generated
2ebdad772a Merge #552: Make constants static:
1c131affd3 Merge #551: secp256k1_fe_sqrt: Verify that the arguments don't alias.
ba698f883b Merge #539: Assorted minor corrections
949e85b009 Merge #550: Optimize secp256k1_fe_normalize_weak calls.
a34bcaadf1 Actually pass CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD to linker
2d5f4cebdc configure: Use CFLAGS_FOR_BUILD when checking native compiler
b408c6a8b2 Merge #579: Use __GNUC_PREREQ for detecting __builtin_expect
6198375218 Make randomization of a non-signing context a noop
74e2dbd68e JNI: fix use sig array
c663397f46 Use __GNUC_PREREQ for detecting __builtin_expect
3cb057f842 Fix possible integer overflow in DER parsing
e34ceb333b Merge #557: Eliminate scratch memory used when generating contexts
b3bf5f99a3 ecmult_impl: expand comment to explain how effective affine interacts with everything
efa783f8f0 Store z-ratios in the 'x' coord they'll recover
ffd3b346fe add `secp256k1_ge_set_all_gej_var` test which deals with many infinite points
84740acd2a ecmult_impl: save one fe_inv_var
47045270fa ecmult_impl: eliminate scratch memory used when generating context
7f7a2ed3a8 ecmult_gen_impl: eliminate scratch memory used when generating context
314a61d724 Merge #553: add static context object which has no capabilities
89a20a8945 Correct order of libs returned on pkg-config --libs --static libsecp256k1 call.
1086fda4c1 Merge #354: [ECDH API change] Support custom hash function
d3cb1f95eb Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
40fde611bd prevent attempts to modify `secp256k1_context_no_precomp`
ed7c08417a add static context object which has no capabilities
496c5b43b8 Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;
bf8b86cc07 secp256k1_fe_sqrt: Verify that the arguments don't alias.
9bd89c836b Optimize secp256k1_fe_normalize_weak calls. Move secp256k1_fe_normalize_weak calls out of ECMULT_TABLE_GET_GE and ECMULT_TABLE_GET_GE_STORAGE and into secp256k1_ge_globalz_set_table_gej instead.
52ab96fedb clean dependendies in field_*_impl.h
deff5edd42 Correct math typos in field_*.h
4efb3f8dd1 Add check that restrict pointers don't alias with all parameters.
1e6f1f5ad5 Merge #529: fix tests.c in the count == 0 case
c8fbc3c397 [ECDH API change] Allow pass arbitrary data to hash function
b00be65056 [ECDH API change] Support custom hash function
95e99f196f fix tests.c in the count == 0 case
452d8e4d2a Merge #523: scratch: add stack frame support
6fe50439ae scratch: add stack frame support
9bc2e26502 Merge #522: parameterize ecmult_const over input size
7c1b91ba4b parameterize ecmult_const over input size
dbc3ddd5e2 Merge #513: Increase sparsity of pippenger fixed window naf representation
3965027c81 Summarize build options in configure script
0f0517369c Fix algorithm selection in bench_ecmult
fb9271dcf0 Merge #510: add a couple missing `const`s to ecmult_pippenger_wnaf
cd5f6028e5 Merge #515: Fix typo
09146ae854 Merge #512: secp256k1_ec_privkey_negate - fix documentation
ec0a7b3ae3 Don't touch leading zeros in wnaf_fixed.
9e36d1bfe2 Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar.
96f68a0afc Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros.
8b3841c91d fix bug in fread() failure check
cddef0c0be tests: add warning message when /dev/urandom fails
9b7c47a21e Fix typo
6dbb007869 Increase sparsity of pippenger fixed window naf representation
1646ace4d5 secp256k1_ec_privkey_negate - fix documentation
270f6c80db Portability fix for the configure scripts generated
9b3ff0309d add a couple missing `const`s to ecmult_pippenger_wnaf
cd329dbc3e Merge #460: [build] Update ax_jni_include_dir.m4 macro
7f9c1a1565 Merge #498: tests: Avoid calling fclose(...) with an invalid argument
f99aa8d4d3 Merge #499: tests: Make sure we get the requested number of bytes from /dev/urandom
b549d3d5f7 Merge #472: [build] Set --enable-jni to no by default instead of auto.
d333521516 Merge #494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
2ef8ea5d21 Merge #495: Add bench_ecmult to .gitignore
82a96e4587 tests: Make sure we get the requested number of bytes from /dev/urandom
5aae5b5bb2 Avoid calling fclose(...) with an invalid argument
cb32940df3 Add bench_ecmult to .gitignore
31abd3ab8d Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
c95f6f1360 Merge #487: fix tests typo, s/changed/unchanged
fb46c83881 Merge #463: Reduce usage of hardcoded size constants
02f5001dfc Merge #490: Disambiguate bench functions and types
1f46d6089e Disambiguate bench functions and types
f54c6c5083 Merge #480: Enable benchmark building by default
c77fc08597 Merge #486: Add pippenger_wnaf for multi-multiplication
d2f9c6b5dc Use more precise pippenger bucket windows
4c950bbeaf Save some additions per window in _pippenger_wnaf
a58f543f5a Add flags for choosing algorithm in ecmult_multi benchmark
36b22c9337 Use scratch space dependent batching in ecmult_multi
355a38f113 Add pippenger_wnaf ecmult_multi
bc65aa794e Add bench_ecmult
dba5471b69 Add ecmult_multi tests
8c1c831bdb Generalize Strauss to support multiple points
548de42ecf add resizeable scratch space API
0e96cdc6b6 fix typo, s/changed/unchanged
c7680e570f Reduce usage of hardcoded size constants
6ad5cdb42a Merge #479: Get rid of reserved _t in type names
7a78f60598 Print whether we're building benchmarks
4afec9f1ae Build benchmarks by default
d1dc9dfc0a Get rid of reserved _t in type names
0b70241850 Merge #474: Fix header guards using reserved identifiers
ab1f89f00a Merge #478: Fixed multiple typos
8c7ea22d54 Fixed multiple typos
abe2d3e84b Fix header guards using reserved identifiers
57752d28b3 [build] Set --enable-jni to no by default instead of auto.
f532bdc9f7 Merge #459: Add pubkey prefix constants to include/secp256k1.h
cac7c5559d Merge #470: Fix wnaf_const documentation
768514bac0 Fix wnaf_const documentation with respect to return value and number of words set
b8c26a3990 Merge #458: Fix typo in API documentation
817fb2013a Merge #440: Fix typos
12230f90ed Merge #468: Remove redundant conditional expression
2e1ccdca0d Remove redundant conditional expression
e7daa9b3c2 [build] Tweak JNI macro to warn instead of error for JNI not found.
5b22977922 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS
bc61b91aca add pubkey prefix constants to include/secp256k1.h
b0452e664b Fix typo in API documentation
84973d393a Merge #454: Remove residual parts from the schnorr expirement.
5e95bf2285 Remove residual parts from the schnorr expirement.
cbc20b8c34 Merge #452: Minor optimizations to _scalar_inverse to save 4M
4cc8f52505 Merge #437: Unroll secp256k1_fe_(get|set)_b32 to make them much faster.
465159c278 Further shorten the addition chain for scalar inversion.
a2b6b1914f Fix benchmark print_number infinite loop.
8b7680a826 Unroll secp256k1_fe_(get|set)_b32 for 10x26.
aa8499080e Unroll secp256k1_fe_(get|set)_b32 for 5x52.
cf12fa13cb Minor optimizations to _scalar_inverse to save 4M
119949232a Merge #408: Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
6af0871070 Merge #441: secp256k1_context_randomize: document.
ab31a524b4 Merge #444: test: Use checked_alloc
eda5c1a062 Merge #449: Remove executable bit from secp256k1.c
51b77ae619 Remove executable bit from secp256k1.c
5eb030ca41 test: Use checked_alloc
72d952c9c4 FIXUP: Missing "is"
70ff29b6a7 secp256k1_context_randomize: document.
4c0f32ed51 Fix typo: "Agressive" → "Aggressive"
73aca8364f Fix typo: "exectured" → "executed"
9d560f992d Merge #428: Exhaustive recovery
8e48aa60dc Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
2cee5fd4c9 exhaustive tests: add recovery module
678b0e5466 exhaustive tests: remove erroneous comment from ecdsa_sig_sign
03ff8c2d0a group_impl.h: remove unused `secp256k1_ge_set_infinity` function
a724d7296d configure: add --enable-coverage to set options for coverage analysis
b595163992 recovery: add tests to cover API misusage
6f8ae2f3c0 ecdh: test NULL-checking of arguments
25e3cfbf9b ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign
git-subtree-dir: src/secp256k1
git-subtree-split: 44c2452fd387f7ca604ab42d73746e7d3a44d8a2
patricklodder
added a commit
to patricklodder/dogecoin
that referenced
this pull request
Jul 28, 2022
44c2452fd3 Merge bitcoin-core/secp256k1#1105: Don't export symbols in static libraries
6f6cab9989 abi: Don't export symbols in static Windows libraries
485f608fa9 Merge bitcoin-core/secp256k1#1104: Fix the false positive of `SECP_64BIT_ASM_CHECK`
8b013fce51 Merge bitcoin-core/secp256k1#1056: Save negations in var-time group addition
7efc9835a9 Fix the false positive of `SECP_64BIT_ASM_CHECK`
8746600eec Merge bitcoin-core/secp256k1#1093: hash: Make code agnostic of endianness
2f984ffc45 Save negations in var-time group addition
37d36927df tests: Add tests for _read_be32 and _write_be32
912b7ccc44 Merge bitcoin-core/secp256k1#1094: doc: Clarify configure flags for optional modules
55512d30b7 doc: clean up module help text in configure.ac
d9d94a9969 doc: mention optional modules in README
616b43dd3b util: Remove endianness detection
8d89b9e6e5 hash: Make code agnostic of endianness
d0ad5814a5 Merge bitcoin-core/secp256k1#995: build: stop treating schnorrsig, extrakeys modules as experimental
1ac7e31c5b Merge bitcoin-core/secp256k1#1089: Schnorrsig API improvements
587239dbe3 Merge bitcoin-core/secp256k1#731: Change SHA256 byte counter from size_t to uint64_t
f8d9174357 Add SHA256 bit counter tests
7f09d0f311 README: mention that ARM assembly is experimental
b8f8b99f0f docs: Fix return value for functions that don't have invalid inputs
f813bb0df3 schnorrsig: Adapt example to new API
99e6568fc6 schnorrsig: Rename schnorrsig_sign to schnorsig_sign32 and deprecate
fc94a2da44 Use SECP256K1_DEPRECATED for existing deprecated API functions
3db0560606 Add SECP256K1_DEPRECATED attribute for marking API parts as deprecated
80cf4eea5f build: stop treating schnorrsig, extrakeys modules as experimental
e0508ee9db Merge bitcoin-core/secp256k1#1090: configure: Remove redundant pkg-config code
21b2ebaf74 configure: Remove redundant pkg-config code
0e5cbd01b3 Merge bitcoin-core/secp256k1#1088: configure: Use modern way to set AR
0d253d52e8 configure: Use modern way to set AR
9b514ce1d2 Add test vector for very long SHA256 messages
8e3dde1137 Simplify struct initializer for SHA256 padding
eb28464a8b Change SHA256 byte counter from size_t to uint64_t
ac83be33d0 Merge bitcoin-core/secp256k1#1079: configure: Add hidden --enable-dev-mode to enable all the stuff
e0838d663d configure: Add hidden --enable-dev-mode to enable all the stuff
fabd579dfa configure: Remove redundant code that sets _enable variables
0d4226c051 configure: Use canonical variable prefix _enable consistently
64b34979ed Merge bitcoin-core/secp256k1#748: Add usage examples
7c9502cece Add a copy of the CC0 license to the examples
42e03432e6 Add usage examples to the readme
517644eab1 Optionally compile the examples in autotools, compile+run in travis
422a7cc86a Add a ecdh shared secret example
b0cfbcc143 Add a Schnorr signing and verifying example
fee7d4bf9e Add an ECDSA signing and verifying example
1253a27756 Merge bitcoin-core/secp256k1#1033: Add _fe_half and use in _gej_add_ge and _gej_double
3ef94aa5ba Merge bitcoin-core/secp256k1#1026: ecdh: Add test computing shared_secret=basepoint with random inputs
3531a43b5b ecdh: Make generator_basepoint test depend on global iteration count
c881dd49bd ecdh: Add test computing shared_secret=basepoint with random inputs
077528317d Merge bitcoin-core/secp256k1#1074: ci: Retry brew update a few times to avoid random failures
e51ad3b737 ci: Retry `brew update` a few times to avoid random failures
b1cb969e8a ci: Revert "Attempt to make macOS builds more reliable"
5dcc6f8dbd Merge bitcoin-core/secp256k1#1069: build: Replace use of deprecated autoconf macro AC_PROG_CC_C89
59547943d6 Merge bitcoin-core/secp256k1#1072: ci: Attempt to make macOS builds more reliable
85b00a1c65 Merge bitcoin-core/secp256k1#1068: sage: Fix incompatibility with sage 9.4
ebb1beea78 sage: Ensure that constraints are always fastfracs
d8d54859ed ci: Run sage prover on CI
77cfa98dbc sage: Normalize sign of polynomial factors in prover
eae75869cf sage: Exit with non-zero status in case of failures
d9396a56da ci: Attempt to make macOS builds more reliable
e0db3f8a25 build: Replace use of deprecated autoconf macro AC_PROG_CC_C89
e848c3799c Update sage files for new formulae
d64bb5d4f3 Add fe_half tests for worst-case inputs
b54d843eac sage: Fix printing of errors
4eb8b932ff Further improve doubling formula using fe_half
557b31fac3 Doubling formula using fe_half
2cbb4b1a42 Run more iterations of run_field_misc
9cc5c257ed Add test for secp256k1_fe_half
925f78d55e Add _fe_half and use in _gej_add_ge
e108d0039c sage: Fix incompatibility with sage 9.4
d8a2463246 Merge bitcoin-core/secp256k1#899: Reduce stratch space needed by ecmult_strauss_wnaf.
0a40a4861a Merge bitcoin-core/secp256k1#1049: Faster fixed-input ecmult tests
070e772211 Faster fixed-input ecmult tests
c8aa516b57 Merge bitcoin-core/secp256k1#1064: Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063
b797a500ec Create a SECP256K1_ECMULT_TABLE_VERIFY macro.
a731200cc3 Replace ECMULT_TABLE_GET_GE_STORAGE macro with a function.
fe34d9f341 Eliminate input_pos state field from ecmult_strauss_wnaf.
0397d00ba0 Eliminate na_1 and na_lam state fields from ecmult_strauss_wnaf.
7ba3ffcca0 Remove the unused pre_a_lam allocations.
b3b57ad6ee Eliminate the pre_a_lam array from ecmult_strauss_wnaf.
ae7ba0f922 Remove the unused prej allocations.
e5c18892db Eliminate the prej array from ecmult_strauss_wnaf.
c9da1baad1 Move secp256k1_fe_one to field.h
45f37b6506 Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063.
a1102b1219 Merge bitcoin-core/secp256k1#1029: Simpler and faster ecdh skew fixup
e82144edfb Fixup skew before global Z fixup
40b624c90b Add tests for _gej_cmov
8c13a9bfe1 ECDH skews by 0 or 1
1515099433 Simpler and faster ecdh skew fixup
39a36db94a Merge bitcoin-core/secp256k1#1054: tests: Fix test whose result is implementation-defined
a310e79ee5 Merge bitcoin-core/secp256k1#1052: Use xoshiro256++ instead of RFC6979 for tests
423b6d19d3 Merge bitcoin-core/secp256k1#964: Add release-process.md
9281c9f4e1 Merge bitcoin-core/secp256k1#1053: ecmult: move `_ecmult_odd_multiples_table_globalz_windowa`
77a19750b4 Use xoshiro256++ PRNG instead of RFC6979 in tests
5f2efe684e secp256k1_testrand_int(2**N) -> secp256k1_testrand_bits(N)
05e049b73c ecmult: move `_ecmult_odd_multiples_table_globalz_windowa`
3d7cbafb5f tests: Fix test whose result is implementation-defined
3ed0d02bf7 doc: add CHANGELOG template
6f42dc16c8 doc: add release_process.md
0bd3e4243c build: set library version to 0.0.0 explicitly
b4b02fd8c4 build: change libsecp version from 0.1 to 0.1.0-pre
09971a3ffd Merge bitcoin-core/secp256k1#1047: ci: Various improvements
0b83b203e1 Merge bitcoin-core/secp256k1#1030: doc: Fix upper bounds + cleanup in field_5x52_impl.h comment
1287786c7a doc: Add comment to top of field_10x26_impl.h
58da5bd589 doc: Fix upper bounds + cleanup in field_5x52_impl.h comment
b39d431aed Merge bitcoin-core/secp256k1#1044: Add another ecmult_multi test
b4ac1a1d5f ci: Run valgrind/memcheck tasks with 2 CPUs
e70acab601 ci: Use Cirrus "greedy" flag to use idle CPU time when available
d07e30176e ci: Update brew on macOS
22382f0ea0 ci: Test different ecmult window sizes
a69df3ad24 Merge bitcoin-core/secp256k1#816: Improve checks at top of _fe_negate methods
22d25c8e0a Add another ecmult_multi test
515e7953ca Improve checks at top of _fe_negate methods
26a022a3a0 ci: Remove STATICPRECOMPUTATION
10461d8bd3 precompute_ecmult: Always compute all tables up to default WINDOW_G
be6944ade9 Merge bitcoin-core/secp256k1#1042: Follow-ups to making all tables fully static
e05da9e480 Fix c++ build
c45386d994 Cleanup preprocessor indentation in precompute{,d}_ecmult{,_gen}
19d96e15f9 Split off .c file from precomputed_ecmult.h
1a6691adae Split off .c file from precomputed_ecmult_gen.h
bb36331412 Simplify precompute_ecmult_print_*
38cd84a0cb Compute ecmult tables at runtime for tests_exhaustive
e458ec26d6 Move ecmult table computation code to separate file
fc1bf9f15f Split ecmult table computation and printing
31feab053b Rename function secp256k1_ecmult_gen_{create_prec -> compute}_table
725370c3f2 Rename ecmult_gen_prec -> ecmult_gen_compute_table
075252c1b7 Rename ecmult_static_pre_g -> precomputed_ecmult
7cf47f72bc Rename ecmult_gen_static_prec_table -> precomputed_ecmult_gen
f95b8106d0 Rename gen_ecmult_static_pre_g -> precompute_ecmult
bae77685eb Rename gen_ecmult_gen_static_prec_table -> precompute_ecmult_gen
0559fc6e41 Merge bitcoin-core/secp256k1#988: Make signing table fully static
7dfceceea6 build: Remove #undef hack for ASM in the precomputation programs
bb36fe9be0 ci: Test `make precomp`
d94a37a20c build: Remove CC_FOR_BUILD stuff
ad63bb4c29 build: Prebuild and distribute ecmult_gen table
ac49361ed0 prealloc: Get rid of manual memory management for prealloc contexts
6573c08f65 ecmult_gen: Tidy precomputed file and save space
5eba83f17c ecmult_gen: Precompute tables for all values of ECMULT_GEN_PREC_BITS
5d0dbef018 Merge bitcoin-core/secp256k1#942: Verify that secp256k1_ge_set_gej_zinv does not operate on infinity.
486205aa68 Merge bitcoin-core/secp256k1#920: Test all ecmult functions with many j*2^i combinations
fdb33dd122 refactor: Make PREC_BITS a parameter of ecmult_gen_build_prec_table
5eb519e1f6 ci: reduce TEST_ITERS in memcheck run
e2cf77328a Test ecmult functions for all i*2^j for j=0..255 and odd i=1..255.
61ae37c612 Merge bitcoin-core/secp256k1#1022: build: Windows DLL additions
4f01840b82 Merge bitcoin-core/secp256k1#1027: build: Add a check that Valgrind actually supports a host platform
6ad908aa00 Merge bitcoin-core/secp256k1#1008: bench.c: add `--help` option and ci: move env variables
592661c22f ci: move test environment variable declaration to .cirrus.yml
dcbe84b841 bench: add --help option to bench.
099bad945e Comment and check a parameter for inf in secp256k1_ecmult_const.
6c0be857f8 Verify that secp256k1_ge_set_gej_zinv does not operate on infinity. a->x and a->y should not be used if the infinity flag is set.
4900227451 Merge bitcoin-core/secp256k1#1025: build: replace backtick command substitution with $()
7c7ce872a5 build: Add a check that Valgrind actually supports a host platform
a4875e30a6 refactor: Move default callbacks to util.h
4c94c55bce doc: Remove obsolete hint for valgrind stack size
5106226991 exhaustive_tests: Fix with ecmult_gen table with custom generator
e1a76530db refactor: Make generator a parameter of ecmult_gen_create_prec_table
9ad09f6911 refactor: Rename program that generates static ecmult_gen table
8ae18f1ab3 refactor: Rename file that contains static ecmult_gen table
00d2fa116e ecmult_gen: Make code consistent with comment
3b0c2185ea ecmult_gen: Simplify ecmult_gen context after making table static
2b7c7497ef build: replace backtick command substitution with $()
49f608de47 Merge bitcoin-core/secp256k1#1004: ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS
c0cd7de6d4 build: add -no-undefined to libtool LDFLAGS
fe32a79d35 build: pass win32-dll to LT_INIT
60bf8890df ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS
fecf436d53 Merge bitcoin-core/secp256k1#1019: build: don't append valgrind CPPFLAGS if not installed (macOS)
2e5e4b67df Merge bitcoin-core/secp256k1#1020: doc: remove use of <0xa0> "no break space"
812ff5c747 doc: remove use of 0xa0 "no break space"
214042a170 build: don't append valgrind CPPFLAGS if not installed
e43ba02cfc refactor: Decouple table generation and ecmult_gen context
22dc2c0a0d ecmult_gen: Move table creation to new file and force static prec
793ad9016a Merge bitcoin-core/secp256k1#1010: doc: Minor fixes in safegcd_implementation.md
dc9b6853b7 doc: Minor fixes in safegcd_implementation.md
ea5e8a9c47 Merge bitcoin-core/secp256k1#1012: Fix typos
233297579d Fix typos
7006f1b97f Merge bitcoin-core/secp256k1#1011: ci: Enable -g if we set CFLAGS manually
72de1359e9 ci: Enable -g if we set CFLAGS manually
74c34e727b Merge bitcoin-core/secp256k1#1009: refactor: Use (int)&(int) in boolean context to avoid compiler warning
16d132215c refactor: Use (int)&(int) in boolean context to avoid compiler warning
c74a7b7e51 Merge bitcoin-core/secp256k1#1007: doc: Replace apoelstra's GPG key by jonasnick's GPG key
3b157c48ed doc: Suggest keys.openpgp.org as keyserver in SECURITY.md
73a7472cd0 doc: Replace apoelstra's GPG key by jonasnick's GPG key
515a5dbd02 Merge bitcoin-core/secp256k1#991: Merge all "external" benchmarks into a single bench binary
af6abcb3d0 Make bench support selecting which benchmarks to run
9f56bdf5b9 Merge bench_schnorrsig into bench
3208557ae1 Merge bench_recover into bench
855e18d8a8 Merge bench_ecdh into bench
2a7be678a6 Combine bench_sign and bench_verify into single bench
8fa41201bd Merge bitcoin-core/secp256k1#1002: Make aux_rnd32==NULL behave identical to 0x0000..00.
5324f8942d Make aux_rnd32==NULL behave identical to 0x0000..00.
21c188b3c5 Merge bitcoin-core/secp256k1#943: VERIFY_CHECK precondition for secp256k1_fe_set_int.
3e7b2ea194 Merge bitcoin-core/secp256k1#999: bench_ecmult: improve clarity of output
23e2f66726 bench: don't return 1 in have_flag() if argc = 1
96b1ad2ea9 bench_ecmult: improve clarity of output
20d791edfb Merge bitcoin-core/secp256k1#989: Shared benchmark format for command line and CSV outputs
aa1b889b61 Merge bitcoin-core/secp256k1#996: Fix G.y parity in sage code
044d956305 Fix G.y parity in sage code
b4b130678d create csv file from the benchmark output
26a255beb6 Shared benchmark format for command line and CSV outputs
9526874d14 Merge bitcoin-core/secp256k1#810: Avoid overly-wide multiplications in 5x52 field mul/sqr
920a0e5fa6 Merge bitcoin-core/secp256k1#952: Avoid computing out-of-bounds pointer.
f34b5cae03 Merge bitcoin-core/secp256k1#983: [RFC] Remove OpenSSL testing support
297ce82091 Merge bitcoin-core/secp256k1#966: Make aux_rand32 arg to secp256k1_schnorrsig_sign const
2888640132 VERIFY_CHECK precondition for secp256k1_fe_set_int.
d49011f54c Make _set_fe_int( . , 0 ) set magnitude to 0
bc08599e77 Remove OpenSSL testing support
10f9bd84f4 Merge bitcoin-core/secp256k1#987: Fix unused parameter warnings when building without VERIFY
189f6bcfef Fix unused parameter warnings when building without VERIFY
da0092bccc Merge bitcoin-core/secp256k1#986: tests: remove `secp256k1_fe_verify` from tests.c and modify `_fe_from_storage` to call `_fe_verify`
d43993724d tests: remove `secp256k1_fe_verify` from tests.c and modify `secp256k1_fe_from_storage` to call `secp256k1_fe_verify`
2a3a97c665 Merge bitcoin-core/secp256k1#976: `secp256k1_schnorrsig_sign_internal` should be static
aa5d34a8fe Merge bitcoin-core/secp256k1#783: Make the public API docs more consistent and explicit
72713872a8 Add missing static to secp256k1_schnorrsig_sign_internal
db4667d5e0 Make aux_rand32 arg to secp256k1_schnorrsig_sign const
9a5a87e0f1 Merge bitcoin-core/secp256k1#956: Replace ecmult_context with a generated static array.
20abd52c2e Add tests for pre_g tables.
6815761cf5 Remove ecmult_context.
f20dcbbad1 Correct typo.
16a3cc07e8 Generate ecmult_static_pre_g.h
8de2d86a06 Bump memory limits in advance of making the ecmult context static.
d7ec49a689 Merge bitcoin-core/secp256k1#969: ci: Fixes after Debian release
5d5c74a057 tests: Rewrite code to circument potential bug in clang
3d2f492ceb ci: Install libasan6 (instead of 5) after Debian upgrade
be8d9c262f Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM
aeece44599 gen_context: Don't use any ASM
7688a4f13a Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups
90e83449b2 ci: Add C++ test
adec5a1638 Add missing null check for ctx and input keys in the public API
f4edfc7581 Improve consistency for NULL arguments in the public interface
f698caaff6 Use unsigned char consistently for byte arrays
b5b8e7b719 Don't declare constants twice
769528f307 Don't use string literals for char arrays without NUL termination
2cc3cfa583 Fix -Wmissing-braces warning in clang
0440945fb5 Merge #844: schnorrsig API overhaul
ec3aaa5014 Merge #960: tests_exhaustive: check the result of secp256k1_ecdsa_sign
a1ee83c654 tests_exhaustive: check the result of secp256k1_ecdsa_sign
253f90cdeb Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG
446d28d9de Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS
0302138f75 ci: Make compiler warning into errors on CI
b924e1e605 build: Ensure that configure's compile checks default to -O2
7939cd571c build: List *CPPFLAGS before *CFLAGS like on the compiler command line
595e8a35d8 build: Enable -Wcast-align=strict warning
07256267ff build: Use own variable SECP_CFLAGS instead of touching user CFLAGS
4866178dfc Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests
75ce488c2a Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse
41ed13942b tests: really test the non-var scalar inverse
5f6ceafcfa schnorrsig: allow setting MSGLEN != 32 in benchmark
fdd06b7967 schnorrsig: add tests for sign_custom and varlen msg verification
d8d806aaf3 schnorrsig: add extra parameter struct for sign_custom
a0c3fc177f schnorrsig: allow signing and verification of variable length msgs
5a8e4991ad Add secp256k1_tagged_sha256 as defined in BIP-340
b6c0b72fb0 schnorrsig: remove noncefp args from sign; add sign_custom function
bdf19f105c Add random field multiply/square tests
9be7b0f083 Avoid computing out-of-bounds pointer.
8ae56e33e7 Merge #879: Avoid passing out-of-bound pointers to 0-size memcpy
a4642fa15e configure: replace AC_PATH_PROG to AC_CHECK_PROG
1758a92ffd Merge #950: ci: Add ppc64le build
c58c4ea470 ci: Add ppc64le build
7973576f6e Merge #662: Add ecmult_gen, ecmult_const and ecmult to benchmark
8f879c2887 Fix array size in bench_ecmult
2fe1b50df1 Add ecmult_gen, ecmult_const and ecmult to benchmark
593e6bad9c Clean up ecmult_bench to make space for more benchmarks
50f3367712 Merge #947: ci: Run PRs on merge result even for i686
a35fdd3478 ci: Run PRs on merge result even for i686
442cee5baf schnorrsig: add algolen argument to nonce_function_hardened
df3bfa12c3 schnorrsig: clarify result of calling nonce_function_bip340 without data
99e8614812 README: mention schnorrsig module
3dc8c072b6 Merge #846: ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs
02dcea1ad9 ci: Make test iterations configurable and tweak for sanitizer builds
489ff5c20a tests: Treat empty SECP2561_TEST_ITERS as if it was unset
fcfcb97e74 ci: Simplify to use generic wrapper for QEMU, Valgrind, etc
de4157f13a ci: Run ASan/LSan and reorganize sanitizer and Valgrind jobs
399722a63a Merge #941: Clean up git tree
09b3bb8648 Clean up git tree
bf0ac46066 Merge #930: Add ARM32/ARM64 CI
202a030f7d Merge #850: add `secp256k1_ec_pubkey_cmp` method
1e78c18d5b Merge bitcoin-core/secp256k1#940: contrib: Explain explicit header guards
69394879b6 Merge #926: secp256k1.h: clarify that by default arguments must be != NULL
6eceec6d56 add `secp256k1_xonly_pubkey_cmp` method
0d9561ae87 add `secp256k1_ec_pubkey_cmp` method
22a9ea154a contrib: Explain explicit header guards
6c52ae8724 Merge #937: Have ge_set_gej_var, gej_double_var and ge_set_all_gej_var initialize all fields of their outputs.
185a6af227 Merge #925: changed include statements without prefix 'include/'
14c9739a1f tests: Improve secp256k1_ge_set_all_gej_var for some infinity inputs
4a19668c37 tests: Test secp256k1_ge_set_all_gej_var for all infinity inputs
3c90bdda95 change local lib headers to be relative for those pointing at "include/" dir
45b6468d7e Have secp256k1_ge_set_all_gej_var initialize all fields. Previous behaviour would not initialize r->y values in the case where infinity is passed in. Furthermore, the previous behaviour wouldn't initialize anything in the case where all inputs were infinity.
31c0f6de41 Have secp256k1_gej_double_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in.
dd6c3de322 Have secp256k1_ge_set_gej_var initialize all fields. Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in.
d0bd2693e3 Merge bitcoin-core/secp256k1#936: Fix gen_context/ASM build on ARM
8bbad7a18e Add asm build to ARM32 CI
7d65ed5214 Add ARM32/ARM64 CI
c8483520c9 Makefile.am: Don't pass a variable twice
2161f31785 Makefile.am: Honor config when building gen_context
99f47c20ec gen_context: Don't use external ASM because it complicates the build
98e0358d29 Merge #933: Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers
99e2d5be0d Avoids a missing brace warning in schnorrsig/tests_impl.h on old compilers.
34388af6b6 Merge #922: Add mingw32-w64/wine CI build
7012a188e6 Merge #928: Define SECP256K1_BUILD in secp256k1.c directly.
ed5a199bed tests: fopen /dev/urandom in binary mode
ae9e648526 Define SECP256K1_BUILD in secp256k1.c directly.
4dc37bf81b Add mingw32-w64/wine CI build
0881633dfd secp256k1.h: clarify that by default arguments must be != NULL
efad3506a8 Merge #906: Use modified divsteps with initial delta=1/2 for constant-time
cc2c09e3a7 Merge #918: Clean up configuration in gen_context
07067967ee add ECMULT_GEN_PREC_BITS to basic_config.h
a3aa2628c7 gen_context: Don't include basic-config.h
be0609fd54 Add unit tests for edge cases with delta=1/2 variant of divsteps
cd393ce228 Optimization: only do 59 hddivsteps per iteration instead of 62
277b224b6a Use modified divsteps with initial delta=1/2 for constant-time
376ca366db Fix typo in explanation
1e5d50fa93 Merge #889: fix uninitialized read in tests
c083cc6e52 Merge #903: Make argument of fe_normalizes_to_zero{_var} const
6e898534ff Merge #907: changed import to use brackets <> for openssl
4504472269 changed import to use brackets <> for openssl as they are not local to the project
26de4dfeb1 Merge #831: Safegcd inverses, drop Jacobi symbols, remove libgmp
23c3fb629b Make argument of fe_normalizes_to_zero{_var} const
24ad04fc06 Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS
ebc1af700f Optimization: track f,g limb count and pass to new variable-time update_fg_var
b306935ac1 Optimization: use formulas instead of lookup tables for cancelling g bits
9164a1b658 Optimization: special-case zero modulus limbs in modinv64
1f233b3fa0 Remove num/gmp support
20448b8d09 Remove unused Jacobi symbol support
5437e7bdfb Remove unused scalar_sqr
aa9cc52180 Improve field/scalar inverse tests
1e0e885c8a Make field/scalar code use the new modinv modules for inverses
436281afdc Move secp256k1_fe_inverse{_var} to per-impl files
aa404d53be Move secp256k1_scalar_{inverse{_var},is_even} to per-impl files
08d54964e5 Improve bounds checks in modinv modules
151aac00d3 Add tests for modinv modules
d8a92fcc4c Add extensive comments on the safegcd algorithm and implementation
8e415acba2 Add safegcd based modular inverse modules
de0a643c3d Add secp256k1_ctz{32,64}_var functions
4c3ba88c3a Merge #901: ci: Switch all Linux builds to Debian and more improvements
9361f360bb ci: Select number of parallel make jobs depending on CI environment
28eccdf806 ci: Split output of logs into multiple sections
c7f754fe4d ci: Run PRs on merge result instead of on the source branch
b994a8be3c ci: Print information about binaries using "file"
f24e122d13 ci: Switch all Linux builds to Debian
ebdba03cb5 Merge #891: build: Add workaround for automake 1.13 and older
3a8b47bc6d Merge #894: ctime_test: move context randomization test to the end
7d3497cdc4 ctime_test: move context randomization test to the end
99a1cfec17 print warnings for conditional-uninitialized
3d2cf6c5bd initialize variable in tests
f329bba244 build: Add workaround for automake 1.13 and older
24d1656c32 Merge #882: Use bit ops instead of int mult for constant-time logic in gej_add_ge
e491d06b98 Use bit ops instead of int mult for constant-time logic in gej_add_ge
f8c0b57e6b Merge #864: Add support for Cirrus CI
cc2a5451dc ci: Refactor Nix shell files
2480e55c8f ci: Remove support for Travis CI
2b359f1c1d ci: Enable simple cache for brewing valgrind on macOS
8c02e465c5 ci: Add support for Cirrus CI
659d0d4798 Merge #880: Add parens around ROUND_TO_ALIGN's parameter.
b6f649889a Add parens around ROUND_TO_ALIGN's parameter. This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.
a4abaab793 Merge #877: Add missing secp256k1_ge_set_gej_var decl.
5671e5f3fd Merge #874: Remove underscores from header defs.
db726782fa Merge #878: Remove unused secp256k1_fe_inv_all_var
b732701faa Merge #875: Avoid casting (void**) values.
9570f674cc Avoid passing out-of-bound pointers to 0-size memcpy
75d2ae149e Remove unused secp256k1_fe_inv_all_var
482e4a9cfc Add missing secp256k1_ge_set_gej_var decl.
2730618604 Avoid casting (void**) values. Replaced with an expression that only casts (void*) values.
fb390c5299 Remove underscores from header defs. This makes them consistent with other files and avoids reserved identifiers.
f2d9aeae6d Merge #862: Autoconf improvements
328aaef22a Merge #845: Extract the secret key from a keypair
3c15130709 Improve CC_FOR_BUILD detection
47802a4762 Restructure and tidy configure.ac
252c19dfc6 Ask brew for valgrind include path
8c727b9087 Merge #860: fixed trivial typo
b7bc3a4aaa fixed typo
33cb3c2b1f Add secret key extraction from keypair to constant time tests
36d9dc1e8e Add seckey extraction from keypair to the extrakeys tests
fc96aa73f5 Add a function to extract the secretkey from a keypair
98dac87839 Merge #858: Fix insecure links
07aa4c70ff Fix insecure links
b61f9da54e Merge #857: docs: fix simple typo, dependecy -> dependency
18aadf9d28 docs: fix simple typo, dependecy -> dependency
2d9e7175c6 Merge #852: Add sage script for generating scalar_split_lambda constants
dc6e5c3a5c Merge #854: Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
6e85d675aa Rename tweak to tweak32 in public API
f587f04e35 Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
329a2e0a3f sage: Add script for generating scalar_split_lambda constants
8f0c6f1545 Merge #851: make test count iteration configurable by environment variable
f4fa8d226a forbid a test iteration of 0 or less
f554dfc708 sage: Reorganize files
3a106966aa Merge #849: Convert Sage code to Python 3 (as used by Sage >= 9)
13c88efed0 Convert Sage code to Python 3 (as used by Sage >= 9)
0ce4554881 make test count iteration configurable by environment variable
9e5939d284 Merge #835: Don't use reserved identifiers memczero and benchmark_verify_t
d0a83f7328 Merge #839: Prevent arithmetic on NULL pointer if the scratch space is too small
903b16aa6c Merge #840: Return NULL early in context_preallocated_create if flags invalid
1f4dd03838 Typedef (u)int128_t only when they're not provided by the compiler
3967d96bf1 Merge #838: Make autotools check for all the used openssl functions
3734b68200 Configure echo if openssl tests are enabled
ebfa2058e9 Return NULL early in context_preallocated_create if flags invalid
6f54e69f03 Merge #841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_
29a299e373 Run the undefined behaviour sanitizer on Travis
7506e064d7 Prevent arithmetic on NULL pointer if the scratch space is too small
8893f42438 Avoids a potentially shortening size_t to int cast in strauss_wnaf_
e6692778d3 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing
ac05f61fcf Merge #809: Stop treating ECDH as experimental
e6e3d5da2f travis: add schnorrsig to valgrind and big endian platform test
353dff156f Stop treating ECDH as experimental
e89278f211 Don't use reserved identifiers memczero and benchmark_verify_t
c6b6b8f1bb Merge #830: Rip out non-endomorphism code + dependencies
c582abade1 Consistency improvements to the comments
63c6b71616 Reorder comments/function around scalar_split_lambda
2edc514c90 WNAF of lambda_split output has max size 129
4232e5b7da Rip out non-endomorphism code
ebad8414b0 Check correctness of lambda split without -DVERIFY
fe7fc1fda8 Make lambda constant accessible
9d2f2b44d8 Add tests to exercise lambda split near bounds
9aca2f7f07 Add secp256k1_split_lambda_verify
acab934d24 Detailed comments for secp256k1_scalar_split_lambda
76ed922a5f Increase precision of g1 and g2
6173839c90 Switch to our own memcmp function
63150ab4da Merge #827: Rename testrand functions to have test in name
c5257aed0b Merge #821: travis: Explicitly set --with-valgrind
bb1f54280f Merge #818: Add static assertion that uint32_t is unsigned int or wider
a45c1fa63c Rename testrand functions to have test in name
5006895bd6 Merge #808: Exhaustive test improvements + exhaustive schnorrsig tests
4eecb4d6ef travis: VALGRIND->RUN_VALGRIND to avoid confusion with WITH_VALGRIND
66a765c775 travis: Explicitly set --with-valgrind
d7838ba6a6 Merge #813: Enable configuring Valgrind support
7ceb0b7611 Merge #819: Enable -Wundef warning
8b7dcdd955 Add exhaustive test for extrakeys and schnorrsig
08d7d89299 Make pubkey parsing test whether points are in the correct subgroup
87af00b511 Abstract out challenge computation in schnorrsig
63e1b2aa7d Disable output buffering in tests_exhaustive.c
39f67dd072 Support splitting exhaustive tests across cores
e99b26fcd5 Give exhaustive_tests count and seed cmdline inputs
49e6630bca refactor: move RNG seeding to testrand
b110c106fa Change exhaustive test groups so they have a point with X=1
cec7b18a34 Select exhaustive lambda in function of order
78f6cdfaae Make the curve B constant a secp256k1_fe
d7f39ae4b6 Delete gej_is_valid_var: unused outside tests
8bcd78cd79 Make secp256k1_scalar_b32 detect overflow in scalar_low
c498366e5b Move exhaustive tests for recovery to module
be31791543 Make group order purely compile-time in exhaustive tests
e73ff30922 Enable -Wundef warning
c0041b5cfc Add static assertion that uint32_t is unsigned int or wider
4ad408faf3 Merge #782: Check if variable=yes instead of if var is set in travis.sh
412bf874d0 configure: Allow specifying --with[out]-valgrind explicitly
34debf7a6d Modify .travis.yml to explictly pass no in env vars instead of setting to nothing
a0e99fc121 Merge #814: tests: Initialize random group elements fully
5738e8622d tests: Initialize random group elements fully
c9939ba55d Merge #812: travis: run bench_schnorrsig
a51f2af62b travis: run bench_schnorrsig
8ab24e8dad Merge #558: Add schnorrsig module which implements BIP-340 compliant signatures
f3733c5433 Merge #797: Fix Jacobi benchmarks and other benchmark improvements
b53e0cd61f Avoid overly-wide multiplications
cb5524adc5 Add benchmark for secp256k1_ge_set_gej_var
5c6af60ec5 Make jacobi benchmarks vary inputs
d0fdd5f009 Randomize the Z coordinates in bench_internal
c7a3424c5f Rename bench_internal variables
875d68b95f Merge #699: Initialize field elements when resulting in infinity
54caf2e74f Merge #799: Add fallback LE/BE for architectures with known endianness + SHA256 selftest
f431b3f28a valgrind_ctime_test: Add schnorrsig_sign
16ffa9d97c schnorrsig: Add taproot test case
8dfd53ee3f schnorrsig: Add benchmark for sign and verify
4e43520026 schnorrsig: Add BIP-340 compatible signing and verification
7332d2db6b schnorrsig: Add BIP-340 nonce function
7a703fd97d schnorrsig: Init empty experimental module
eabd9bc46a Allow initializing tagged sha256
6fcb5b845d extrakeys: Add keypair_xonly_tweak_add
58254463f9 extrakeys: Add keypair struct with create, pub and pub_xonly
f0010349b8 Separate helper functions for pubkey_create and seckey_tweak_add
910d9c284c extrakeys: Add xonly_pubkey_tweak_add & xonly_pubkey_tweak_add_test
176bfb1110 Separate helper function for ec_pubkey_tweak_add
4cd2ee474d extrakeys: Add xonly_pubkey with serialize, parse and from_pubkey
f49c9896b0 Merge #806: Trivial: Add test logs to gitignore
aabf00c155 Merge #648: Prevent ints from wrapping around in scratch space functions
f5adab16a9 Merge #805: Remove the extremely outdated TODO file.
bceefd6547 Add test logs to gitignore
1c325199d5 Remove the extremely outdated TODO file.
47e6618e11 extrakeys: Init empty experimental module
3e08b02e2a Make the secp256k1_declassify argument constant
8bc6aeffa9 Add SHA256 selftest
670cdd3f8b Merge #798: Check assumptions on integer implementation at compile time
5e5fb28b4a Use additional system macros to figure out endianness
7c068998ba Compile-time check assumptions on integer types
02b6c87b52 Add support for (signed) __int128
979961c506 Merge #787: Use preprocessor macros instead of autoconf to detect endianness
887bd1f8b6 Merge #793: Make scalar/field choice depend on C-detected __int128 availability
0dccf98a21 Use preprocessor macros instead of autoconf to detect endianness
b2c8c42cf1 Merge #795: Avoid linking libcrypto in the valgrind ct test.
57d3a3c64c Avoid linking libcrypto in the valgrind ct test.
79f1f7a4f1 Autodetect __int128 availability on the C side
0d7727f95e Add SECP256K1_FE_STORAGE_CONST_GET to 5x52 field
805082de11 Merge #696: Run a Travis test on s390x (big endian)
39295362cf Test travis s390x (big endian)
ef37761fee Change travis.sh to check if variables are equal to yes instead of not-empty. Before this, setting `VALGRIND=wat` was considered as true, and to make it evaluate as false you had to unset the variable `VALGRIND=` but not it checks if `VALGRIND=yes` and if it's not `yes` then it's evaluated to false
6034a04fb1 Merge #778: secp256k1_gej_double_nonzero supports infinity
f60915906d Merge #779: travis: Fix argument quoting for ./configure
9e49a9b255 travis: Fix argument quoting for ./configure
18d36327fd secp256k1_gej_double_nonzero supports infinity
214cb3c321 Merge #772: Improve constant-timeness on PowerPC
40412b1930 Merge #774: tests: Abort if malloc() fails during context cloning tests
2e1b9e0458 tests: Abort if malloc() fails during context cloning tests
67a429f31f Suppress a harmless variable-time optimization by clang in _int_cmov
5b196338f0 Remove redundant "? 1 : 0" after comparisons in scalar code
3e5cfc5c73 Merge #741: Remove unnecessary sign variable from wnaf_const
66bb9320c0 Merge #773: Fix some compile problems on weird/old compilers.
1309c03c45 Fix some compile problems on weird/old compilers.
2309c7dd4a Merge #769: Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
22e578bb11 Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
3f4a5a10e4 Merge #765: remove dead store in ecdsa_signature_parse_der_lax
f00d6575ca remove dead store in ecdsa_signature_parse_der_lax
dbd41db16a Merge #759: Fix uninitialized variables in ecmult_multi test
2e7fc5b537 Fix uninitialized variables in ecmult_multi test
2ed54da18a Merge #755: Recovery signing: add to constant time test, and eliminate non ct operators
28609507e7 Add tests for the cmov implementations
73596a85a2 Add ecdsa_sign_recoverable to the ctime tests
2876af4f8d Split ecdsa_sign logic into a new function and use it from ecdsa_sign and recovery
5e1c885efb Merge #754: Fix uninit values passed into cmov
f79a7adcf5 Add valgrind uninit check to cmovs output
05d315affe Merge #752: autoconf: Use ":" instead of "dnl" as a noop
a39c2b09de Fixed UB(arithmetics on uninit values) in cmovs
3a6fd7f636 Merge #750: Add macOS to the CI
5e8747ae2a autoconf: Use ":" instead of "dnl" as a noop
71757da5cc Explictly pass SECP256K1_BENCH_ITERS to the benchmarks in travis.sh
99bd661d71 Replace travis_wait with a loop printing "\a" to stdout every minute
bc818b160c Bump travis Ubuntu from xenial(16.04) to bionic(18.04)
0c5ff9066e Add macOS support to travis
b6807d91d8 Move travis script into a standalone sh file
f39f99be0e Merge #701: Make ec_ arithmetic more consistent and add documentation
37dba329c6 Remove unnecessary sign variable from wnaf_const
6bb0b77e15 Fix test_constant_wnaf for -1 and add a test for it.
39198a03ea Merge #732: Retry if r is zero during signing
59a8de8f64 Merge #742: Fix typo in ecmult_const_impl.h
4e284655d9 Fix typo in ecmult_const_impl.h
f862b4ca13 Merge #740: Make recovery/main_impl.h non-executable
ffef45c98a Make recovery/main_impl.h non-executable
2361b3719a Merge #735: build: fix OpenSSL EC detection on macOS
3b7d26b23c build: add SECP_TEST_INCLUDES to bench_verify CPPFLAGS
84b5fc5bc3 build: fix OpenSSL EC detection on macOS
37ed51a7ea Make ecdsa_sig_sign constant-time again after reverting 25e3cfb
93d343bfc5 Revert "ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign"
7e3952ae82 Clarify documentation of tweak functions.
89853a0f2e Make tweak function documentation more consistent.
41fc785602 Make ec_privkey functions aliases for ec_seckey_negate, ec_seckey_tweak_add and ec_seckey_mul
22911ee6da Rename private key to secret key in public API (with the exception of function names)
5a73f14d6c Mention that value is unspecified for In/Out parameters if the function returns 0
f03df0e6d7 Define valid ECDSA keys in the documentation of seckey_verify
5894e1f1df Return 0 if the given seckey is invalid in privkey_negate, privkey_tweak_add and privkey_tweak_mul
8f814cddb9 Add test for boundary conditions of scalar_set_b32 with respect to overflows
3fec982608 Use scalar_set_b32_seckey in ecdsa_sign, pubkey_create and seckey_verify
9ab2cbe0eb Add scalar_set_b32_seckey which does the same as scalar_set_b32 and also returns whether it's a valid secret key
4f27e344c6 Merge #728: Suppress a harmless variable-time optimization by clang in memczero
01993878bb Add test for memczero()
52a03512c1 Suppress a harmless variable-time optimization by clang in memczero
8f78e208ad Merge #722: Context isn't freed in the ECDH benchmark
ed1b91171a Merge #700: Allow overriding default flags
85b35afa76 Add running benchmarks regularly and under valgrind in travis
ca4906b02e Pass num of iters to benchmarks as variable, and define envvar
02dd5f1bbb free the ctx at the end of bench_ecdh
e9fccd4de1 Merge #708: Constant-time behaviour test using valgrind memtest.
08fb6c4926 Run valgrind_ctime_test in travis
3d2302257f Constant-time behaviour test using valgrind memtest.
96d8ccbd16 Merge #710: Eliminate harmless non-constant time operations on secret data.
0585b8b2ee Merge #718: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1
7b50483ad7 Adds a declassify operation to aid constant-time analysis.
34a67c773b Eliminate harmless non-constant time operations on secret data.
ca739cba23 Compile with optimization flag -O2 by default instead of -O3
eb45ef3384 Clarify that a secp256k1_ecdh_hash_function must return 0 or 1
856a01d6ad Merge #714: doc: document the length requirements of output parameter.
d72b9e2483 Merge #682: Remove Java Native Interface
4b48a43106 doc: document the length requirements of output parameter.
1b4d256e2e Merge #713: Docstrings
dabfea7e21 field: extend docstring of secp256k1_fe_normalize
dc7d8fd9e2 scalar: extend docstring of secp256k1_scalar_set_b32
074ab582dd Merge #704: README: add a section for test coverage
acb7f97eb8 README: add a section for test coverage
227a4f2d07 Merge #709: Remove secret-dependant non-constant time operation in ecmult_const.
d567b779fe Clarify comments about use of rzr on ge functions and abs function.
2241ae6d14 Remove secret-dependant non-constant time operation in ecmult_const.
642cd062bd Remove Java Native Interface
83fb1bcef4 Remove -O2 from default CFLAGS because this would override the -O3 flag (see AC_PROG_CC in the Autoconf manual)
ecba8138ec Append instead of Prepend user-CFLAGS to default CFLAGS allowing the user to override default variables
613c34cd86 Remove test in configure.ac because it doesn't have an effect
f45d897101 Merge #703: Overhaul README.md
2e759ec753 Overhaul README.md
d644dda5c9 Merge #689: Remove "except in benchmarks" exception for fp math
bde2a32286 Convert bench.h to fixed-point math
47a7b8382f Clear field elements when writing infinity
61d1ecb028 Added test with additions resulting in infinity
387d723c3f Merge #679: Add SECURITY.md
0db61d25c9 Merge #685: Fix issue where travis does not show the ./tests seed…
a0771d15e6 Explicitly disable buffering for stderr in tests
fb424fbba2 Make travis show the ./tests seed by removing stdout buffering and always cat tests.log after a travis run.
22a6031184 Merge #690: Add valgrind check to travis
544002c008 Merge #678: Preventing compiler optimizations in benchmarks without a memory fence
dd98cc988f travis: Added a valgrind test without endro and enabled recovery+ecdh
b4c1382a87 Add valgrind check to travis
0c774d89e6 Merge #688: Fix ASM setting in travis
5c5f71eea5 Fix ASM setting in travis
e2625f8a98 Merge #684: Make no-float policy explicit
bae1bea3c4 Make no-float policy explicit
78c3836341 Add SECURITY.md
362bb25608 Modified bench_scalar_split so it won't get optimized out
73a30c6b58 Added accumulators and checks on benchmarks so they won't get optimized out
770b3dcd6f Merge #677: Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var
b76142ff25 Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var which was removed in 47045270fa90f81205d989f7107769bce1e71c4d
137d304a6b Merge #647: Increase robustness against UB in secp256k1_scalar_cadd_bit
0d9540b13f Merge #664: Remove mention of ec_privkey_export because it doesn't exist
59782c68b4 Remove mention of ec_privkey_export because it doesn't exist
96cd94e385 Merge #337: variable sized precomputed table for signing
dcb2e3b3ff variable signing precompute table
b4bff99028 Merge #661: Make ./configure string consistent
a467047e11 Make ./configure string consistent
e729cc7f5a Merge #657: Fix a nit in the recovery tests
b64a2e2597 Fix a nit in the recovery tests
e028aa33d3 Merge #650: secp256k1/src/tests.c: Properly handle sscanf return value
f1e11d363d Merge #654: Fix typo (∞)
ef83281c3a Merge pull request #656 from real-or-random/patch-1
556caad2ca Fix typo in docs for _context_set_illegal_callback
0d82732a9a Improve VERIFY_CHECK of overflow in secp256k1_scalar_cadd_bit. This added check ensures that any curve order overflow doesn't go undetected due a uint32_t overflow.
786dfb49f5 Merge #583: JNI: fix use sig array
e95f8ab098 Merge #644: Avoid optimizing out a verify_check
384f55606a Merge #652: README.md: update instruction to run tests
ee56accd47 Merge #651: Fix typo in secp256k1_preallocated.h
7b9b117230 Merge #640: scalar_impl.h: fix includes
d99bec2e21 Merge #655: jni: Use only Guava for hex encoding and decoding
2abcf951af jni: Use only Guava for hex encoding and decoding
271582b3b7 Fix typo
60f7f2de5d Don't assume that ALIGNMENT > 1 in tests
ada6361dec Use ROUND_TO_ALIGN in scratch_create
8ecc6ce50e Add check preventing rounding to alignment from wrapping around in scratch_alloc
4edaf06fb0 Add check preventing integer multiplication wrapping around in scratch_max_allocation
ce6d438266 README.md: update instruction to run tests
b1e68cb8e6 Fix typo in secp256k1_preallocated.h
a11c76c59a secp256k1/src/tests.c: Properly handle sscanf return value
8fe63e5654 Increase robustness against UB. Thanks to elichai2 who noted that the literal '1' is a signed integer, and that shifting a signed 32-bit integer by 31 bits causes an overflow and yields undefined behaviour. While 'scalar_low_impl''s 'secp256k1_scalar_cadd_bit' is only used for testing purposes and currently the 'bit' parameter is only 0 or 1, it is better to avoid undefined behaviour in case the used domain of 'secp256k1_scalar_cadd_bit' expands.
94ae7cbf83 Moved a dereference so the null check will be before the dereferencing
2cb73b1064 scalar_impl.h: fix includes
fa33017135 Merge #634: Add a descriptive comment for secp256k1_ecmult_const.
ee9e68cd30 Add a descriptive comment for secp256k1_ecmult_const.
d0d738d32d Merge #631: typo in comment for secp256k1_ec_pubkey_tweak_mul ()
6914c25276 typo in comment for secp256k1_ec_pubkey_tweak_mul ()
e541a90ef6 Merge #629: Avoid calling _is_zero when _set_b32 fails.
f34b0c3f35 Merge #630: Note intention of timing sidechannel freeness.
8d1563b0ff Note intention of timing sidechannel freeness.
1669bb2865 Merge #628: Fix ability to compile tests without -DVERIFY.
ecc94abcc8 Merge #627: Guard memcmp in tests against mixed size inputs.
544435fc90 Merge #578: Avoid implementation-defined and undefined behavior when dealing with sizes
143dc6e9ee Merge #595: Allow to use external default callbacks
e49f7991c2 Add missing #(un)defines to base-config.h
77defd2c3b Add secp256k1_ prefix to default callback functions
908bdce64e Include stdio.h and stdlib.h explicitly in secp256k1.c
5db782e655 Allow usage of external default callbacks
6095a863fa Replace CHECKs for no_precomp ctx by ARG_CHECKs without a return
cd473e02c3 Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails.
6c36de7a33 Merge #600: scratch space: use single allocation
98836b11f0 scratch: replace frames with "checkpoint" system
7623cf2b97 scratch: save a couple bytes of unnecessarily-allocated memory
a7a164f2c6 scratch: rename `max_size` to `size`, document that extra will actually be allocated
5a4bc0bb95 scratch: unify allocations
c2b028a281 scratch space: thread `error_callback` into all scratch space functions
0be1a4ae62 scratch: add magic bytes to beginning of structure
92a48a764d scratch space: use single allocation
40839e21b9 Merge #592: Use trivial algorithm in ecmult_multi if scratch space is small
dcf392027b Fix ability to compile tests without -DVERIFY.
a484e0008b Merge #566: Enable context creation in preallocated memory
0522caac8f Explain caller's obligations for preallocated memory
238305fdbb Move _preallocated functions to separate header
695feb6fbd Export _preallocated functions
814cc78d71 Add tests for contexts in preallocated memory
ba12dd08da Check arguments of _preallocated functions
5feadde462 Support cloning a context into preallocated memory
c4fd5dab45 Switch to a single malloc call
ef020de16f Add size constants for preallocated memory
1bf7c056ba Prepare for manual memory management in preallocated memory
248bffb052 Guard memcmp in tests against mixed size inputs.
36698dcfee Merge #596: Make WINDOW_G configurable
a61a93ff50 Clean up ./configure help strings
2842dc523e Make WINDOW_G configurable
1a02d6ce51 Merge #626: Revert "Merge #620: Install headers automatically"
662918cb29 Revert "Merge #620: Install headers automatically"
14c7dbd444 Simplify control flow in DER parsing
ec8f20babd Avoid out-of-bound pointers and integer overflows in size comparisons
01ee1b3b3c Parse DER-enconded length into a size_t instead of an int
912680ed86 Merge #561: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
91fae3ace0 Merge #620: Install headers automatically
5df77a0eda Merge #533: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...)
975e51e0d9 Merge #617: Pass scalar by reference in secp256k1_wnaf_const()
735fbde04e Merge #619: Clear a copied secret key after negation
16e86150d0 Install headers automatically
069870d92a Clear a copied secret key after negation
8979ec0d9a Pass scalar by reference in secp256k1_wnaf_const()
84a808598b Merge #612: Allow field_10x26_arm.s to compile for ARMv7 architecture
d4d270a59c Allow field_10x26_arm.s to compile for ARMv7 architecture
b19c000063 Merge #607: Use size_t shifts when computing a size_t
4d01bc2d9c Merge #606: travis: Remove unused sudo:false
e6d01e9347 Use size_t shifts when computing a size_t
7667532bd7 travis: Remove unused sudo:false
248f046611 Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...)
9ab96f7b12 Use trivial algorithm in ecmult_multi if scratch space is small
ee99f12f3d Merge #599: Switch x86_64 asm to use "i" instead of "n" for immediate values.
d58bc93f2c Switch x86_64 asm to use "i" instead of "n" for immediate values.
05362ee042 Merge #597: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
83483869ac Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
aa15154a48 Merge #568: Fix integer overflow in ecmult_multi_var when n is large
2277af5ff0 Fix integer overflow in ecmult_multi_var when n is large
dbed75d969 Undefine `STATIC_PRECOMPUTATION` if using the basic config
310111e093 Keep LDFLAGS if `--coverage`
85d0e1bcce Merge #591: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
14196379ec Merge #580: Add trivial ecmult_multi algorithm which does not require a scratch space
a697d82da9 Add trivial ecmult_multi to the benchmark tool
bade617417 Add trivial ecmult_multi algorithm. It is selected when no scratch space is given and just multiplies and adds the points.
5545e13dea Merge #584: configure: Use CFLAGS_FOR_BUILD when checking native compiler
20c5869df2 Merge #516: improvements to random seed in src/tests.c
b76e45d5d6 Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
870a977644 Merge #562: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
be40c4d0b5 Fixup for C90 mixed declarations.
c71dd2c08f Merge #509: Fix algorithm selection in bench_ecmult
6492bf88cc Merge #518: Summarize build options after running configure
0e9ada1941 Merge #567: Correct order of libs returned on pkg-config --libs --static libsecp2…
e96901a4b9 Merge #587: Make randomization of a non-signing context a noop
58df8d03ad Merge #511: Portability fix for the configure scripts generated
2ebdad772a Merge #552: Make constants static:
1c131affd3 Merge #551: secp256k1_fe_sqrt: Verify that the arguments don't alias.
ba698f883b Merge #539: Assorted minor corrections
949e85b009 Merge #550: Optimize secp256k1_fe_normalize_weak calls.
a34bcaadf1 Actually pass CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD to linker
2d5f4cebdc configure: Use CFLAGS_FOR_BUILD when checking native compiler
b408c6a8b2 Merge #579: Use __GNUC_PREREQ for detecting __builtin_expect
6198375218 Make randomization of a non-signing context a noop
74e2dbd68e JNI: fix use sig array
c663397f46 Use __GNUC_PREREQ for detecting __builtin_expect
3cb057f842 Fix possible integer overflow in DER parsing
e34ceb333b Merge #557: Eliminate scratch memory used when generating contexts
b3bf5f99a3 ecmult_impl: expand comment to explain how effective affine interacts with everything
efa783f8f0 Store z-ratios in the 'x' coord they'll recover
ffd3b346fe add `secp256k1_ge_set_all_gej_var` test which deals with many infinite points
84740acd2a ecmult_impl: save one fe_inv_var
47045270fa ecmult_impl: eliminate scratch memory used when generating context
7f7a2ed3a8 ecmult_gen_impl: eliminate scratch memory used when generating context
314a61d724 Merge #553: add static context object which has no capabilities
89a20a8945 Correct order of libs returned on pkg-config --libs --static libsecp256k1 call.
1086fda4c1 Merge #354: [ECDH API change] Support custom hash function
d3cb1f95eb Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
40fde611bd prevent attempts to modify `secp256k1_context_no_precomp`
ed7c08417a add static context object which has no capabilities
496c5b43b8 Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;
bf8b86cc07 secp256k1_fe_sqrt: Verify that the arguments don't alias.
9bd89c836b Optimize secp256k1_fe_normalize_weak calls. Move secp256k1_fe_normalize_weak calls out of ECMULT_TABLE_GET_GE and ECMULT_TABLE_GET_GE_STORAGE and into secp256k1_ge_globalz_set_table_gej instead.
52ab96fedb clean dependendies in field_*_impl.h
deff5edd42 Correct math typos in field_*.h
4efb3f8dd1 Add check that restrict pointers don't alias with all parameters.
1e6f1f5ad5 Merge #529: fix tests.c in the count == 0 case
c8fbc3c397 [ECDH API change] Allow pass arbitrary data to hash function
b00be65056 [ECDH API change] Support custom hash function
95e99f196f fix tests.c in the count == 0 case
452d8e4d2a Merge #523: scratch: add stack frame support
6fe50439ae scratch: add stack frame support
9bc2e26502 Merge #522: parameterize ecmult_const over input size
7c1b91ba4b parameterize ecmult_const over input size
dbc3ddd5e2 Merge #513: Increase sparsity of pippenger fixed window naf representation
3965027c81 Summarize build options in configure script
0f0517369c Fix algorithm selection in bench_ecmult
fb9271dcf0 Merge #510: add a couple missing `const`s to ecmult_pippenger_wnaf
cd5f6028e5 Merge #515: Fix typo
09146ae854 Merge #512: secp256k1_ec_privkey_negate - fix documentation
ec0a7b3ae3 Don't touch leading zeros in wnaf_fixed.
9e36d1bfe2 Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar.
96f68a0afc Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros.
8b3841c91d fix bug in fread() failure check
cddef0c0be tests: add warning message when /dev/urandom fails
9b7c47a21e Fix typo
6dbb007869 Increase sparsity of pippenger fixed window naf representation
1646ace4d5 secp256k1_ec_privkey_negate - fix documentation
270f6c80db Portability fix for the configure scripts generated
9b3ff0309d add a couple missing `const`s to ecmult_pippenger_wnaf
cd329dbc3e Merge #460: [build] Update ax_jni_include_dir.m4 macro
7f9c1a1565 Merge #498: tests: Avoid calling fclose(...) with an invalid argument
f99aa8d4d3 Merge #499: tests: Make sure we get the requested number of bytes from /dev/urandom
b549d3d5f7 Merge #472: [build] Set --enable-jni to no by default instead of auto.
d333521516 Merge #494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
2ef8ea5d21 Merge #495: Add bench_ecmult to .gitignore
82a96e4587 tests: Make sure we get the requested number of bytes from /dev/urandom
5aae5b5bb2 Avoid calling fclose(...) with an invalid argument
cb32940df3 Add bench_ecmult to .gitignore
31abd3ab8d Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
c95f6f1360 Merge #487: fix tests typo, s/changed/unchanged
fb46c83881 Merge #463: Reduce usage of hardcoded size constants
02f5001dfc Merge #490: Disambiguate bench functions and types
1f46d6089e Disambiguate bench functions and types
f54c6c5083 Merge #480: Enable benchmark building by default
c77fc08597 Merge #486: Add pippenger_wnaf for multi-multiplication
d2f9c6b5dc Use more precise pippenger bucket windows
4c950bbeaf Save some additions per window in _pippenger_wnaf
a58f543f5a Add flags for choosing algorithm in ecmult_multi benchmark
36b22c9337 Use scratch space dependent batching in ecmult_multi
355a38f113 Add pippenger_wnaf ecmult_multi
bc65aa794e Add bench_ecmult
dba5471b69 Add ecmult_multi tests
8c1c831bdb Generalize Strauss to support multiple points
548de42ecf add resizeable scratch space API
0e96cdc6b6 fix typo, s/changed/unchanged
c7680e570f Reduce usage of hardcoded size constants
6ad5cdb42a Merge #479: Get rid of reserved _t in type names
7a78f60598 Print whether we're building benchmarks
4afec9f1ae Build benchmarks by default
d1dc9dfc0a Get rid of reserved _t in type names
0b70241850 Merge #474: Fix header guards using reserved identifiers
ab1f89f00a Merge #478: Fixed multiple typos
8c7ea22d54 Fixed multiple typos
abe2d3e84b Fix header guards using reserved identifiers
57752d28b3 [build] Set --enable-jni to no by default instead of auto.
f532bdc9f7 Merge #459: Add pubkey prefix constants to include/secp256k1.h
cac7c5559d Merge #470: Fix wnaf_const documentation
768514bac0 Fix wnaf_const documentation with respect to return value and number of words set
b8c26a3990 Merge #458: Fix typo in API documentation
817fb2013a Merge #440: Fix typos
12230f90ed Merge #468: Remove redundant conditional expression
2e1ccdca0d Remove redundant conditional expression
e7daa9b3c2 [build] Tweak JNI macro to warn instead of error for JNI not found.
5b22977922 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS
bc61b91aca add pubkey prefix constants to include/secp256k1.h
b0452e664b Fix typo in API documentation
84973d393a Merge #454: Remove residual parts from the schnorr expirement.
5e95bf2285 Remove residual parts from the schnorr expirement.
cbc20b8c34 Merge #452: Minor optimizations to _scalar_inverse to save 4M
4cc8f52505 Merge #437: Unroll secp256k1_fe_(get|set)_b32 to make them much faster.
465159c278 Further shorten the addition chain for scalar inversion.
a2b6b1914f Fix benchmark print_number infinite loop.
8b7680a826 Unroll secp256k1_fe_(get|set)_b32 for 10x26.
aa8499080e Unroll secp256k1_fe_(get|set)_b32 for 5x52.
cf12fa13cb Minor optimizations to _scalar_inverse to save 4M
119949232a Merge #408: Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
6af0871070 Merge #441: secp256k1_context_randomize: document.
ab31a524b4 Merge #444: test: Use checked_alloc
eda5c1a062 Merge #449: Remove executable bit from secp256k1.c
51b77ae619 Remove executable bit from secp256k1.c
5eb030ca41 test: Use checked_alloc
72d952c9c4 FIXUP: Missing "is"
70ff29b6a7 secp256k1_context_randomize: document.
4c0f32ed51 Fix typo: "Agressive" → "Aggressive"
73aca8364f Fix typo: "exectured" → "executed"
9d560f992d Merge #428: Exhaustive recovery
8e48aa60dc Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
2cee5fd4c9 exhaustive tests: add recovery module
678b0e5466 exhaustive tests: remove erroneous comment from ecdsa_sig_sign
03ff8c2d0a group_impl.h: remove unused `secp256k1_ge_set_infinity` function
a724d7296d configure: add --enable-coverage to set options for coverage analysis
b595163992 recovery: add tests to cover API misusage
6f8ae2f3c0 ecdh: test NULL-checking of arguments
25e3cfbf9b ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign
git-subtree-dir: src/secp256k1
git-subtree-split: 44c2452fd387f7ca604ab42d73746e7d3a44d8a2
str4d
added a commit
to str4d/zcash
that referenced
this pull request
Apr 21, 2023
be8d9c262f Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM aeece44599 gen_context: Don't use any ASM 7688a4f13a Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups 90e83449b2 ci: Add C++ test f698caaff6 Use unsigned char consistently for byte arrays b5b8e7b719 Don't declare constants twice 769528f307 Don't use string literals for char arrays without NUL termination 2cc3cfa583 Fix -Wmissing-braces warning in clang 0440945fb5 Merge zcash#844: schnorrsig API overhaul ec3aaa5014 Merge zcash#960: tests_exhaustive: check the result of secp256k1_ecdsa_sign a1ee83c654 tests_exhaustive: check the result of secp256k1_ecdsa_sign 253f90cdeb Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG 446d28d9de Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS 0302138f75 ci: Make compiler warning into errors on CI b924e1e605 build: Ensure that configure's compile checks default to -O2 7939cd571c build: List *CPPFLAGS before *CFLAGS like on the compiler command line 595e8a35d8 build: Enable -Wcast-align=strict warning 07256267ff build: Use own variable SECP_CFLAGS instead of touching user CFLAGS 4866178dfc Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests 75ce488c2a Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse 41ed13942b tests: really test the non-var scalar inverse 5f6ceafcfa schnorrsig: allow setting MSGLEN != 32 in benchmark fdd06b7967 schnorrsig: add tests for sign_custom and varlen msg verification d8d806aaf3 schnorrsig: add extra parameter struct for sign_custom a0c3fc177f schnorrsig: allow signing and verification of variable length msgs 5a8e4991ad Add secp256k1_tagged_sha256 as defined in BIP-340 b6c0b72fb0 schnorrsig: remove noncefp args from sign; add sign_custom function bdf19f105c Add random field multiply/square tests 8ae56e33e7 Merge zcash#879: Avoid passing out-of-bound pointers to 0-size memcpy a4642fa15e configure: replace AC_PATH_PROG to AC_CHECK_PROG 442cee5baf schnorrsig: add algolen argument to nonce_function_hardened df3bfa12c3 schnorrsig: clarify result of calling nonce_function_bip340 without data 99e8614812 README: mention schnorrsig module 9570f674cc Avoid passing out-of-bound pointers to 0-size memcpy git-subtree-dir: src/secp256k1 git-subtree-split: be8d9c262f46309d9b4165b0498b71d704aba8fe
vmta
added a commit
to umkoin/umkoin
that referenced
this pull request
Jun 4, 2023
60556c9f4 Merge bitcoin-core/secp256k1#1337: ci: Fix error D8037 in `cl.exe` (attempt 2) db29bf220 ci: Remove quirk that runs dummy command after wineserver c7db4942b ci: Fix error D8037 in `cl.exe` 7dae11586 Revert "ci: Move wine prefix to /tmp to avoid error D8037 in cl.exe" bf29f8d0a Merge bitcoin-core/secp256k1#1334: fix input range comment for `secp256k1_fe_add_int` 605e07e36 fix input range comment for `secp256k1_fe_add_int` debf3e5c0 Merge bitcoin-core/secp256k1#1330: refactor: take use of `secp256k1_scalar_{zero,one}` constants d75dc59b5 Merge bitcoin-core/secp256k1#1333: test: Warn if both `VERIFY` and `COVERAGE` are defined ade5b3670 tests: add checks for scalar constants `secp256k1_scalar_{zero,one}` e83801f5d test: Warn if both `VERIFY` and `COVERAGE` are defined 654246c63 refactor: take use of `secp256k1_scalar_{zero,one}` constants 908e02d59 Merge bitcoin-core/secp256k1#1328: build: Bump MSVC warning level up to W3 1549db0ca build: Level up MSVC warnings 20a5da5fb Merge bitcoin-core/secp256k1#1310: Refine release process ad8460329 release process: clarify change log updates 6348bc7ee release process: fix process for maintenance release 79fa50b08 release process: mention targeted release schedule 165206789 release process: add sanity checks 09df0bfb2 Merge bitcoin-core/secp256k1#1327: ci: Move wine prefix to /tmp to avoid error D8037 in cl.exe 27504d5c9 ci: Move wine prefix to /tmp to avoid error D8037 in cl.exe d373a7215 Merge bitcoin-core/secp256k1#1316: Do not invoke fe_is_zero on failed set_b32_limit 6433175ff Do not invoke fe_is_zero on failed set_b32_limit 5f7903c73 Merge bitcoin-core/secp256k1#1318: build: Enable -DVERIFY for precomputation binaries e9e4526a4 Merge bitcoin-core/secp256k1#1317: Make fe_cmov take max of magnitudes 5768b5022 build: Enable -DVERIFY for precomputation binaries 31b4bbee1 Make fe_cmov take max of magnitudes 83186db34 Merge bitcoin-core/secp256k1#1314: release cleanup: bump version after 0.3.2 95448ef2f release cleanup: bump version after 0.3.2 acf5c55ae Merge bitcoin-core/secp256k1#1312: release: Prepare for 0.3.2 d490ca204 release: Prepare for 0.3.2 3e3d125b8 Merge bitcoin-core/secp256k1#1309: changelog: Catch up e8295d07a Merge bitcoin-core/secp256k1#1311: Revert "Remove unused scratch space from API" 697e1ccf4 changelog: Catch up 3ad1027a4 Revert "Remove unused scratch space from API" 76b43f344 changelog: Add entry for #1303 7d4f86d24 Merge bitcoin-core/secp256k1#1307: Mark more assembly outputs as early clobber b54a0672e Merge bitcoin-core/secp256k1#1304: build: Rename arm to arm32 and check if it's really supported c6bb29b30 build: Rename `64bit` to `x86_64` 8c9ae37a5 Add release note 03246457a autotools: Add `SECP_ARM32_ASM_CHECK` macro ed4ba238e cmake: Add `check_arm32_assembly` function 350b4bd6e Mark stack variables as early clobber for technical correctness 0c729ba70 Bugfix: mark outputs as early clobber in scalar x86_64 asm 3353d3c75 Merge bitcoin-core/secp256k1#1207: Split fe_set_b32 into reducing and normalizing variants 5b3260229 Split fe_set_b32 into reducing and normalizing variants 006ddc1f4 Merge bitcoin-core/secp256k1#1306: build: Make tests work with external default callbacks 1907f0f16 build: Make tests work with external default callbacks fb3a80636 Merge bitcoin-core/secp256k1#1133: schnorrsig: Add test vectors for variable-length messages cd54ac7c1 schnorrsig: Improve docs of schnorrsig_sign_custom 28687b031 schnorrsig: Add BIP340 varlen test vectors 97a98bed1 schnorrsig: Refactor test vector code to allow varlen messages ab5a91712 Merge bitcoin-core/secp256k1#1303: ct: Use more volatile 9eb6934f6 Merge bitcoin-core/secp256k1#1305: Remove unused scratch space from API 073d98a07 Merge bitcoin-core/secp256k1#1292: refactor: Make 64-bit shift explicit 17fa21733 ct: Be cautious and use volatile trick in more "conditional" paths 5fb336f9c ct: Use volatile trick in scalar_cond_negate 712e7f872 Remove unused scratch space from API 54d34b6c2 Merge bitcoin-core/secp256k1#1300: Avoid normalize conditional on VERIFY c63ec88eb Merge bitcoin-core/secp256k1#1066: Abstract out and merge all the magnitude/normalized logic 7fc642fa2 Simplify secp256k1_fe_{impl_,}verify 4e176ad5b Abstract out verify logic for fe_is_square_var 4371f9834 Abstract out verify logic for fe_add_int 89e324c6b Abstract out verify logic for fe_half 283cd80ab Abstract out verify logic for fe_get_bounds d5aa2f035 Abstract out verify logic for fe_inv{,_var} 316764607 Abstract out verify logic for fe_from_storage 76d31e504 Abstract out verify logic for fe_to_storage 1e6894bdd Abstract out verify logic for fe_cmov be82bd8e0 Improve comments/checks for fe_sqrt 6ab35082e Abstract out verify logic for fe_sqr 4c25f6efb Abstract out verify logic for fe_mul e179e651c Abstract out verify logic for fe_add 7e7ad7ff5 Abstract out verify logic for fe_mul_int 65d82a344 Abstract out verify logic for fe_negate 144670893 Abstract out verify logic for fe_get_b32 f7a7666ae Abstract out verify logic for fe_set_b32 ce4d2093e Abstract out verify logic for fe_cmp_var 7d7d43c6d Improve comments/check for fe_equal{,_var} c5e788d67 Abstract out verify logic for fe_is_odd d3f3fe861 Abstract out verify logic for fe_is_zero c701d9a47 Abstract out verify logic for fe_clear 19a2bfeee Abstract out verify logic for fe_set_int 864f9db49 Abstract out verify logic for fe_normalizes_to_zero{,_var} 6c3137112 Abstract out verify logic for fe_normalize_var e28b51f52 Abstract out verify logic for fe_normalize_weak b6b6f9cb9 Abstract out verify logic for fe_normalize 7fa519555 Bugfix: correct SECP256K1_FE_CONST mag/norm fields e5cf4bf3f build: Rename `arm` to `arm32` b29566c51 Merge magnitude/normalized fields, move/improve comments 97c63b903 Avoid normalize conditional on VERIFY 341cc1972 Merge bitcoin-core/secp256k1#1299: Infinity handling: ecmult_const(infinity) works, and group verification bbc834467 Avoid secp256k1_ge_set_gej_zinv with uninitialized z 0a2e0b2ae Make secp256k1_{fe,ge,gej}_verify work as no-op if non-VERIFY f20266722 Add invariant checking to group elements a18821d5b Always initialize output coordinates in secp256k1_ge_set_gej 3086cb90a Expose secp256k1_fe_verify to other modules a0e696fd4 Make secp256k1_ecmult_const handle infinity 24c768ae0 Merge bitcoin-core/secp256k1#1301: Avoid using bench_verify_data as bench_sign_data; merge them 2e65f1fdb Avoid using bench_verify_data as bench_sign_data; merge them 1cf15ebd9 Merge bitcoin-core/secp256k1#1296: docs: complete interface description for `secp256k1_schnorrsig_sign_custom` 149c41cee docs: complete interface description for `secp256k1_schnorrsig_sign_custom` f30c74866 Merge bitcoin-core/secp256k1#1270: cmake: Fix library ABI versioning d1e48e547 refactor: Make 64-bit shift explicit b2e29e43d ci: Treat all compiler warnings as errors in "Windows (VS 2022)" task 3c8183885 Merge bitcoin-core/secp256k1#1289: cmake: Use full signature of `add_test()` command 755629bc0 cmake: Use full signature of `add_test()` command bef448f9a cmake: Fix library ABI versioning 4b0f711d4 Merge bitcoin-core/secp256k1#1277: autotools: Clean up after adding Wycheproof 222ecaf66 Merge bitcoin-core/secp256k1#1284: cmake: Some improvements using `PROJECT_IS_TOP_LEVEL` variable 71f746c05 cmake: Include `include` directory for subtree builds 024a40948 Merge bitcoin-core/secp256k1#1240: cmake: Improve and document compiler flag checks a8d059f76 cmake, doc: Document compiler flags 6ece1507c cmake, refactor: Rename `try_add_compile_option` to `try_append_cflags` 19516ed3e cmake: Use `add_compile_options()` in `try_add_compile_option()` 4b84f4bf0 Merge bitcoin-core/secp256k1#1239: cmake: Bugfix and other improvements after bumping CMake up to 3.13 596b336ff Merge bitcoin-core/secp256k1#1234: cmake: Add dev-mode 6b7e5b717 Merge bitcoin-core/secp256k1#1275: build: Fix C4005 "macro redefinition" MSVC warnings in examples 1c8953671 Merge bitcoin-core/secp256k1#1286: tests: remove extra semicolon in macro c4062d6b5 debug: move helper for printing buffers into util.h 7e977b3c5 autotools: Take VPATH builds into account when generating testvectors 2418d3260 autotools: Create src/wycheproof dir before creating file in it 8764034ed autotools: Make all "pregenerated" targets .PHONY e1b9ce881 autotools: Use same conventions for all pregenerated files 3858bad2c tests: remove extra semicolon in macro 1f33bb2b1 Merge bitcoin-core/secp256k1#1205: field: Improve docs +tests of secp256k1_fe_set_b32 162da73e9 tests: Add debug helper for printing buffers e9fd3dff7 field: Improve docs and tests of secp256k1_fe_set_b32 f6bef03c0 Merge bitcoin-core/secp256k1#1283: Get rid of secp256k1_fe_const_b 5431b9dec cmake: Make `SECP256K1_INSTALL` default depend on `PROJECT_IS_TOP_LEVEL` 5ec1333d4 Merge bitcoin-core/secp256k1#1285: bench: Make sys/time.h a system include 68b16a166 bench: Make sys/time.h a system include 162608cc9 cmake: Emulate `PROJECT_IS_TOP_LEVEL` for CMake<3.21 69e1ec033 Get rid of secp256k1_fe_const_b ce5ba9e24 gitignore: Add CMakeUserPresets.json 0a446a312 cmake: Add dev-mode CMake preset a6f4bcf6e Merge bitcoin-core/secp256k1#1231: Move `SECP256K1_INLINE` macro definition out from `include/secp256k1.h` a273d74b2 cmake: Improve version comparison 6a58b483e cmake: Use `if(... IN_LIST ...)` command 2445808c0 cmake: Use dedicated `GENERATOR_IS_MULTI_CONFIG` property 9f8703ef1 cmake: Use dedicated `CMAKE_HOST_APPLE` variable 8c2017035 cmake: Use recommended `add_compile_definitions` command 04d4cc071 cmake: Add `DESCRIPTION` and `HOMEPAGE_URL` options to `project` command 8a8b6536e cmake: Use `SameMinorVersion` compatibility mode 5b0444a3b Merge bitcoin-core/secp256k1#1263: cmake: Make installation optional 47ac3d63c cmake: Make installation optional 2e035af25 Merge bitcoin-core/secp256k1#1273: build: Make `SECP_VALGRIND_CHECK` preserve `CPPFLAGS` 5be353d65 Merge bitcoin-core/secp256k1#1279: tests: lint wycheproof's python script 08f4b1632 autotools: Move code around to tidy Makefile 04bf3f677 Merge bitcoin-core/secp256k1#1230: Build: allow static or shared but not both 9ce9984f3 Merge bitcoin-core/secp256k1#1265: Remove bits argument from secp256k1_wnaf_const{_xonly} 566faa17d Merge bitcoin-core/secp256k1#1267: doc: clarify process for patch releases ef49a11d2 build: allow static or shared but not both 35ada3b95 tests: lint wycheproof's python script 4258c54f4 Merge bitcoin-core/secp256k1#1276: autotools: Don't regenerate Wycheproof header automatically 529b54d92 autotools: Move Wycheproof header from EXTRA_DIST to noinst_HEADERS 06c67dea9 autotools: Don't regenerate Wycheproof header automatically dc0657c76 build: Fix C4005 "macro redefinition" MSVC warnings in examples 1ecb94ebe build: Make `SECP_VALGRIND_CHECK` preserve `CPPFLAGS` 3bab71cf0 Merge bitcoin-core/secp256k1#1268: release cleanup: bump version after 0.3.1 656c6ea8d release cleanup: bump version after 0.3.1 346a053d4 Merge bitcoin-core/secp256k1#1269: changelog: Fix link 6a37b2a5e changelog: Fix link ec98fcedd Merge bitcoin-core/secp256k1#1266: release: Prepare for 0.3.1 1b6fb5593 doc: clarify process for patch releases 898e1c676 release: Prepare for 0.3.1 1d9a13fc2 changelog: Remove inconsistent newlines 0e091669a changelog: Catch up in preparation of 0.3.1 7b7503dac Merge bitcoin-core/secp256k1#1245: tests: Add Wycheproof ECDSA vectors a575339c0 Remove bits argument from secp256k1_wnaf_const (always 256) 145078c41 Merge bitcoin-core/secp256k1#1118: Add x-only ecmult_const version with x specified as n/d e5de45460 tests: Add Wycheproof ECDSA vectors 0f8642079 Add exhaustive tests for ecmult_const_xonly 4485926ac Add x-only ecmult_const version for x=n/d a0f4644f7 Merge bitcoin-core/secp256k1#1252: Make position of * in pointer declarations in include/ consistent 4e682626a Merge bitcoin-core/secp256k1#1226: Add CMake instructions to release process 2d51a454f Merge bitcoin-core/secp256k1#1257: ct: Use volatile "trick" in all fe/scalar cmov implementations 4a496a36f ct: Use volatile "trick" in all fe/scalar cmov implementations 3d1f430f9 Make position of * in pointer declarations in include/ consistent 2bca0a5cb Merge bitcoin-core/secp256k1#1241: build: Improve `SECP_TRY_APPEND_DEFAULT_CFLAGS` macro afd8b23b2 Merge bitcoin-core/secp256k1#1244: Suppress `-Wunused-parameter` when building for coverage analysis 1d8f36751 Merge bitcoin-core/secp256k1#1250: No need to subtract 1 before doing a right shift 3e43041be No need to subtract 1 before doing a right shift 3addb4c1e build: Improve `SECP_TRY_APPEND_DEFAULT_CFLAGS` macro 0c07c8283 Add CMake instructions to release process 464a9115b Merge bitcoin-core/secp256k1#1242: Set ARM ASM symbol visibility to `hidden` f16a709fd Merge bitcoin-core/secp256k1#1247: Apply Checks only in VERIFY mode. 70be3cade Merge bitcoin-core/secp256k1#1246: Typo 4ebd82852 Apply Checks only in VERIFY mode. d1e7ca192 Typo 36b0adf1b build: remove warning until it's reproducible 5bb03c291 Replace `SECP256K1_ECMULT_TABLE_VERIFY` macro by a function 9c8c4f443 Merge bitcoin-core/secp256k1#1238: build: bump CMake minimum requirement to 3.13 0cf2fb91e Merge bitcoin-core/secp256k1#1243: build: Ensure no optimization when building for coverage analysis fd2a40864 Set ARM ASM symbol visibility to `hidden` 4429a8c21 Suppress `-Wunused-parameter` when building for coverage analysis 8e79c7ed1 build: Ensure no optimization when building for coverage analysis 96dd06251 build: bump CMake minimum requirement to 3.13 427bc3cdc Merge bitcoin-core/secp256k1#1236: Update comment for secp256k1_modinv32_inv256 647f0a5cb Update comment for secp256k1_modinv32_inv256 8e142ca41 Move `SECP256K1_INLINE` macro definition out from `include/secp256k1.h` 77445898a Remove `SECP256K1_INLINE` usage from examples 565820945 Merge bitcoin-core/secp256k1#1228: release cleanup: bump version after 0.3.0 bdf39000b Merge bitcoin-core/secp256k1#1223: release: prepare for 0.3.0 28e63f7ea release cleanup: bump version after 0.3.0 b40adf236 release: prepare for 0.3.0 90b513aad Merge bitcoin-core/secp256k1#1229: cmake: Rename project to "libsecp256k1" 8be82d436 cmake: Rename project to "libsecp256k1" ef4f8bd02 Merge bitcoin-core/secp256k1#1227: readme: Use correct build type in CMake/Windows build instructions 756b61d45 readme: Use correct build type in CMake/Windows build instructions 3295aa149 Merge bitcoin-core/secp256k1#1225: changelog: Add entry for CMake 92098d84c changelog: Add entry for CMake df323b5c1 Merge bitcoin-core/secp256k1#1113: build: Add CMake-based build system e1eb33724 ci: Add "x86_64: Windows (VS 2022)" task 10602b003 cmake: Export config files 5468d7096 build: Add CMake-based build system 6048e6c03 Merge bitcoin-core/secp256k1#1222: Remove redundant checks. eb8749fcd Merge bitcoin-core/secp256k1#1221: Update Changelog 5d8f53e31 Remove redudent checks. 9d1b458d5 Merge bitcoin-core/secp256k1#1217: Add secp256k1_fe_add_int function d232112fa Update Changelog 8962fc95b Merge bitcoin-core/secp256k1#1218: Update overflow check 2ef1c9b38 Update overflow check 575731878 Merge bitcoin-core/secp256k1#1212: Prevent dead-store elimination when clearing secrets in examples b081f7e4c Add secp256k1_fe_add_int function 5660c1375 prevent optimization in algorithms 09b1d466d Merge bitcoin-core/secp256k1#979: Native jacobi symbol algorithm ce3cfc78a doc: Describe Jacobi calculation in safegcd_implementation.md 6be01036c Add secp256k1_fe_is_square_var function 1de2a01c2 Native jacobi symbol algorithm 04c6c1b18 Make secp256k1_modinv64_det_check_pow2 support abs val 5fffb2c7a Make secp256k1_i128_check_pow2 support -(2^n) cbd255593 Merge bitcoin-core/secp256k1#1209: build: Add SECP256K1_API_VAR to fix importing variables from DLLs 1b21aa517 Merge bitcoin-core/secp256k1#1078: group: Save a normalize_to_zero in gej_add_ge e4330341b ci: Shutdown wineserver whenever CI script exits 9a5a611a2 build: Suppress stupid MSVC linker warning 739c53b19 examples: Extend sig examples by call that uses static context 914276e4d build: Add SECP256K1_API_VAR to fix importing variables from DLLs 1cca7c174 Merge bitcoin-core/secp256k1#1206: build: Add -Wreserved-identifier supported by clang 8c7e0fc1d build: Add -Wreserved-identifier supported by clang ca92a35d0 field: Simplify code in secp256k1_fe_set_b32 d93f62e36 field: Verify field element even after secp256k1_fe_set_b32 fails 8ebe5c520 Merge bitcoin-core/secp256k1#1201: ci: Do not set git's `user.{email,name}` config options 5596ec5c2 Merge bitcoin-core/secp256k1#1203: Do not link `bench` and `ctime_tests` to `COMMON_LIB` ef39721cc Do not link `bench` and `ctime_tests` to `COMMON_LIB` 9b60e3148 ci: Do not set git's `user.{email,name}` config options e1817a6f5 Merge bitcoin-core/secp256k1#1199: ci: Minor improvements inspired by Bitcoin Core 1bff20058 Merge bitcoin-core/secp256k1#1200: Drop no longer used Autoheader macros 9b7d18669 Drop no longer used Autoheader macros c2415866c ci: Don't fetch git history 0ecf31885 ci: Use remote pull/merge ref instead of local git merge 2b77240b3 Merge bitcoin-core/secp256k1#1172: benchmarks: fix bench_scalar_split eb6bebaee scalar: restrict split_lambda args, improve doc and VERIFY_CHECKs 7f49aa7f2 ci: add test job with -DVERIFY 620ba3d74 benchmarks: fix bench_scalar_split 5fbff5d34 Merge bitcoin-core/secp256k1#1170: contexts: Forbid destroying, cloning and randomizing the static context 233822d84 Merge bitcoin-core/secp256k1#1195: ctime_tests: improve output when CHECKMEM_RUNNING is not defined ad7433b14 Merge bitcoin-core/secp256k1#1196: Drop no longer used variables from the build system e39d954f1 tests: Add CHECK_ILLEGAL(_VOID) macros and use in static ctx tests 2cd4e3c0a Drop no longer used `SECP_{LIBS,INCLUDE}` variables 613626f94 Drop no longer used `SECP_TEST_{LIBS,INCLUDE}` variables 61841fc9e contexts: Forbid randomizing secp256k1_context_static 4b6df5e33 contexts: Forbid cloning/destroying secp256k1_context_static b1579cf5f Merge bitcoin-core/secp256k1#1194: Ensure safety of ctz_debruijn implementation. 8f51229e0 ctime_tests: improve output when CHECKMEM_RUNNING is not defined d6ff738d5 Ensure safety of ctz_debruijn implementation. a01a7d86d Merge bitcoin-core/secp256k1#1192: Switch to exhaustive groups with small B coefficient a7a7bfaf3 Merge bitcoin-core/secp256k1#1190: Make all non-API functions (except main) static f29a32709 Merge bitcoin-core/secp256k1#1169: Add support for msan instead of valgrind (for memcheck and ctime test) ff8edf89e Merge bitcoin-core/secp256k1#1193: Add `noverify_tests` to `.gitignore` ce60785b2 Introduce SECP256K1_B macro for curve b coefficient 4934aa799 Switch to exhaustive groups with small B coefficient d4a6b58df Add `noverify_tests` to `.gitignore` 88e80722d Merge bitcoin-core/secp256k1#1160: Makefile: add `-I$(top_srcdir)/{include,src}` to `CPPFLAGS` for precomputed 0f088ec11 Rename CTIMETEST -> CTIMETESTS 74b026f05 Add runtime checking for DECLASSIFY flag 5e2e6fcfc Run ctime test in Linux MSan CI job 18974061a Make ctime tests building configurable 5048be17e Rename valgrind_ctime_test -> ctime_tests 6eed6c18d Update error messages to suggest msan as well 8e11f89a6 Add support for msan integration to checkmem.h 8dc64079e Add compile-time error to valgrind_ctime_test 0db05a770 Abstract interactions with valgrind behind new checkmem.h 4f1a54e41 Move valgrind CPPFLAGS into SECP_CONFIG_DEFINES cc3b8a4f4 Merge bitcoin-core/secp256k1#1187: refactor: Rename global variables in tests 9a93f48f5 refactor: Rename STTC to STATIC_CTX in tests 3385a2648 refactor: Rename global variables to uppercase in tests e03ef8655 Make all non-API functions (except main) static cbe41ac13 Merge bitcoin-core/secp256k1#1188: tests: Add noverify_tests which is like tests but without VERIFY 203760023 tests: Add noverify_tests which is like tests but without VERIFY e862c4af0 Makefile: add -I$(top_srcdir)/src to CPPFLAGS for precomputed 0eb300041 Merge bitcoin-core/secp256k1#1186: tests: Tidy context tests 39e8f0e3d refactor: Separate run_context_tests into static vs proper contexts a4a09379b tests: Clean up and improve run_context_tests() further fc90bb569 refactor: Tidy up main() f32a36f62 tests: Don't use global context for context tests ce4f936c4 tests: Tidy run_context_tests() by extracting functions 18e0db30c tests: Don't recreate global context in scratch space test b19806122 tests: Use global copy of secp256k1_context_static instead of clone 2a39ac162 Merge bitcoin-core/secp256k1#1185: Drop `SECP_CONFIG_DEFINES` from examples 2f9ca284e Drop `SECP_CONFIG_DEFINES` from examples 31ed5386e Merge bitcoin-core/secp256k1#1183: Bugfix: pass SECP_CONFIG_DEFINES to bench compilation c0a555b2a Bugfix: pass SECP_CONFIG_DEFINES to bench compilation 01b819a8c Merge bitcoin-core/secp256k1#1158: Add a secp256k1_i128_to_u64 function. eacad90f6 Merge bitcoin-core/secp256k1#1171: Change ARG_CHECK_NO_RETURN to ARG_CHECK_VOID which returns (void) 3f57b9f77 Merge bitcoin-core/secp256k1#1177: Some improvements to the changelog c30b889f1 Clarify that the ABI-incompatible versions are earlier 881fc33d0 Consistency in naming of modules 665ba77e7 Merge bitcoin-core/secp256k1#1178: Drop `src/libsecp256k1-config.h` 75d7b7f5b Merge bitcoin-core/secp256k1#1154: ci: set -u in cirrus.sh to treat unset variables as an error 7a7468820 ci: add missing CFLAGS & CPPFLAGS variable to print_environment c2e0fdade ci: set -u in cirrus.sh to treat unset variables as an error 9c5a4d21b Do not define unused `HAVE_VALGRIND` macro ad8647f54 Drop no longer relevant files from `.gitignore` b627ba705 Remove dependency on `src/libsecp256k1-config.h` 9ecf8149a Reduce font size in changelog 2dc133a67 Add more changelog entries ac233e181 Add links to diffs to changelog cee8223ef Mention semantic versioning in changelog 9a8d65f07 Merge bitcoin-core/secp256k1#1174: release cleanup: bump version after 0.2.0 02ebc290f release cleanup: bump version after 0.2.0 b6b360efa doc: improve message of cleanup commit 21ffe4b22 Merge bitcoin-core/secp256k1#1055: Prepare initial release e025ccdf7 release: prepare for initial release 0.2.0 6d1784a2e build: add missing files to EXTRA_DIST 8c949f56d Merge bitcoin-core/secp256k1#1173: Don't use compute credits for now 13bf1b6b3 changelog: make order of change types match keepachangelog.com b1f992a55 doc: improve release process 7e5b22684 Don't use compute credits for now a49e0940a docs: Fix typo 2551cdac9 tests: Fix code formatting c635c1bfd Change ARG_CHECK_NO_RETURN to ARG_CHECK_VOID which returns (void) cf66f2357 refactor: Add helper function secp256k1_context_is_proper() ad39e2dc4 build: change package version to 0.1.0-dev 5c789dcd7 Merge bitcoin-core/secp256k1#1168: Replace deprecated context flags with NONE in benchmarks and tests d6dc0f4ae tests: Switch to NONE contexts in module tests 0c8a5cadd tests: Switch to NONE contexts in tests.c 86540e9e1 tests: add test for deprecated flags and rm them from run_context caa0ad631 group: add gej_eq_var 37ba744f5 tests: Switch to NONE contexts in exhaustive and ctime tests 8d7a9a8ed benchmarks: Switch to NONE contexts 90618e926 doc: move CHANGELOG from doc/ to root directory e3f84777e Merge bitcoin-core/secp256k1#1126: API cleanup with respect to contexts 4386a2306 examples: Switch to NONE contexts 7289b51d3 docs: Use doxygen style if and only if comment is user-facing e7d0185c9 docs: Get rid of "initialized for signing" terminology 06126364a docs: Tidy and improve docs about contexts and randomization e02d6862b selftest: Expose in public API e383fbfa6 selftest: Rename internal function to make name available for API d2c6d48de tests: Use new name of static context 53796d2b2 contexts: Rename static context 72fedf8a6 docs: Improve docs for static context 316ac7625 contexts: Deprecate all context flags except SECP256K1_CONTEXT_NONE 477f02c4d Merge bitcoin-core/secp256k1#1165: gitignore: Add *.sage.py files autogenerated by sage [skip ci] 092be61c5 gitignore: Add *.sage.py files autogenerated by sage 1a553ee8b docs: Change signature "validation" to "verification" ee7341fba docs: Never require a verification context 751c4354d Merge bitcoin-core/secp256k1#1152: Update macOS image for CI 2286f8090 Merge bitcoin-core/secp256k1#993: Enable non-experimental modules by default d21647520 test secp256k1_i128_to_i64 4bc429019 Add a secp256k1_i128_to_u64 function. e40fd277b Merge bitcoin-core/secp256k1#1156: Followups to int128_struct arithmetic 99bd33559 Make int128 overflow test use secp256k1_[ui]128_mul a8494b02b Use compute credits for macOS jobs 3afce0af7 Avoid signed overflow in MSVC AMR64 secp256k1_mul128 c0ae48c99 Update macOS image for CI 9b5f589d3 Heuristically decide whether to use int128_struct 63ff064d2 int128: Add test override for testing __(u)mulh on MSVC X64 f2b7e8876 Add int128 randomized tests 6138d73be Merge bitcoin-core/secp256k1#1155: Add MSan CI jobs ddf2b2910 Merge bitcoin-core/secp256k1#1000: Synthetic int128 type. 86e3b38a4 Merge bitcoin-core/secp256k1#1149: Remove usage of CHECK from non-test file 00a42b91b Add MSan CI job 44916ae91 Merge bitcoin-core/secp256k1#1147: ci: print env to allow reproducing the job outside of CI c2ee9175e Merge bitcoin-core/secp256k1#1146: ci: prevent "-v/--version: not found" irrelevant error e13fae487 Merge bitcoin-core/secp256k1#1150: ci: always cat test_env.log a340d9500 ci: add int128_struct tests dceaa1f57 int128: Tidy #includes of int128.h and int128_impl.h 2914bccbc Simulated int128 type. 6a965b6b9 Remove usage of CHECK from non-test file 5c9f1a5c3 ci: always cat all logs_snippets 49ae84359 ci: mostly prevent "-v/--version: not found" irrelevant error 4e54c0315 ci: print env to allow reproducing the job outside of CI a43e982bc Merge bitcoin-core/secp256k1#1144: Cleanup `.gitignore` file f5039cb66 Cleanup `.gitignore` file 798727ae1 Revert "Add test logs to gitignore" 41e8704b4 build: Enable some modules by default 694ce8fb2 Merge bitcoin-core/secp256k1#1131: readme: Misc improvements 88b00897e readme: Fix line break 78f5296da readme: Sell "no runtime dependencies" ef48f088a readme: Add IRC channel 9f8a13dc8 Merge bitcoin-core/secp256k1#1128: configure: Remove pkgconfig macros again (reintroduced by mismerge) cabe085bb configure: Remove pkgconfig macros again (reintroduced by mismerge) 3efeb9da2 Merge bitcoin-core/secp256k1#1121: config: Set preprocessor defaults for ECMULT_* config values 6a873cc4a Merge bitcoin-core/secp256k1#1122: tests: Randomize the context with probability 15/16 instead of 1/4 17065f48a tests: Randomize the context with probability 15/16 instead of 1/4 c27ae4514 config: Remove basic-config.h da6514a04 config: Introduce DEBUG_CONFIG macro for debug output of config 63a3565e9 Merge bitcoin-core/secp256k1#1120: ecmult_gen: Skip RNG when creating blinding if no seed is available d0cf55e13 config: Set preprocessor defaults for ECMULT_* config values 55f8bc99d ecmult_gen: Improve comments about projective blinding 7a8695580 ecmult_gen: Simplify code (no observable change) 4cc0b1b66 ecmult_gen: Skip RNG when creating blinding if no seed is available af65d30cc Merge bitcoin-core/secp256k1#1116: build: Fix #include "..." paths to get rid of further -I arguments 40a3473a9 build: Fix #include "..." paths to get rid of further -I arguments 43756da81 Merge bitcoin-core/secp256k1#1115: Fix sepc256k1 -> secp256k1 typo in group.h 069aba812 Fix sepc256k1 -> secp256k1 typo in group.h accadc94d Merge bitcoin-core/secp256k1#1114: `_scratch_destroy`: move `VERIFY_CHECK` after invalid scrach space check cd4703333 Merge bitcoin-core/secp256k1#1084: ci: Add MSVC builds 1827c9bf2 scratch_destroy: move VERIFY_CHECK after invalid scrach space check 49e2acd92 configure: Improve rationale for WERROR_CFLAGS 8dc4b0334 ci: Add a C++ job that compiles the public headers without -fpermissive 51f296a46 ci: Run persistent wineserver to speed up wine 3fb3269c2 ci: Add 32-bit MinGW64 build 9efc2e522 ci: Add MSVC builds 2be6ba0fe configure: Convince autotools to work with MSVC's archiver lib.exe bd81f4140 schnorrsig bench: Suppress a stupid warning in MSVC 44c2452fd Merge bitcoin-core/secp256k1#1105: Don't export symbols in static libraries 6f6cab998 abi: Don't export symbols in static Windows libraries 485f608fa Merge bitcoin-core/secp256k1#1104: Fix the false positive of `SECP_64BIT_ASM_CHECK` 8b013fce5 Merge bitcoin-core/secp256k1#1056: Save negations in var-time group addition 7efc9835a Fix the false positive of `SECP_64BIT_ASM_CHECK` 8746600ee Merge bitcoin-core/secp256k1#1093: hash: Make code agnostic of endianness 2f984ffc4 Save negations in var-time group addition 37d36927d tests: Add tests for _read_be32 and _write_be32 912b7ccc4 Merge bitcoin-core/secp256k1#1094: doc: Clarify configure flags for optional modules 55512d30b doc: clean up module help text in configure.ac d9d94a996 doc: mention optional modules in README 616b43dd3 util: Remove endianness detection 8d89b9e6e hash: Make code agnostic of endianness d0ad5814a Merge bitcoin-core/secp256k1#995: build: stop treating schnorrsig, extrakeys modules as experimental 1ac7e31c5 Merge bitcoin-core/secp256k1#1089: Schnorrsig API improvements 587239dbe Merge bitcoin-core/secp256k1#731: Change SHA256 byte counter from size_t to uint64_t f8d917435 Add SHA256 bit counter tests 7f09d0f31 README: mention that ARM assembly is experimental b8f8b99f0 docs: Fix return value for functions that don't have invalid inputs f813bb0df schnorrsig: Adapt example to new API 99e6568fc schnorrsig: Rename schnorrsig_sign to schnorsig_sign32 and deprecate fc94a2da4 Use SECP256K1_DEPRECATED for existing deprecated API functions 3db056060 Add SECP256K1_DEPRECATED attribute for marking API parts as deprecated 09f3d71c5 configure: Add a few CFLAGS for MSVC 3b4f3d0d4 build: Reject C++ compilers in the preprocessor 1cc094141 configure: Don't abort if the compiler does not define __STDC__ 80cf4eea5 build: stop treating schnorrsig, extrakeys modules as experimental e0508ee9d Merge bitcoin-core/secp256k1#1090: configure: Remove redundant pkg-config code 21b2ebaf7 configure: Remove redundant pkg-config code cca8cbbac configure: Output message when checking for valgrind 1a6be5745 bench: Make benchmarks compile on MSVC 0e5cbd01b Merge bitcoin-core/secp256k1#1088: configure: Use modern way to set AR 0d253d52e configure: Use modern way to set AR 9b514ce1d Add test vector for very long SHA256 messages 8e3dde113 Simplify struct initializer for SHA256 padding eb28464a8 Change SHA256 byte counter from size_t to uint64_t ac83be33d Merge bitcoin-core/secp256k1#1079: configure: Add hidden --enable-dev-mode to enable all the stuff e089eecc1 group: Further simply gej_add_ge e0838d663 configure: Add hidden --enable-dev-mode to enable all the stuff fabd579df configure: Remove redundant code that sets _enable variables 0d4226c05 configure: Use canonical variable prefix _enable consistently 64b34979e Merge bitcoin-core/secp256k1#748: Add usage examples 7c9502cec Add a copy of the CC0 license to the examples 42e03432e Add usage examples to the readme 517644eab Optionally compile the examples in autotools, compile+run in travis 422a7cc86 Add a ecdh shared secret example b0cfbcc14 Add a Schnorr signing and verifying example fee7d4bf9 Add an ECDSA signing and verifying example ac71020eb group: Save a normalize_to_zero in gej_add_ge 1253a2775 Merge bitcoin-core/secp256k1#1033: Add _fe_half and use in _gej_add_ge and _gej_double 3ef94aa5b Merge bitcoin-core/secp256k1#1026: ecdh: Add test computing shared_secret=basepoint with random inputs 3531a43b5 ecdh: Make generator_basepoint test depend on global iteration count c881dd49b ecdh: Add test computing shared_secret=basepoint with random inputs 077528317 Merge bitcoin-core/secp256k1#1074: ci: Retry brew update a few times to avoid random failures e51ad3b73 ci: Retry `brew update` a few times to avoid random failures b1cb969e8 ci: Revert "Attempt to make macOS builds more reliable" 5dcc6f8db Merge bitcoin-core/secp256k1#1069: build: Replace use of deprecated autoconf macro AC_PROG_CC_C89 59547943d Merge bitcoin-core/secp256k1#1072: ci: Attempt to make macOS builds more reliable 85b00a1c6 Merge bitcoin-core/secp256k1#1068: sage: Fix incompatibility with sage 9.4 ebb1beea7 sage: Ensure that constraints are always fastfracs d8d54859e ci: Run sage prover on CI 77cfa98db sage: Normalize sign of polynomial factors in prover eae75869c sage: Exit with non-zero status in case of failures d9396a56d ci: Attempt to make macOS builds more reliable e0db3f8a2 build: Replace use of deprecated autoconf macro AC_PROG_CC_C89 e848c3799 Update sage files for new formulae d64bb5d4f Add fe_half tests for worst-case inputs b54d843ea sage: Fix printing of errors 4eb8b932f Further improve doubling formula using fe_half 557b31fac Doubling formula using fe_half 2cbb4b1a4 Run more iterations of run_field_misc 9cc5c257e Add test for secp256k1_fe_half 925f78d55 Add _fe_half and use in _gej_add_ge e108d0039 sage: Fix incompatibility with sage 9.4 d8a246324 Merge bitcoin-core/secp256k1#899: Reduce stratch space needed by ecmult_strauss_wnaf. 0a40a4861 Merge bitcoin-core/secp256k1#1049: Faster fixed-input ecmult tests 070e77221 Faster fixed-input ecmult tests c8aa516b5 Merge bitcoin-core/secp256k1#1064: Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063 b797a500e Create a SECP256K1_ECMULT_TABLE_VERIFY macro. a731200cc Replace ECMULT_TABLE_GET_GE_STORAGE macro with a function. fe34d9f34 Eliminate input_pos state field from ecmult_strauss_wnaf. 0397d00ba Eliminate na_1 and na_lam state fields from ecmult_strauss_wnaf. 7ba3ffcca Remove the unused pre_a_lam allocations. b3b57ad6e Eliminate the pre_a_lam array from ecmult_strauss_wnaf. ae7ba0f92 Remove the unused prej allocations. e5c18892d Eliminate the prej array from ecmult_strauss_wnaf. c9da1baad Move secp256k1_fe_one to field.h 45f37b650 Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063. a1102b121 Merge bitcoin-core/secp256k1#1029: Simpler and faster ecdh skew fixup e82144edf Fixup skew before global Z fixup 40b624c90 Add tests for _gej_cmov 8c13a9bfe ECDH skews by 0 or 1 151509943 Simpler and faster ecdh skew fixup 39a36db94 Merge bitcoin-core/secp256k1#1054: tests: Fix test whose result is implementation-defined a310e79ee Merge bitcoin-core/secp256k1#1052: Use xoshiro256++ instead of RFC6979 for tests 423b6d19d Merge bitcoin-core/secp256k1#964: Add release-process.md 9281c9f4e Merge bitcoin-core/secp256k1#1053: ecmult: move `_ecmult_odd_multiples_table_globalz_windowa` 77a19750b Use xoshiro256++ PRNG instead of RFC6979 in tests 5f2efe684 secp256k1_testrand_int(2**N) -> secp256k1_testrand_bits(N) 05e049b73 ecmult: move `_ecmult_odd_multiples_table_globalz_windowa` 3d7cbafb5 tests: Fix test whose result is implementation-defined 3ed0d02bf doc: add CHANGELOG template 6f42dc16c doc: add release_process.md 0bd3e4243 build: set library version to 0.0.0 explicitly b4b02fd8c build: change libsecp version from 0.1 to 0.1.0-pre 09971a3ff Merge bitcoin-core/secp256k1#1047: ci: Various improvements 0b83b203e Merge bitcoin-core/secp256k1#1030: doc: Fix upper bounds + cleanup in field_5x52_impl.h comment 1287786c7 doc: Add comment to top of field_10x26_impl.h 58da5bd58 doc: Fix upper bounds + cleanup in field_5x52_impl.h comment b39d431ae Merge bitcoin-core/secp256k1#1044: Add another ecmult_multi test b4ac1a1d5 ci: Run valgrind/memcheck tasks with 2 CPUs e70acab60 ci: Use Cirrus "greedy" flag to use idle CPU time when available d07e30176 ci: Update brew on macOS 22382f0ea ci: Test different ecmult window sizes a69df3ad2 Merge bitcoin-core/secp256k1#816: Improve checks at top of _fe_negate methods 22d25c8e0 Add another ecmult_multi test 515e7953c Improve checks at top of _fe_negate methods 26a022a3a ci: Remove STATICPRECOMPUTATION 10461d8bd precompute_ecmult: Always compute all tables up to default WINDOW_G be6944ade Merge bitcoin-core/secp256k1#1042: Follow-ups to making all tables fully static e05da9e48 Fix c++ build c45386d99 Cleanup preprocessor indentation in precompute{,d}_ecmult{,_gen} 19d96e15f Split off .c file from precomputed_ecmult.h 1a6691ada Split off .c file from precomputed_ecmult_gen.h bb3633141 Simplify precompute_ecmult_print_* 38cd84a0c Compute ecmult tables at runtime for tests_exhaustive e458ec26d Move ecmult table computation code to separate file fc1bf9f15 Split ecmult table computation and printing 31feab053 Rename function secp256k1_ecmult_gen_{create_prec -> compute}_table 725370c3f Rename ecmult_gen_prec -> ecmult_gen_compute_table 075252c1b Rename ecmult_static_pre_g -> precomputed_ecmult 7cf47f72b Rename ecmult_gen_static_prec_table -> precomputed_ecmult_gen f95b8106d Rename gen_ecmult_static_pre_g -> precompute_ecmult bae77685e Rename gen_ecmult_gen_static_prec_table -> precompute_ecmult_gen 0559fc6e4 Merge bitcoin-core/secp256k1#988: Make signing table fully static 7dfceceea build: Remove #undef hack for ASM in the precomputation programs bb36fe9be ci: Test `make precomp` d94a37a20 build: Remove CC_FOR_BUILD stuff ad63bb4c2 build: Prebuild and distribute ecmult_gen table ac49361ed prealloc: Get rid of manual memory management for prealloc contexts 6573c08f6 ecmult_gen: Tidy precomputed file and save space 5eba83f17 ecmult_gen: Precompute tables for all values of ECMULT_GEN_PREC_BITS 5d0dbef01 Merge bitcoin-core/secp256k1#942: Verify that secp256k1_ge_set_gej_zinv does not operate on infinity. 486205aa6 Merge bitcoin-core/secp256k1#920: Test all ecmult functions with many j*2^i combinations fdb33dd12 refactor: Make PREC_BITS a parameter of ecmult_gen_build_prec_table 5eb519e1f ci: reduce TEST_ITERS in memcheck run e2cf77328 Test ecmult functions for all i*2^j for j=0..255 and odd i=1..255. 61ae37c61 Merge bitcoin-core/secp256k1#1022: build: Windows DLL additions 4f01840b8 Merge bitcoin-core/secp256k1#1027: build: Add a check that Valgrind actually supports a host platform 6ad908aa0 Merge bitcoin-core/secp256k1#1008: bench.c: add `--help` option and ci: move env variables 592661c22 ci: move test environment variable declaration to .cirrus.yml dcbe84b84 bench: add --help option to bench. 099bad945 Comment and check a parameter for inf in secp256k1_ecmult_const. 6c0be857f Verify that secp256k1_ge_set_gej_zinv does not operate on infinity. a->x and a->y should not be used if the infinity flag is set. 490022745 Merge bitcoin-core/secp256k1#1025: build: replace backtick command substitution with $() 7c7ce872a build: Add a check that Valgrind actually supports a host platform a4875e30a refactor: Move default callbacks to util.h 4c94c55bc doc: Remove obsolete hint for valgrind stack size 510622699 exhaustive_tests: Fix with ecmult_gen table with custom generator e1a76530d refactor: Make generator a parameter of ecmult_gen_create_prec_table 9ad09f691 refactor: Rename program that generates static ecmult_gen table 8ae18f1ab refactor: Rename file that contains static ecmult_gen table 00d2fa116 ecmult_gen: Make code consistent with comment 3b0c2185e ecmult_gen: Simplify ecmult_gen context after making table static 2b7c7497e build: replace backtick command substitution with $() 49f608de4 Merge bitcoin-core/secp256k1#1004: ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS c0cd7de6d build: add -no-undefined to libtool LDFLAGS fe32a79d3 build: pass win32-dll to LT_INIT 60bf8890d ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS fecf436d5 Merge bitcoin-core/secp256k1#1019: build: don't append valgrind CPPFLAGS if not installed (macOS) 2e5e4b67d Merge bitcoin-core/secp256k1#1020: doc: remove use of <0xa0> "no break space" 812ff5c74 doc: remove use of 0xa0 "no break space" 214042a17 build: don't append valgrind CPPFLAGS if not installed e43ba02cf refactor: Decouple table generation and ecmult_gen context 22dc2c0a0 ecmult_gen: Move table creation to new file and force static prec 793ad9016 Merge bitcoin-core/secp256k1#1010: doc: Minor fixes in safegcd_implementation.md dc9b6853b doc: Minor fixes in safegcd_implementation.md ea5e8a9c4 Merge bitcoin-core/secp256k1#1012: Fix typos 233297579 Fix typos 7006f1b97 Merge bitcoin-core/secp256k1#1011: ci: Enable -g if we set CFLAGS manually 72de1359e ci: Enable -g if we set CFLAGS manually 74c34e727 Merge bitcoin-core/secp256k1#1009: refactor: Use (int)&(int) in boolean context to avoid compiler warning 16d132215 refactor: Use (int)&(int) in boolean context to avoid compiler warning c74a7b7e5 Merge bitcoin-core/secp256k1#1007: doc: Replace apoelstra's GPG key by jonasnick's GPG key 3b157c48e doc: Suggest keys.openpgp.org as keyserver in SECURITY.md 73a7472cd doc: Replace apoelstra's GPG key by jonasnick's GPG key 515a5dbd0 Merge bitcoin-core/secp256k1#991: Merge all "external" benchmarks into a single bench binary af6abcb3d Make bench support selecting which benchmarks to run 9f56bdf5b Merge bench_schnorrsig into bench 3208557ae Merge bench_recover into bench 855e18d8a Merge bench_ecdh into bench 2a7be678a Combine bench_sign and bench_verify into single bench 8fa41201b Merge bitcoin-core/secp256k1#1002: Make aux_rnd32==NULL behave identical to 0x0000..00. 5324f8942 Make aux_rnd32==NULL behave identical to 0x0000..00. 21c188b3c Merge bitcoin-core/secp256k1#943: VERIFY_CHECK precondition for secp256k1_fe_set_int. 3e7b2ea19 Merge bitcoin-core/secp256k1#999: bench_ecmult: improve clarity of output 23e2f6672 bench: don't return 1 in have_flag() if argc = 1 96b1ad2ea bench_ecmult: improve clarity of output 20d791edf Merge bitcoin-core/secp256k1#989: Shared benchmark format for command line and CSV outputs aa1b889b6 Merge bitcoin-core/secp256k1#996: Fix G.y parity in sage code 044d95630 Fix G.y parity in sage code b4b130678 create csv file from the benchmark output 26a255beb Shared benchmark format for command line and CSV outputs 9526874d1 Merge bitcoin-core/secp256k1#810: Avoid overly-wide multiplications in 5x52 field mul/sqr 920a0e5fa Merge bitcoin-core/secp256k1#952: Avoid computing out-of-bounds pointer. f34b5cae0 Merge bitcoin-core/secp256k1#983: [RFC] Remove OpenSSL testing support 297ce8209 Merge bitcoin-core/secp256k1#966: Make aux_rand32 arg to secp256k1_schnorrsig_sign const 288864013 VERIFY_CHECK precondition for secp256k1_fe_set_int. d49011f54 Make _set_fe_int( . , 0 ) set magnitude to 0 bc08599e7 Remove OpenSSL testing support 10f9bd84f Merge bitcoin-core/secp256k1#987: Fix unused parameter warnings when building without VERIFY 189f6bcfe Fix unused parameter warnings when building without VERIFY da0092bcc Merge bitcoin-core/secp256k1#986: tests: remove `secp256k1_fe_verify` from tests.c and modify `_fe_from_storage` to call `_fe_verify` d43993724 tests: remove `secp256k1_fe_verify` from tests.c and modify `secp256k1_fe_from_storage` to call `secp256k1_fe_verify` 2a3a97c66 Merge bitcoin-core/secp256k1#976: `secp256k1_schnorrsig_sign_internal` should be static aa5d34a8f Merge bitcoin-core/secp256k1#783: Make the public API docs more consistent and explicit 72713872a Add missing static to secp256k1_schnorrsig_sign_internal db4667d5e Make aux_rand32 arg to secp256k1_schnorrsig_sign const 9a5a87e0f Merge bitcoin-core/secp256k1#956: Replace ecmult_context with a generated static array. 20abd52c2 Add tests for pre_g tables. 6815761cf Remove ecmult_context. f20dcbbad Correct typo. 16a3cc07e Generate ecmult_static_pre_g.h 8de2d86a0 Bump memory limits in advance of making the ecmult context static. d7ec49a68 Merge bitcoin-core/secp256k1#969: ci: Fixes after Debian release 5d5c74a05 tests: Rewrite code to circument potential bug in clang 3d2f492ce ci: Install libasan6 (instead of 5) after Debian upgrade be8d9c262 Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM aeece4459 gen_context: Don't use any ASM 7688a4f13 Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups 90e83449b ci: Add C++ test adec5a163 Add missing null check for ctx and input keys in the public API f4edfc758 Improve consistency for NULL arguments in the public interface f698caaff Use unsigned char consistently for byte arrays b5b8e7b71 Don't declare constants twice 769528f30 Don't use string literals for char arrays without NUL termination 2cc3cfa58 Fix -Wmissing-braces warning in clang 0440945fb Merge #844: schnorrsig API overhaul ec3aaa501 Merge #960: tests_exhaustive: check the result of secp256k1_ecdsa_sign a1ee83c65 tests_exhaustive: check the result of secp256k1_ecdsa_sign 253f90cde Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG 446d28d9d Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS 0302138f7 ci: Make compiler warning into errors on CI b924e1e60 build: Ensure that configure's compile checks default to -O2 7939cd571 build: List *CPPFLAGS before *CFLAGS like on the compiler command line 595e8a35d build: Enable -Wcast-align=strict warning 07256267f build: Use own variable SECP_CFLAGS instead of touching user CFLAGS 4866178df Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests 75ce488c2 Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse 41ed13942 tests: really test the non-var scalar inverse 5f6ceafcf schnorrsig: allow setting MSGLEN != 32 in benchmark fdd06b796 schnorrsig: add tests for sign_custom and varlen msg verification d8d806aaf schnorrsig: add extra parameter struct for sign_custom a0c3fc177 schnorrsig: allow signing and verification of variable length msgs 5a8e4991a Add secp256k1_tagged_sha256 as defined in BIP-340 b6c0b72fb schnorrsig: remove noncefp args from sign; add sign_custom function bdf19f105 Add random field multiply/square tests 9be7b0f08 Avoid computing out-of-bounds pointer. a4642fa15 configure: replace AC_PATH_PROG to AC_CHECK_PROG 442cee5ba schnorrsig: add algolen argument to nonce_function_hardened df3bfa12c schnorrsig: clarify result of calling nonce_function_bip340 without data 99e861481 README: mention schnorrsig module b53e0cd61 Avoid overly-wide multiplications git-subtree-dir: src/secp256k1 git-subtree-split: 60556c9f49a9384efd7f16b734820ae19108f053
vmta
added a commit
to umkoin/umkoin
that referenced
this pull request
Jul 1, 2023
0fa84f869 Merge bitcoin-core/secp256k1#1358: tests: introduce helper for non-zero `random_fe_test()` results 5a95a268b tests: introduce helper for non-zero `random_fe_test` results 304421d57 tests: refactor: remove duplicate function `random_field_element_test` 3aef6ab8e Merge bitcoin-core/secp256k1#1345: field: Static-assert that int args affecting magnitude are constant 4494a369b Merge bitcoin-core/secp256k1#1357: tests: refactor: take use of `secp256k1_ge_x_on_curve_var` 799f4eec2 Merge bitcoin-core/secp256k1#1356: ci: Adjust Docker image to Debian 12 "bookworm" c862a9fb4 ci: Adjust Docker image to Debian 12 "bookworm" a1782098a ci: Force DWARF v4 for Clang when Valgrind tests are expected 7d8d5c86d tests: refactor: take use of `secp256k1_ge_x_on_curve_var` 8a7273465 Help the compiler prove that a loop is entered fd491ea1b Merge bitcoin-core/secp256k1#1355: Fix a typo in the error message ac43613d2 Merge bitcoin-core/secp256k1#1354: Add ellswift to CHANGELOG 67887ae65 Fix a typo in the error message 926dd3e96 Merge bitcoin-core/secp256k1#1295: abi: Use dllexport for mingw builds 10836832e Merge bitcoin-core/secp256k1#1336: Use `__shiftright128` intrinsic in `secp256k1_u128_rshift` on MSVC 7c7467ab7 Refer to ellswift.md in API docs c32ffd8d8 Add ellswift to CHANGELOG 3c1a0fd37 Merge bitcoin-core/secp256k1#1347: field: Document return value of fe_sqrt() 705ce7ed8 Merge bitcoin-core/secp256k1#1129: ElligatorSwift + integrated x-only DH 0702ecb06 Merge bitcoin-core/secp256k1#1338: Drop no longer needed `#include "../include/secp256k1.h"` 577913745 field: Document return value of fe_sqrt() 90e360acc Add doc/ellswift.md with ElligatorSwift explanation 4f091847c Add ellswift testing to CI 1bcea8c57 Add benchmarks for ellswift module 2d1d41acf Add ctime tests for ellswift module df633cdeb Add _prefix and _bip324 ellswift_xdh hash functions 9695deb35 Add tests for ellswift module c47917bbd Add ellswift module implementing ElligatorSwift 79e5b2a8b Add functions to test if X coordinate is valid a597a5a9c Add benchmark for key generation 30574f22e Merge bitcoin-core/secp256k1#1349: Normalize ge produced from secp256k1_pubkey_load 45c5ca767 Merge bitcoin-core/secp256k1#1350: scalar: introduce and use `secp256k1_{read,write}_be64` helpers f1652528b Normalize ge produced from secp256k1_pubkey_load 7067ee54b tests: add tests for `secp256k1_{read,write}_be64` 740528caa scalar: use newly introduced `secp256k1_{read,write}_be64` helpers (4x64 impl.) be8ff3a02 field: Static-assert that int args affecting magnitude are constant 67214f5f7 Merge bitcoin-core/secp256k1#1339: scalar: refactor: use `secp256k1_{read,write}_be32` helpers cb1a59275 Merge bitcoin-core/secp256k1#1341: docs: correct `pubkey` param descriptions for `secp256k1_keypair_{xonly_,}pub` f3644287b docs: correct `pubkey` param descriptions for `secp256k1_keypair_{xonly_,}pub` 887183e7d scalar: use `secp256k1_{read,write}_be32` helpers (4x64 impl.) 52b84238d scalar: use `secp256k1_{read,write}_be32` helpers (8x32 impl.) e449af687 Drop no longer needed `#include "../include/secp256k1.h"` 5b7bf2e9d Use `__shiftright128` intrinsic in `secp256k1_u128_rshift` on MSVC 60556c9f4 Merge bitcoin-core/secp256k1#1337: ci: Fix error D8037 in `cl.exe` (attempt 2) db29bf220 ci: Remove quirk that runs dummy command after wineserver c7db4942b ci: Fix error D8037 in `cl.exe` 7dae11586 Revert "ci: Move wine prefix to /tmp to avoid error D8037 in cl.exe" bf29f8d0a Merge bitcoin-core/secp256k1#1334: fix input range comment for `secp256k1_fe_add_int` 605e07e36 fix input range comment for `secp256k1_fe_add_int` debf3e5c0 Merge bitcoin-core/secp256k1#1330: refactor: take use of `secp256k1_scalar_{zero,one}` constants d75dc59b5 Merge bitcoin-core/secp256k1#1333: test: Warn if both `VERIFY` and `COVERAGE` are defined ade5b3670 tests: add checks for scalar constants `secp256k1_scalar_{zero,one}` e83801f5d test: Warn if both `VERIFY` and `COVERAGE` are defined 654246c63 refactor: take use of `secp256k1_scalar_{zero,one}` constants 908e02d59 Merge bitcoin-core/secp256k1#1328: build: Bump MSVC warning level up to W3 1549db0ca build: Level up MSVC warnings 20a5da5fb Merge bitcoin-core/secp256k1#1310: Refine release process ad8460329 release process: clarify change log updates 6348bc7ee release process: fix process for maintenance release 79fa50b08 release process: mention targeted release schedule 165206789 release process: add sanity checks 09df0bfb2 Merge bitcoin-core/secp256k1#1327: ci: Move wine prefix to /tmp to avoid error D8037 in cl.exe 27504d5c9 ci: Move wine prefix to /tmp to avoid error D8037 in cl.exe d373a7215 Merge bitcoin-core/secp256k1#1316: Do not invoke fe_is_zero on failed set_b32_limit 6433175ff Do not invoke fe_is_zero on failed set_b32_limit 5f7903c73 Merge bitcoin-core/secp256k1#1318: build: Enable -DVERIFY for precomputation binaries e9e4526a4 Merge bitcoin-core/secp256k1#1317: Make fe_cmov take max of magnitudes 5768b5022 build: Enable -DVERIFY for precomputation binaries 31b4bbee1 Make fe_cmov take max of magnitudes 83186db34 Merge bitcoin-core/secp256k1#1314: release cleanup: bump version after 0.3.2 95448ef2f release cleanup: bump version after 0.3.2 acf5c55ae Merge bitcoin-core/secp256k1#1312: release: Prepare for 0.3.2 d490ca204 release: Prepare for 0.3.2 3e3d125b8 Merge bitcoin-core/secp256k1#1309: changelog: Catch up e8295d07a Merge bitcoin-core/secp256k1#1311: Revert "Remove unused scratch space from API" 697e1ccf4 changelog: Catch up 3ad1027a4 Revert "Remove unused scratch space from API" 76b43f344 changelog: Add entry for #1303 7d4f86d24 Merge bitcoin-core/secp256k1#1307: Mark more assembly outputs as early clobber b54a0672e Merge bitcoin-core/secp256k1#1304: build: Rename arm to arm32 and check if it's really supported c6bb29b30 build: Rename `64bit` to `x86_64` 8c9ae37a5 Add release note 03246457a autotools: Add `SECP_ARM32_ASM_CHECK` macro ed4ba238e cmake: Add `check_arm32_assembly` function 350b4bd6e Mark stack variables as early clobber for technical correctness 0c729ba70 Bugfix: mark outputs as early clobber in scalar x86_64 asm 3353d3c75 Merge bitcoin-core/secp256k1#1207: Split fe_set_b32 into reducing and normalizing variants 5b3260229 Split fe_set_b32 into reducing and normalizing variants 006ddc1f4 Merge bitcoin-core/secp256k1#1306: build: Make tests work with external default callbacks 1907f0f16 build: Make tests work with external default callbacks fb3a80636 Merge bitcoin-core/secp256k1#1133: schnorrsig: Add test vectors for variable-length messages cd54ac7c1 schnorrsig: Improve docs of schnorrsig_sign_custom 28687b031 schnorrsig: Add BIP340 varlen test vectors 97a98bed1 schnorrsig: Refactor test vector code to allow varlen messages ab5a91712 Merge bitcoin-core/secp256k1#1303: ct: Use more volatile 9eb6934f6 Merge bitcoin-core/secp256k1#1305: Remove unused scratch space from API 073d98a07 Merge bitcoin-core/secp256k1#1292: refactor: Make 64-bit shift explicit 17fa21733 ct: Be cautious and use volatile trick in more "conditional" paths 5fb336f9c ct: Use volatile trick in scalar_cond_negate 712e7f872 Remove unused scratch space from API 54d34b6c2 Merge bitcoin-core/secp256k1#1300: Avoid normalize conditional on VERIFY c63ec88eb Merge bitcoin-core/secp256k1#1066: Abstract out and merge all the magnitude/normalized logic 7fc642fa2 Simplify secp256k1_fe_{impl_,}verify 4e176ad5b Abstract out verify logic for fe_is_square_var 4371f9834 Abstract out verify logic for fe_add_int 89e324c6b Abstract out verify logic for fe_half 283cd80ab Abstract out verify logic for fe_get_bounds d5aa2f035 Abstract out verify logic for fe_inv{,_var} 316764607 Abstract out verify logic for fe_from_storage 76d31e504 Abstract out verify logic for fe_to_storage 1e6894bdd Abstract out verify logic for fe_cmov be82bd8e0 Improve comments/checks for fe_sqrt 6ab35082e Abstract out verify logic for fe_sqr 4c25f6efb Abstract out verify logic for fe_mul e179e651c Abstract out verify logic for fe_add 7e7ad7ff5 Abstract out verify logic for fe_mul_int 65d82a344 Abstract out verify logic for fe_negate 144670893 Abstract out verify logic for fe_get_b32 f7a7666ae Abstract out verify logic for fe_set_b32 ce4d2093e Abstract out verify logic for fe_cmp_var 7d7d43c6d Improve comments/check for fe_equal{,_var} c5e788d67 Abstract out verify logic for fe_is_odd d3f3fe861 Abstract out verify logic for fe_is_zero c701d9a47 Abstract out verify logic for fe_clear 19a2bfeee Abstract out verify logic for fe_set_int 864f9db49 Abstract out verify logic for fe_normalizes_to_zero{,_var} 6c3137112 Abstract out verify logic for fe_normalize_var e28b51f52 Abstract out verify logic for fe_normalize_weak b6b6f9cb9 Abstract out verify logic for fe_normalize 7fa519555 Bugfix: correct SECP256K1_FE_CONST mag/norm fields e5cf4bf3f build: Rename `arm` to `arm32` b29566c51 Merge magnitude/normalized fields, move/improve comments 97c63b903 Avoid normalize conditional on VERIFY 341cc1972 Merge bitcoin-core/secp256k1#1299: Infinity handling: ecmult_const(infinity) works, and group verification bbc834467 Avoid secp256k1_ge_set_gej_zinv with uninitialized z 0a2e0b2ae Make secp256k1_{fe,ge,gej}_verify work as no-op if non-VERIFY f20266722 Add invariant checking to group elements a18821d5b Always initialize output coordinates in secp256k1_ge_set_gej 3086cb90a Expose secp256k1_fe_verify to other modules a0e696fd4 Make secp256k1_ecmult_const handle infinity 24c768ae0 Merge bitcoin-core/secp256k1#1301: Avoid using bench_verify_data as bench_sign_data; merge them 2e65f1fdb Avoid using bench_verify_data as bench_sign_data; merge them 1cf15ebd9 Merge bitcoin-core/secp256k1#1296: docs: complete interface description for `secp256k1_schnorrsig_sign_custom` bc7c8db17 abi: Use dllexport for mingw builds 149c41cee docs: complete interface description for `secp256k1_schnorrsig_sign_custom` f30c74866 Merge bitcoin-core/secp256k1#1270: cmake: Fix library ABI versioning d1e48e547 refactor: Make 64-bit shift explicit b2e29e43d ci: Treat all compiler warnings as errors in "Windows (VS 2022)" task 3c8183885 Merge bitcoin-core/secp256k1#1289: cmake: Use full signature of `add_test()` command 755629bc0 cmake: Use full signature of `add_test()` command bef448f9a cmake: Fix library ABI versioning 4b0f711d4 Merge bitcoin-core/secp256k1#1277: autotools: Clean up after adding Wycheproof 222ecaf66 Merge bitcoin-core/secp256k1#1284: cmake: Some improvements using `PROJECT_IS_TOP_LEVEL` variable 71f746c05 cmake: Include `include` directory for subtree builds 024a40948 Merge bitcoin-core/secp256k1#1240: cmake: Improve and document compiler flag checks a8d059f76 cmake, doc: Document compiler flags 6ece1507c cmake, refactor: Rename `try_add_compile_option` to `try_append_cflags` 19516ed3e cmake: Use `add_compile_options()` in `try_add_compile_option()` 4b84f4bf0 Merge bitcoin-core/secp256k1#1239: cmake: Bugfix and other improvements after bumping CMake up to 3.13 596b336ff Merge bitcoin-core/secp256k1#1234: cmake: Add dev-mode 6b7e5b717 Merge bitcoin-core/secp256k1#1275: build: Fix C4005 "macro redefinition" MSVC warnings in examples 1c8953671 Merge bitcoin-core/secp256k1#1286: tests: remove extra semicolon in macro c4062d6b5 debug: move helper for printing buffers into util.h 7e977b3c5 autotools: Take VPATH builds into account when generating testvectors 2418d3260 autotools: Create src/wycheproof dir before creating file in it 8764034ed autotools: Make all "pregenerated" targets .PHONY e1b9ce881 autotools: Use same conventions for all pregenerated files 3858bad2c tests: remove extra semicolon in macro 1f33bb2b1 Merge bitcoin-core/secp256k1#1205: field: Improve docs +tests of secp256k1_fe_set_b32 162da73e9 tests: Add debug helper for printing buffers e9fd3dff7 field: Improve docs and tests of secp256k1_fe_set_b32 f6bef03c0 Merge bitcoin-core/secp256k1#1283: Get rid of secp256k1_fe_const_b 5431b9dec cmake: Make `SECP256K1_INSTALL` default depend on `PROJECT_IS_TOP_LEVEL` 5ec1333d4 Merge bitcoin-core/secp256k1#1285: bench: Make sys/time.h a system include 68b16a166 bench: Make sys/time.h a system include 162608cc9 cmake: Emulate `PROJECT_IS_TOP_LEVEL` for CMake<3.21 69e1ec033 Get rid of secp256k1_fe_const_b ce5ba9e24 gitignore: Add CMakeUserPresets.json 0a446a312 cmake: Add dev-mode CMake preset a6f4bcf6e Merge bitcoin-core/secp256k1#1231: Move `SECP256K1_INLINE` macro definition out from `include/secp256k1.h` a273d74b2 cmake: Improve version comparison 6a58b483e cmake: Use `if(... IN_LIST ...)` command 2445808c0 cmake: Use dedicated `GENERATOR_IS_MULTI_CONFIG` property 9f8703ef1 cmake: Use dedicated `CMAKE_HOST_APPLE` variable 8c2017035 cmake: Use recommended `add_compile_definitions` command 04d4cc071 cmake: Add `DESCRIPTION` and `HOMEPAGE_URL` options to `project` command 8a8b6536e cmake: Use `SameMinorVersion` compatibility mode 5b0444a3b Merge bitcoin-core/secp256k1#1263: cmake: Make installation optional 47ac3d63c cmake: Make installation optional 2e035af25 Merge bitcoin-core/secp256k1#1273: build: Make `SECP_VALGRIND_CHECK` preserve `CPPFLAGS` 5be353d65 Merge bitcoin-core/secp256k1#1279: tests: lint wycheproof's python script 08f4b1632 autotools: Move code around to tidy Makefile 04bf3f677 Merge bitcoin-core/secp256k1#1230: Build: allow static or shared but not both 9ce9984f3 Merge bitcoin-core/secp256k1#1265: Remove bits argument from secp256k1_wnaf_const{_xonly} 566faa17d Merge bitcoin-core/secp256k1#1267: doc: clarify process for patch releases ef49a11d2 build: allow static or shared but not both 35ada3b95 tests: lint wycheproof's python script 4258c54f4 Merge bitcoin-core/secp256k1#1276: autotools: Don't regenerate Wycheproof header automatically 529b54d92 autotools: Move Wycheproof header from EXTRA_DIST to noinst_HEADERS 06c67dea9 autotools: Don't regenerate Wycheproof header automatically dc0657c76 build: Fix C4005 "macro redefinition" MSVC warnings in examples 1ecb94ebe build: Make `SECP_VALGRIND_CHECK` preserve `CPPFLAGS` 3bab71cf0 Merge bitcoin-core/secp256k1#1268: release cleanup: bump version after 0.3.1 656c6ea8d release cleanup: bump version after 0.3.1 346a053d4 Merge bitcoin-core/secp256k1#1269: changelog: Fix link 6a37b2a5e changelog: Fix link ec98fcedd Merge bitcoin-core/secp256k1#1266: release: Prepare for 0.3.1 1b6fb5593 doc: clarify process for patch releases 898e1c676 release: Prepare for 0.3.1 1d9a13fc2 changelog: Remove inconsistent newlines 0e091669a changelog: Catch up in preparation of 0.3.1 7b7503dac Merge bitcoin-core/secp256k1#1245: tests: Add Wycheproof ECDSA vectors a575339c0 Remove bits argument from secp256k1_wnaf_const (always 256) 145078c41 Merge bitcoin-core/secp256k1#1118: Add x-only ecmult_const version with x specified as n/d e5de45460 tests: Add Wycheproof ECDSA vectors 0f8642079 Add exhaustive tests for ecmult_const_xonly 4485926ac Add x-only ecmult_const version for x=n/d a0f4644f7 Merge bitcoin-core/secp256k1#1252: Make position of * in pointer declarations in include/ consistent 4e682626a Merge bitcoin-core/secp256k1#1226: Add CMake instructions to release process 2d51a454f Merge bitcoin-core/secp256k1#1257: ct: Use volatile "trick" in all fe/scalar cmov implementations 4a496a36f ct: Use volatile "trick" in all fe/scalar cmov implementations 3d1f430f9 Make position of * in pointer declarations in include/ consistent 2bca0a5cb Merge bitcoin-core/secp256k1#1241: build: Improve `SECP_TRY_APPEND_DEFAULT_CFLAGS` macro afd8b23b2 Merge bitcoin-core/secp256k1#1244: Suppress `-Wunused-parameter` when building for coverage analysis 1d8f36751 Merge bitcoin-core/secp256k1#1250: No need to subtract 1 before doing a right shift 3e43041be No need to subtract 1 before doing a right shift 3addb4c1e build: Improve `SECP_TRY_APPEND_DEFAULT_CFLAGS` macro 0c07c8283 Add CMake instructions to release process 464a9115b Merge bitcoin-core/secp256k1#1242: Set ARM ASM symbol visibility to `hidden` f16a709fd Merge bitcoin-core/secp256k1#1247: Apply Checks only in VERIFY mode. 70be3cade Merge bitcoin-core/secp256k1#1246: Typo 4ebd82852 Apply Checks only in VERIFY mode. d1e7ca192 Typo 36b0adf1b build: remove warning until it's reproducible 5bb03c291 Replace `SECP256K1_ECMULT_TABLE_VERIFY` macro by a function 9c8c4f443 Merge bitcoin-core/secp256k1#1238: build: bump CMake minimum requirement to 3.13 0cf2fb91e Merge bitcoin-core/secp256k1#1243: build: Ensure no optimization when building for coverage analysis fd2a40864 Set ARM ASM symbol visibility to `hidden` 4429a8c21 Suppress `-Wunused-parameter` when building for coverage analysis 8e79c7ed1 build: Ensure no optimization when building for coverage analysis 96dd06251 build: bump CMake minimum requirement to 3.13 427bc3cdc Merge bitcoin-core/secp256k1#1236: Update comment for secp256k1_modinv32_inv256 647f0a5cb Update comment for secp256k1_modinv32_inv256 8e142ca41 Move `SECP256K1_INLINE` macro definition out from `include/secp256k1.h` 77445898a Remove `SECP256K1_INLINE` usage from examples 565820945 Merge bitcoin-core/secp256k1#1228: release cleanup: bump version after 0.3.0 bdf39000b Merge bitcoin-core/secp256k1#1223: release: prepare for 0.3.0 28e63f7ea release cleanup: bump version after 0.3.0 b40adf236 release: prepare for 0.3.0 90b513aad Merge bitcoin-core/secp256k1#1229: cmake: Rename project to "libsecp256k1" 8be82d436 cmake: Rename project to "libsecp256k1" ef4f8bd02 Merge bitcoin-core/secp256k1#1227: readme: Use correct build type in CMake/Windows build instructions 756b61d45 readme: Use correct build type in CMake/Windows build instructions 3295aa149 Merge bitcoin-core/secp256k1#1225: changelog: Add entry for CMake 92098d84c changelog: Add entry for CMake df323b5c1 Merge bitcoin-core/secp256k1#1113: build: Add CMake-based build system e1eb33724 ci: Add "x86_64: Windows (VS 2022)" task 10602b003 cmake: Export config files 5468d7096 build: Add CMake-based build system 6048e6c03 Merge bitcoin-core/secp256k1#1222: Remove redundant checks. eb8749fcd Merge bitcoin-core/secp256k1#1221: Update Changelog 5d8f53e31 Remove redudent checks. 9d1b458d5 Merge bitcoin-core/secp256k1#1217: Add secp256k1_fe_add_int function d232112fa Update Changelog 8962fc95b Merge bitcoin-core/secp256k1#1218: Update overflow check 2ef1c9b38 Update overflow check 575731878 Merge bitcoin-core/secp256k1#1212: Prevent dead-store elimination when clearing secrets in examples b081f7e4c Add secp256k1_fe_add_int function 5660c1375 prevent optimization in algorithms 09b1d466d Merge bitcoin-core/secp256k1#979: Native jacobi symbol algorithm ce3cfc78a doc: Describe Jacobi calculation in safegcd_implementation.md 6be01036c Add secp256k1_fe_is_square_var function 1de2a01c2 Native jacobi symbol algorithm 04c6c1b18 Make secp256k1_modinv64_det_check_pow2 support abs val 5fffb2c7a Make secp256k1_i128_check_pow2 support -(2^n) cbd255593 Merge bitcoin-core/secp256k1#1209: build: Add SECP256K1_API_VAR to fix importing variables from DLLs 1b21aa517 Merge bitcoin-core/secp256k1#1078: group: Save a normalize_to_zero in gej_add_ge e4330341b ci: Shutdown wineserver whenever CI script exits 9a5a611a2 build: Suppress stupid MSVC linker warning 739c53b19 examples: Extend sig examples by call that uses static context 914276e4d build: Add SECP256K1_API_VAR to fix importing variables from DLLs 1cca7c174 Merge bitcoin-core/secp256k1#1206: build: Add -Wreserved-identifier supported by clang 8c7e0fc1d build: Add -Wreserved-identifier supported by clang ca92a35d0 field: Simplify code in secp256k1_fe_set_b32 d93f62e36 field: Verify field element even after secp256k1_fe_set_b32 fails 8ebe5c520 Merge bitcoin-core/secp256k1#1201: ci: Do not set git's `user.{email,name}` config options 5596ec5c2 Merge bitcoin-core/secp256k1#1203: Do not link `bench` and `ctime_tests` to `COMMON_LIB` ef39721cc Do not link `bench` and `ctime_tests` to `COMMON_LIB` 9b60e3148 ci: Do not set git's `user.{email,name}` config options e1817a6f5 Merge bitcoin-core/secp256k1#1199: ci: Minor improvements inspired by Bitcoin Core 1bff20058 Merge bitcoin-core/secp256k1#1200: Drop no longer used Autoheader macros 9b7d18669 Drop no longer used Autoheader macros c2415866c ci: Don't fetch git history 0ecf31885 ci: Use remote pull/merge ref instead of local git merge 2b77240b3 Merge bitcoin-core/secp256k1#1172: benchmarks: fix bench_scalar_split eb6bebaee scalar: restrict split_lambda args, improve doc and VERIFY_CHECKs 7f49aa7f2 ci: add test job with -DVERIFY 620ba3d74 benchmarks: fix bench_scalar_split 5fbff5d34 Merge bitcoin-core/secp256k1#1170: contexts: Forbid destroying, cloning and randomizing the static context 233822d84 Merge bitcoin-core/secp256k1#1195: ctime_tests: improve output when CHECKMEM_RUNNING is not defined ad7433b14 Merge bitcoin-core/secp256k1#1196: Drop no longer used variables from the build system e39d954f1 tests: Add CHECK_ILLEGAL(_VOID) macros and use in static ctx tests 2cd4e3c0a Drop no longer used `SECP_{LIBS,INCLUDE}` variables 613626f94 Drop no longer used `SECP_TEST_{LIBS,INCLUDE}` variables 61841fc9e contexts: Forbid randomizing secp256k1_context_static 4b6df5e33 contexts: Forbid cloning/destroying secp256k1_context_static b1579cf5f Merge bitcoin-core/secp256k1#1194: Ensure safety of ctz_debruijn implementation. 8f51229e0 ctime_tests: improve output when CHECKMEM_RUNNING is not defined d6ff738d5 Ensure safety of ctz_debruijn implementation. a01a7d86d Merge bitcoin-core/secp256k1#1192: Switch to exhaustive groups with small B coefficient a7a7bfaf3 Merge bitcoin-core/secp256k1#1190: Make all non-API functions (except main) static f29a32709 Merge bitcoin-core/secp256k1#1169: Add support for msan instead of valgrind (for memcheck and ctime test) ff8edf89e Merge bitcoin-core/secp256k1#1193: Add `noverify_tests` to `.gitignore` ce60785b2 Introduce SECP256K1_B macro for curve b coefficient 4934aa799 Switch to exhaustive groups with small B coefficient d4a6b58df Add `noverify_tests` to `.gitignore` 88e80722d Merge bitcoin-core/secp256k1#1160: Makefile: add `-I$(top_srcdir)/{include,src}` to `CPPFLAGS` for precomputed 0f088ec11 Rename CTIMETEST -> CTIMETESTS 74b026f05 Add runtime checking for DECLASSIFY flag 5e2e6fcfc Run ctime test in Linux MSan CI job 18974061a Make ctime tests building configurable 5048be17e Rename valgrind_ctime_test -> ctime_tests 6eed6c18d Update error messages to suggest msan as well 8e11f89a6 Add support for msan integration to checkmem.h 8dc64079e Add compile-time error to valgrind_ctime_test 0db05a770 Abstract interactions with valgrind behind new checkmem.h 4f1a54e41 Move valgrind CPPFLAGS into SECP_CONFIG_DEFINES cc3b8a4f4 Merge bitcoin-core/secp256k1#1187: refactor: Rename global variables in tests 9a93f48f5 refactor: Rename STTC to STATIC_CTX in tests 3385a2648 refactor: Rename global variables to uppercase in tests e03ef8655 Make all non-API functions (except main) static cbe41ac13 Merge bitcoin-core/secp256k1#1188: tests: Add noverify_tests which is like tests but without VERIFY 203760023 tests: Add noverify_tests which is like tests but without VERIFY e862c4af0 Makefile: add -I$(top_srcdir)/src to CPPFLAGS for precomputed 0eb300041 Merge bitcoin-core/secp256k1#1186: tests: Tidy context tests 39e8f0e3d refactor: Separate run_context_tests into static vs proper contexts a4a09379b tests: Clean up and improve run_context_tests() further fc90bb569 refactor: Tidy up main() f32a36f62 tests: Don't use global context for context tests ce4f936c4 tests: Tidy run_context_tests() by extracting functions 18e0db30c tests: Don't recreate global context in scratch space test b19806122 tests: Use global copy of secp256k1_context_static instead of clone 2a39ac162 Merge bitcoin-core/secp256k1#1185: Drop `SECP_CONFIG_DEFINES` from examples 2f9ca284e Drop `SECP_CONFIG_DEFINES` from examples 31ed5386e Merge bitcoin-core/secp256k1#1183: Bugfix: pass SECP_CONFIG_DEFINES to bench compilation c0a555b2a Bugfix: pass SECP_CONFIG_DEFINES to bench compilation 01b819a8c Merge bitcoin-core/secp256k1#1158: Add a secp256k1_i128_to_u64 function. eacad90f6 Merge bitcoin-core/secp256k1#1171: Change ARG_CHECK_NO_RETURN to ARG_CHECK_VOID which returns (void) 3f57b9f77 Merge bitcoin-core/secp256k1#1177: Some improvements to the changelog c30b889f1 Clarify that the ABI-incompatible versions are earlier 881fc33d0 Consistency in naming of modules 665ba77e7 Merge bitcoin-core/secp256k1#1178: Drop `src/libsecp256k1-config.h` 75d7b7f5b Merge bitcoin-core/secp256k1#1154: ci: set -u in cirrus.sh to treat unset variables as an error 7a7468820 ci: add missing CFLAGS & CPPFLAGS variable to print_environment c2e0fdade ci: set -u in cirrus.sh to treat unset variables as an error 9c5a4d21b Do not define unused `HAVE_VALGRIND` macro ad8647f54 Drop no longer relevant files from `.gitignore` b627ba705 Remove dependency on `src/libsecp256k1-config.h` 9ecf8149a Reduce font size in changelog 2dc133a67 Add more changelog entries ac233e181 Add links to diffs to changelog cee8223ef Mention semantic versioning in changelog 9a8d65f07 Merge bitcoin-core/secp256k1#1174: release cleanup: bump version after 0.2.0 02ebc290f release cleanup: bump version after 0.2.0 b6b360efa doc: improve message of cleanup commit 21ffe4b22 Merge bitcoin-core/secp256k1#1055: Prepare initial release e025ccdf7 release: prepare for initial release 0.2.0 6d1784a2e build: add missing files to EXTRA_DIST 8c949f56d Merge bitcoin-core/secp256k1#1173: Don't use compute credits for now 13bf1b6b3 changelog: make order of change types match keepachangelog.com b1f992a55 doc: improve release process 7e5b22684 Don't use compute credits for now a49e0940a docs: Fix typo 2551cdac9 tests: Fix code formatting c635c1bfd Change ARG_CHECK_NO_RETURN to ARG_CHECK_VOID which returns (void) cf66f2357 refactor: Add helper function secp256k1_context_is_proper() ad39e2dc4 build: change package version to 0.1.0-dev 5c789dcd7 Merge bitcoin-core/secp256k1#1168: Replace deprecated context flags with NONE in benchmarks and tests d6dc0f4ae tests: Switch to NONE contexts in module tests 0c8a5cadd tests: Switch to NONE contexts in tests.c 86540e9e1 tests: add test for deprecated flags and rm them from run_context caa0ad631 group: add gej_eq_var 37ba744f5 tests: Switch to NONE contexts in exhaustive and ctime tests 8d7a9a8ed benchmarks: Switch to NONE contexts 90618e926 doc: move CHANGELOG from doc/ to root directory e3f84777e Merge bitcoin-core/secp256k1#1126: API cleanup with respect to contexts 4386a2306 examples: Switch to NONE contexts 7289b51d3 docs: Use doxygen style if and only if comment is user-facing e7d0185c9 docs: Get rid of "initialized for signing" terminology 06126364a docs: Tidy and improve docs about contexts and randomization e02d6862b selftest: Expose in public API e383fbfa6 selftest: Rename internal function to make name available for API d2c6d48de tests: Use new name of static context 53796d2b2 contexts: Rename static context 72fedf8a6 docs: Improve docs for static context 316ac7625 contexts: Deprecate all context flags except SECP256K1_CONTEXT_NONE 477f02c4d Merge bitcoin-core/secp256k1#1165: gitignore: Add *.sage.py files autogenerated by sage [skip ci] 092be61c5 gitignore: Add *.sage.py files autogenerated by sage 1a553ee8b docs: Change signature "validation" to "verification" ee7341fba docs: Never require a verification context 751c4354d Merge bitcoin-core/secp256k1#1152: Update macOS image for CI 2286f8090 Merge bitcoin-core/secp256k1#993: Enable non-experimental modules by default d21647520 test secp256k1_i128_to_i64 4bc429019 Add a secp256k1_i128_to_u64 function. e40fd277b Merge bitcoin-core/secp256k1#1156: Followups to int128_struct arithmetic 99bd33559 Make int128 overflow test use secp256k1_[ui]128_mul a8494b02b Use compute credits for macOS jobs 3afce0af7 Avoid signed overflow in MSVC AMR64 secp256k1_mul128 c0ae48c99 Update macOS image for CI 9b5f589d3 Heuristically decide whether to use int128_struct 63ff064d2 int128: Add test override for testing __(u)mulh on MSVC X64 f2b7e8876 Add int128 randomized tests 6138d73be Merge bitcoin-core/secp256k1#1155: Add MSan CI jobs ddf2b2910 Merge bitcoin-core/secp256k1#1000: Synthetic int128 type. 86e3b38a4 Merge bitcoin-core/secp256k1#1149: Remove usage of CHECK from non-test file 00a42b91b Add MSan CI job 44916ae91 Merge bitcoin-core/secp256k1#1147: ci: print env to allow reproducing the job outside of CI c2ee9175e Merge bitcoin-core/secp256k1#1146: ci: prevent "-v/--version: not found" irrelevant error e13fae487 Merge bitcoin-core/secp256k1#1150: ci: always cat test_env.log a340d9500 ci: add int128_struct tests dceaa1f57 int128: Tidy #includes of int128.h and int128_impl.h 2914bccbc Simulated int128 type. 6a965b6b9 Remove usage of CHECK from non-test file 5c9f1a5c3 ci: always cat all logs_snippets 49ae84359 ci: mostly prevent "-v/--version: not found" irrelevant error 4e54c0315 ci: print env to allow reproducing the job outside of CI a43e982bc Merge bitcoin-core/secp256k1#1144: Cleanup `.gitignore` file f5039cb66 Cleanup `.gitignore` file 798727ae1 Revert "Add test logs to gitignore" 41e8704b4 build: Enable some modules by default 694ce8fb2 Merge bitcoin-core/secp256k1#1131: readme: Misc improvements 88b00897e readme: Fix line break 78f5296da readme: Sell "no runtime dependencies" ef48f088a readme: Add IRC channel 9f8a13dc8 Merge bitcoin-core/secp256k1#1128: configure: Remove pkgconfig macros again (reintroduced by mismerge) cabe085bb configure: Remove pkgconfig macros again (reintroduced by mismerge) 3efeb9da2 Merge bitcoin-core/secp256k1#1121: config: Set preprocessor defaults for ECMULT_* config values 6a873cc4a Merge bitcoin-core/secp256k1#1122: tests: Randomize the context with probability 15/16 instead of 1/4 17065f48a tests: Randomize the context with probability 15/16 instead of 1/4 c27ae4514 config: Remove basic-config.h da6514a04 config: Introduce DEBUG_CONFIG macro for debug output of config 63a3565e9 Merge bitcoin-core/secp256k1#1120: ecmult_gen: Skip RNG when creating blinding if no seed is available d0cf55e13 config: Set preprocessor defaults for ECMULT_* config values 55f8bc99d ecmult_gen: Improve comments about projective blinding 7a8695580 ecmult_gen: Simplify code (no observable change) 4cc0b1b66 ecmult_gen: Skip RNG when creating blinding if no seed is available af65d30cc Merge bitcoin-core/secp256k1#1116: build: Fix #include "..." paths to get rid of further -I arguments 40a3473a9 build: Fix #include "..." paths to get rid of further -I arguments 43756da81 Merge bitcoin-core/secp256k1#1115: Fix sepc256k1 -> secp256k1 typo in group.h 069aba812 Fix sepc256k1 -> secp256k1 typo in group.h accadc94d Merge bitcoin-core/secp256k1#1114: `_scratch_destroy`: move `VERIFY_CHECK` after invalid scrach space check cd4703333 Merge bitcoin-core/secp256k1#1084: ci: Add MSVC builds 1827c9bf2 scratch_destroy: move VERIFY_CHECK after invalid scrach space check 49e2acd92 configure: Improve rationale for WERROR_CFLAGS 8dc4b0334 ci: Add a C++ job that compiles the public headers without -fpermissive 51f296a46 ci: Run persistent wineserver to speed up wine 3fb3269c2 ci: Add 32-bit MinGW64 build 9efc2e522 ci: Add MSVC builds 2be6ba0fe configure: Convince autotools to work with MSVC's archiver lib.exe bd81f4140 schnorrsig bench: Suppress a stupid warning in MSVC 44c2452fd Merge bitcoin-core/secp256k1#1105: Don't export symbols in static libraries 6f6cab998 abi: Don't export symbols in static Windows libraries 485f608fa Merge bitcoin-core/secp256k1#1104: Fix the false positive of `SECP_64BIT_ASM_CHECK` 8b013fce5 Merge bitcoin-core/secp256k1#1056: Save negations in var-time group addition 7efc9835a Fix the false positive of `SECP_64BIT_ASM_CHECK` 8746600ee Merge bitcoin-core/secp256k1#1093: hash: Make code agnostic of endianness 2f984ffc4 Save negations in var-time group addition 37d36927d tests: Add tests for _read_be32 and _write_be32 912b7ccc4 Merge bitcoin-core/secp256k1#1094: doc: Clarify configure flags for optional modules 55512d30b doc: clean up module help text in configure.ac d9d94a996 doc: mention optional modules in README 616b43dd3 util: Remove endianness detection 8d89b9e6e hash: Make code agnostic of endianness d0ad5814a Merge bitcoin-core/secp256k1#995: build: stop treating schnorrsig, extrakeys modules as experimental 1ac7e31c5 Merge bitcoin-core/secp256k1#1089: Schnorrsig API improvements 587239dbe Merge bitcoin-core/secp256k1#731: Change SHA256 byte counter from size_t to uint64_t f8d917435 Add SHA256 bit counter tests 7f09d0f31 README: mention that ARM assembly is experimental b8f8b99f0 docs: Fix return value for functions that don't have invalid inputs f813bb0df schnorrsig: Adapt example to new API 99e6568fc schnorrsig: Rename schnorrsig_sign to schnorsig_sign32 and deprecate fc94a2da4 Use SECP256K1_DEPRECATED for existing deprecated API functions 3db056060 Add SECP256K1_DEPRECATED attribute for marking API parts as deprecated 09f3d71c5 configure: Add a few CFLAGS for MSVC 3b4f3d0d4 build: Reject C++ compilers in the preprocessor 1cc094141 configure: Don't abort if the compiler does not define __STDC__ 80cf4eea5 build: stop treating schnorrsig, extrakeys modules as experimental e0508ee9d Merge bitcoin-core/secp256k1#1090: configure: Remove redundant pkg-config code 21b2ebaf7 configure: Remove redundant pkg-config code cca8cbbac configure: Output message when checking for valgrind 1a6be5745 bench: Make benchmarks compile on MSVC 0e5cbd01b Merge bitcoin-core/secp256k1#1088: configure: Use modern way to set AR 0d253d52e configure: Use modern way to set AR 9b514ce1d Add test vector for very long SHA256 messages 8e3dde113 Simplify struct initializer for SHA256 padding eb28464a8 Change SHA256 byte counter from size_t to uint64_t ac83be33d Merge bitcoin-core/secp256k1#1079: configure: Add hidden --enable-dev-mode to enable all the stuff e089eecc1 group: Further simply gej_add_ge e0838d663 configure: Add hidden --enable-dev-mode to enable all the stuff fabd579df configure: Remove redundant code that sets _enable variables 0d4226c05 configure: Use canonical variable prefix _enable consistently 64b34979e Merge bitcoin-core/secp256k1#748: Add usage examples 7c9502cec Add a copy of the CC0 license to the examples 42e03432e Add usage examples to the readme 517644eab Optionally compile the examples in autotools, compile+run in travis 422a7cc86 Add a ecdh shared secret example b0cfbcc14 Add a Schnorr signing and verifying example fee7d4bf9 Add an ECDSA signing and verifying example ac71020eb group: Save a normalize_to_zero in gej_add_ge 1253a2775 Merge bitcoin-core/secp256k1#1033: Add _fe_half and use in _gej_add_ge and _gej_double 3ef94aa5b Merge bitcoin-core/secp256k1#1026: ecdh: Add test computing shared_secret=basepoint with random inputs 3531a43b5 ecdh: Make generator_basepoint test depend on global iteration count c881dd49b ecdh: Add test computing shared_secret=basepoint with random inputs 077528317 Merge bitcoin-core/secp256k1#1074: ci: Retry brew update a few times to avoid random failures e51ad3b73 ci: Retry `brew update` a few times to avoid random failures b1cb969e8 ci: Revert "Attempt to make macOS builds more reliable" 5dcc6f8db Merge bitcoin-core/secp256k1#1069: build: Replace use of deprecated autoconf macro AC_PROG_CC_C89 59547943d Merge bitcoin-core/secp256k1#1072: ci: Attempt to make macOS builds more reliable 85b00a1c6 Merge bitcoin-core/secp256k1#1068: sage: Fix incompatibility with sage 9.4 ebb1beea7 sage: Ensure that constraints are always fastfracs d8d54859e ci: Run sage prover on CI 77cfa98db sage: Normalize sign of polynomial factors in prover eae75869c sage: Exit with non-zero status in case of failures d9396a56d ci: Attempt to make macOS builds more reliable e0db3f8a2 build: Replace use of deprecated autoconf macro AC_PROG_CC_C89 e848c3799 Update sage files for new formulae d64bb5d4f Add fe_half tests for worst-case inputs b54d843ea sage: Fix printing of errors 4eb8b932f Further improve doubling formula using fe_half 557b31fac Doubling formula using fe_half 2cbb4b1a4 Run more iterations of run_field_misc 9cc5c257e Add test for secp256k1_fe_half 925f78d55 Add _fe_half and use in _gej_add_ge e108d0039 sage: Fix incompatibility with sage 9.4 d8a246324 Merge bitcoin-core/secp256k1#899: Reduce stratch space needed by ecmult_strauss_wnaf. 0a40a4861 Merge bitcoin-core/secp256k1#1049: Faster fixed-input ecmult tests 070e77221 Faster fixed-input ecmult tests c8aa516b5 Merge bitcoin-core/secp256k1#1064: Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063 b797a500e Create a SECP256K1_ECMULT_TABLE_VERIFY macro. a731200cc Replace ECMULT_TABLE_GET_GE_STORAGE macro with a function. fe34d9f34 Eliminate input_pos state field from ecmult_strauss_wnaf. 0397d00ba Eliminate na_1 and na_lam state fields from ecmult_strauss_wnaf. 7ba3ffcca Remove the unused pre_a_lam allocations. b3b57ad6e Eliminate the pre_a_lam array from ecmult_strauss_wnaf. ae7ba0f92 Remove the unused prej allocations. e5c18892d Eliminate the prej array from ecmult_strauss_wnaf. c9da1baad Move secp256k1_fe_one to field.h 45f37b650 Modulo-reduce msg32 inside RFC6979 nonce fn to match spec. Fixes #1063. a1102b121 Merge bitcoin-core/secp256k1#1029: Simpler and faster ecdh skew fixup e82144edf Fixup skew before global Z fixup 40b624c90 Add tests for _gej_cmov 8c13a9bfe ECDH skews by 0 or 1 151509943 Simpler and faster ecdh skew fixup 39a36db94 Merge bitcoin-core/secp256k1#1054: tests: Fix test whose result is implementation-defined a310e79ee Merge bitcoin-core/secp256k1#1052: Use xoshiro256++ instead of RFC6979 for tests 423b6d19d Merge bitcoin-core/secp256k1#964: Add release-process.md 9281c9f4e Merge bitcoin-core/secp256k1#1053: ecmult: move `_ecmult_odd_multiples_table_globalz_windowa` 77a19750b Use xoshiro256++ PRNG instead of RFC6979 in tests 5f2efe684 secp256k1_testrand_int(2**N) -> secp256k1_testrand_bits(N) 05e049b73 ecmult: move `_ecmult_odd_multiples_table_globalz_windowa` 3d7cbafb5 tests: Fix test whose result is implementation-defined 3ed0d02bf doc: add CHANGELOG template 6f42dc16c doc: add release_process.md 0bd3e4243 build: set library version to 0.0.0 explicitly b4b02fd8c build: change libsecp version from 0.1 to 0.1.0-pre 09971a3ff Merge bitcoin-core/secp256k1#1047: ci: Various improvements 0b83b203e Merge bitcoin-core/secp256k1#1030: doc: Fix upper bounds + cleanup in field_5x52_impl.h comment 1287786c7 doc: Add comment to top of field_10x26_impl.h 58da5bd58 doc: Fix upper bounds + cleanup in field_5x52_impl.h comment b39d431ae Merge bitcoin-core/secp256k1#1044: Add another ecmult_multi test b4ac1a1d5 ci: Run valgrind/memcheck tasks with 2 CPUs e70acab60 ci: Use Cirrus "greedy" flag to use idle CPU time when available d07e30176 ci: Update brew on macOS 22382f0ea ci: Test different ecmult window sizes a69df3ad2 Merge bitcoin-core/secp256k1#816: Improve checks at top of _fe_negate methods 22d25c8e0 Add another ecmult_multi test 515e7953c Improve checks at top of _fe_negate methods 26a022a3a ci: Remove STATICPRECOMPUTATION 10461d8bd precompute_ecmult: Always compute all tables up to default WINDOW_G be6944ade Merge bitcoin-core/secp256k1#1042: Follow-ups to making all tables fully static e05da9e48 Fix c++ build c45386d99 Cleanup preprocessor indentation in precompute{,d}_ecmult{,_gen} 19d96e15f Split off .c file from precomputed_ecmult.h 1a6691ada Split off .c file from precomputed_ecmult_gen.h bb3633141 Simplify precompute_ecmult_print_* 38cd84a0c Compute ecmult tables at runtime for tests_exhaustive e458ec26d Move ecmult table computation code to separate file fc1bf9f15 Split ecmult table computation and printing 31feab053 Rename function secp256k1_ecmult_gen_{create_prec -> compute}_table 725370c3f Rename ecmult_gen_prec -> ecmult_gen_compute_table 075252c1b Rename ecmult_static_pre_g -> precomputed_ecmult 7cf47f72b Rename ecmult_gen_static_prec_table -> precomputed_ecmult_gen f95b8106d Rename gen_ecmult_static_pre_g -> precompute_ecmult bae77685e Rename gen_ecmult_gen_static_prec_table -> precompute_ecmult_gen 0559fc6e4 Merge bitcoin-core/secp256k1#988: Make signing table fully static 7dfceceea build: Remove #undef hack for ASM in the precomputation programs bb36fe9be ci: Test `make precomp` d94a37a20 build: Remove CC_FOR_BUILD stuff ad63bb4c2 build: Prebuild and distribute ecmult_gen table ac49361ed prealloc: Get rid of manual memory management for prealloc contexts 6573c08f6 ecmult_gen: Tidy precomputed file and save space 5eba83f17 ecmult_gen: Precompute tables for all values of ECMULT_GEN_PREC_BITS 5d0dbef01 Merge bitcoin-core/secp256k1#942: Verify that secp256k1_ge_set_gej_zinv does not operate on infinity. 486205aa6 Merge bitcoin-core/secp256k1#920: Test all ecmult functions with many j*2^i combinations fdb33dd12 refactor: Make PREC_BITS a parameter of ecmult_gen_build_prec_table 5eb519e1f ci: reduce TEST_ITERS in memcheck run e2cf77328 Test ecmult functions for all i*2^j for j=0..255 and odd i=1..255. 61ae37c61 Merge bitcoin-core/secp256k1#1022: build: Windows DLL additions 4f01840b8 Merge bitcoin-core/secp256k1#1027: build: Add a check that Valgrind actually supports a host platform 6ad908aa0 Merge bitcoin-core/secp256k1#1008: bench.c: add `--help` option and ci: move env variables 592661c22 ci: move test environment variable declaration to .cirrus.yml dcbe84b84 bench: add --help option to bench. 099bad945 Comment and check a parameter for inf in secp256k1_ecmult_const. 6c0be857f Verify that secp256k1_ge_set_gej_zinv does not operate on infinity. a->x and a->y should not be used if the infinity flag is set. 490022745 Merge bitcoin-core/secp256k1#1025: build: replace backtick command substitution with $() 7c7ce872a build: Add a check that Valgrind actually supports a host platform a4875e30a refactor: Move default callbacks to util.h 4c94c55bc doc: Remove obsolete hint for valgrind stack size 510622699 exhaustive_tests: Fix with ecmult_gen table with custom generator e1a76530d refactor: Make generator a parameter of ecmult_gen_create_prec_table 9ad09f691 refactor: Rename program that generates static ecmult_gen table 8ae18f1ab refactor: Rename file that contains static ecmult_gen table 00d2fa116 ecmult_gen: Make code consistent with comment 3b0c2185e ecmult_gen: Simplify ecmult_gen context after making table static 2b7c7497e build: replace backtick command substitution with $() 49f608de4 Merge bitcoin-core/secp256k1#1004: ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS c0cd7de6d build: add -no-undefined to libtool LDFLAGS fe32a79d3 build: pass win32-dll to LT_INIT 60bf8890d ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS fecf436d5 Merge bitcoin-core/secp256k1#1019: build: don't append valgrind CPPFLAGS if not installed (macOS) 2e5e4b67d Merge bitcoin-core/secp256k1#1020: doc: remove use of <0xa0> "no break space" 812ff5c74 doc: remove use of 0xa0 "no break space" 214042a17 build: don't append valgrind CPPFLAGS if not installed e43ba02cf refactor: Decouple table generation and ecmult_gen context 22dc2c0a0 ecmult_gen: Move table creation to new file and force static prec 793ad9016 Merge bitcoin-core/secp256k1#1010: doc: Minor fixes in safegcd_implementation.md dc9b6853b doc: Minor fixes in safegcd_implementation.md ea5e8a9c4 Merge bitcoin-core/secp256k1#1012: Fix typos 233297579 Fix typos 7006f1b97 Merge bitcoin-core/secp256k1#1011: ci: Enable -g if we set CFLAGS manually 72de1359e ci: Enable -g if we set CFLAGS manually 74c34e727 Merge bitcoin-core/secp256k1#1009: refactor: Use (int)&(int) in boolean context to avoid compiler warning 16d132215 refactor: Use (int)&(int) in boolean context to avoid compiler warning c74a7b7e5 Merge bitcoin-core/secp256k1#1007: doc: Replace apoelstra's GPG key by jonasnick's GPG key 3b157c48e doc: Suggest keys.openpgp.org as keyserver in SECURITY.md 73a7472cd doc: Replace apoelstra's GPG key by jonasnick's GPG key 515a5dbd0 Merge bitcoin-core/secp256k1#991: Merge all "external" benchmarks into a single bench binary af6abcb3d Make bench support selecting which benchmarks to run 9f56bdf5b Merge bench_schnorrsig into bench 3208557ae Merge bench_recover into bench 855e18d8a Merge bench_ecdh into bench 2a7be678a Combine bench_sign and bench_verify into single bench 8fa41201b Merge bitcoin-core/secp256k1#1002: Make aux_rnd32==NULL behave identical to 0x0000..00. 5324f8942 Make aux_rnd32==NULL behave identical to 0x0000..00. 21c188b3c Merge bitcoin-core/secp256k1#943: VERIFY_CHECK precondition for secp256k1_fe_set_int. 3e7b2ea19 Merge bitcoin-core/secp256k1#999: bench_ecmult: improve clarity of output 23e2f6672 bench: don't return 1 in have_flag() if argc = 1 96b1ad2ea bench_ecmult: improve clarity of output 20d791edf Merge bitcoin-core/secp256k1#989: Shared benchmark format for command line and CSV outputs aa1b889b6 Merge bitcoin-core/secp256k1#996: Fix G.y parity in sage code 044d95630 Fix G.y parity in sage code b4b130678 create csv file from the benchmark output 26a255beb Shared benchmark format for command line and CSV outputs 9526874d1 Merge bitcoin-core/secp256k1#810: Avoid overly-wide multiplications in 5x52 field mul/sqr 920a0e5fa Merge bitcoin-core/secp256k1#952: Avoid computing out-of-bounds pointer. f34b5cae0 Merge bitcoin-core/secp256k1#983: [RFC] Remove OpenSSL testing support 297ce8209 Merge bitcoin-core/secp256k1#966: Make aux_rand32 arg to secp256k1_schnorrsig_sign const 288864013 VERIFY_CHECK precondition for secp256k1_fe_set_int. d49011f54 Make _set_fe_int( . , 0 ) set magnitude to 0 bc08599e7 Remove OpenSSL testing support 10f9bd84f Merge bitcoin-core/secp256k1#987: Fix unused parameter warnings when building without VERIFY 189f6bcfe Fix unused parameter warnings when building without VERIFY da0092bcc Merge bitcoin-core/secp256k1#986: tests: remove `secp256k1_fe_verify` from tests.c and modify `_fe_from_storage` to call `_fe_verify` d43993724 tests: remove `secp256k1_fe_verify` from tests.c and modify `secp256k1_fe_from_storage` to call `secp256k1_fe_verify` 2a3a97c66 Merge bitcoin-core/secp256k1#976: `secp256k1_schnorrsig_sign_internal` should be static aa5d34a8f Merge bitcoin-core/secp256k1#783: Make the public API docs more consistent and explicit 72713872a Add missing static to secp256k1_schnorrsig_sign_internal db4667d5e Make aux_rand32 arg to secp256k1_schnorrsig_sign const 9a5a87e0f Merge bitcoin-core/secp256k1#956: Replace ecmult_context with a generated static array. 20abd52c2 Add tests for pre_g tables. 6815761cf Remove ecmult_context. f20dcbbad Correct typo. 16a3cc07e Generate ecmult_static_pre_g.h 8de2d86a0 Bump memory limits in advance of making the ecmult context static. d7ec49a68 Merge bitcoin-core/secp256k1#969: ci: Fixes after Debian release 5d5c74a05 tests: Rewrite code to circument potential bug in clang 3d2f492ce ci: Install libasan6 (instead of 5) after Debian upgrade be8d9c262 Merge bitcoin-core/secp256k1#965: gen_context: Don't use any ASM aeece4459 gen_context: Don't use any ASM 7688a4f13 Merge bitcoin-core/secp256k1#963: "Schnorrsig API overhaul" fixups 90e83449b ci: Add C++ test adec5a163 Add missing null check for ctx and input keys in the public API f4edfc758 Improve consistency for NULL arguments in the public interface f698caaff Use unsigned char consistently for byte arrays b5b8e7b71 Don't declare constants twice 769528f30 Don't use string literals for char arrays without NUL termination 2cc3cfa58 Fix -Wmissing-braces warning in clang 0440945fb Merge #844: schnorrsig API overhaul ec3aaa501 Merge #960: tests_exhaustive: check the result of secp256k1_ecdsa_sign a1ee83c65 tests_exhaustive: check the result of secp256k1_ecdsa_sign 253f90cde Merge bitcoin-core/secp256k1#951: configure: replace AC_PATH_PROG to AC_CHECK_PROG 446d28d9d Merge bitcoin-core/secp256k1#944: Various improvements related to CFLAGS 0302138f7 ci: Make compiler warning into errors on CI b924e1e60 build: Ensure that configure's compile checks default to -O2 7939cd571 build: List *CPPFLAGS before *CFLAGS like on the compiler command line 595e8a35d build: Enable -Wcast-align=strict warning 07256267f build: Use own variable SECP_CFLAGS instead of touching user CFLAGS 4866178df Merge bitcoin-core/secp256k1#955: Add random field multiply/square tests 75ce488c2 Merge bitcoin-core/secp256k1#959: tests: really test the non-var scalar inverse 41ed13942 tests: really test the non-var scalar inverse 5f6ceafcf schnorrsig: allow setting MSGLEN != 32 in benchmark fdd06b796 schnorrsig: add tests for sign_custom and varlen msg verification d8d806aaf schnorrsig: add extra parameter struct for sign_custom a0c3fc177 schnorrsig: allow signing and verification of variable length msgs 5a8e4991a Add secp256k1_tagged_sha256 as defined in BIP-340 b6c0b72fb schnorrsig: remove noncefp args from sign; add sign_custom function bdf19f105 Add random field multiply/square tests 9be7b0f08 Avoid computing out-of-bounds pointer. a4642fa15 configure: replace AC_PATH_PROG to AC_CHECK_PROG 442cee5ba schnorrsig: add algolen argument to nonce_function_hardened df3bfa12c schnorrsig: clarify result of calling nonce_function_bip340 without data 99e861481 README: mention schnorrsig module b53e0cd61 Avoid overly-wide multiplications git-subtree-dir: src/secp256k1 git-subtree-split: 0fa84f869d51e1b71113d81fcd518ebcee08709a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
test_inverse_scalarcontains:The two sides of the condition are the same function. This seems to be an error, as there also exists a non-var function, named
secp256k1_scalar_inverse.Make
test_inverse_scalaruse this other function whenvaris false.This issue was found using clang's static analyzer, which reported a "Logic error: Identical expressions in conditional expression" (with checker
alpha.core.IdenticalExpr).