This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
refactor: include-what-you-use #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 12, 2022
6c19d050a9 Merge bitcoin-core/univalue-subtree#33: Add getInt<Integral>() helper 09e4a930fc Add getInt helper 10619e0d9a Merge bitcoin-core/univalue-subtree#32: refactor: include-what-you-use 431cdf5d27 refactor: use constexpr where appropriate 64fc881fa4 refactor: cleanup headers for iwyu 9c35bf38eb Merge bitcoin-core/univalue-subtree#30: doc: note that our API has diverged from upstream 09b65facb9 doc: note that our API has diverged from upstream git-subtree-dir: src/univalue git-subtree-split: 6c19d050a9bcb2be216121db0df57c930a9ee12e
vmta
added a commit
to umkoin/umkoin
that referenced
this pull request
May 15, 2022
68c8f5532 Merge bitcoin-core/univalue-subtree#34: doc: remove TODO 297c53a5e doc: remove TODO 6c19d050a Merge bitcoin-core/univalue-subtree#33: Add getInt<Integral>() helper 09e4a930f Add getInt helper 10619e0d9 Merge bitcoin-core/univalue-subtree#32: refactor: include-what-you-use 431cdf5d2 refactor: use constexpr where appropriate 64fc881fa refactor: cleanup headers for iwyu 9c35bf38e Merge bitcoin-core/univalue-subtree#30: doc: note that our API has diverged from upstream 09b65facb doc: note that our API has diverged from upstream a44caf65f Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues 135254331 Import fixes for sanitizer reported issues d5fb86940 refactor: use c++11 range based for loop in checkObject ff9c37930 refactor: Use nullptr (c++11) instead of NULL 08a99754d build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support 66d3713ce Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus 808d48729 ci: travis -> cirrus c390ac375 Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration 4a5b0a1c6 build: Move source entries out to sources.mk 6c7d94b33 build: cleanup wonky gen usage git-subtree-dir: src/univalue git-subtree-split: 68c8f5532d02203ec37eb4b2baf8492249f73ab6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With there changes there is a single suggested include, which is incorrect, and can be dealt with in our mapping file:
lib/univalue.cpp should add these lines: #include <ext/alloc_traits.h> // for __alloc_traits<>::value_type