Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP 118 (ANYPREVOUT) #4

Merged
merged 8 commits into from
Oct 20, 2022
Merged

BIP 118 (ANYPREVOUT) #4

merged 8 commits into from
Oct 20, 2022

Commits on Sep 23, 2022

  1. anyprevout

    @ajtowns
    ajtowns committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e1d319a View commit details
    Browse the repository at this point in the history

  2. unit_tests

    @ajtowns
    ajtowns committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    68913ec View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Add ANYPREVOUT deployment

    @ajtowns
    ajtowns committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    5696581 View commit details
    Browse the repository at this point in the history

  2. update test framework for anyprevout

    @ajtowns
    ajtowns committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    130a0de View commit details
    Browse the repository at this point in the history

  3. functional test updates

    @ajtowns
    ajtowns committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    7439808 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. fixups: review feedback

    @ajtowns
    ajtowns committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    abcfeb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. fixup: pass m_internal_key to VerifyTaprootCommitment as reference

    @ajtowns
    ajtowns committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    9f116ef View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. qa: add a fuzz target ensuring the sighash behaviour for non APO keys… 

    … was conserved

This fuzz targets copied the SignatureHashSchnorr function for Bitcoin
Core 23.0 and checks the output of the APO-ready SignatureHashSchnorr
from this branch against it.

This is to make sure the behaviour of the function was not changed for
non ANYPREVOUT keys, which would make some previously valid signatures
invalid and, even worse, some previously invalid signatures valid.
    @darosior @ajtowns
    darosior authored and ajtowns committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    9723de0 View commit details
    Browse the repository at this point in the history