gui: Create wallet menu option #15450

achow101 · 2019-02-20T17:45:01Z

This PR adds a menu option to create a new wallet. When clicked, a CreateWalletDialog will be created and prompt the user to name the wallet and choose whether to disable private keys, make a blank wallet, and encrypt the wallet. If the wallet is encrypted, the wallet will be born encrypted with the wallet first created blank, then encrypted, and then a new HD seed generated and set.

To allow the newly created wallets to be encrypted, some changes to how encrypting a wallet works. Instead of encrypting and locking the wallet, the wallet will be encrypted and then unlocked. This is also an extra belt-and-suspenders check to make sure that encryption worked.

ryanofsky · 2019-02-20T18:39:30Z

src/qt/createwalletdialog.cpp

+    dialog->show();
+
+    // Create the wallet
+    std::unique_ptr<interfaces::Wallet> wallet = m_wallet_controller->createWallet(wallet_name, flags);


Maybe it is too difficult to do in this PR, but if it's possible to avoid creating the wallet in the GUI event loop thread and calling createWallet, setNewHdSeed, topUpKeyPool synchronously that would be a nice of allowing the GUI to avoid hangs and be more responsive. I believe @promag has some changes which use worker threads, so he might be able to give specific suggestions.

There may also be reason to avoid the new dlg.exec() call as in #15313.

I'm not very familiar with the GUI code so I think it would best to let someone else do that.

The suggestion I have is to do similar to #15478. I think it's fine as a follow up.

instagibbs · 2019-02-20T19:36:16Z

Maybe:

Move Encrypt wallet to the top since it's likely the most common thing people would do
The menu as-is lacks any explanation, which makes it hard to evaluate unless you're an expert and know all the internals. Explain what they do/interactions between different modes

achow101 · 2019-02-20T19:46:00Z

Move Encrypt wallet to the top since it's likely the most common thing people would do

Done

The menu as-is lacks any explanation, which makes it hard to evaluate unless you're an expert and know all the internals. Explain what they do/interactions between different modes

There are tooltips that explain this. Hover over the selections.

DrahtBot · 2019-02-20T20:02:54Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#10102 ([experimental] Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Sjors · 2019-02-20T21:11:58Z

Concept ACK 🎉

promag · 2019-02-20T21:53:14Z

Concept ACK, will pick this shortly and push a branch with some changes for your consideration.

src/qt/bitcoingui.cpp

fanquake · 2019-02-21T04:51:41Z

Concept ACK.

Screen:

Travis warning:
A new circular dependency in the form of "qt/bitcoingui -> qt/createwalletdialog -> qt/bitcoingui" appears to have been introduced.

jonasschnelli · 2019-02-21T05:45:29Z

General Concept ACK
I'm not sure if we – yet - should allow creating a blank wallet or a wallet with disabled private keys since it can't be used/extended with the GUI (outside of the console). It would make very much sense if there would be a way to import descriptors/addresses and or set/change a hd seed via the GUI.

Sjors · 2019-02-21T08:50:13Z

Works!

Couple of things, nothing that can't wait for a followup, but since this is still very early in the 0.19 cycle might as well get it right:

I suspect adding a grey border, like in the send / receive screen, is more visually pleasing. It also allows separating the screen into sections.
Let's add a section Advanced, where the Disable Private Keys and Make Blank Wallet goes.
Left side of check boxes should be aligned with the "Wallet" label.
"Create Wallet" menu items needs "..." (to indicate there's still some form of confirmation)
Rename "OK" to "Create"
Disable OK and Cancel buttons as soon as the users clicks OK (might tie into @ryanofsky's point about event loops, because double clicking doesn't cause a duplicate wallet afaik)
When you click Encrypt Wallet, unhide an "Encryption" section with a Password & Confirmation field (just like we unhide coin selection and fees section)
Disable the OK (Create) button until form validation passes (in this case: name must be set)
Set initial focus on name field, and pressing tab should jump to the check boxes, the text next to them (this makes the tooltip accessible), and the OK / Cancel field
Canceling the password dialog should result in canceling wallet creation (easy to prevent with the previous suggestion, because the form would simply be invalid if "Encrypt" is ticked and the password is empty or not matching)

I agree with @jonasschnelli that being able to enter descriptors here would be useful, but I suggest holding off on that until we have a descriptor based wallet. Otherwise we have to explain that once the keypool runs out they somehow need to top it up. For the most part I expect descriptors would be part of a recovery workflow, which could be another menu item like Recover wallet. But they could also be an advanced setting during wallet creation, if someone wants to override our default derivation paths.

hebasto · 2019-02-24T20:54:22Z

Concept ACK.

src/qt/walletcontroller.cpp

jnewbery · 2019-05-22T17:52:42Z

This fails a linter on Travis ("A new circular dependency in the form of "qt/bitcoingui -> qt/createwalletdialog -> qt/bitcoingui" appears to have been introduced."), and also fails to build when rebased on master, since WalletImpl.m_wallet is now a shared pointer instead of a CWallet object.

@achow101 - do you intend to keep working on this?

achow101 · 2019-05-22T18:13:55Z

Yes, I'll rebase and have a look at it again soon.

achow101 · 2019-05-23T18:36:24Z

Rebased.

I'm not entirely sure how to get rid of the circular dependency.

jnewbery

Thanks for rebasing @achow101!

I'm not entirely sure how to get rid of the circular dependency.

I think for now it's ok to remove the call to m_parent->setCurrentWallet(model); in CreateWalletDialog::accept(). That would allow you to not have an m_wallet member variable, and change the CreateWalletDialog::CreateWalletDialog() signature to take a QWidget* instead of a BitcoinGUI*.

This matches the existing 'Open Wallet' behaviour, which does not select the new wallet when it's opened.

src/wallet/wallet.cpp

src/wallet/wallet.h

src/wallet/rpcwallet.cpp

src/qt/createwalletdialog.cpp

src/qt/forms/createwalletdialog.ui

jnewbery · 2019-05-23T22:13:45Z

src/qt/forms/createwalletdialog.ui

+    <string>Wallet Name</string>
+   </property>
+  </widget>
+  <widget class="QCheckBox" name="disable_privkeys_checkbox">


I agree with @Sjors that these two boxes should be hidden in an 'Advanced options' section.

I couldn't figure out how to do this.

src/qt/createwalletdialog.cpp

jnewbery

This now segfaults for me when I try to create an encryted wallet.

I think that https://github.com/bitcoin/bitcoin/pull/15450/files#r287152838 needs to be addressed. If not, perhaps this PR could drop support for creating encrypted wallets to begin with, and we add that later.

src/qt/createwalletdialog.h

src/qt/createwalletdialog.cpp

achow101 · 2019-05-24T22:18:20Z

I've made two major changes to this: AskPassphraseDialog now has an output parameter for it to return the passphrase for encryption mode and I refactored the createwallet RPC so that all of the other wallet creation stuff it does (checking flags, encryption, etc.) is in its own function that this GUI option can call too. These two changes fix the issues that @jnewbery mentioned earlier. And it no longer segfaults.

fanquake

ACK da8a86c - Haven't reviewed all of the Qt changes in depth. However I would like to see this in for v0.19.0. If this is merged soon, then we've still got time to shake out any bugs and get follow up changes in.

Tested creating the different types of wallets.

Checked that when Encrypt Wallet is selected Disable Private Keys is disabled. Also checked that if Disable Private Keys was checked before Encrypt Wallet is selected it gets unchecked.

Looks like my auto-focusing suggestion might have been lost in a rebase?
However at this point it's definitely not a blocker for merging:

m_passphrase_dialog->setWindowModality(Qt::ApplicationModal); 
m_passphrase_dialog->show();

This is at least one inconsistency where if you create a wallet with a HTML escaped character in the name, i.e Alice & Bob, then the & will not be shown in some menus / dialogs.

meshcollider · 2019-09-05T13:37:06Z

I agree with fanquake, I'll review+test tomorrow but I think I will merge it after that to give proper time for testing as mentioned. Please review before then everyone :D

jonatack

ACK da8a86c. Built, ran all tests, manually tested the gui wallet with Debian, reviewed the code.

Verified:

when "Encrypt Wallet" is selected, "Disable Private Keys" is disabled
when "Disable Private Keys" is checked and then "Encrypt Wallet" is selected, "Disable" is unchecked

I'm not sure what auto-focus issue @fanquake is seeing in #15450 (review). The focus behaves well in my testing. It begins automatically in the name field, and tabbing moves it successively through all the fields in the correct order.

if you create a wallet with a HTML escaped character in the name, i.e Alice & Bob,
then the & will not be shown in some menus / dialogs.

Saw the same issue on Debian. Among the special characters I entered, only the & seemed to be affected.

A few comments follow. Feel free to ignore or add them to the to-do list for the future.

jonatack · 2019-09-05T18:20:56Z

src/qt/forms/createwalletdialog.ui

+    </rect>
+   </property>
+   <property name="toolTip">
+    <string>Encrypt the wallet. The wallet will be encrypted with a password of your choice.</string>


s/password/passphrase/ given that the dialog in question asks the user to input passphrases, not passwords

jonatack · 2019-09-05T18:25:17Z

src/qt/createwalletdialog.cpp

+    return ui->wallet_name_line_edit->text();
+}
+
+bool CreateWalletDialog::encrypt() const


Nit: it would be clearer to name this as encryptWallet here and makeBlankWallet on line 58, the way disablePrivateKeys is named.

jonatack · 2019-09-05T18:28:07Z

src/qt/createwalletdialog.h

+    QString walletName() const;
+    bool encrypt() const;
+    bool disablePrivateKeys() const;
+    bool blank() const;


Nit: following my comment above, naming these encryptWallet and makeBlankWallet (like disablePrivateKeys) seems more precise/coherent/would improve git grepping.

jonatack · 2019-09-05T18:32:33Z

src/qt/guiconstants.h

@@ -5,6 +5,8 @@
 #ifndef BITCOIN_QT_GUICONSTANTS_H
 #define BITCOIN_QT_GUICONSTANTS_H

+#include <cstdint>


For my understanding, why is this now needed?

jonatack · 2019-09-05T18:34:52Z

src/qt/walletcontroller.cpp

    }
+
+    QTimer::singleShot(500, worker(), [this, name, flags] {


Nit: would be nice to hoist the 4 occurrences of this magic value (500) to a helpfully named constant.

promag · 2019-09-05T23:06:25Z

@achow101 please rebase, here's the trivial diff from my PR:

diff --git a/src/qt/walletcontroller.cpp b/src/qt/walletcontroller.cpp
index d0ffd6ba3..88ccc8c2d 100644
--- a/src/qt/walletcontroller.cpp
+++ b/src/qt/walletcontroller.cpp
@@ -160,10 +160,6 @@ void WalletControllerActivity::showProgressDialog(const QString& label_text)
     m_progress_dialog->setCancelButton(nullptr);
     m_progress_dialog->setWindowModality(Qt::ApplicationModal);
     GUIUtil::PolishProgressDialog(m_progress_dialog);
-
-    connect(m_progress_dialog, &QObject::destroyed, [this] {
-        m_progress_dialog = nullptr;
-    });
 }

 OpenWalletActivity::OpenWalletActivity(WalletController* wallet_controller, QWidget* parent_widget)
@@ -192,11 +188,11 @@ void OpenWalletActivity::open(const std::string& path)

     showProgressDialog(tr("Opening Wallet <b>%1</b>...").arg(name.toHtmlEscaped()));

-    QTimer::singleShot(500, worker(), [this, path] {
+    QTimer::singleShot(0, worker(), [this, path] {
         std::unique_ptr<interfaces::Wallet> wallet = node().loadWallet(path, m_error_message, m_warning_message);

         if (wallet) m_wallet_model = m_wallet_controller->getOrCreateWallet(std::move(wallet));

-        QTimer::singleShot(500, this, &OpenWalletActivity::finish);
+        QTimer::singleShot(0, this, &OpenWalletActivity::finish);
     });
 }
diff --git a/src/qt/walletcontroller.h b/src/qt/walletcontroller.h
index da8fde9f5..dada9cfa6 100644
--- a/src/qt/walletcontroller.h
+++ b/src/qt/walletcontroller.h
@@ -46,10 +46,11 @@ public:
     //! Returns wallet models currently open.
     std::vector<WalletModel*> getOpenWallets() const;

+    WalletModel* getOrCreateWallet(std::unique_ptr<interfaces::Wallet> wallet);
+
     //! Returns all wallet names in the wallet dir mapped to whether the wallet
     //! is loaded.
     std::map<std::string, bool> listWalletDir() const;
-    WalletModel* getOrCreateWallet(std::unique_ptr<interfaces::Wallet> wallet);

     void closeWallet(WalletModel* wallet_model, QWidget* parent = nullptr);

promag · 2019-09-05T23:35:57Z

Tested ACK on macOS 10.14.3 (rebased with my branch), played around, looks good to me.

This is at least one inconsistency where if you create a wallet with a HTML escaped character in the name, i.e Alice & Bob, then the & will not be shown in some menus / dialogs.

@fanquake something to fix next.

Co-authored-by: João Barbosa <[email protected]>

achow101 · 2019-09-06T00:38:49Z

Rebased onto #16261

sipa · 2019-09-06T18:42:35Z

Concept and approach ACK

fanquake · 2019-09-07T06:29:29Z

ACK 613de61 - re-reviewed on macOS. I'm going to merge this now. It's had a stack of review, and as mentioned multiple times above, lets get this into master so it can get more testing pre v0.19.0.

Checked that the gui: Refactor OpenWalletActivity commit in this PR matches the one in #16261. So will close #16261 post merge here.

Re-rested creating the different wallet types.

Checked that when Encrypt Wallet is selected Disable Private Keys is disabled. Also checked that if Disable Private Keys was checked before Encrypt Wallet is selected it gets unchecked.

Checked that there still aren't any issues when compiling with --disable-wallet.

I'm not sure what auto-focus issue @fanquake is seeing

At least on macOS, if you're creating an encrypted wallet, after clicking Create the Encrypt wallet dialog isn't focused, so you can't type until you click on it.

Screenshots:

Follow up for this PR include:

Encrypt wallet focussing (maybe macOS only).
HTML escaping issue
A couple nits from jonatack review

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK 613de61 - re-reviewed on macOS. I'm going to merge this now. It's had a stack of review, and as mentioned multiple times above, lets get this into master so it can get more testing pre v0.19.0.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEz7FuIclQ9n+pXlWPLuufXMCVJsEFAl1zUgAACgkQLuufXMCV
JsGSEg//QrKZvNXQ6Jwom8qsfw3Zlcd7rIoJoLI9jfhXEGzIDi9yrTryrYWTzaqq
PVp8aeFyQtXPg9a06mWaQJG0Gb2sQRv6rUAba8fLfDiEg+ycFzMRsd53o3fY0O+a
FhTmE2hdkVQnwZX9yDmyRKnbmL2l0FP9zGqfas78yHVkq47zRe7dbcTQcLyLjhck
sFAnZGJVgyko3ynRsk4YqIk3e5ALMcVXzJIXknbpiHlmwb346on1O08oiPMjArmo
3lDrEF1QuOs7DXrmW5y/aaCgd06EtqlZ1ufL1ISSHM8lah/sRrDkF+TMymJ6yLie
pIrOQu8UUkLLh8hUsmHMlMtFksQHUSBRI2XYuYkfHJI6TB/M0f4UfCz7nq1VlLyZ
YUKl4r6hgy+/GPrjQkf7b80zwpLdC0xaiNGI9S2zfpIk0rYJxkrB+2AKpmRQZsCX
B004jEICoe6elyLtepAwm77UCDXz6cA3XDhlYT1415nWm3MM4mRgGPKMHe1K19A8
YyhrUfPI5ZCS2hEim5g/6VCYeY4HzOi9OlsZnzFhQbL2ImgNlyMQ3OC2KiSxJrg/
4yEahL+zIGYe/esBu7rrRV76j6Q0c5ngkjSVMR9+ZhHV49T5AWUYQKwdUENc3TM9
gtk2q9Zi5cnLlSDPOtPW7NxWT0oKzHNJ5VmS8EdWGZ1aMZwF+UE=
=AV8M
-----END PGP SIGNATURE-----

613de61 Add Create Wallet menu action (Andrew Chow) 9b41cbb Expose wallet creation to the GUI via WalletController (Andrew Chow) 78863e2 Add CreateWalletDialog to create wallets from the GUI (Andrew Chow) 60adb21 Optionally allow AskPassphraseDialog to output the passphrase (Andrew Chow) bc6d8a3 gui: Refactor OpenWalletActivity (João Barbosa) Pull request description: This PR adds a menu option to create a new wallet. When clicked, a `CreateWalletDialog` will be created and prompt the user to name the wallet and choose whether to disable private keys, make a blank wallet, and encrypt the wallet. If the wallet is encrypted, the wallet will be born encrypted with the wallet first created blank, then encrypted, and then a new HD seed generated and set. To allow the newly created wallets to be encrypted, some changes to how encrypting a wallet works. Instead of encrypting and locking the wallet, the wallet will be encrypted and then unlocked. This is also an extra belt-and-suspenders check to make sure that encryption worked. ACKs for top commit: fanquake: ACK 613de61 - re-reviewed on macOS. I'm going to merge this now. It's had a stack of review, and as mentioned multiple times above, lets get this into `master` so it can get more testing pre `v0.19.0`. Tree-SHA512: 3f22cc20b13703ffc90d366ae9133114832fea77f4f319da7fd85eb454f2f0bd5d7e1e6e20284dea2f370d8574f83b45669dcbbe506b994410d32e8e7a6fa877

cad3ab5 gui: fix autofocus in CreateWalletActivity::askPassphrase() (Jon Atack) 539d940 gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog (Jon Atack) 43aa9b0 gui: rename encrypt(), blank(), and askPasshprase() (Jon Atack) Pull request description: Closes bitcoin#16820. The wallet [name escaping issue](bitcoin#15450 (review)) in that issue predates bitcoin#15450 and is fixed by bitcoin#16826. - [x] rename encrypt() to encryptWallet(), and blank() to makeBlankWallet() // EDIT: updated to isEncryptWalletChecked() isDisablePrivateKeysChecked() isMakeBlankWalletChecked() - [x] fix naming of askPasshprase() to askPassphrase() - [x] fix passphrase labels and tooltip in createwalletdialog.ui and askpassphrasedialog.ui - [x] fix grammar of labels in askpassphrase dialog and WalletController::closeWallet - [x] fix autofocus in CreateWalletActivity::askPassphrase() Squashed down to three commits. Reviewers, to test manually: build, launch the gui wallet, and look at labels/tooltips/focus with the create wallet, encrypt wallet, change password, and close wallet commands. ACKs for top commit: jb55: Approach ACK cad3ab5 instagibbs: code review and tACK cad3ab5 fanquake: ACK cad3ab5 Tree-SHA512: b441fbf8f8cd370dd692bac24f0d3c1b32fc7d947b6c3a2c9ba7cf0bc175a72b3460440f2f10f7632c0e8e0f8e65fe15615a30c46e2c7763bf258c504b457dd6

Summary: bitcoin/bitcoin@bc6d8a3 Partial backport of Core [[bitcoin/bitcoin#15450 | PR15450]] depends on D7108 Test Plan: ninja check Open bitcoin-qt open and close wallets to make sure it works as before Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7102

…he passphrase Summary: bitcoin/bitcoin@60adb21 --- Depends on D7102 Partial backport of Core [[bitcoin/bitcoin#15450 | PR15450]] Test Plan: ninja check Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D7103

…e GUI Summary: Co-authored-by: João Barbosa <[email protected]> bitcoin/bitcoin@78863e2 --- Depends on D7103 Partial backport of Core [[bitcoin/bitcoin#15450 | PR15450]] Test Plan: ninja check Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D7104

…roller Summary: Co-authored-by: João Barbosa <[email protected]> bitcoin/bitcoin@9b41cbb --- Depends on D7104 Partial backport of Core [[bitcoin/bitcoin#15450 | PR15450]] Test Plan: ninja check Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D7105

Summary: Co-authored-by: João Barbosa <[email protected]> bitcoin/bitcoin@613de61 --- Depends on D7105 Concludes backport of Core [[bitcoin/bitcoin#15450 | PR15450]] Test Plan: ninja check check-functional Used the bitcoin-qt wallet on regtest mode to create wallets and make sure behavior is expected Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7106

achow101 force-pushed the gui-create-wallet branch from bb8f840 to 63f1309 Compare February 20, 2019 18:04

ryanofsky reviewed Feb 20, 2019

View reviewed changes

achow101 force-pushed the gui-create-wallet branch from 63f1309 to 668aa51 Compare February 20, 2019 19:45

achow101 mentioned this pull request Feb 20, 2019

Remove the automatic creation and loading of the default wallet #15454

Merged

fanquake added the GUI label Feb 20, 2019

promag reviewed Feb 21, 2019

View reviewed changes

src/qt/bitcoingui.cpp Outdated Show resolved Hide resolved

promag mentioned this pull request Feb 21, 2019

Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet #15453

Closed

jnewbery mentioned this pull request Feb 23, 2019

Dynamic wallet load / create / unload #13059

Closed

10 tasks

fanquake added the Wallet label Feb 23, 2019

fanquake added this to the 0.19.0 milestone Feb 23, 2019

practicalswift reviewed Feb 25, 2019

View reviewed changes

src/qt/walletcontroller.cpp Outdated Show resolved Hide resolved

achow101 force-pushed the gui-create-wallet branch from 668aa51 to 767a5f8 Compare May 23, 2019 18:34

jnewbery reviewed May 23, 2019

View reviewed changes

achow101 force-pushed the gui-create-wallet branch from 767a5f8 to b2d0546 Compare May 24, 2019 16:45

jnewbery reviewed May 24, 2019

View reviewed changes

src/qt/createwalletdialog.h Outdated Show resolved Hide resolved

src/qt/createwalletdialog.cpp Outdated Show resolved Hide resolved

src/qt/createwalletdialog.cpp Outdated Show resolved Hide resolved

src/qt/createwalletdialog.cpp Outdated Show resolved Hide resolved

achow101 force-pushed the gui-create-wallet branch 2 times, most recently from dc13d00 to 76bc7ae Compare May 24, 2019 22:15

fanquake approved these changes Aug 31, 2019

View reviewed changes

meshcollider requested a review from promag September 5, 2019 13:34

jonatack reviewed Sep 5, 2019

View reviewed changes

gui: Refactor OpenWalletActivity

bc6d8a3

achow101 and others added 4 commits September 5, 2019 20:36

Optionally allow AskPassphraseDialog to output the passphrase

60adb21

Add CreateWalletDialog to create wallets from the GUI

78863e2

Co-authored-by: João Barbosa <[email protected]>

Expose wallet creation to the GUI via WalletController

9b41cbb

Co-authored-by: João Barbosa <[email protected]>

Add Create Wallet menu action

613de61

Co-authored-by: João Barbosa <[email protected]>

achow101 force-pushed the gui-create-wallet branch from da8a86c to 613de61 Compare September 6, 2019 00:38

fanquake merged commit 613de61 into bitcoin:master Sep 7, 2019

fanquake mentioned this pull request Sep 7, 2019

Follow ups from #15450 #16820

Closed

jonatack mentioned this pull request Sep 7, 2019

gui: Create wallet menu option follow-ups #16822

Merged

5 tasks

fanquake mentioned this pull request Sep 8, 2019

Add Qt programs to msvc build (updated, no code changes) #15529

Merged

Rspigler mentioned this pull request Aug 22, 2020

Confusion with Create Wallet menu options bitcoin-core/gui#69

Closed

ryanofsky mentioned this pull request Nov 13, 2020

Slight improve create wallet dialog bitcoin-core/gui#96

Merged

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gui: Create wallet menu option #15450

gui: Create wallet menu option #15450

achow101 commented Feb 20, 2019

ryanofsky Feb 20, 2019

achow101 Feb 20, 2019

promag May 30, 2019

instagibbs commented Feb 20, 2019

achow101 commented Feb 20, 2019

DrahtBot commented Feb 20, 2019 •

edited

Loading

Sjors commented Feb 20, 2019

promag commented Feb 20, 2019

fanquake commented Feb 21, 2019

jonasschnelli commented Feb 21, 2019

Sjors commented Feb 21, 2019

hebasto commented Feb 24, 2019

jnewbery commented May 22, 2019

achow101 commented May 22, 2019

achow101 commented May 23, 2019

jnewbery left a comment

jnewbery May 23, 2019

achow101 May 24, 2019

jnewbery left a comment

achow101 commented May 24, 2019

fanquake left a comment •

edited

Loading

meshcollider commented Sep 5, 2019

jonatack left a comment

jonatack Sep 5, 2019

jonatack Sep 5, 2019

jonatack Sep 5, 2019

jonatack Sep 5, 2019

jonatack Sep 5, 2019

promag commented Sep 5, 2019

promag commented Sep 5, 2019

achow101 commented Sep 6, 2019

sipa commented Sep 6, 2019

fanquake commented Sep 7, 2019 •

edited

Loading

gui: Create wallet menu option #15450

gui: Create wallet menu option #15450

Conversation

achow101 commented Feb 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

instagibbs commented Feb 20, 2019

achow101 commented Feb 20, 2019

DrahtBot commented Feb 20, 2019 • edited Loading

Conflicts

Sjors commented Feb 20, 2019

promag commented Feb 20, 2019

fanquake commented Feb 21, 2019

jonasschnelli commented Feb 21, 2019

Sjors commented Feb 21, 2019

hebasto commented Feb 24, 2019

jnewbery commented May 22, 2019

achow101 commented May 22, 2019

achow101 commented May 23, 2019

jnewbery left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnewbery left a comment

Choose a reason for hiding this comment

achow101 commented May 24, 2019

fanquake left a comment • edited Loading

Choose a reason for hiding this comment

meshcollider commented Sep 5, 2019

jonatack left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

promag commented Sep 5, 2019

promag commented Sep 5, 2019

achow101 commented Sep 6, 2019

sipa commented Sep 6, 2019

fanquake commented Sep 7, 2019 • edited Loading

DrahtBot commented Feb 20, 2019 •

edited

Loading

fanquake left a comment •

edited

Loading

fanquake commented Sep 7, 2019 •

edited

Loading