Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor cleanup #31

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Some minor cleanup #31

merged 5 commits into from
Jan 5, 2024

Commits on Dec 14, 2023

  1. Hard code signature verification test for simplicity and determinism

    Signature hex was obtained by running the previous version of the test,
    but with `println!("signature: {signature}"); panic!();` inserted before
    the `Witness::new()` line. The output was collected by running the test
    as follows `cargo test invalid_signature -- --show-output`.
    
    ECDSA signature generation appears to be deterministic on my machine so
    you ought to be able to verify this new constant yourself.
    Ademan committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6ceece7 View commit details
    Browse the repository at this point in the history
  2. Avoid round trip through bitcoin::Address for unspendable output

    This makes the `network` parameter of `crate::reserves::verify_proof()`
    unused, it should probably be removed at the next opportunity to break
    the API.
    Ademan committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    33dc91b View commit details
    Browse the repository at this point in the history
  3. Remove irrelevant validation of challenge input spending conditions

    Checking the challenge input is able to spend a fabricated OP_TRUE input
    doesn't verify anything useful. The challenge input is intentionally
    unspendable to begin with.
    
    The witness_utxo in the psbt for the challenge input is there for
    signers, not validators.
    
    The check that the challenge input txid is properly constructed is the
    important one.
    Ademan committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0340d69 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Remove base64ct dev dependency

    Ademan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    f066e50 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Getting the CI working again.

    Raising the MSRV from 0.57 to 0.63. Lower rust versions became increasingly difficult to maintain.
    ulrichard committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    616a72e View commit details
    Browse the repository at this point in the history