Cleanup #33
Merged
Cleanup #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signature hex was obtained by running the previous version of the test,
but with `println!("signature: {signature}"); panic!();` inserted before
the `Witness::new()` line. The output was collected by running the test
as follows `cargo test invalid_signature -- --show-output`.
ECDSA signature generation appears to be deterministic on my machine so
you ought to be able to verify this new constant yourself.
This makes the `network` parameter of `crate::reserves::verify_proof()` unused, it should probably be removed at the next opportunity to break the API.
Checking the challenge input is able to spend a fabricated OP_TRUE input doesn't verify anything useful. The challenge input is intentionally unspendable to begin with. The witness_utxo in the psbt for the challenge input is there for signers, not validators. The check that the challenge input txid is properly constructed is the important one.
ulrichard
force-pushed
the
cleanup
branch
8 times, most recently
from
d207fbe
to
4d28fae
Compare
Raising the MSRV from 0.57 to 0.63. Lower rust versions became increasingly difficult to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.