Some minor fixes and adding progressCallback functionality #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thehobbit85
commented
Nov 3, 2015
thehobbit85
commented
- Added progressCallback to module functions
- Added progressCallback explanation to the Readme
- Fixed problem with travis badge and added standard badge to readme
- Added coverage and logs to gitignore
- Small fix to npm coveralls script
|
ACK on everything. LGTM. |
|
Tests are good, just coveralls dying for some reason. 91% coverage. |
|
I think the coveralls die since the repo at coverall is still set to cryptocoinjs/bip38 instead of bitcoinjs/bip38. |
|
Thanks, reviewing... |
jprichardson
added a commit
that referenced
this pull request
Nov 3, 2015
Some minor fixes and adding progressCallback functionality
Tried re-syncing coveralls... but bitcoinjs repo doesn't show up. @dcousens you may need to add it on your end because you're an owner? |
|
@jprichardson I think I enabled it. Time will tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.