-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit use of non-primitive types throughout the API #407
Comments
Wherever the API changes, warnings will need to be added to |
Best I can tell, the only non-primitive constructor that we have is in |
I didn't realise before, but With modules like https://github.com/bitcoinjs/bip69 coming up, the ability to reduce this part of the API would be asimilar to the changes made to And therefore highly beneficial. |
For the record, as per #407 (comment), Non-POD data types that still exist are basically limited to ECDSA system... and that's it? |
Related 0030854 |
We really want to avoid the use of |
Closing in favour of #508 |
As a result of the discussion in #359, the aim will be to limit the use of non primitives in the API.
Buffer
is considered a primitive in this case, and is therefore acceptable.The text was updated successfully, but these errors were encountered: