txbuilder: add setLockTime #507
Conversation
|
Resolves #437 |
|
ping @jprichardson thoughts on API? |
|
An aside, builders are commonly used in conjunction with a fluent interface. Since it doesn't, what's the rationalization for splitting up |
|
|
Any ideas on how we could improve this interface? The requirements are just that I'd like to not enforce that all private keys must be available when signing. |
|
|
||
| return input.signatures.some(function (s) { return s }) | ||
| })) { | ||
| throw new Error('No, this would invalidate signatures') |
There was a problem hiding this comment.
I still find this error message funny because it answers "no" without any question asked :P
There was a problem hiding this comment.
Haha, I know. But, it works.
If you can think of something for 3.0.0, go for it :)
|
The API looks ok to me. |
|
@jprichardson not going to merge this without status checks as tests have been added. |
|
Needed #524, so merged manually after local verification. |
txbuilder: add setLockTime
|
👍 |
|
Changes Unknown when pulling 9a62ab6 on locktime into ** on master**. |
WIP, needs tests.
Open to feedback, not the biggest fan, but, its simple enough.
Maybe I should use a property instead?