varstruct - WIP

[fanatid]

varstruct for encode/decode blocks/txs?

[dcousens]

Will review soon :)

[fanatid]

@dcousens please check it, I want to know you opinion about this.
I fixed varstruct and now fromBuffer works fine. toBuffer doesn't work because txOut can have valueBuffer instead value (I don't know how handle it, may be create custom codec...).

@mappum since same structures are used in bitcoin-protocol maybe make sense create package bitcoin-struct-tx-block or two bitcoin-tx-struct and bitcoin-block-struct?

[mappum]

Maybe we should just make one bitcoin-struct package with all the structs in it?

[fanatid]

Sorry, what do you mean under all ? tx and block ?

[fanatid]

ping

[mappum]

I was thinking there might be other structs we might want to include, such as merkleblocks and full blocks (although those are not used by bitcoinjs).

[fanatid]

Looks like not actual right now, hope varstruct will be used in #508

[dcousens]

@fanatid this looks really good 👍

[dcousens]

bitcoin-structs might work, assuming we just put all the basic POD types in there.

Transaction, Block? Any others?

[fanatid]

or move messages from bitcoin-protocol to bitcoin-protocol-messages and use tx, block from there
https://github.com/mappum/bitcoin-protocol/blob/10d67127c89ed1928094be84375f70dfef0a43b3/src/messages.js

[dcousens]

@fanatid looks good to me.
Though that would make #440 either impossible, or something we'd need to do in lockstep with @mappum's bitcoin-protocol.

[dcousens]

Maybe @mappum we could move bitcoin-protocol to the bitcoinjs-org, you'd still be lead contributor, but then it would be clear that the repository is linked (and hence in lockstep)?

[fanatid]

@dcousens if you wanted to move bitcoin-protocol you probably should do same with bitcoin-net

[dcousens]

Well, that is up to @mappum

[dcousens]

I started playing with this @fanatid, and ran into issues with valueBuffer edge cases.
I'd have to make a custom encode/decode that handled both cases (Buffer and Number).

Handling this that way is fine, and welcome, however, it would be a breaking change.

[dcousens]

Closing for now

[dcousens]

Still covered by #513