Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port for vcpkg #8

Closed
Nomade040 opened this issue Jul 26, 2020 · 5 comments
Closed

Add port for vcpkg #8

Nomade040 opened this issue Jul 26, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Nomade040
Copy link

Hello, I think this project would be more accessible if present in vcpkg.

Cheers.

@ianichitei ianichitei self-assigned this Jul 27, 2020
@ianichitei
Copy link
Contributor

ianichitei commented Jul 27, 2020

Hello. This sounds like a nice thing to have.

I looked a bit over vcpkg docs and it looks like we need a tagged release in order to be able to add it to vcpkg. We don't have a tagged release, yet, but we are working on making one.

It also looks like it is easier to add a port for a project that is using CMake, which we don't use for bddisasm.

I'll get back to this once that is done.

@ianichitei ianichitei added the enhancement New feature or request label Jul 27, 2020
@ianichitei
Copy link
Contributor

ianichitei commented Aug 5, 2020

I looked a bit more over the docs and and I'm wondering how useful it would be for vcpkg users. bddisasm is not using cmake for builds, and vcpkg seems to be built around that. For Linux builds I can probably generate a pkgconfig file at build/install time and cmake users can use pkg_check_modules to get the required build information, but that feels a bit like a hack.

@Nomade040 do you have a specific use case in mind?

@Nomade040
Copy link
Author

My bad, I didn't know that vcpkg required cmake and bddisasm doesn't use it. Vcpkg is really helpful for me because you just install a library once and at least on Visual studio which is my main IDE I just #include whatever library I had previously installed.

@ianichitei
Copy link
Contributor

My bad, I didn't know that vcpkg required cmake and bddisasm doesn't use it. Vcpkg is really helpful for me because you just install a library once and at least on Visual studio which is my main IDE I just #include whatever library I had previously installed.

This is easy to handle and it looks like it does not need any kind of special treatment.

@ianichitei
Copy link
Contributor

microsoft/vcpkg#18046 which adds a port for bddisasm was just merged. I may also take a look at Conan in the future, but for now I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants