[bddisasm] new port #18046
Merged
[bddisasm] new port #18046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently fetching bddisasm from my fork of the project
Converted with ./vcpkg format-manifest
Added port-version, license, homepage, documentation, and port mantainers
|
|
JackBoosY
added
the
category:new-port
|
Please ping me if this is ready for review. |
All the checks have passed now. |
NancyLi1013
suggested changes
May 24, 2021
|
Please convert this PR to open instead of draft if it is ready for review. @ianichitei |
NancyLi1013
suggested changes
May 24, 2021
NancyLi1013
approved these changes
May 25, 2021
|
LGTM now, thanks for your adding this new port. @ianichitei |
NancyLi1013
added
info:reviewed
Thanks for helping me :) |
bddisasm only supports being built as a static library, so say that in the portfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Create a port of https://github.com/bitdefender/bddisasm as discussed in #16982.
Which triplets are supported/not supported? Have you updated the CI baseline?
Windows
Linux
I'm not entirely sure I did the right thing here. The library can be built only as a static library. Should that be expressed in some way in the port file? As it stands,
x64-windowsandx64-windows-staticare the same thing. This feels wrong, but I can't figure out what's the right way to do things in this case. Should the install fail ifVCPKG_LIBRARY_LINKAGEisdynamic? The docs say that "libraries can ignore this setting if they do not support the preferred linkage type", so I'm thinking that probably not.For the same reason, I'm not entirely sure what should I use for the
supportsfield of the manifest file.I haven't update
ci.baseline.txt. I'm not entirely sure how that works (I'm fairly new to vcpkg, but if I'm pointed in the right direction I'll probably do the right thing).Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/